On Wed, 20 Jan 2021 16:37:04 GMT, Kevin Rushforth wrote:
>> By using the anchor location facility of PopupWindows we can avoid
>> miscalculation of the
>> menu's height entirely.
>> This fix also cleans up some documentation issues.
>> This fix introduces tests that check the correct
On Wed, 20 Jan 2021 16:39:45 GMT, Kevin Rushforth wrote:
> I recommend that you follow the instructions in the earlier comment about
> pushing these changes to a new branch, resetting your master branch, and
> creating a new PR from your new branch.
Ah yes, will try to do so tomorrow.
On Tue, 19 Jan 2021 15:06:00 GMT, Laurent Bourgès wrote:
>> Changes:
>> - Removed single-precision Marlin renderer
>> - class name refactoring
>> - fix prism
>> - copyright year
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
On Wed, 20 Jan 2021 16:37:04 GMT, Kevin Rushforth wrote:
> This changes the specification in a way that will require prior discussion,.
> It also will need a CSR.
My hope is that it really doesn't change the specification in any way. All it
should do is fix the bug.
What part of the spec do
On Wed, 20 Jan 2021 11:57:04 GMT, Robert Lichtenberger
wrote:
> By using the anchor location facility of PopupWindows we can avoid
> miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct
On Wed, 20 Jan 2021 16:44:14 GMT, Robert Lichtenberger
wrote:
>> I recommend that you follow the instructions in the earlier comment about
>> pushing these changes to a new branch, resetting your master branch, and
>> creating a new PR from your new branch.
>
>> I recommend that you follow
On Sun, 17 Jan 2021 15:49:33 GMT, Laurent Bourgès wrote:
> Changes:
> - Removed single-precision Marlin renderer
> - class name refactoring
> - fix prism
> - copyright year
This pull request has now been integrated.
Changeset: c1b14de9
Author:Laurent Bourgès
URL:
Update JavaFX WebKit to GTK WebKit 2.30 (610.2)
-
Commit messages:
- 8259635: Update to 610.2 version of WebKit
Changes: https://git.openjdk.java.net/jfx/pull/382/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=382=00
Issue:
On Wed, 20 Jan 2021 16:49:35 GMT, Kevin Rushforth wrote:
> Regarding the spec change, I was thinking of this section, which you removed:
>
> ```
> * To clarify the purpose of the {@code hpos} and {@code vpos} parameters,
> * consider that they are relative to the anchor node. As such,
On Wed, 20 Jan 2021 11:57:04 GMT, Robert Lichtenberger
wrote:
> By using the anchor location facility of PopupWindows we can avoid
> miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct
By using the anchor location facility of PopupWindows we can avoid
miscalculation of the
menu's height entirely.
This fix also cleans up some documentation issues.
This fix introduces tests that check the correct positioning (test_position_)
test_position_withCSS reproduces the problem that is
On Thu, 21 Jan 2021 06:37:59 GMT, Robert Lichtenberger
wrote:
>> Regarding the spec change, I was thinking of this section, which you removed:
>>
>> * To clarify the purpose of the {@code hpos} and {@code vpos}
>> parameters,
>> * consider that they are relative to the anchor node.
> By using the anchor location facility of PopupWindows we can avoid
> miscalculation of the
> menu's height entirely.
> This fix also cleans up some documentation issues.
> This fix introduces tests that check the correct positioning (test_position_*)
> test_position_withCSS reproduces the
On Mon, 7 Dec 2020 16:21:57 GMT, Kevin Rushforth wrote:
>> Marked as reviewed by aghaisas (Reviewer).
>
> I don't yet know whether there is an alternative that would allow the menubar
> to work without deactivating the app, but I filed a follow-up bug to track
> this:
>
>
On Tue, 8 Sep 2020 20:16:20 GMT, Kevin Rushforth wrote:
>> @kevinrushforth
>>
>> I have another working alternative, but won't make a PR for it until it is
>> more clear which direction the TableView / TreeTableView performance fixes
>> are going to take.
>>
>> The alternative would convert
By using the anchor location facility of PopupWindows we can avoid
miscalculation of the
menu's height entirely.
This fix also cleans up some documentation issues.
This fix introduces tests that check the correct positioning (test_position_*)
test_position_withCSS reproduces the problem that is
16 matches
Mail list logo
