Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Ajit Ghaisas
On Thu, 21 May 2020 10:45:09 GMT, Jeanette Winzenburg wrote: >> It's a task to support cross-control/skin testing for recurring issues (like >> memory leaks on switching skins) >> >> Basically, there's a utility class >> - to access lists of all control/classes, >> - to access/create all behav

Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Ajit Ghaisas
On Thu, 21 May 2020 10:47:52 GMT, Jeanette Winzenburg wrote: >> that's the point - they are examples of how-to use it and see our tasks :) >> >> Will address your other comments in a minute - and add two real tests (on >> skin/behavior memory leaks with the >> misbehaving classes removed: then

Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Jeanette Winzenburg
On Thu, 21 May 2020 10:22:18 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlBehaviorTestExample.java >> line 52: >>> 51: @RunWith(Parameterized.class) >>> 52: public class ControlBehaviorTestExample { >>> 53: >> >

Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Jeanette Winzenburg
On Thu, 21 May 2020 06:47:09 GMT, Ajit Ghaisas wrote: >> Jeanette Winzenburg has updated the pull request incrementally with one >> additional commit since the last revision: >> >> code/doc changes as requested in review >> >> added Skin/BehaviorMemoryLeakTest > > modules/javafx.controls

Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Jeanette Winzenburg
On Thu, 21 May 2020 10:33:27 GMT, Jeanette Winzenburg wrote: >> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/ControlSkinFactoryTest.java >> line >> 91: >>> 90: Control control = createControl(controlClass); >>> 91: Skin old = rep

Re: [Rev 01] RFR: 8244531: Tests: add support to identify recurring issues with controls et al

2020-05-21 Thread Jeanette Winzenburg
> It's a task to support cross-control/skin testing for recurring issues (like > memory leaks on switching skins) > > Basically, there's a utility class > - to access lists of all control/classes, > - to access/create all behaviors > - has alternative skins classes for all controls and utility to