On Sat, 21 Dec 2019 20:35:10 GMT, Phil Race wrote:
>> Link problem appears to just be a missing slash:
>> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>
>> Link problem appears to just be a missing slash:
>> https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>
> Seems
On Sat, 21 Dec 2019 18:35:26 GMT, Scott Palmer wrote:
>> I'm not sure if I'me supposed to try to integrate now that I've made that 10
>> -> 0 change, or if the new change resets the need for review... Also, note
>> that the link in the bot msg for "project specific requirements" is giving
>>
On Sat, 21 Dec 2019 03:03:57 GMT, Scott Palmer wrote:
>> Interesting. I was only running the tests in graphics (gradle
>> :graphics:test) as when I run all the tests I always get this failure
>> (unrelated to anything I've changed):
>>
>>> Task :base:test
>>
>>
On 12/20/19, 7:04 PM, Scott Palmer wrote:
I'm not sure if I'me supposed to try to integrate now that I've made that 10 ->
0 change, or if the new change resets the need for review...
It shows ready, which surprises me.
Still learning skara .. I'd expect any change to reset as how can it
On Sat, 21 Dec 2019 02:50:54 GMT, Scott Palmer wrote:
>> The fix looks good now. There is one problem in the test (in
>> `StubTextLayout`) that needs to be fixed.
>
> Interesting. I was only running the tests in graphics (gradle
> :graphics:test) as when I run all the tests I always get this
On Fri, 20 Dec 2019 23:43:53 GMT, Kevin Rushforth wrote:
>> The pull request has been updated with 1 additional commit.
>
> The fix looks good now. There is one problem in the test (in
> `StubTextLayout`) that needs to be fixed.
Interesting. I was only running the tests in graphics (gradle
On Fri, 20 Dec 2019 23:44:07 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
The fix looks good now.
On Sat, 14 Dec 2019 16:38:25 GMT, Kevin Rushforth wrote:
>> TextFlow isn't mentioned in the JavaDoc for any of the other Text properties
>> where the same rule applies. Perhaps that should be remedied with a
>> follow-up task?
>
> A follow-up issue would be fine.
I've created
On Fri, 13 Dec 2019 01:20:47 GMT, Scott Palmer wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
>> 494:
>>
>>> 493: * Values less than 1 are treated as 1. This value overrides the
>>> 494: * {@code tabSize} of contained {@link
On Thu, 12 Dec 2019 22:02:14 GMT, Nir Lisker wrote:
>> The pull request has been updated with 1 additional commit.
>
> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
> 494:
>
>> 493: * Values less than 1 are treated as 1. This value overrides the
>> 494:
On Thu, 12 Dec 2019 22:02:27 GMT, Scott Palmer wrote:
>> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute
>> to both. TextFlow's tab size overrides that of contained Text nodes.
>
> The pull request has been updated with 1 additional commit.
> Added tabSize property to Text and TextFlow and -fx-tab-size CSS attribute to
> both. TextFlow's tab size overrides that of contained Text nodes.
The pull request has been updated with 1 additional commit.
-
Added commits:
- f99a3aa9: 8130738: Add tabSize property to Text and
12 matches
Mail list logo