Re: Adding GStreamer plugins

2014-03-31 Thread Kirill Kirichenko
Hi Michael On 28.03.2014 23:40, Michael Berry wrote: Hi Kirill, Ok, so with help from here (https://github.com/pgregory/libffi-msvc) I think I've now got a VS project / makefile that builds libffi.lib, but I can't work out how to get the build script to build the visual studio project! The

Re: Adding GStreamer plugins

2014-03-28 Thread Michael Berry
Hi Kirill, Ok, so with help from here (https://github.com/pgregory/libffi-msvc) I think I've now got a VS project / makefile that builds libffi.lib, but I can't work out how to get the build script to build the visual studio project! The project is in

Re: Adding GStreamer plugins

2014-03-26 Thread Michael Berry
Hi David, Sure - I'm aware there's legal issues surrounding many of the formats, though one of the reasons I picked MKV to start with was because it's an open container format. I'm certainly not aware of any restrictions surrounding it (though please correct me if I'm wrong on that front!) A

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
There is another issue with new plugins. We have thoroughly tested with a closed source internal test suite on all platforms every plugin that we already have. If we add something new this may open a way for crashes, security breaches. So if you add something new and want this to be included

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
Michael, On 26.03.2014 04:11, Michael Berry wrote: Kirill - I think I'll take your suggestion next and start looking at upgrading the existing native components to the latest version of GStreamer before I look at adding any more plugins, that would seem to make sense. Have you any pointers in

Re: Adding GStreamer plugins

2014-03-26 Thread Stephen F Northover
https://javafx-jira.kenai.com/browse/RT-18009 This JIRA is covering adding support for more media formats. Since we are just talking about MKV, please open a separate JIRA to cover this work and attach the patch there. We can link to the new JIRA from RT-18009. Steve On 2014-03-25 7:47

Re: Adding GStreamer plugins

2014-03-26 Thread Kirill Kirichenko
I added a wiki link: https://wiki.openjdk.java.net/pages/viewpage.action?pageId=18808963 I welcome free will participants to go over the steps, upgrade GStreamer and eventually create a precise version of the guide. I will provide as much help as I can. K On 26.03.2014 16:43, Kirill

Re: Adding GStreamer plugins

2014-03-25 Thread Kirill Kirichenko
Hi Michael. See my comments inline. On 24.03.2014 04:31, Michael Berry wrote: I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting a bunch of unresolved external symbol errors for functions it uses in glib - not entirely sure why at the moment,

Re: Adding GStreamer plugins

2014-03-25 Thread Michael Berry
Hi Kirill, Many thanks for the detailed response, that's incredibly helpful. I had noted already that you were using gstreamer 0.10.35 from downloading the gstreamer modifications for JFX8 from Oracle's site, so was using the appropriate version of the plugin already to try to ensure no

Re: Adding GStreamer plugins

2014-03-25 Thread Kirill Kirichenko
On 25.03.2014 17:21, Michael Berry wrote: It seems the issue that I was having was indeed to do with the step you outlined; I was getting unresolved external linker issues because it couldn't find the functions I hadn't added. However, while the linker errors associated with all the glib

Re: Adding GStreamer plugins

2014-03-25 Thread Stephen F Northover
On 2014-03-25 7:00 AM, Kirill Kirichenko wrote: Hi Michael. See my comments inline. On 24.03.2014 04:31, Michael Berry wrote: I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting a bunch of unresolved external symbol errors for functions it

Re: Adding GStreamer plugins

2014-03-25 Thread Michael Berry
Hi all, Turns out it was a stupid mistake on my part causing the last few linking errors, I hadn't added one of the C files I needed to the makefile (well I had, but I'd then reverted it again without realising!) Thanks to all for the prods and advice. Once I'd done that, the build went through

Re: Adding GStreamer plugins

2014-03-25 Thread Richard Bair
Turns out it was a stupid mistake on my part causing the last few linking errors, I hadn't added one of the C files I needed to the makefile (well I had, but I'd then reverted it again without realising!) Thanks to all for the prods and advice. Once I'd done that, the build went through

Re: Adding GStreamer plugins

2014-03-25 Thread Jonathan Giles
Typically in this case you would email the patch to the assigned developer, but it appears RT-18009 is unassigned at present. I think that is the first hurdle that needs to be resolved, but if you email me your patch I will attach it to the jira issue so that it is at least available for

Re: Adding GStreamer plugins

2014-03-25 Thread Michael Berry
Hi Richard, Sure, I've emailed the patch to Scott and will work on a writeup for others that want to do something similar! (Minor point, is the wiki source in standard MediaWiki style or something else?) Kirill - I think I'll take your suggestion next and start looking at upgrading the existing

Re: Adding GStreamer plugins

2014-03-25 Thread David DeHaven
I mainly wanted to do this as a personal exercise, though I'd imagine this is a useful piece of functionality for many others also - so should I submit a patch of the changes, or is this unlikely to be accepted? (Again, sorry for the perhaps obvious question, I'm rather new to this.) I've had

Re: Adding GStreamer plugins

2014-03-24 Thread anton nashatyrev
Hi Michael, On 24.03.2014 4:31, Michael Berry wrote: Hi all, I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting a bunch of unresolved external symbol errors for functions it uses in glib - not entirely sure why at the moment, as I said C is

Re: Adding GStreamer plugins

2014-03-23 Thread Scott Palmer
I applaud your effort, but please consider while you are doing this: Addressing RT-18009 is good Addressing RT-2684 is way better. https://javafx-jira.kenai.com/browse/RT-2684 If there is a mechanism to write a stub plugin that hooks into the GStreamer plugin mechanism such that end users of

Re: Adding GStreamer plugins

2014-03-23 Thread Michael Berry
Hi Scott, Sure, that's in fact my eventual goal - but in order to successfully get that far I need to work out how to compile OpenJFX with other GStreamer plugins first, and unfortunately at the moment I seem to be getting stuck at that hurdle! Time permitting, I do indeed plan to look at

Re: Adding GStreamer plugins

2014-03-23 Thread Michael Berry
Hi all, I'm now a bit further along with this, though struggling to get the matroska plugin to compile (getting a bunch of unresolved external symbol errors for functions it uses in glib - not entirely sure why at the moment, as I said C is not my strong point.) I've also noticed the plugins