Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Kevin Rushforth
<mailto:openjfx-dev@openjdk.java.net> Mailing mailto:openjfx-dev@openjdk.java.net>> *Subject:* RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger Hi Nir, 1)Regarding “verbose” flag usage: ·Currently verbose flag

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Nir Lisker
t;\n"; >> >> } >> >> }); >> >> log.addHandler(handler); >> >> } >> >> >> >> Thanks, >> >> MUrali >> >> *From:* Murali Billa >> *Sent:* Thursday, May

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Kevin Rushforth
...@gmail.com>> *Cc:* openjfx-dev@openjdk.java.net <mailto:openjfx-dev@openjdk.java.net> Mailing mailto:openjfx-dev@openjdk.java.net>> *Subject:* RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger Hi Nir, 1)Regarding “verbose” flag usage:

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Nir Lisker
*Sent:* Thursday, May 03, 2018 1:52 AM > *To:* Nir Lisker > *Cc:* openjfx-dev@openjdk.java.net Mailing > *Subject:* RE: JDK-8195974: Replace use of java.util.logging in javafx > with System logger > > > > Hi Nir, > > > > 1) Regarding “verbose” flag usage: &

RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-17 Thread Murali Billa
MUrali From: Murali Billa Sent: Thursday, May 03, 2018 1:52 AM To: Nir Lisker Cc: openjfx-dev@openjdk.java.net Mailing Subject: RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger   Hi Nir,   1)  Regarding “verbose” flag usage:  · Currently verbose

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-03 Thread Kevin Rushforth
Also, why is webkit.mediaplayer special in its usage of the logger (that it requires its own property)? That's the real question: are the needs of the WebView media component so special that it justifies its own mechanism / property. I doubt it, which is why removing the verbose flag

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-03 Thread Nir Lisker
> > Also, why is webkit.mediaplayer special in its usage of the logger (that >> it requires its own property)? > > > That's the real question: are the needs of the WebView media component so > special that it justifies its own mechanism / property. I doubt it, which > is why removing the verbose fl

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-03 Thread Kevin Rushforth
On 5/2/2018 6:25 PM, Nir Lisker wrote: Not sure what you mean by "that file". Sorry, I meant the log/config file. I see. This isn't something that a library like JavaFX should read. keeping the verbose flag but putting it on a System property Then why not get a minimum level fr

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
> > Not sure what you mean by "that file". Sorry, I meant the log/config file. keeping the verbose flag but putting it on a System property Then why not get a minimum level from a system property instead of a general on/off flag? Also, why is webkit.mediaplayer special in its usage of the log

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Kevin Rushforth
inline On 5/2/2018 4:52 PM, Nir Lisker wrote: Thanks Murali, I won’t suggest reading level value from log/config file. Is that file user facing? If so, wouldn't ignoring the level set in the file break current behavior? Would there need to be follow-up changes to this file to remove the leve

Re: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Nir Lisker
Thanks Murali, I won’t suggest reading level value from log/config file. Is that file user facing? If so, wouldn't ignoring the level set in the file break current behavior? Would there need to be follow-up changes to this file to remove the level setting from it? About option (a), wouldn't rem

RE: JDK-8195974: Replace use of java.util.logging in javafx with System logger

2018-05-02 Thread Murali Billa
Hi Nir,   1)  Regarding “verbose” flag usage:  · Currently verbose flag is used to show log Levels (FINER/FINE/INFO/WARNING) in WCMediaPlayer & WCMediaPlayerImpl.  I feel it is not desirable to remove this flag as all these logs will start appearing now by default. · We