On Wed, 11 Dec 2019 19:05:54 GMT, Thiago Milczarek Sayao
wrote:
>> With your latest patch, which reverts the changes to `GtkDnDClipboard.java`,
>> I now get the DRAG_DONE event, but the following warning printed to the
>> console in the case of a `DRAG_DONE` event with a null transfer mode:
>>
On Wed, 11 Dec 2019 18:43:23 GMT, Kevin Rushforth wrote:
>> I don't get an assertion error on Oracle Linux 7.7 -- so far only on Ubuntu
>> 16.04. I will resume reviewing once you restore the `DRAG_DONE` behavior.
>
> With your latest patch, which reverts the changes to `GtkDnDClipboard.java`,
On Wed, 11 Dec 2019 00:21:20 GMT, Kevin Rushforth wrote:
>>> Does it send the event on other platforms? I can test on Windows.
>>
>> Yes, it always sends the `DRAG_DONE` event on all platforms today (I tested
>> it on Mac, Windows, and Linux).
>>
>>> Will look into the assertion error - it doe
On Tue, 10 Dec 2019 23:53:27 GMT, Kevin Rushforth wrote:
>> @kevinrushforth I changed that behaviour. Since the drag does not complete i
>> find it counter-intuitive to send the DRAG_DONE event.
>>
>> Does it send the event on other platforms? I can test on Windows.
>>
>> Will look into the as
On Tue, 10 Dec 2019 19:41:05 GMT, Thiago Milczarek Sayao
wrote:
>> I'm starting to look at this. I see at least one behavioral difference that
>> will need to be addressed. With the existing implementation, if I drag /
>> drop onto a target that set up to receive the drop, the transfer complet
On Tue, 10 Dec 2019 16:13:06 GMT, Kevin Rushforth wrote:
>> Just a reminder to take a look when time allows.
>
> I'm starting to look at this. I see at least one behavioral difference that
> will need to be addressed. With the existing implementation, if I drag / drop
> onto a target that set
On Mon, 2 Dec 2019 11:09:05 GMT, Thiago Milczarek Sayao
wrote:
>> Preliminary review was here:
>> [javafxports/openjdk-jfx/pull/490](https://github.com/javafxports/openjdk-jfx/pull/490)
>
> Just a reminder to take a look when time allows.
I'm starting to look at this. I see at least one behav
On Fri, 4 Oct 2019 23:03:00 GMT, Kevin Rushforth wrote:
> On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote:
>
>> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao
>> wrote:
>>
>>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote:
>>>
On Wed, 2 Oct 2019 19:54:48 GMT,
On Wed, 2 Oct 2019 20:02:22 GMT, Kevin Rushforth wrote:
> On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao
> wrote:
>
>> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote:
>>
>>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao
>>> wrote:
>>>
https://bugs.openjdk.j
On Wed, 2 Oct 2019 19:54:50 GMT, Thiago Milczarek Sayao
wrote:
> On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote:
>
>> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao
>> wrote:
>>
>>> https://bugs.openjdk.java.net/browse/JDK-8225571
>>>
>>> To run tests (on the root of the s
On Wed, 2 Oct 2019 19:54:50 GMT, Kevin Rushforth wrote:
> On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao
> wrote:
>
>> https://bugs.openjdk.java.net/browse/JDK-8225571
>>
>> To run tests (on the root of the source tree):
>> ./gradlew apps
>> java @build/run.args -cp apps/toys/DragDro
On Wed, 2 Oct 2019 19:54:48 GMT, Thiago Milczarek Sayao
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8225571
>
> To run tests (on the root of the source tree):
> ./gradlew apps
> java @build/run.args -cp apps/toys/DragDrop/dist/DragDrop.jar
> dragdrop.DragDropWithControls
> java @build/ru
12 matches
Mail list logo
