On Fri, 30 Apr 2021 00:10:30 GMT, John Neffenger wrote:
>> This is a continuation of the [pull request][1] started by @bmwiedemann in
>> January 2020. After this change is integrated, I can follow up immediately
>> with additional pull requests that get us much closer to providing fully
>>
On Fri, 30 Apr 2021 00:10:30 GMT, John Neffenger wrote:
>> This is a continuation of the [pull request][1] started by @bmwiedemann in
>> January 2020. After this change is integrated, I can follow up immediately
>> with additional pull requests that get us much closer to providing fully
>>
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
> reproducible builds.
>
> Motivation
>
> The only
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger wrote:
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
>
On Sat, 27 Mar 2021 18:49:32 GMT, Bernhard M. Wiedemann
wrote:
> Sorted output still complies with that API, though.
Well, that's true. I hadn't thought of it that way.
I have tried twice and failed to [add you as a
contributor](https://github.com/openjdk/jfx/pull/422#issuecomment-806317783)
On Sat, 27 Mar 2021 17:26:21 GMT, John Neffenger wrote:
> The API states, "There is no guarantee that the name strings in the resulting
> array will appear in any specific order; they are not, in particular,
> guaranteed to appear in alphabetical order." That API was defined in December
>
On Wed, 29 Jan 2020 08:58:47 GMT, Bernhard M. Wiedemann
wrote:
> Allow to override buildDate with `SOURCE_DATE_EPOCH`
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the
On Wed, 29 Jan 2020 08:58:47 GMT, Bernhard M. Wiedemann
wrote:
> Allow to override buildDate with `SOURCE_DATE_EPOCH`
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the
On Sat, 27 Mar 2021 03:34:11 GMT, Bernhard M. Wiedemann
wrote:
> Now the interesting question is, if it is possible to change `listFiles` to
> always return deterministic output ...
Yes, that would be interesting, if `listFiles()` were defined by the Gradle
build tool. I think it originates,
On Fri, 26 Mar 2021 19:19:10 GMT, John Neffenger wrote:
> objectDir.listFiles().sort()
Now the interesting question is, if it is possible to change `listFiles` to
always return deterministic output or if we have to patch an infinite number of
callers instead. For those cases where people do
On Tue, 9 Mar 2021 03:11:48 GMT, Bernhard M. Wiedemann
wrote:
> When linking shared libraries, ensure that .o files are listed in
> deterministic order - i.e. `sort(glob(*.c))` and check if individual .c or .o
> files vary between builds.
Wow, that tip was priceless! Thank you, Bernhard. It
On Wed, 15 Apr 2020 02:35:44 GMT, Bernhard M. Wiedemann
wrote:
> I am currently low on time and my Java-foo is not that great, so I was hoping
> that someone would pick it up.
@bmwiedemann Thank you for getting this important change started. If you can
finish this pull request, I'll follow
On Mon, 8 Mar 2021 17:32:20 GMT, John Neffenger wrote:
>> Long term, yes.
>>
>> I am currently low on time and my Java-foo is not that great, so I was
>> hoping that someone would pick it up.
>
>> I am currently low on time and my Java-foo is not that great, so I was
>> hoping that someone
On Thu, 25 Mar 2021 02:35:24 GMT, John Neffenger wrote:
>>> @jgneff Could not parse `bmwiedemann` as a valid contributor.
>>
>> You might retry the "contributor" command with the `@` before their GitHub
>> username (I'm not 100% sure that will work, though).
>
>> You might retry the
On Wed, 24 Mar 2021 23:39:21 GMT, Kevin Rushforth wrote:
> You might retry the "contributor" command with the `@` before their GitHub
> username.
Thanks. I'll try that now. I checked and Bernhard is on the list of "OCAs
submitted prior to 2021," but not on the OpenJDK Census list, in case
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger wrote:
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
>
On Tue, 9 Mar 2021 22:20:10 GMT, John Neffenger
wrote:
> This is a continuation of the [pull request][1] started by @bmwiedemann in
> January 2020. After this change is integrated, I can follow up immediately
> with additional pull requests that get us much closer to providing fully
>
On Fri, 8 May 2020 19:03:26 GMT, Kevin Rushforth wrote:
>> Long term, yes.
>>
>> I am currently low on time and my Java-foo is not that great, so I was
>> hoping that someone would pick it up.
>
> I note that the JDK build recently implemented this feature in JDK 15 with
>
On Wed, 15 Apr 2020 02:35:44 GMT, Bernhard M. Wiedemann
wrote:
>> @bmwiedemann are you planning to pursue this PR?
>
> Long term, yes.
>
> I am currently low on time and my Java-foo is not that great, so I was hoping
> that someone would pick it up.
I note that the JDK build recently
On Tue, 14 Apr 2020 11:48:55 GMT, Kevin Rushforth wrote:
>> Finally getting to this (sorry for the delay). This seems OK to me, as it is
>> not an intrusive change. I do not think
>> that actually setting this property for production builds is a good idea, so
>> I recommend against that
On Thu, 27 Feb 2020 00:01:28 GMT, Kevin Rushforth wrote:
>> Allow to override buildDate with `SOURCE_DATE_EPOCH`
>> in order to make builds reproducible.
>> See https://reproducible-builds.org/ for why this is good
>> and https://reproducible-builds.org/specs/source-date-epoch/
>> for the
On Wed, 29 Jan 2020 08:58:47 GMT, Bernhard M. Wiedemann
wrote:
> Allow to override buildDate with `SOURCE_DATE_EPOCH`
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the
On Tue, 25 Feb 2020 18:15:31 GMT, Bernhard M. Wiedemann
wrote:
>>> FWIW, I have scripts that will unpack the modular jar files and diff each
>>> class
>>
>> I agree that such specialized diff tools have some value, yet, there are
>> also some limitations and downsides to them. E.g. you
On Sat, 8 Feb 2020 11:14:29 GMT, Bernhard M. Wiedemann
wrote:
>> As an optional override, I am OK with the concept of having a way for the
>> build to be reproducible.
>>
>> FWIW, I have scripts that will unpack the modular jar files and diff each
>> class as well as doing the same for a
On Fri, 7 Feb 2020 20:04:21 GMT, Kevin Rushforth wrote:
>>> Do I have to open a separate bug for each of them?
>>
>> Every fix (meaning each pull request) needs a unique bug ID.
>
> As an optional override, I am OK with the concept of having a way for the
> build to be reproducible.
>
>
On Fri, 7 Feb 2020 19:51:07 GMT, Kevin Rushforth wrote:
>>> The OCA needs to be validated and recorded.
>>
>> https://www.oracle.com/technetwork/community/oca-486395.html#w now has
>> `Bernhard Wiedemann - OpenJDK - bmwiedemann`
>>
>>> As for the bug, it has been transferred to the JDK project
On Fri, 7 Feb 2020 19:32:39 GMT, Bernhard M. Wiedemann
wrote:
>> The OCA needs to be validated and recorded. As for the bug, it has been
>> transferred to the JDK project as
>> [JDK-8238650](https://bugs.openjdk.java.net/browse/JDK-8238650).
>
>> The OCA needs to be validated and recorded.
>
On Fri, 7 Feb 2020 13:43:50 GMT, Kevin Rushforth wrote:
>> So the contributor agreement is done. How can I find the bug?
>
> The OCA needs to be validated and recorded. As for the bug, it has been
> transferred to the JDK project as
>
On Wed, 29 Jan 2020 12:48:35 GMT, Kevin Rushforth wrote:
>> /signed
>>
>> I filed one bug and got review ID : 9063488
>
>> I filed one bug and got review ID : 9063488
>
> OK.
So the contributor agreement is done. How can I find the bug?
-
PR:
On Wed, 29 Jan 2020 12:40:05 GMT, Bernhard M. Wiedemann
wrote:
>> In addition to a signed OCA, we will need a bug filed to track this. Please
>> read the [CONTRIBUTING
>> guidelines](https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md).
>
> /signed
>
> I filed one bug and got review
On Wed, 29 Jan 2020 08:58:47 GMT, Bernhard M. Wiedemann
wrote:
> Allow to override buildDate with `SOURCE_DATE_EPOCH`
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the
On Fri, 7 Feb 2020 12:11:24 GMT, Bernhard M. Wiedemann
wrote:
>>> I filed one bug and got review ID : 9063488
>>
>> OK.
>
> So the contributor agreement is done. How can I find the bug?
The OCA needs to be validated and recorded. As for the bug, it has been
transferred to the JDK project as
On Wed, 29 Jan 2020 12:33:00 GMT, Kevin Rushforth wrote:
>> Allow to override buildDate with `SOURCE_DATE_EPOCH`
>> in order to make builds reproducible.
>> See https://reproducible-builds.org/ for why this is good
>> and https://reproducible-builds.org/specs/source-date-epoch/
>> for the
33 matches
Mail list logo
