Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-08-28 Thread John Hendrikx
On Fri, 14 May 2021 22:30:16 GMT, Michael Strauß wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >>

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-05-17 Thread Ambarish Rapte
On Fri, 14 May 2021 22:30:16 GMT, Michael Strauß wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >>

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-05-14 Thread Kevin Rushforth
On Fri, 14 May 2021 22:30:16 GMT, Michael Strauß wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >>

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-05-14 Thread Michael Strauß
On Sat, 3 Apr 2021 15:20:41 GMT, Michael Strauß wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. >

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-05-14 Thread Michael Strauß
On Fri, 14 May 2021 21:40:39 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added missing oldValue assignments > >

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing [v2]

2021-05-14 Thread Michael Strauß
> The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. > specializations of the Property class with a similar design

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-05-14 Thread Kevin Rushforth
On Sat, 3 Apr 2021 15:20:41 GMT, Michael Strauß wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. >

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-05-10 Thread Ambarish Rapte
On Sat, 3 Apr 2021 15:20:41 GMT, mstr2 wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. > specializations of

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread mstr2
On Tue, 6 Apr 2021 14:29:28 GMT, Nir Lisker wrote: > The benchmark might not tell the real story. To test these sorts of > performance changes you have to use JMH. There's too much relating to JIT > optimizations and JVM startup to be able to rely on the current benchmark. > The theoretical

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread Nir Lisker
On Tue, 6 Apr 2021 12:08:39 GMT, Kevin Rushforth wrote: >>> Seems like I forgot to hit the send button on the webform. Here's the >>> tracking number: 9069787. >> >> I see it now. And thanks for providing the benchmark. That's what I was >> looking for. > > The bug is now visible here:

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread mstr2
On Mon, 5 Apr 2021 21:54:40 GMT, Kevin Rushforth wrote: >> The internal BidirectionalBinding class implements bidirectional bindings >> for JavaFX properties. The design intent of this class is to provide >> specializations for primitive value types to prevent boxing conversions (cf. >>

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread Kevin Rushforth
On Mon, 5 Apr 2021 23:38:29 GMT, Kevin Rushforth wrote: >> Seems like I forgot to hit the send button on the webform. Here's the >> tracking number: 9069787. >> >> I've used the following manual benchmark, which bidirectionally binds two >> properties and then produces a billion change

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread Kevin Rushforth
On Mon, 5 Apr 2021 23:16:53 GMT, mstr2 wrote: > Seems like I forgot to hit the send button on the webform. Here's the > tracking number: 9069787. I see it now. And thanks for providing the benchmark. That's what I was looking for. - PR: https://git.openjdk.java.net/jfx/pull/454

Re: RFR: 8264770: BidirectionalBinding should use InvalidationListener to prevent boxing

2021-04-06 Thread Kevin Rushforth
On Sat, 3 Apr 2021 15:20:41 GMT, mstr2 wrote: > The internal BidirectionalBinding class implements bidirectional bindings for > JavaFX properties. The design intent of this class is to provide > specializations for primitive value types to prevent boxing conversions (cf. > specializations of