Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread hyc
Ryan Tandy wrote: > On Tue, Sep 12, 2017 at 08:24:15PM +, h...@symas.com wrote: >> I don't have documentation for sd_notify() on my machine > > https://www.freedesktop.org/software/systemd/man/sd_notify.html > >> - what does it return if systemd isn't running at the moment? What does it >> r

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread ryan
On Tue, Sep 12, 2017 at 08:24:15PM +, h...@symas.com wrote: >I don't have documentation for sd_notify() on my machine https://www.freedesktop.org/software/systemd/man/sd_notify.html >- what does it return if systemd isn't running at the moment? What does >it return if the current program was

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread hyc
mich...@stroeder.com wrote: > Howard Chu wrote: >> If no one has any other reasons to offer, I'm inclined to reject >> and close this ITS. > > Note that the systemd unit file was only a little detail in this > ITS. The most important part is the C code change. OK. Looking at the patch: +dnl +dnl

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread michael
Howard Chu wrote: > If no one has any other reasons to offer, I'm inclined to reject > and close this ITS. Note that the systemd unit file was only a little detail in this ITS. The most important part is the C code change. Ciao, Michael.

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread ryan
On Tue, Sep 12, 2017 at 07:04:48PM +, h...@symas.com wrote: >My experience so far with Arch/Debian/Ubuntu/Centos mirrors this - >they're all different in FS layouts (/var/run vs /run, etc etc etc) and >the situation is no better than it was in SysV init In the case of the unit file proposed,

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread hyc
mich...@stroeder.com wrote: > r...@nardis.ca wrote: >> An explicit design goal of systemd is that unit files should be >> uniform enough that it's reasonable for upstream projects to >> ship them, >=20 > Yes, systemd has many admirable goals. And not enough competent developers to achieve any of t

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread michael
r...@nardis.ca wrote: > An explicit design goal of systemd is that unit files should be > uniform enough that it's reasonable for upstream projects to > ship them, Yes, systemd has many admirable goals. On the other hands Linux distributions differ a lot especially regarding file system layout,

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread quanah
--On Tuesday, September 12, 2017 11:30 AM -0700 Ryan Tandy wrote: > "Part of this is that we want that unit files are supplied with upstream, > and not just added by the packager -- how it has usually been done in the > SysV world." > > Of course the unit file should only be installed if the con

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread ryan
On Tue, Sep 12, 2017 at 05:17:11PM +, qua...@symas.com wrote: >b) The OpenLDAP project has never provided init scripts of their >equivalents. I'm not sure it would be correct to include the systemd unit >file as a part of the project. An explicit design goal of systemd is that unit files shou

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread michael
qua...@symas.com wrote: > b) The OpenLDAP project has never provided init scripts of > their equivalents. I'm not sure it would be correct to include > the systemd unit file as a part of the project. I also suspect that many Linux distributions are picky regarding their own systemd flavors. My

Re: (ITS#8707) slapd: Add systemd service notification support

2017-09-12 Thread quanah
--On Sunday, August 13, 2017 12:55 PM + fumi...@osstech.co.jp wrote: A couple of things: a) There is no IPR statement provided, so this cannot be examined. b) The OpenLDAP project has never provided init scripts of their equivalents. I'm not sure it would be correct to include the systemd

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-13 Thread fumiyas
On Sat, 12 Aug 2017 02:58:20 +0900, Ryan Tandy wrote: > > I've added slapd.service file. Please check. > > Looks good to me. Thanks again for working on this! :) > > Just minor comments: > > > - $(srcdir)/slapd.conf > slapd.conf.tmp ; \ > > + $(srcdir)/slapd.conf > slapd.conf

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-11 Thread ryan
On Fri, Aug 11, 2017 at 08:10:09PM +0900, SATOH Fumiyasu wrote: >I've added slapd.service file. Please check. Looks good to me. Thanks again for working on this! :) Just minor comments: >- $(srcdir)/slapd.conf > slapd.conf.tmp ; \ >+ $(srcdir)/slapd.conf > slapd.conf.tm

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-11 Thread fumiyas
Hi, I've added slapd.service file. Please check. * https://github.com/osstech-jp/openldap/pull/4 * https://patch-diff.githubusercontent.com/raw/osstech-jp/openldap/pull/4.patch On Thu, 10 Aug 2017 19:26:48 +0900, fumiyas wrote: > > > I've revised the patch for master to check if the listener ini

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-10 Thread fumiyas
On Thu, 10 Aug 2017 02:16:56 +0900, Ryan Tandy wrote: > > I've revised the patch for master to check if the listener initialization > > suceeds or not. With this patch, `slapd -d0` can return non-zero exit code > > if the listener initialization fails, thus systemd can detect slapd.service > > star

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-09 Thread ryan
On Wed, Aug 09, 2017 at 05:13:44PM +0900, SATOH Fumiyasu wrote: >I've revised the patch for master to check if the listener initialization >suceeds or not. With this patch, `slapd -d0` can return non-zero exit code >if the listener initialization fails, thus systemd can detect slapd.service >startu

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-09 Thread fumiyas
On Tue, 08 Aug 2017 04:23:27 +0900, Ryan Tandy wrote: > > + rc = sd_notifyf( 1, > > + "READY=1\n" > > + "STATUS=slapd: ready to serve connections...\n" > > + "MAINPID=%lu", > > + (unsigned long) getpid() ); > I see you've placed this call later than the pa

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-08 Thread ryan
On Tue, Aug 08, 2017 at 03:10:35PM +0900, SATOH Fumiyasu wrote: >My slapd.service file: > >[Unit] >Description=OpenLDAP Server >After=syslog.target network-online.target >Documentation=man:slapd >Documentation=man:slapd.conf >Documentation=man:slapd-config >Documentation=man:slapd-bdb >Documentatio

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-07 Thread fumiyas
Hi, Sorry, I'm not good at English. :-) On Tue, 08 Aug 2017 05:12:02 +0900, Ryan Tandy wrote: > > I guess MAINPID= is actually needed, unless we run slapd with -d, > > regardless of > > whether we set Type=forking or Type=notify. Not exactly "needed", but > > better to > > have it than not. >

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-07 Thread ryan
On Mon, Aug 07, 2017 at 01:12:02PM -0700, Ryan Tandy wrote: >Side note: the version message from slapd appears in the journal >twice, once with the timestamp and once without... not sure exactly >why! Sorry, meant to delete this paragraph before sending. The difference between "-dnone" and "-d0

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-07 Thread ryan
On Mon, Aug 07, 2017 at 12:23:27PM -0700, Ryan Tandy wrote: >I guess MAINPID= is actually needed, unless we run slapd with -d, regardless of >whether we set Type=forking or Type=notify. Not exactly "needed", but better to >have it than not. I experimented a bit with a service file. It seems to wor

Re: (ITS#8707) slapd: Add systemd service notification support

2017-08-07 Thread ryan
On Mon, Aug 07, 2017 at 01:30:44PM +, fumi...@osstech.co.jp wrote: >I've created patches for slapd to add systemd service notification >(sd_notify(3)) support. Thanks for working on this! I'm also interested in having this feature. What do you think about including a slapd.service file? I kn