Re: [Openocd-development] [PATCH] FT2232H / FT2242H support for D2XX driver

2009-06-01 Thread Zach Welch
On Mon, 2009-06-01 at 22:09 -0700, Rick Altherr wrote: On May 23, 2009, at 7:28 PM, Zach Welch wrote: On Wed, 2009-05-20 at 22:59 -0700, Zach Welch wrote: On Wed, 2009-05-20 at 22:54 -0700, Rick Altherr wrote: On May 20, 2009, at 10:31 PM, Zach Welch wrote: On Wed, 2009-05-20 at 22:23

Re: [Openocd-development] More reset_config docs

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 10:13 +0200, Øyvind Harboe wrote: Been there, done that. Reread what I wrote: the issue is the *board* not wiring it. The current code to check is RTCK supported only addresses the JTAG adapter. There's no way for it to discern the case which I listed: adapter

Re: [Openocd-development] Dealing with cumulative patches - and patch sets

2009-05-31 Thread Zach Welch
On Sat, 2009-05-30 at 17:18 -0400, Duane Ellis wrote: All, (especially david zach, you seem to do this very well). Yes, this is some what off-topic for this list, but it is on topic because the list wants small more reviewable patches. To that end, I'm looking for a better way to deal

Re: [Openocd-development] More reset_config docs

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 10:50 +0200, Øyvind Harboe wrote: It sounds like the problem relates to the fact that reset_config will not work for all combinations of interfaces and targets. All of this discussion makes me think that OpenOCD needs two reset_config commands: one for the interface

Re: [Openocd-development] More reset_config docs

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 15:17 -0700, David Brownell wrote: On Sunday 31 May 2009, Zach Welch wrote: What I would like to see is that we push funky rules into board/target config files and keep the reset_config implementation as simple as possible. One reason I dislike that model

[Openocd-development] The Taming of target_type_t

2009-05-31 Thread Zach Welch
Hi all, Last night, I committed patches to hide the definition of the target_type_s structure from out-of-module users. This was done over the course of a few series of patches. I apologize if any problems crop up, but I will report my own status in a new thread following this one. Suffice it

[Openocd-development] a minor victory

2009-05-31 Thread Zach Welch
Hi all, After my patch series today, I discovered that I am finally able to flash my custom target reliably from the latest trunk. This is the _first_ time that I have seen success with a recent build. Personally, I consider this a major breakthrough in terms of stability. After over a month

[Openocd-development] RFC: struct cleanup and more

2009-05-31 Thread Zach Welch
Hi all, The following things nagged at me when I did the target_type clean-up: 1) Remove redundant structure typedefs: a) Entails the following steps (for each named struct type): i) s/^typedef struct type_s/struct type_s/ ii) s/^} type_t;/};/ iii) s/type_t/struct type_s/

Re: [Openocd-development] new target_types.h

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 21:31 -0400, Duane Ellis wrote: duane [about target_types.h]and openocd/types.h I do like what you have done with target_types.h - Yes, absolutely - good idea, I think I said it wrong, I'm sure I'll make that mistake again. zach You want to expose every struct

[Openocd-development] [PATCH] 1 of 2: remove jtag_tap_t from types.h

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 16:37 -0700, Zach Welch wrote: Hi all, The following things nagged at me when I did the target_type clean-up: 1) Remove redundant structure typedefs: a) Entails the following steps (for each named struct type): i) s/^typedef struct type_s/struct type_s

Re: [Openocd-development] RFC: struct cleanup and more

2009-05-31 Thread Zach Welch
On Mon, 2009-06-01 at 04:15 +0200, Michael Bruck wrote: The 'struct foo_s' syntax is code bloat that obscures the actual algorithms. 'foo_t' is shorter. I assume you prefer u32 over uint32_t, then? ;) Nevermind I think 'struct foo' is much more clear when reading and writing code.

Re: [Openocd-development] RFC: struct cleanup and more

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 16:37 -0700, Zach Welch wrote: Hi all, The following things nagged at me when I did the target_type clean-up: 1) Remove redundant structure typedefs: a) Entails the following steps (for each named struct type): i) s/^typedef struct type_s/struct type_s

Re: [Openocd-development] [patch 1/6] whitespace fixes for NOR drivers

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 15:03 -0700, David Brownell wrote: Remove broken whitespace ... mostly at end of line, but also in some cases blocks of inappropriate empty lines. And spell comamnd right. :) --- src/flash/avrf.c | 108 ++-- src/flash/lpc288x.c | 94 +-

Re: [Openocd-development] RFC: struct cleanup and more

2009-05-31 Thread Zach Welch
On Mon, 2009-06-01 at 05:16 +0200, Michael Bruck wrote: On Mon, Jun 1, 2009 at 4:41 AM, David Brownell davi...@pacbell.net wrote: On Sunday 31 May 2009, Michael Bruck wrote: The 'struct foo_s' syntax is code bloat that obscures the actual algorithms. 'foo_t' is shorter. Disagree about

Re: [Openocd-development] RFC: struct cleanup and more

2009-05-31 Thread Zach Welch
On Sun, 2009-05-31 at 21:00 -0700, David Brownell wrote: On Sunday 31 May 2009, Michael Bruck wrote: and I imagined how much worse that that would get once we mix in struct and enum. Heck, I imagined how much *better* it would be, especially if the whitespace/layout bugs got fixed. ;)

Re: [Openocd-development] Listing BSDL files

2009-05-30 Thread Zach Welch
On Fri, 2009-05-29 at 11:38 -0300, Alan Carvalho de Assis wrote: Hi all, Follow below links to some BSDL files: NXP LPC: http://www.standardics.nxp.com/support/models/lpc2000/ Freescale PowerPC: http://www.freescale.com/webapp/sps/site/overview.jsp?code=DRPPCBSDLFLS Freescale i.MX1

Re: [Openocd-development] [PATCH] Minor fix to J-Link debugging

2009-05-30 Thread Zach Welch
On Sat, 2009-05-30 at 23:15 +0100, Peter Denison wrote: The debugging code in jlink_tap_execute() called when _DEBUG_USB_COMMS_ is defined was using the entire cached scan length to print the results buffers, and not the correct length of each individual buffer. Committed, r1955. --Z

Re: [Openocd-development] 0.2.0 Status Update

2009-05-29 Thread Zach Welch
On Thu, 2009-05-28 at 23:45 -0700, Rick Altherr wrote: On May 28, 2009, at 7:04 PM, Zach Welch wrote: In addition, the following issues appear to require resolution, in order to decided whether they should be accomplished for 0.2.0 or postponed: - ft2232 high-speed device support

Re: [Openocd-development] 0.2.0 Status Update

2009-05-29 Thread Zach Welch
On Thu, 2009-05-28 at 23:45 -0700, Rick Altherr wrote: On May 28, 2009, at 7:04 PM, Zach Welch wrote: [snip] In addition, the following issues appear to require resolution, in order [snip] - fix jlink to work with large scan chains (e.g. R.Doss svf test). As long as the fix

Re: [Openocd-development] openocd too slow

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 11:01 +0300, Vytautas Lukenskas wrote: On Friday 29 May 2009 10:31:25 massimiliano cialdi wrote: but make stops whit an error: libtool: link: gcc -std=gnu99 -g -O2 -I/home/POWERSOFT/massimiliano/download/openocd/libftd2xx0.4.16_x86_64 -Wall -Wstrict-prototypes

Re: [Openocd-development] 0.2.0 Status Update

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 13:02 +0800, Xiaofan Chen wrote: On Fri, May 29, 2009 at 10:04 AM, Zach Welch z...@superlucidity.net wrote: The following tasks appear to be pending for the 0.2.0 release: - fix OMAP3 problems reported by Dick Behme (or did these get resolved?) - final packaging fix

Re: [Openocd-development] openocd too slow

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 11:23 +0200, massimiliano cialdi wrote: On Fri, May 29, 2009 at 10:01 AM, Vytautas Lukenskas vytautas.lukens...@arevita.com wrote: On Friday 29 May 2009 10:31:25 massimiliano cialdi wrote: but make stops whit an error: libtool: link: gcc -std=gnu99 -g -O2

Re: [Openocd-development] Listing BSDL files

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 12:30 -0300, Alan Carvalho de Assis wrote: Hi David, On 5/29/09, David Brownell davi...@pacbell.net wrote: On Friday 29 May 2009, Alan Carvalho de Assis wrote: Did I forget other BSDL links? Show me the link ;-) TI links theirs right off the generic page for each

[Openocd-development] [PATCH] encapsulate jtag interface

2009-05-29 Thread Zach Welch
Hi all, The following patch encapsulates the global JTAG interface pointer, adding a wrapper routine for the only out-of-module user. I will apply unless there are objections. Cheers, Zach == Encapsulate the global jtag jtag_interface pointer: - Add jtag_interface_quit, factored from

Re: [Openocd-development] [patch] reset config updates

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 12:51 -0700, David Brownell wrote: Make it so the magic reset_config keywords can be provided in any order. This eliminates needless error paths, and makes it easier to define things at the right level (adapter, board, target). It also includes two other behavioral

Re: [Openocd-development] [patch] openocd.texi - ARM trace docs (ETM, ETB)

2009-05-29 Thread Zach Welch
On Fri, 2009-05-29 at 17:50 -0700, David Brownell wrote: Provide basic documentation on the ARM ETM and ETB trace commands. Fix minor goofs in registration of the ETM commands; and whitespace issues in the proof-of-concept oocd_trace code. (Plus include a ref to Dominic's email saying that

Re: [Openocd-development] [patch] openocd.texi arch/core commands

2009-05-28 Thread Zach Welch
On Thu, 2009-05-28 at 14:55 -0700, David Brownell wrote: Start converting the architecture-specific commands to @deffn format, reviewing against the code. * armv4_5 disassemble ... now documented; although Jazelle code is not handled * It's armv4_5 core_state not core_mode;

Re: [Openocd-development] [patch] openocd.texi ... more NOR flash drivers

2009-05-28 Thread Zach Welch
On Thu, 2009-05-28 at 18:16 -0700, David Brownell wrote: Provide basic documentation for some of the other flash drivers. avr ... looks incomplete, may work with one AVR8 microcontroller ecosflash ... can't find docs lpc288x ... an NXP part, driver seems lpc2888-specific ocl ... some

Re: [Openocd-development] 0.2.0 Pending RFCs

2009-05-27 Thread Zach Welch
On Mon, 2009-05-25 at 19:02 -0700, Zach Welch wrote: On Sat, 2009-05-23 at 21:55 -0700, Zach Welch wrote: [snip] 2) move board, target, and interface Jim script directories to src/tcl/ - this will move the whole directories intact, parallel to tcl/chip. - more structure can be added

Re: [Openocd-development] vsllink update for scan size

2009-05-27 Thread Zach Welch
On Wed, 2009-05-27 at 00:56 +0800, simon qian wrote: This patch make vsllink support very large scan size in dma mode. Committed, r1926. Maybe jlink driver can also apply similar patch. Care to submit one? :) BTW: This is my new email on gmail. Mail me if it breaks anything. Thanks for

Re: [Openocd-development] [PATCH 1/6] mflash: use mg_ as prefix

2009-05-27 Thread Zach Welch
On Tue, 2009-05-26 at 18:19 +0900, unsik Kim wrote: Change function prefix to mg_ Committed, r1927. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH 2/6] mflash: remove unused bank option

2009-05-27 Thread Zach Welch
On Tue, 2009-05-26 at 18:21 +0900, unsik Kim wrote: remove unused bank option Committed, r1928. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH 3/6] mflash: remove unused flag

2009-05-27 Thread Zach Welch
On Tue, 2009-05-26 at 18:22 +0900, unsik Kim wrote: remove unused flag Committed, r1929. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH 4/6] mflash: add config command

2009-05-27 Thread Zach Welch
On Tue, 2009-05-26 at 18:23 +0900, unsik Kim wrote: add config command Committed, r1930. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH 5/6] mflash: large file write/dump support

2009-05-27 Thread Zach Welch
On Tue, 2009-05-26 at 18:24 +0900, unsik Kim wrote: large file write/dump support Committed, r1931. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [patch/rfc] let reset_config tokens appear in any order

2009-05-27 Thread Zach Welch
On Mon, 2009-05-25 at 23:55 -0700, David Brownell wrote: Make it so the magic reset_config keywords can be provided in any order. Example, trst_and_srst after srst_open_drain, omitting the separate combination (which should be the default in any case). These sorts of improvement seems like

Re: [Openocd-development] [PATCH 1/6] mflash: use mg_ as prefix

2009-05-27 Thread Zach Welch
On Thu, 2009-05-28 at 07:44 +0800, Xiaofan Chen wrote: On Wed, May 27, 2009 at 8:26 PM, Zach Welch z...@superlucidity.net wrote: On Tue, 2009-05-26 at 18:19 +0900, unsik Kim wrote: Change function prefix to mg_ Committed, r1927. One of these patches caused the build error under gcc 4.4

Re: [Openocd-development] [patch 0/3] openocd.texi updates

2009-05-27 Thread Zach Welch
On Wed, 2009-05-27 at 16:53 -0700, David Brownell wrote: Here are more doc updates - get rid of most PDF generation errors, like the line too long ones, as well as the can't do sane linebreak warnings - restructure flash driver descriptions so each driver's info is in one

Re: [Openocd-development] [PATCH] - src/flash/flash.h - Add Doxygen documentation to the various flash structures.

2009-05-26 Thread Zach Welch
On Thu, 2009-05-21 at 23:00 -0400, Duane Ellis wrote: 1) Rather the commit this my self, I'd like somebody to read through the comments (double check my work), much of this is by just reading the source code and entering doxygen text. 2) Well call it doxygen style, sure looks like doxygen,

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-25 Thread Zach Welch
On Sun, 2009-05-24 at 22:43 -0700, Rick Altherr wrote: On May 24, 2009, at 9:37 PM, Zach Welch wrote: On Sun, 2009-05-24 at 21:19 -0700, Rick Altherr wrote: =On May 24, 2009, at 9:04 PM, Zach Welch wrote: On Sun, 2009-05-24 at 20:51 -0700, David Brownell wrote: On Sunday 24 May 2009

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-25 Thread Zach Welch
On Mon, 2009-05-25 at 14:01 -0700, Rick Altherr wrote: On May 25, 2009, at 1:52 PM, Zach Welch wrote: On Mon, 2009-05-25 at 13:10 -0700, Rick Altherr wrote: [snip] Sorry Rick, but I think that you and Duane have lost this argument. You have failed to defend your position with facts

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-25 Thread Zach Welch
On Mon, 2009-05-25 at 14:38 -0700, Rick Altherr wrote: On May 25, 2009, at 2:24 PM, Zach Welch wrote: Further, you can argue with the following assertions -- only if you can show me a patch that proves them wrong: Show me your patch, or let me commit mine. This debate is silly

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-25 Thread Zach Welch
On Mon, 2009-05-25 at 15:02 -0700, Rick Altherr wrote: On May 25, 2009, at 2:50 PM, Zach Welch wrote: On Mon, 2009-05-25 at 14:38 -0700, Rick Altherr wrote: On May 25, 2009, at 2:24 PM, Zach Welch wrote: Further, you can argue with the following assertions -- only if you can

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-25 Thread Zach Welch
On Mon, 2009-05-25 at 16:02 -0700, Rick Altherr wrote: On May 25, 2009, at 3:37 PM, Zach Welch wrote: The opposing patch is attached. As I already mentioned, it is large, but the changes were done entirely with the following commands: find . -name \*.[ch] -exec sed -i .old -e 's/u8

Re: [Openocd-development] openocd boundary scan

2009-05-25 Thread Zach Welch
On Mon, 2009-05-25 at 15:21 -0700, Paul Thomas wrote: Hello, I would like to do a boundary scan on a imx27 part. I've looked through the documentation and mailing list and I don't see much on this. The most helpful thing has been a very short wikipedia entry on the SVF format

Re: [Openocd-development] svf patch for 32bit scan

2009-05-25 Thread Zach Welch
On Tue, 2009-05-26 at 00:34 +0800, SimonQian wrote: Add svf_get_mask_u32 to generate a mask according to bitlen. Fix this bug in other functions except for svf_check_tdo. Next patch will fix the segfault reported by R.Doss. Committed, r1914.

Re: [Openocd-development] svf patch for segfault

2009-05-25 Thread Zach Welch
On Tue, 2009-05-26 at 02:03 +0800, SimonQian wrote: This patch fix segfault reported by R.Doss. Committed, r1915. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] 0.2.0 Pending RFCs

2009-05-25 Thread Zach Welch
On Sat, 2009-05-23 at 21:55 -0700, Zach Welch wrote: [snip] 2) move board, target, and interface Jim script directories to src/tcl/ - this will move the whole directories intact, parallel to tcl/chip. - more structure can be added, if we see fit; this is a small step. - http

Re: [Openocd-development] Sorry for breaking the thread

2009-05-25 Thread Zach Welch
On Tue, 2009-05-26 at 11:36 +0800, SimonQian wrote: As Zach Welch mentioned, my posts breaks the thread. Translation: for some reason he and a few others' replies are often (but not always) threaded incorrectly in some e-mail readers. To give a basis for comparison, look at the BerliOS archive

Re: [Openocd-development] [patch] minor davinci_nand bugfix

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 13:38 -0700, David Brownell wrote: Fix a bug that joined us at the last minute, when an efficient alloca() call got swapped out for a more portable malloc(). Also log one error, to give a clue in case it appears in the wild. --- src/flash/davinci_nand.c |6 --

Re: [Openocd-development] [patch] fix useless illegal mode diagnostic

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 13:45 -0700, David Brownell wrote: The Illegal mode for command diagnostic is deeply useless. Say Command '%s' only runs during configuration stage instead, letting users know what the real issue is. --- src/helper/command.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [Openocd-development] [patch] jtag_hz updates, mostly doc

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 13:49 -0700, David Brownell wrote: On Sunday 24 May 2009, David Brownell wrote: - move deprecated jtag_speed into collection of deprecated calls Also, I think all those deprecated calls should be issuing runtime warnings, nudging scripts to get rid of their usage.

Re: [Openocd-development] [patch] remove port 'using default' messages; doc updates

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 13:46 -0700, David Brownell wrote: Make startup for the various server ports be quiet, unless debugging is active: don't emit needless scarey messages. Update the relevant documentation and its references: - For these port commands ... cover the default values;

Re: [Openocd-development] 0.2.0 Status Report

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 15:28 -0700, David Brownell wrote: On Sunday 24 May 2009, Zach Welch wrote: The OpenOCD User Guide: (aka The Guide) Someone needs to change the name of the document then; it's now Open On-Chip Debugger (OpenOCD). Agreed that calling it a User's Guide would clarify

Re: [Openocd-development] 0.2.0 Pending RFCs

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 20:53 -0400, Duane Ellis wrote: zach [previous things] david Well, yes ... what eventually goes into /usr/include should be strongly limited to the interfaces. How anything gets implemented inside the library is nobody's busienss except for the library

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 21:40 -0400, Duane Ellis wrote: That is the other question: stdint.h is a C99 header, yes? It might be better to unconditionally included it, defining our short types from it. What do you think? We already do, it is included by 'types.h'. Conditionally. The

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 20:51 -0700, David Brownell wrote: On Sunday 24 May 2009, Zach Welch wrote: - add iN equivalents to intN_t types; i32 is used by replacements.h The traditional sibling of a u32 (unsigned) is an s32 (signed). I don't know where i32 came from, it's an interloper

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 21:19 -0700, Rick Altherr wrote: =On May 24, 2009, at 9:04 PM, Zach Welch wrote: On Sun, 2009-05-24 at 20:51 -0700, David Brownell wrote: On Sunday 24 May 2009, Zach Welch wrote: - add iN equivalents to intN_t types; i32 is used by replacements.h The traditional

Re: [Openocd-development] RFC: uint32_t vrs u32 - et al

2009-05-24 Thread Zach Welch
On Sun, 2009-05-24 at 21:37 -0700, Zach Welch wrote: On Sun, 2009-05-24 at 21:19 -0700, Rick Altherr wrote: =On May 24, 2009, at 9:04 PM, Zach Welch wrote: On Sun, 2009-05-24 at 20:51 -0700, David Brownell wrote: On Sunday 24 May 2009, Zach Welch wrote: - add iN equivalents

Re: [Openocd-development] Building OpenOCD with Cygwin

2009-05-23 Thread Zach Welch
On Sun, 2009-05-24 at 00:38 +0800, SimonQian wrote: Add #include stdint.h in replacements.h to solve this problem. There has been a report of this in the past, but I thought that it turned out to be a red herring:

Re: [Openocd-development] SVN revision in Windows

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 16:11 +0200, Freddie Chopin wrote: Michael Fischer pisze: have you installed SVN under Cygwin too? I use MSYS + MinGW to compile, so I guess that I should use some SVN client for MSYS for that feature to work? Yes. Take a look at guess-rev.sh. --Z

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 09:54 +0200, Magnus Lundin wrote: Comment - In jlink_execute_reset(jtag_command_t *cmd) jlink_tap_execute(); Should be removed and be superflous, actually both of them should be removed. After seeing your latest post, I now think I understand this to mean that the

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 13:42 -0700, Zach Welch wrote: On Sat, 2009-05-23 at 09:54 +0200, Magnus Lundin wrote: Comment - In jlink_execute_reset(jtag_command_t *cmd) jlink_tap_execute(); Should be removed and be superflous, actually both of them should be removed. After seeing your

[Openocd-development] [PATCH] remove cmd_queue_cur_state

2009-05-23 Thread Zach Welch
Hi all, The attached patch removes the cmd_queue_cur_state global variable, replacing all uses with calls to tap_set_state() or tap_get_state(). While this seems completely trivial, I wanted to post it for review. Any objections? All in favor? Cheers, Zach --- jtag/jtag.c | 13

Re: [Openocd-development] RFC: style guide update

2009-05-23 Thread Zach Welch
On Wed, 2009-05-20 at 01:08 -0700, Zach Welch wrote: Hi all, I want to get the style guide up-to-date. Here's my plan. Barring any objections, I will add doc/manual/style.txt by moving the relevant bits out of openocd.texi. The style guide is for developers working on the code; the user

Re: [Openocd-development] Adding simulated target support for regression testing purposes

2009-05-23 Thread Zach Welch
On Thu, 2009-05-21 at 16:54 -0700, David Brownell wrote: On Thursday 21 May 2009, Michael Fischer wrote: It looks that these JTAG interfaces have not the same behaviour. One point could be the RESET signals SRST and TRST. Here the FT2232 can set both signals at the same time, which I think

Re: [Openocd-development] SAM7S256 still broken, by 1889 too

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 21:41 +0200, Freddie Chopin wrote: Zach Welch pisze: So if I understand this right: 1) With jtag.c patch from Magnus, it works with short delays. 2) Without that patch, it requires long delays. Is that summary correct? No (; If there is ANY delay both versions

Re: [Openocd-development] SVF patch according to Johann's test

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 02:05 +0800, SimonQian wrote: it only changes svf_check_tdo function, which is used to check tdo output with desired values. The patch will call buf_cmp_mask function to do the comparation instead of writing the loop code. The patch also fix a bug when data length is

Re: [Openocd-development] [PATCH] Doxygen - build when SRCDIR != BLDDIR - it fails

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 21:22 -0400, Duane Ellis wrote: See attached patch. Doxygen does not build if source dir != build dir. This patch fixes that. Does r1901 float your boat better? It's technically more correct, as far as I know. A PITA, but correct. ;) Cheers, Zach

Re: [Openocd-development] Being careful not to brake anything is good but ...

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 18:42 -0700, Rick Altherr wrote: On May 23, 2009, at 1:30 PM, Magnus Lundin wrote: Common people So much soul searching about a oneliner in jtag.c . Setting the current tap state with cmd_queue_cur_state = TAP_RESET is an obvious error as 5 minutes of code

Re: [Openocd-development] Being careful not to brake anything is good but ...

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 18:48 -0700, Zach Welch wrote: [snip] At this point, I have a system in place to make it unlikely for me to let any threads be forgotten, but I am still trying to catch all those that are still in the air. One thing you might look at is David's recent NAND changes

Re: [Openocd-development] [patch] davinci NAND for OpenOCD

2009-05-23 Thread Zach Welch
On Fri, 2009-05-22 at 10:43 -0700, David Brownell wrote: NAND support for DaVinci-family drivers, with HW ECC support. Declare the NAND chip on the DM355 EVM board. Currently tested on DM355 for Linux interop using the standard large page (2KB) chip in the EVM socket; hwecc1 and hwecc4 work

Re: [Openocd-development] [patch] more NAND cleanup and doc updates

2009-05-23 Thread Zach Welch
On Fri, 2009-05-22 at 20:28 -0700, David Brownell wrote: Update two oddball NAND commands to work with {offset, length} instead of block numbers, matching the other commands as well as usage in U-Boot and the Linux-MTD utilities. Document them accordingly. Update the single in-tree use of

Re: [Openocd-development] [PATCH] make SheevaPlug init more reliable

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 21:59 -0400, Nicolas Pitre wrote: When the CPU is in the WFI state, the JTAG interface simply doesn't respond at all and initial tap examination simply fails. Let's simply do it again when we come around to assert nSRST. Committed as r1905. --Z

Re: [Openocd-development] [PATCH] FT2232H / FT2242H support for D2XX driver

2009-05-23 Thread Zach Welch
On Wed, 2009-05-20 at 22:59 -0700, Zach Welch wrote: On Wed, 2009-05-20 at 22:54 -0700, Rick Altherr wrote: On May 20, 2009, at 10:31 PM, Zach Welch wrote: On Wed, 2009-05-20 at 22:23 -0700, Rick Altherr wrote: On Mar 25, 2009, at 2:54 PM, joern kaipf wrote: * autodetection if FS

Re: [Openocd-development] Broken r1870 (head)

2009-05-23 Thread Zach Welch
On Fri, 2009-05-22 at 10:57 +0200, Øyvind Harboe wrote: Trying again... My editor is screwing things up with whitespace, hence all those irrelevant changes... The second attempt was no better. Here it is done right. Please let me know if this fixes things, and I will get it committed.

Re: [Openocd-development] svn 1881 with jlink and STM32

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 03:57 -0700, David Brownell wrote: I am also thinking that the USB timeout value may be extended a bit longer. Right now it is 1000ms. Should be ok. But may not be ok for people using VM or similar. The problem with this is that it slows down the failure

Re: [Openocd-development] Being careful not to brake anything is good but ...

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 20:16 -0700, David Brownell wrote: On Saturday 23 May 2009, Zach Welch wrote: At this point, I have a system in place to make it unlikely for me to let any threads be forgotten, Some Linux groups use a new tool called patchwork which monitors mailing lists

Re: [Openocd-development] svn 1881 with jlink and STM32

2009-05-23 Thread Zach Welch
On Sat, 2009-05-23 at 21:06 -0700, David Brownell wrote: On Saturday 23 May 2009, Zach Welch wrote: Considering that USB bulk transfers are best effort and might easily be delayed by concurrent activity to a USB disk or webcam ... a single second seems absurdly short. Even

[Openocd-development] 0.2.0 Status Report

2009-05-23 Thread Zach Welch
been reported and should try to be resolved: - reset issues (possibly regressions due to 1890, 1892, and 1893) - flashing on LPC-P2148 (Xiaofan Chen) - LPC2000 series problems - others? Cheers, Zach Welch Corvallis, OR ___ Openocd-development mailing

[Openocd-development] 0.2.0 Pending RFCs

2009-05-23 Thread Zach Welch
in these matters. Cheers, Zach Welch Corvallis, OR P.S. There are other pending RFCS, but they do not seem 0.2.0 material. ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd

Re: [Openocd-development] RFC: relocate configuration scripts?

2009-05-22 Thread Zach Welch
On Thu, 2009-05-21 at 22:38 -0400, Duane Ellis wrote: Zach static inline functions should be preferred over macros, yes. I personally despise 'static inline' functions. One cannot never set breakpoints on them, because the debugger cannot figure out *which* instance you want to set

Re: [Openocd-development] RFC: relocate configuration scripts?

2009-05-22 Thread Zach Welch
On Thu, 2009-05-21 at 20:23 -0700, David Brownell wrote: On Thursday 21 May 2009, Zach Welch wrote: I feel like this is a dumb question but here goes Why [are] all of the TCL configuration files (src/target/{target,board,interface}/*) located in src/target/ instead of src/tcl

Re: [Openocd-development] RFC: relocate configuration scripts?

2009-05-22 Thread Zach Welch
On Fri, 2009-05-22 at 06:35 -0400, Duane Ellis wrote: zach Also, because they are not really TCL scripts. zach They are Jim TCL scripts, . so -- zach if anything -- they should be renamed '.jim' -1 From me. That suggestion was mostly in jest. The main config scripts (interface,

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-22 Thread Zach Welch
On Sat, 2009-05-23 at 00:18 +0200, Magnus Lundin wrote: Zach Welch wrote: On Tue, 2009-05-19 at 16:53 +0200, Magnus Lundin wrote: Hi Info : J-Link compiled Feb 20 2006 18:20:20 -- Update -- Info : JLink caps 0x3 Error: J-Link command EMU_CMD_GET_MAX_MEM_BLOCK failed (-110

Re: [Openocd-development] [PATCH] Doxygen strip code comments = NO

2009-05-22 Thread Zach Welch
On Fri, 2009-05-22 at 20:05 -0400, Duane Ellis wrote: I prefer the STRIP_CODE_COMMENTS = NO Reason: Don't hide things. Make it all visible. Committed r1887. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-22 Thread Zach Welch
On Sat, 2009-05-23 at 09:12 +0800, Xiaofan Chen wrote: On Sat, May 23, 2009 at 6:18 AM, Magnus Lundin lun...@mlu.mine.nu wrote: There is a set of new patches that has been tested by Michael Fischer, as far as i know there were no problems. There are still things that should be fixed in

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-22 Thread Zach Welch
On Sat, 2009-05-23 at 09:35 +0800, Xiaofan Chen wrote: 2009/5/23 Zach Welch z...@superlucidity.net: I'd like to test as well for my V3 black J-link. It works well with your previous patch. But the latest trunk does not build under Arch Linux. It is also pointed out by Simon Qian. How

Re: [Openocd-development] OpenOCD and different versions of J-Link

2009-05-22 Thread Zach Welch
On Sat, 2009-05-23 at 00:46 +0200, Magnus Lundin wrote: Zach Welch wrote: On Sat, 2009-05-23 at 00:18 +0200, Magnus Lundin wrote: Zach Welch wrote: On Tue, 2009-05-19 at 16:53 +0200, Magnus Lundin wrote: [snip] There is a set of new patches that has been tested

[Openocd-development] RFC: add doc/interface/*, doc/target/*, and doc/board/*

2009-05-21 Thread Zach Welch
Hi all, In thinking about user documentation, I was wondering whether we should think about adding doc/target/ and doc/boards directories. In it, we would place a documentation file for each supported target and board, respectively. It may be possible to consolidate some guides, but this would

Re: [Openocd-development] Testing, bug tracking and external lists

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 02:41 +0200, Magnus Lundin wrote: [snip] Simply redirecting users with problems to this list is IMHO not a solution. This is where the eyeballs are today. Myself, I do not like web forums and will not voluntarily spend my time on them. Further, I am not keen on splitting

[Openocd-development] RFC: bug/patch/testing tracking

2009-05-21 Thread Zach Welch
to these points. Sincerely, Zach Welch Corvallis, OR ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [patch] printf format bugfixes

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 01:22 -0700, David Brownell wrote: I've tripped across several bugs caused by bad printf format strings. This is foolish, since GCC will tell about them when functions have proper annotations. This patch adds annotations to the key command_*() helper functions. And

Re: [Openocd-development] Balloon board config and some queries

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 21:50 +0100, Wookey wrote: +++ Wookey [2009-05-19 12:29 +0100]: As described on http://www.balloonboard.org/balloonwiki/Balloon3OpenOCD I have working configs for use with the balloon board and Olimex and Amontec JTAG dongles. I won't copy them all into this message

[Openocd-development] RFC: relocate configuration scripts?

2009-05-21 Thread Zach Welch
Hi all, I feel like this is a dumb question but here goes Why aren't all of the TCL configuration files (src/target/{target,board,interface}/*) located in src/target/ instead of src/tcl/? I would be more than happy to manage the process of making the moves, but I cannot understand why this

Re: [Openocd-development] RFC: relocate configuration scripts?

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 17:14 -0700, Zach Welch wrote: Hi all, I feel like this is a dumb question but here goes Why aren't all of the TCL configuration files (src/target/{target,board,interface}/*) located in src/target/ instead of src/tcl/? As-is, the question is double-dumb; please s

Re: [Openocd-development] Request of feature freeze

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 17:02 -0700, David Brownell wrote: On Thursday 21 May 2009, Rick Altherr wrote: At this point we are not introducing new features or functionality to SVN. Hmm, I was hoping to send a new NAND driver now that it's basically working ... and some updated board support

Re: [Openocd-development] RFC: relocate configuration scripts?

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 21:43 -0400, Duane Ellis wrote: Zach Welch wrote: Hi all, I feel like this is a dumb question but here goes Why aren't all of the TCL configuration files (src/target/{target,board,interface}/*) located in src/target/ instead of src/tcl/? I presume you

Re: [Openocd-development] [patch] NAND texi

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 18:25 -0700, David Brownell wrote: Add a NAND Commands section to to the TEXI docs, covering the basic commands except for those previously discussed as being due for removal (nand copy) or switching to use byte offsets not block numbers. This uses the @deffn... syntax

Re: [Openocd-development] [PATCH] arm7_9_common: Documentation and typos

2009-05-21 Thread Zach Welch
On Thu, 2009-05-21 at 19:49 -0500, Dean Glazeski wrote: Dean Glazeski dngl...@gmail.com Applied r1880. --Z ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

<    2   3   4   5   6   7   8   9   >