Ack,
This check was previously in avd_su_db_add but got removed with the new db
Thanks,
Hans
-Original Message-
From: praveen.malv...@oracle.com [mailto:praveen.malv...@oracle.com]
Sent: den 30 maj 2014 13:20
To: Hans Feldt; nagendr...@oracle.com
Cc:
Hi Nagu
Sorry, I forgot to change the 3 instances of '%d' below, to '%u'.
Can you please change before pushing, or should I send another patch?
Thanks
Gary
On Mon, 2014-06-02 at 13:08 +1000, Gary Lee wrote:
+
+void su_increment_su_restart_count(AVND_SU su)
+{
+ su.su_restart_cnt++;
+
Hi Gary,
I will take this part.
Thanks
-Nagu
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 02 June 2014 12:18
To: hans.fe...@ericsson.com
Cc: hans.nordeb...@ericsson.com; Praveen Malviya; Nagendra Kumar;
opensaf-devel@lists.sourceforge.net
Ack,
Minor comments inline.
Additionally, should we log when a probation timer is started and its duration?
I think it would be good, then we can see how a user has configured and we can
correlate with the timeout log entry. We can add this in a subsequent patch.
Thanks,
Hans
-Original
Comments inline
Thanks,
Hans
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juni 2014 08:20
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;
praveen.malv...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfd:
Hi Hans,
On 5/20/2014 12:36 AM, Hans Feldt wrote:
Next steps:
- Set DEST_DROPPABLE=False
What are we planning to achieve ? if it is only for Loging , we
already have `i_msg_loss_indication` flag
which is part of svc_install , if enabled any message is lost a
callback of type
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 2 juni 2014 09:20
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [opensaf:tickets] #654 MDS improvements
Hi Hans,
On 5/20/2014 12:36 AM, Hans Feldt wrote:
Next steps:
- Set DEST_DROPPABLE=False
What are we
Please see comments inline
Thanks/Minh
On 6/2/2014 5:02 PM, Hans Feldt wrote:
Comments inline
Thanks,
Hans
-Original Message-
From: Minh Hon Chau [mailto:minh.c...@dektech.com.au]
Sent: den 2 juni 2014 08:20
To: Hans Feldt; Hans Nordebäck; nagendr...@oracle.com;
Ack.
Can you please update the ticket with the below remarks:
* log when SU restart/failover limits have been reached
* log each time a SU restart/failover occurs
* add a log entry when error escalation is changed
* log each time a component is restarted, or when restart limits have been
osaf/services/saf/amf/amfd/imm.cc | 5 +
1 files changed, 5 insertions(+), 0 deletions(-)
Standby AMFD process ccb completed cbk.
AMFD processes all ccb completed cbk without checking its own HA role.
Since standby AMFD is just an applier, all the CCB related validation
should be done by
Summary: amfd : skip processing of ccb completed cbk at standby amfd [#305]
Review request for Trac Ticket(s): #305
Peer Reviewer(s): AMF contributors
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): ALL
Development branch: IF ANY GIVE THE REPO URL
Why don't you do a general change in imm.cc ccb_completed_cb and instead remove
all checks in class specific completed callbacks?
Basically move the check you have proposed into imm.cc ccb_completed_cb
Thanks,
Hans
-Original Message-
From: praveen.malv...@oracle.com
osaf/services/saf/amf/amfd/include/si.h | 2 +-
osaf/services/saf/amf/amfd/si.cc | 16
osaf/services/saf/amf/amfd/sirankedsu.cc | 2 +-
3 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/si.h
osaf/services/saf/amf/amfd/app.cc| 18 +-
osaf/services/saf/amf/amfd/include/app.h | 2 +-
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/app.cc
b/osaf/services/saf/amf/amfd/app.cc
--- a/osaf/services/saf/amf/amfd/app.cc
Summary: amfd: add support for different key types in db_template v2
Review request for Trac Ticket(s): #713
Peer Reviewer(s): HansF, Nagu, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Summary: osaf: port existing daemonization and nid process to systemd
new-style daemon
Review request for Trac Ticket(s): 455
Peer Reviewer(s): HansF, AndersW
Pull request to: AndersW
Affected branch(es): branch
Development branch:
Impacted area Impact y/n
Makefile.common | 1 +
configure.ac | 16 ++
contrib/plmc/Makefile.common | 1 +
contrib/plmc/config/plmcd.conf | 4 +
Hi Hans,
On 6/2/2014 1:40 PM, Hans Feldt wrote:
*/[Hans] DEST_DROPPABLE works on the sending node whereas
MDS_CALLBACK_MSG_LOSS works on the receiving node. So I guess they can
just complement each other?/*
*/We can never have too much info.../*
You are right both complement each other
osaf/services/saf/amf/amfd/include/su.h |9 +
osaf/services/saf/amf/amfd/su.cc| 461 +--
2 files changed, 257 insertions(+), 213 deletions(-)
complexity of su.cc dropped pretty good:
$ pmccabe su.cc | sort -nr | head -2
73 78 154 865
osaf/libs/common/amf/d2nmsg.c | 184 --
osaf/libs/common/amf/include/amf_d2nmsg.h |1 -
osaf/services/saf/amf/amfd/include/mds.h |1 -
osaf/services/saf/amf/amfd/include/msg.h |1 -
osaf/services/saf/amf/amfd/mds.cc | 175
osaf/services/saf/amf/amfd/include/su.h | 1 +
osaf/services/saf/amf/amfd/sgproc.cc| 40
osaf/services/saf/amf/amfd/su.cc| 17 ++
3 files changed, 28 insertions(+), 30 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/su.h
Summary: AMF SU refactoring
Review request for Trac Ticket(s): 713
Peer Reviewer(s): AMF developers
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: IF ANY GIVE THE REPO URL
Impacted area Impact y/n
osaf/services/saf/amf/amfd/chkop.cc | 1 +
osaf/services/saf/amf/amfd/include/ntf.h | 14 +++-
osaf/services/saf/amf/amfd/ntf.cc| 54 ++-
3 files changed, 64 insertions(+), 5 deletions(-)
This is enhancement that standby amfd sends notification
Summary: amfd: Send notifications when cold sync is completed [#860]
Review request for Trac Ticket(s): 860
Peer Reviewer(s): Hans F, Hans N, Nagendra, Praveen
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 3 juni 2014 06:21
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [opensaf:tickets] #654 MDS improvements
Hi Hans,
On 6/2/2014 1:40 PM, Hans Feldt wrote:
[Hans] DEST_DROPPABLE works on the sending node whereas
25 matches
Mail list logo
