Johan,
Nice work. The sample applications depict the usage of different
features in IMMOI in a simple way.
Here are couple of comments.
-> The file python/pyosaf/utils/immoi/Makefile.am is not part of patch
sent. Because of which, compilation fails.
-> As the file
Hi Hung,
Reviewed and tested the patch.
Ack.
/Neel.
On Wednesday 16 September 2015 02:12 PM, Hung Nguyen wrote:
> Summary: imm: Assigning default value to no-dangling attributes make cluster
> fail to start [#1474]
> Review request for Trac Ticket(s): 1474
> Peer Reviewer(s): AndersBj, Zoran,
Hi Srikanth,
Comments inline.
/ Johan
-Original Message-
From: Srikanth Revanuru [mailto:srikanth.revan...@oracle.com]
Sent: den 18 september 2015 11:01
To: Johan Mårtensson O; Hans Nordebäck; mathi.naic...@oracle.com; Hung Nguyen D
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
osaf/tools/safimm/immadm/imm_admin.c | 2 +-
osaf/tools/safimm/immcfg/imm_cfg.c | 2 +-
osaf/tools/safimm/immcfg/imm_import.cc | 6 --
osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 9 +
osaf/tools/safimm/immfind/imm_find.c | 2 +-
opensaf.spec.in | 1 +
osaf/libs/agents/saf/imma/imma_cb.h | 1 +
osaf/libs/agents/saf/imma/imma_def.h | 2 +-
osaf/libs/agents/saf/imma/imma_oi_api.c | 3 +
osaf/libs/agents/saf/imma/imma_om_api.c | 12
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 30 ++
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
osaf/services/saf/immsv/immnd/immnd_init.h | 1 +
4 files changed, 33 insertions(+), 0 deletions(-)
Add
osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 +-
osaf/services/saf/immsv/immloadd/imm_pbe_load.cc |2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 81 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 17 +
Summary: imm: Add attribute def flag SA_IMM_ATTR_DEFAULT_REMOVED [#1471]
Review request for Trac Ticket(s): 1471
Peer Reviewer(s): AndersBj, Zoran, Neelakanta
Pull request to: Zoran
Affected branch(es): default(4.7)
Development branch: default(4.7)
Impacted area
tests/immsv/common/immtest.c |4 +-
tests/immsv/management/test_saImmOmClassCreate_2.c | 661 +
2 files changed, 663 insertions(+), 2 deletions(-)
Add test cases for default value removal.
diff --git a/tests/immsv/common/immtest.c
Hi all!
I would like to remind everyone that we intend to tag OpenSAF 4.7.FC on
October 1, which is about two weeks from now. Please make sure that you
have accepted all enhancement tickets that you intend to include in
OpenSAF 4.7, and send out the code for review well in advance before
Johan,
Comments inline
- johan.o.martens...@ericsson.com wrote:
> Hi Srikanth,
>
> Comments inline.
>
> / Johan
>
> -Original Message-
> From: Srikanth Revanuru [mailto:srikanth.revan...@oracle.com]
> Sent: den 18 september 2015 11:01
> To: Johan Mårtensson O; Hans Nordebäck;
osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c | 6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
When SA_PLM_ADMIN_DEACTIVATE is issued for an ATCA FRU, the HE presence
state gets stuck in SA_PLM_HE_PRESENCE_DEACTIVATING, and never transitions
to SA_PLM_HE_PRESENCE_INACTIVE.
The
Summary: PLM: fix deactivate for ATCA
Review request for Trac Ticket(s): [#1289]
Peer Reviewer(s): Mathi
Pull request to: Mathi
Affected branch(es): 4.5, 4.6, default
Development branch:
Impacted area Impact y/n
Docs
Ack for all patches of the series.
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 17 September 2015 10:53
> To: hans.nordeb...@ericsson.com; Praveen Malviya; Nagendra Kumar;
> minh.c...@dektech.com.au; gary@dektech.com.au
> Cc:
Hi Neelakanta,
1. free() is safe for NULL value and there is no need for extra check.
2. It is not missed.
OM for ccbAugmentInit is OI callback.
Error string is attached to the main CCB (not to augmented CCB), and sending
error string over MDS is skipped:
if(ccb->mVeto != SA_AIS_OK) {
Hi Hung,
Find my comments inline.
From: Hung Nguyen D
Sent: Thursday, September 17, 2015 12:00 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] imm: classify abort error strings and
prefix existing error strings
Ack
Thanks
Lennart
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 17 september 2015 12:46
To: mathi.naic...@oracle.com; Lennart Lund; Giang Do T
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] log: cannot delete value of
Hi zoran,
Ok, I overlooked the functionality part immnd_evt_ccb_augment_init.
Thanks,
Neel.
On Friday 18 September 2015 06:47 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> 1. free() is safe for NULL value and there is no need for extra check.
>
> 2. It is not missed.
> OM for
Hi Gary,
ack, one question, please see inline.
/Thanks HansN
/Thanks Hans
On 09/17/2015 07:22 AM, Gary Lee wrote:
> osaf/services/saf/amf/amfd/sg.cc | 179
> +++---
> 1 files changed, 90 insertions(+), 89 deletions(-)
>
>
> diff --git
Ack. I think this patch is on top of older patches, so was not able to apply,
but could review.
Thanks
-Nagu
> -Original Message-
> From: Gary Lee [mailto:gary@dektech.com.au]
> Sent: 17 September 2015 11:25
> To: hans.nordeb...@ericsson.com; Nagendra Kumar;
>
20 matches
Mail list logo
