src/amf/amfd/app.cc| 3 +-
src/amf/amfd/apptype.cc| 9 +
src/amf/amfd/chkop.cc | 3 +-
src/amf/amfd/ckpt_dec.cc | 15 +++
src/amf/amfd/ckpt_edu.cc | 3 +-
src/amf/amfd/ckpt_enc.cc | 60 ---
Hi Vu,
ACK
-AVM
On 3/6/2017 5:41 PM, Vu Minh Nguyen wrote:
> src/log/logd/lgs_dest.cc | 4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>
> DestinationHandler::UpdateRtDestStatus() uses lgs_cfgupd_mutival_replace()
> to update logRecordDestinationStatus but not freeing buffer
> Ok. I have no comment with your fix for cppcheck 1.77's report.
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Tuesday, March 7, 2017 5:11 AM
>> To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>;
>
errors, as if i have already recive ACK for Lennart and Canh
I would lie to push .
-AVM
On 3/6/2017 8:48 AM, A V Mahesh wrote:
> Hi Vu,
>
> Ok I will check & match with other DB definitions .
>
> -AVM
>
>
> On 3/3/2017 12:49 PM, Vu Minh Nguyen wrote:
>> Hi Ma
Hi Hoang Vo,
ACK , with following ,tested.
use directly the macro `#MDS_DIRECT_BUF_MAXSIZE (65535 - (57 +
_POSIX_HOST_NAME_MAX))`
src/mds/mds_papi.h , so that in further change in MDS header will not
effect the test case .
-AVM
On 3/6/2017 1:20 PM, Hoang Vo wrote:
>
Hi Lennart ,
I just raised Ticket to #2326 log : fix all cpp check issues, as if
#1984 pushed
I will fix #2326 as soon as possible.
-AVM
On 2/24/2017 4:53 PM, Lennart Lund wrote:
> Hi Mahesh
>
> Ack with comments
>
> Comments inline [Lennart]
>
> * Remove '#include "base/ncspatricia.h"' in
Hi Vu,
ACK with following for All patch list
Note : default functionality tested , Enhancement specific
functionality not tested.
- consider optimizing encoding function uint32_t edp_ed_open_stream_rec()
- Update PR document
- Is multiple alternative destinations allowed concurrently ?
Hi Vu,
Except replacing `const auto`, incorporated all other comments.
I will consider replacing `const auto` after 5.2 tag, to avoid last
minute change .
-AVM
On 2/24/2017 1:52 PM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> Ack with comments, [Vu].
>
> Regards, Vu
>
>> -Original
Hi Lennart,
I just published V1 by re-baseing on latest staging.
can you please review.
-AVM
On 2/24/2017 9:06 AM, A V Mahesh wrote:
> Hi Lennart,
>
> The lgs_send_severity_filter_to_clients() function introduced in
> latest enhancements
> I will re-base and republish .
>
Hi Lennart,
The lgs_send_severity_filter_to_clients() function introduced in latest
enhancements
I will re-base and republish .
-AVM
On 2/23/2017 8:40 PM, Lennart Lund wrote:
> Hi Mahesh,
>
> The patch cannot be applied on latest changeset. The main problem is function
>
> Sorry, I missed fixing other point. See 2258_additional_fix_err.patch.
>
> For your convenience, I pack them all to new version 2258_v10.patch.
>
> Regards, Vu
>
>> -Original Message-
>> From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
>> Sent: Thu
Hi Lanert
ACK , ( code review only ) will be tested along with Vu Part of #2258
-AVM
On 2/23/2017 3:41 PM, A V Mahesh wrote:
> Hi Lanert
>
> This means , user can configure multiple DESTINATION_CONFIGURATION
> concurrently ?
>
>
> + switch (attrMod->mo
Hi Vu,
On 2/23/2017 3:13 PM, A V Mahesh wrote:
>
> Not sure what are other change compare to V7 to V9 , New problems got
> introduced
>
> Both nodes SC-1 & SC-2 ( with 2258_v9.patch ) , trying bring up both
> SC`s simple node bringup ,
>
> SC-2 goi
based on the latest changeset.
>
> Note that, in the attached patch, I have included one more dependency,
> that is on base::Hash() function, the patch sent by Anders [#2266]
>
> Please review the patch, then comment if any. Thanks.
>
> Regards, Vu
>
>> -Original Message-
&
I have included one more dependency,
> that is on base::Hash() function, the patch sent by Anders [#2266]
>
> Please review the patch, then comment if any. Thanks.
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
)
===
-AVM
On 2/23/2017 11:44 AM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> Maybe it was broken when transmitting. I zipped to a tar file. Please try it
> one more.
>
> Regards, Vu
>
>
>> -Original Me
> To apply 2258_v7.patch, please do remove the just pushed ticket "log:
> implement SaLogFilterSetCallbackT and version handling [#2146]" ,
> I have not rebased the code on that yet.
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh
try to bring up that node in to cluster.
-AVM
>
> I have informed this to IMM to have a look, not sure any problem with MDS
> layer or any problem with my environment setup.
> In the meantime, please have a look at the updated patch, I will continue
> checking the problem. Will kee
Please see correction New Standby SC-1 ( with patch )
-AVM
On 2/22/2017 4:02 PM, A V Mahesh wrote:
> Hi Vu,
>
> With this new patch , we have another issue :
>
> 1) standby Core by `/usr/lib64/opensaf/osaflogd' issue got resolved .
>
> 2) In-service upgrade is Not working
-AVM
On 2/22/2017 3:13 PM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> I put all required patches into one. Try to use this and see if you still
> have that problem or not.
>
> Regards, Vu
>
>> -Original Message-
>
c
> Backtrace still points to old position (lgs_mbcsv:2195). I guess the
> osaflogd binary has not been updated with the fixed patch.
>
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Wednesday, February 22,
Sg=2N,safApp=OpenSAF Faulted due to:avaDown
Recovery is:nodeFailfast
Feb 22 13:40:56 SC-2 osafamfnd[4634]: Rebooting OpenSAF NodeId = 131599
EE Name = , Reason: Component faulted: recovery is node failfast,
OwnNodeId = 131599, SupervisionTime = 60
Feb 22 13:40:56 SC-2 opensaf_reboot: Rebooting local node; timeout=60
=
19 PM, Vu Minh Nguyen wrote:
> Hi Mahehs,
>
> See my reply inline, [Vu].
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Wednesday, February 22, 2017 1:36 PM
>> To: Vu Minh Nguyen <vu.
: Rebooting local node; timeout=60
On 2/22/2017 12:05 PM, A V Mahesh wrote:
> Hi Vu,
>
>
> On 2/22/2017 11:52 AM, Vu Minh Nguyen wrote:
>> Hi Mahesh,
>>
>> Have a code fa
check to that test case later.
-AVM
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Wednesday, February 22, 2017 12:16 PM
>> To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>;
>> lennart
ACK not tested
-AVM
On 2/21/2017 10:49 PM, Anders Widell wrote:
> src/dtm/transport/log_writer.cc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> Use a ".1" file name extension for the MDS log backup file. This aligns with
> the
> naming convention used for log rotation
wrote:
> Hi Mahesh,
>
> I send them in attachment instead, and name them in the order.
> I just pull the latest code, and apply them without getting any hunk error.
>
> Please try with them, and let me know if you see any problem.
>
> Regards, Vu
>
>> -Original
Hi Vu,
Sorry I did missed Lennart #2258 (v2) , now it is fine
-AVM
On 2/22/2017 9:39 AM, A V Mahesh wrote:
> Hi Vu,
>
> I did follow that still i get Hunk #2 FAILED even on today's staging
>
>
by Lennart
> yesterday, then mine.
>
> Regards, Vu
>
>> -Original Message-
>> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
>> Sent: Tuesday, February 21, 2017 5:10 PM
>> To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>;
>> lennart.l...@ericsson.co
Hi Vu,
Is this applies on top of log #2146 - V4 , I see both #tickets has
version changes ?
in which order i need to apply ( #2146 & #2258 )or (#2258 & #2146).
=
patching file src/log/Makefile.am
Hunk #1 FAILED at 72.
Hunk #2
gt; add more one header file.
>
> Regards
> Canh
>
> -Original Message-
> From: Canh Truong [mailto:canh.v.tru...@dektech.com.au]
> Sent: Tuesday, February 21, 2017 4:41 PM
> To: 'A V Mahesh'; 'lennart.l...@ericsson.com'; 'vu.m.ngu...@dektech.com.au'
> Cc: 'opensaf
ncrease version to A.02.03.
> You can refer at Lennart's comments in
> https://sourceforge.net/p/opensaf/tickets/2146/ for version handling.
>
> Regards
> Canh
>
> -----Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Tuesday, February 21,
Hi Canh,
I am sorry saLogFilterSetCallback is existing call back in specification
and it seem we increased initialized version jut to support agent
version is that right ?
-AVM
On 2/21/2017 2:51 PM, A V Mahesh wrote:
> Hi Canh,
>
> The general practice of implementing any
definitions
Is their any reson `SaLogFilterSetCallbackT` didn't followed this ?
How application will include this `SaLogFilterSetCallbackT` ?
-AVM
On 2/21/2017 2:07 PM, A V Mahesh wrote:
> Hi Canh,
>
> I can see that you are passing NULL callbacks as `` for
> "logtest 1 10" and &qu
n test case 11, log agent reassign for version of client is A.02.01 before
> sending to the initialized request to log server. So the test case is
> successful.
>
> The test cases for filter callback is in test suite 17. (logtest 17)
>
> Regards
> Canh
>
>
> -Origi
Hi Canh,
I was jut testing Agent in-service upgrade , so I have following setup
and run the New FilterSetCallback test case
and i was expecting case should receive fail/not-supported , but they
are getting succeed how ?
-SC-2 ACTIVE Old Node ( LOG is old code with out #2146 patch )
-SC-1
Hi Anders Widell,
As work around while pushing patch, Just consider to have condition
either number of accumulated logs exceed
some count ( say 10 ) or every 15 seconds for log server to flushes
messages to disk.
-AVM
On 2/20/2017 9:02 AM, A V Mahesh wrote:
> ACK, tested as w
Hi Alex,
ACK Not tested.
-AVM
On 2/15/2017 2:12 AM, Alex Jones wrote:
> src/msg/msgd/mqd_api.c | 53
> ++---
> 1 files changed, 28 insertions(+), 25 deletions(-)
>
>
> If a node is hosting a msg queue, and the node is rebooted, it can take 20
>
. I think the recommendation is to set
> this attribute to the same value as the domain name of the nodes in
> the cluster.
>
> regards,
> Anders Widell
>
> On 02/20/2017 10:56 AM, A V Mahesh wrote:
>> Hi Anders Widell,
>>
>>
>> On 2/20/2017 2:25 PM, Anders Widel
I
> would anyhow recommend to configure host name and node name with the
> same value.
Then Opensaf Should force `domain name` should be same as Opensaf IMM
configured CLM Name while starting Opensaf .
-AVM
>
> regards,
>
> Anders Widell
>
> On 02/20/2017 07:17 AM,
Hi Anders Widell,
I see an issue with the way the MW Node name presented in MDS log with
this patch , I did configured CLM/AMF name
as below ( NON SC_1 & SC-2 ) , but the mds log is considering linux
name , either we have to use CLM name or AMF name in MDS log
On 2/17/2017 2:59 PM, Anders Widell wrote:
> we should check that our README refers to the RFC somewhere.
That will be even good for completely understand the New MDS log format.
-AVM
On 2/17/2017 2:59 PM, Anders Widell wrote:
> Hi!
>
>
> On 02/17/2017 10:16 AM, A V Mahesh wrot
:22 PM, Anders Widell wrote:
> See below.
>
> regards,
>
> Anders Widell
>
>
> On 02/17/2017 06:21 AM, A V Mahesh wrote:
>> Hi Anders Widell,
>>
>> Can you please clarify below :
>>
>> 1) is this meta sequenceId is rotates after reaching some
Hi Anders Widell,
While testing the patch , Delayed MDS loging is observed , see below
even after successful Re-Starting OpenSAF Services,
MDS logs are not reflected immediately , after some time the accumulated
logs are getting added to /var/log/opensaf/mds.log
is this expected behavior ?
Hi Anders Widell,
Can you please clarify below :
1) is this meta sequenceId is rotates after reaching some value ? (
Max value )
2) is this meta sequenceId persistent even after application respawn ?
Hi Hoang,
The CPD_CPND_DOWN_RETENTION is to recognize, ether CPND temporarily
down or permanently down,
this is started a CPND is down and based on cpd_evt_proc_timer_expiry(),
cpd recognize that
the CPND is complete down and do cleanup, else cpnd rejoined with in
Hi Zoran,
ACK , Not tested.
-AVM
On 2/9/2017 7:07 PM, Zoran Milinkovic wrote:
> src/mds/mds_c_sndrcv.c | 38 +++---
> 1 files changed, 23 insertions(+), 15 deletions(-)
>
>
> Improve MDS logging in mds_mcm_time_wait() and split the common MDS log into
>
Hi Hans N,
ACK with following comment ( not tested)
I think, need to check both (POLLNVAL | POLLERR)
-AVM
On 2/8/2017 6:04 PM, Hans Nordeback wrote:
> src/mds/mds_dt_trans.c | 5 +
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
>
> diff --git a/src/mds/mds_dt_trans.c
Hi Hans N,
ACK , with following comment
This is not related to cinttypes ,but still remove line number 51 (static
const unsigned int max_waiting_time_3s = (3 * 1000); /* 60 sec */)
from src/ntf/ntfimcnd/ntfimcn_imm.c before pushing this part of the code will
get compile when
Hi Hoang,
Is this issue is an extension of ticket #1765 issue `cpd: to correct
failover behavior of cpsv [#1765]` ?
If so let us fist address the Ticket #1765 with my proposed approach ,
then we can fix this issue on top of that.
-AVM
On 1/31/2017 5:23 PM, Zoran Milinkovic wrote:
> Hi
Hi Zoran,
ACK , not tested.
Is this case getting hit in case of Headless ?
-AVM
On 1/31/2017 6:24 PM, Zoran Milinkovic wrote:
> src/ckpt/ckptnd/cpnd_evt.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>
> If a client node is not found in cpnd_evt_proc_ckpt_open(), the
;
> /Regards Hans
>
>
> On 01/31/2017 01:34 PM, Hans Nordebäck wrote:
>>
>> -Original Message-
>> From: Hans Nordebäck [mailto:hans.nordeb...@ericsson.com]
>> Sent: den 31 januari 2017 12:59
>> To: A V Mahesh <mahesh.va...@oracle.com>; Chani
Hi Hans N,
This same issue exist with all following file , is their any common
location we can include this
?
vi src/amf/amfd/mds.cc
vi src/imm/agent/imma_mds.cc
vi src/amf/amfd/ndfsm.cc
vi src/amf/amfd/mds.cc
vi src/amf/amfd/sgproc.cc
vi src/amf/amfd/siass.cc
vi src/amf/amfd/util.cc
vi
Hi Hans N,
ACK, Not tested.
I Hope you have simulated the New return cases.
-AVM
On 1/27/2017 8:20 PM, Hans Nordeback wrote:
> src/mds/mds_dt_trans.c | 34 +-
> 1 files changed, 17 insertions(+), 17 deletions(-)
>
>
> diff --git a/src/mds/mds_dt_trans.c
e in the middle of client_list and setting the
> p_client to the beginning of the client_list after deleting the invalidated
> client looks not correct to me.
>
> How do you think?
>
> /Tai
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent
Hi Tai,
I did test by bringing down one LGA when in headless mode on payload ,
and didn't observer any issue , any how will re-test and update.
By the why do you any observation ?
-AVM
On 1/24/2017 12:52 PM, Tai Dinh wrote:
> Hi Mahesh,
>
> What'll happen if the removed node is at the middle
(
>
> Reproduce steps:
> - in SC1 open a checkpoint (non col)
> - set retention value to big: 9
> - reboot SC1 by killing osafamfd
> - reboot SC2 by killing osafamfd
>
> Check retention value and it is default value (60) not set one.
>
> Thank you and best reg
Ok i will review/check the patch/case update you.
-AVM
On 1/19/2017 1:17 PM, Vo Minh Hoang wrote:
>
> Dear Mahesh,
>
> >>So we can always re-use the existing UN-linked resources by just
> simply removing UN-link flag,
> >> what is your opinion?
>
> Based on my understanding, new checkpoint even
dated file for review.
>
> Thank you and best regards,
> Hoang
>
> -Original Message-
> From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
> Sent: Thursday, January 19, 2017 2:17 PM
> To: 'A V Mahesh' <mahesh.va...@oracle.com>; zoran.milinko...@ericsson.com
HiHoang,
>>The replica IMM objects are not created after opening a checkpoint in
following scenario:
1. Open a checkpoint with flag SA_CKPT_CHECKPOINT_CREATE
2. Unlink the checkpoint ( the checkpoint is still being used)
3. Open a checkpoint with flag SA_CKPT_CHECKPOINT_CREATE with same
cpd)
if so this has some relation with #2253 , let us retest the case with
#2253 and confirm the issue still exist.
-AVM
On 1/19/2017 12:33 PM, A V Mahesh wrote:
> Hi Hoang,
>
> Can you please crosscheck is this issue has any relation with #2253
>
> -AVM
>
>
> On 1/1
Hi Hoang,
Thanks for the comments i will incorporate these two comments while pushing.
-AVM
On 1/18/2017 10:17 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I have 2 comments.
> Please find with [Hoang] tag and consider.
>
> Sincerely,
> Hoang
>
> -Original Message-
> From:
---
Sincerely,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Tuesday, January 17, 2017 10:45 AM
To: hoang.m...@dektech.com.au
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] cpd: syncup active standby mbcsv dtat
for non-colcated ckpt
Hi Hoang,
It seem you missed to see this, can you please review.
-AVM
On 1/6/2017 5:47 PM, mahesh.va...@oracle.com wrote:
> src/ckpt/ckptd/cpd_sbevt.c | 30 +-
> 1 files changed, 21 insertions(+), 9 deletions(-)
>
>
> Issue :According to Ckpt
Hi Canh
Ack, not tested.
-AVM
On 12/30/2016 5:10 AM, Canh Van Truong wrote:
> osaf/services/saf/logsv/lgs/lgs_stream.cc | 5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
>
> The log file is changed during si-swap after patch for #2215 is applied.
>
> This patch fix to reopen
Hi Zora,
ACK.
LONG DN not tested .
-AVM
On 1/10/2017 8:57 PM, Zoran Milinkovic wrote:
> src/ckpt/agent/cpa_api.c | 26 +++---
> src/ckpt/ckptnd/cpnd_evt.c | 12
> 2 files changed, 19 insertions(+), 19 deletions(-)
>
>
> Fix string temination issues
Hi Zoran,
ACK Not tested.
-AVM
On 1/10/2017 9:18 PM, Zoran Milinkovic wrote:
> src/ckpt/ckptd/cpd_red.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>
> Fix memory leak in cpd_a2s_ckpt_usr_info() in cpd_red.c
>
> diff --git a/src/ckpt/ckptd/cpd_red.c
file descriptor is -1.
> The second is checked if open log if open log file fail.
>
> Regards
> Canh
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Wednesday, December 14, 2016 1:45 PM
> To: Canh Van Truong; vu.m.ngu...@dektech.com.a
oang wrote:
> Dear Mahesh,
>
> Sorry for late reply when others tickets have higher priority.
>
> I manually tested your case with collocated/non-collocated checkpoint and
> found that it work normally following expected scenario
>
> Thank you and best regards,
> Hoang
>
Hi Hoang Vo,
Not sure why unfinished unlink operation , unlink will land on old CPD
active or after fail-over New CPD active ,
in transit time CPND will get try-again , can you please elaborate the
case .
-AVM
On 10/13/2016 2:02 PM, Hoang Vo wrote:
> osaf/services/saf/cpsv/cpd/cpd_db.c
Hi Canh Van,
One more point : In function log_stream_config_change() , you have
` if (*stream->p_fd == -1) {` at the top and bottom , try to optimize to ,
code looks confusing .
Normal testing done.
-AVM
On 12/14/2016 11:52 AM, A V Mahesh wrote:
> Hi ,
>
> ACK with following m
Hi Anders Widell,
ACK , Tested TCP /TIPC
-AVM
On 12/6/2016 8:05 PM, Anders Widell wrote:
> osaf/services/infrastructure/dtms/transport/main.cc | 33
> +---
> 1 files changed, 27 insertions(+), 6 deletions(-)
>
>
> There were error handling paths where the LogServer object
Hi HansN,
ACK from me.
In all normal conditions no issues observed even with callback option.
If we see any further issue in future testing , MDS will use mailbox
option with default enabled instead of the callbacks.
-AVM
On 12/8/2016 4:44 PM, Hans Nordeback wrote:
>
Hi HansN,
On 12/12/2016 11:52 AM, A V Mahesh wrote:
> Hi HansN,
>
> On 12/8/2016 2:20 PM, Hans Nordeback wrote:
>> And checking pfd in the FD_BSRSOCK loop will probably give the old
>> behaviour
>
I understand that it will give old behavior , even giving less valu
35
<133>1 2016-12-12T11:40:33.133457+05:30 SC-1 osafamfd 21193 46 - MDTM:
svc up event for svc_id = NTFS(28), subscri. by svc_id = NTFA(29)
pwe_id=1 Adest = <rem_node[2]:dest_tipc_id_ref[3630301206]>
<133>1 2016-12-12T11:40:33.133512+05:30 SC-1 osafamfd 21193 47 - MDTM:
svc u
>> great, the suggestion below looks good. I will send out a V4 shortly.
>>
>> /Thanks HansN
>>
>>
>> On 12/07/2016 05:29 AM, A V Mahesh wrote:
>>> Hi HansN,
>>>
>>> I did some investigation my fist observation is , issues occurring
nsigned
int recv_ctr = 0`
-AVM
On 11/23/2016 11:07 AM, A V Mahesh wrote:
> Hi HansN
>
> In my testing with concurrent application which sends large data and
> large number of up/down event ,
> the cluster is going for reboot because of some MDS application are
> not getting
Hi Anders Widell,
ACK for all the patches .
Tested with MDS_LOG_LEVEL=5 with high traffic , no issue with MDS loging .
Observation :
The `UnixServerSocket::OpenHook()` looks more optimized way to open Unix
Socket
may we can have one enhancement #ticket for TCP/MDS code.
-AVM
On 11/3/2016
ACK,
-AVM
On 11/9/2016 9:27 PM, Anders Widell wrote:
> osaf/libs/core/mds/mds_dt_tipc.c | 2 +-
> osaf/libs/core/mds/mds_dt_trans.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
> The result from poll() was incorrectly stored in an unsigned integer, which
> means that if
Hi Ramesh,
- Most of the your review comment are related to cpnd_ckpt_sec_write()
in case of cpnd_ckpt_sec_write fail nothing to be rollback of any
cktp/section recently/long back/just- created
just need to report we are not able to write user data in to SHM, so
that the user will
Hi Hoang,
ACK for the attached patch .
-AVM
On 11/29/2016 6:01 PM, A V Mahesh wrote:
> HI All,
>
> Validation of this patch dependent on #2202 , so please find the attached
> re-based patch of this (#2207) ticket.
>
> Hoang will re-publish the V3 patch once he is in office.
Hi Hoang,
On 12/1/2016 9:15 AM, Vo Minh Hoang wrote:
> Dear Mahesh,
>
> I have one small concern about:
> Please consider get CB data by ncshm_take_hdl() or pass in ensures_space as
> parameter.
> When CB is global access, adding it to parameters of many API is a little
> bit inconvenient.
The
n
OpenSAF servicesy
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 7b53e1b3754622fe90c22c801adeb7
Mahesh,
I will do following your request.
Please note that test case executing time is very long so result might not
be available in today.
Thank you and best regards,
Hoang
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: Wednesday, November 30, 2016 1:35 PM
n
> Tests n
> Other n
>
>
> Comments (indicate scope for each "y" above):
> -
>
> changeset 7b53e1b3754622fe90c22c801adeb7df6d808c30
> Author: A V Mahesh <m
HI All,
Validation of this patch dependent on #2202 , so please find the attached
re-based patch of this (#2207) ticket.
Hoang will re-publish the V3 patch once he is in office.
-AVM
On 11/29/2016 4:23 PM, Hoang Vo wrote:
osaf/libs/common/cpsv/include/cpnd_sec.h | 2 +-
> i//f (statvfs(shm_dir, ) == 0)/
>>>
>>> and get available space by calculating
>>> "/info.f_bfree*info.f_bsize/" etc.
>>>
>>> Also make sure to do this check before every write in cpnd.
>>>
>>> If my in
Hi Anders Widell,
ACK, Not build/tested.
-AVM
On 11/25/2016 7:55 PM, Anders Widell wrote:
> tests/logsv/logutil.c | 6 +++---
> tests/logsv/logutil.h | 6 +++---
> tests/logsv/tet_LogOiOps.c | 2 +-
> tests/logsv/tet_saLogLimitGet.c | 2 +-
> 4 files
gt; OSAF_CKPT_SHM_ALLOC_GUARANTEE is not set.
>>
>> My thinking is that because we provide 2 mode (guarantee or not) so we
>> should making sure no coredump happened.
>> Btw, because this is out of my scope of decide, I would like to ask
>> Anders
>> Widell abou
might return OK.
> cpnd_ckpt_sec_del() itself do not have params that carry error information.
> Global variable is should not be used also.
>
> Sincerely,
> Hoang
>
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Friday, Novemb
s that cpnd_ckpt_sec_del() keep original
> the cpnd_ckpt_sec_del_db() is revert of action before cpnd_sec_hdr_update()
> cpnd_ckpt_sec_del_db() can be called after cpnd_ckpt_sec_del() many time
> without affecting system.
>
> Please consider and tell me your judgement.
> Best r
Hi Hoang,
Is this issue coming with enabling #1712 feature ?
Exporting `OSAF_CKPT_SHM_ALLOC_GUARANTEE=1` will provide guaranteed
CPSV service SHM
issue and this is addressed broadly all SHM memory issue.
So I don't think we required API level changes. ( may we need to
document the
nd the ER that you point out.
>
> Sincerely,
> Hoang
>
> -Original Message-
> From: A V Mahesh [mailto:mahesh.va...@oracle.com]
> Sent: Friday, November 25, 2016 1:20 PM
> To: Vo Minh Hoang <hoang.m...@dektech.com.au>
> Cc: anders.wid...@ericsson.com; opensaf-dev
Ok ACK.
On 11/25/2016 12:11 PM, Hans Nordebäck wrote:
> Hi Mahesh,
>
> It is an alternative, but as of today in OpenSAF only MSG_NOSIGNAL is used, I
> think it is better to follow that pattern.
> /Thanks HansN
>
> -Original Message-----
> From: A V Mahesh [mailto
URE);
> }
> +
> rc = saClmSelectionObjectGet(_lgs_cb->clm_hdl,
> _cb->clmSelectionObject);
> if (rc != SA_AIS_OK) {
> LOG_ER("saClmSelectionObjectGet failed with error: %d", rc);
> //<
>
>
> Regards, Vu
>
>> -Origi
remove if found.
> In case ckpt_hdr_update_fails, the cpnd_ckpt_sec_del_db() is called twice,
> the first one remove sectionInfo from maps, the second one does not found
> sectionInfo and cannot remove anything, will not generate error.
>
> Sincerely,
> Hoang
>
> -Original Message-
>
Hi HansN,
ACK with following
Do you agree the better alternativeis that to do setsockopt(fd, ..
SO_NOSIGPIPE,
instead of each send ?
-AVM
On 11/23/2016 3:29 PM, Hans Nordeback wrote:
> osaf/libs/core/mds/mds_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
>
Hi Hoang,
NACK
This patch has some fundamental problem, this will corrupt the cpsv
database .
This patch instead of resolving the issue , increase the percentage of
problem occurrence .
Basically this patch splitscpnd_ckpt_sec_del() in to two parts
cpnd_ckpt_sec_del_db() &
Hi HansN,
ACK not tested.
-AVM
On 11/23/2016 3:16 PM, Hans Nordeback wrote:
> osaf/services/infrastructure/dtms/transport/log_writer.cc | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/services/infrastructure/dtms/transport/log_writer.cc
>
Hi HansN
In my testing with concurrent application which sends large data and
large number of up/down event ,
the cluster is going for reboot because of some MDS application are not
getting scope to process with in expected time ( see below logs) as I
expected,
for example `osafamfnd[18568]:
101 - 200 of 568 matches
Mail list logo
