Re: [devel] [PATCH 1/1] osaf: perform handshake in tcp_server in new thread [#3099]

so I think this change looks good./BR Hans -Original Message- From: Gary Lee Sent: den 11 oktober 2019 05:22 To: Hans Nordebäck ; Minh Hon Chau ; Thuan Tran Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: perform handshake in tcp_server in new thread [#3099] ---

Re: [devel] [PATCH 1/1] osaf: add tcp arbitrator [#3064]

Hi Gary, ack, review only. One comment/suggestion can we provide a small script that generates the x509 certificate (use e.g. openssl X509 ... ) instead of including a self signed cert? /BR Hans On Tue, 2019-10-01 at 12:53 +1000, Gary Lee wrote: > --- > src/osaf/consensus/plugins/tcp/README

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Minh, see one comment below. /Thanks Hans On 2019-08-23 03:48, Minh Hon Chau wrote: > Hi Hans, > > Thanks for your time to review the patch, please see my replies below > your comments. > > Regards, > > Minh > > On 22/8/19 11:07 pm, Hans Nordebäck wrote: >>

Re: [devel] [PATCH 3/9] mds: Add implementation for TIPC buffer overflow solution [#1960]

Hi Minh, it is a large patch so i have to review parts of it, below are my comments, marked with [HansN], for files: src/mds/Makefile.am src/mds/mds_dt.h src/mds/mds_dt_tipc.c I'll continue with the rest of the files a bit later. /Thanks Hans On 2019-08-14 08:38, Minh Chau wrote: > This is a

[devel] [PATCH 0/1] Review Request for util: Fenced should only write a log record when two acitve controllers is seen [#3073]

Summary: util: Fenced should only write a log record when two acitve controllers is seen [#3073] Review request for Ticket(s): 3073 Peer Reviewer(s): Gary, Duc Pull request to: Affected branch(es): develop Development branch: ticket-3073 Base revision: 729f71fbfff0eea6d4a6a394780142b87a9fb472

[devel] [PATCH 1/1] util: Fenced should only write a log record when two acitve controllers is seen [#3073]

--- tools/devel/fenced/node_state_hdlr_pl.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/devel/fenced/node_state_hdlr_pl.cc b/tools/devel/fenced/node_state_hdlr_pl.cc index c74fe72b9..6bf032e5a 100644 --- a/tools/devel/fenced/node_state_hdlr_pl.cc +++

Re: [devel] [PATCH 2/9] mds: Resolve c/c++ linking issue [#1960]

Hi Minh, ack, code review only/Thanks HansN On 2019-08-14 08:38, Minh Chau wrote: > (Sending on behalf of Thuan) > This patch solves the linking issue if mds_dt.h or mds_core.h > is included in c++ sources. > --- > src/mds/mds_core.h| 74 >

Re: [devel] [PATCH 1/9] mds: Add README for solution of TIPC buffer overflow at MDS [#1960]

Hi Minh, ack, some minor comments below/Thanks Hans On 2019-08-14 08:38, Minh Chau wrote: > --- > src/mds/README | 221 > + > 1 file changed, 221 insertions(+) > create mode 100644 src/mds/README > > diff --git a/src/mds/README

Re: [devel] [PATCH 1/1] amfd: add support for dynamically changing saAmfRank of SaAmfSIRankedSU [#3058]

Hi Alex, ack code review only, a few minor comments below/Thanks HansN On 2019-07-18 21:04, Jones, Alex wrote: Allow saAmfRank of SaAmfSIRankedSU to be changed at runtime --- src/amf/amfd/si.cc | 103 + src/amf/amfd/si.h | 3 ++ src/amf/amfd/siass.cc | 38

Re: [devel] [PATCH 1/1] amfd: prevent infinite loop [#3050]

Hi Gary, ack, code review only/Thanks HansN On 2019-06-20 04:13, Gary Lee wrote: > In handle_event_in_failover_state(), we iterate through > queue_evt in a while loop, but process_event() can insert > items into the queue inside the loop, and we may end > up never exiting the while loop. > --- >

[devel] [PATCH 0/1] Review Request for utils: Use a fence daemon as an alternative to payload reboot fencing [#3048]

Summary: utils: Use a fence daemon as an alternative to payload reboot fencing [#3048] Review request for Ticket(s): 3048 Peer Reviewer(s): Duc, Gary, Anders Pull request to: Affected branch(es): develop Development branch: ticket-3048 Base revision: 3895c7a88bdb3c6f86da1083ea0fd9e2cd642d01

[devel] [PATCH 1/1] utils: Use a fence daemon as an alternative to payload reboot fencing [#3048]

--- src/fm/Makefile.am| 6 +- src/fm/fmd/fm_amf.cc | 14 + src/fm/fmd/tipc_server.cc | 93 ++ src/fm/fmd/tipc_server.h | 45 +++ tools/devel/fenced/Makefile | 63

Re: [devel] [PATCH 1/1] rded: improve self-fencing response time [#3039]

Hi Gary, ack, review only/Thanks HansN On 5/27/19 2:09 AM, Gary Lee wrote: > When connectivity to consensus service is lost, it is recorded > in a state variable. When all RDE peers are lost, the node will > now self-fence immediately. > --- > src/rde/rded/rde_cb.h| 5 + >

Re: [devel] [PATCH 1/1] uml: Update to Linux 4.18.20, iproute2 5.1.0 and busybox 1.30.1 [#3042]

Hi Anders, ack, (I think CONFIG_KCOV=n should be added to the config file). /BR HansN On 2019-05-20 14:38, Anders Widell wrote: > Uplift the Linux kernel version for UML to 4.18.20, to make it possible to > build > UML with newer glibc version (e.g. on Ubuntu 18.04). > --- >

[devel] [PATCH 0/1] Review Request for mds: use new TIPC getsockopt to log receive buffer utilization [#3038]

Summary: mds: use new TIPC getsockopt to log receive queue utilization [#3038] Review request for Ticket(s): 3038 Peer Reviewer(s): AndersW, Lennart, Gary Pull request to: Affected branch(es): develop Development branch: ticket-3038 Base revision: 3b124020051730287ace8bd9ab28a8fa431fc85a Personal

[devel] [PATCH 1/1] mds: use new TIPC getsockopt to log receive queue utilization [#3038]

--- 00-README.conf | 14 +++ src/base/Makefile.am | 1 + src/base/statistics.h| 88 + src/mds/Makefile.am | 8 +- src/mds/mds_dt_tipc.c| 3 + src/mds/mds_tipc_recvq_stats.cc | 29 +

Re: [devel] [PATCH 1/1] base: strip leading and trailing quotes [#3041]

Hi Gary, ack, code review only/Thanks HansN On 2019-05-17 14:47, Gary Lee wrote: > ConfigFileReader enables runtime 'reload' of .conf files. > However, if the environment variable is surrounded by quotes, > it adds the quotes to the value which is not the expected behaviour. > > export FOO="foo"

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

Both functions are call sendto() of TIPC but just different parameters. Best Regards, ThuanTr From: Hans Nordebäck <mailto:hans.nordeb...@ericsson.com> Sent: Friday, May 3, 2019 3:50 PM To: Thuan Tran <mailto:thuan.t...@dektech.com.au>; Minh Hon Chau <mailto:minh.c...@dektech.com.

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

multicast the fragments? What problem do this patch solves, can you clarify? /Thanks HansN On 2019-05-03 10:20, Tran Thuan wrote: Hi Hans, Yes, we try that kind of basic test, IMMD can deliver big message via multicast. Best Regards, ThuanTr -Original Message----- From: Hans

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

st Regards, > ThuanTr > > -Original Message- > From: Hans Nordebäck > Sent: Friday, May 3, 2019 2:45 PM > To: Thuan Tran ; Minh Hon Chau > ; Vu Minh Nguyen > Cc: opensaf-devel@lists.sourceforge.net > Subject: RE: [PATCH 0/1] Review Request for mds: support multicas

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

Hi Thuan, I'm reviewing the patch now. I haven't checked yet but do you know if the mds apitests cover this case sending large multicast messages? /Thanks HansN -Original Message- From: Tran Thuan Sent: den 2 maj 2019 05:56 To: Minh Hon Chau ; Vu Minh Nguyen ; Hans Nordebäck Cc

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

Hi Thuan, ok, if we can add additional tests to the mds api test suite would be good/Thanks HansN -Original Message- From: Tran Thuan Sent: den 3 maj 2019 09:41 To: Hans Nordebäck ; Minh Hon Chau ; Vu Minh Nguyen Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 0/1] Review

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

Hi Vu and Thuan, a few question, is the text in the ticket description correct? E.g it says unicast is used if a multicast message is fragmented, (I think multicast still is used to send the fragments), this is what you mean with 2 different channels? (only one socket is used, BSRsock), The

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

dto() is called inside the function > mdtm_frag_and_send(). > > Regards, Vu > >> -----Original Message- >> From: Hans Nordebäck >> Sent: Thursday, April 25, 2019 6:10 PM >> To: Vu Minh Nguyen ; Thuan Tran >> ; Minh Hon Chau >> >> Cc: o

Re: [devel] [PATCH 0/1] Review Request for mds: support multicast fragmented messages [#3033] V3

Hi Vu, It seems mdtm_mcast_sendto is used in mdtm_frag_and_send, at MDS_SENDTYPE_BCAST/BR Hans -Original Message- From: Vu Minh Nguyen Sent: den 25 april 2019 12:20 To: Hans Nordebäck ; Thuan Tran ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 0/1

Re: [devel] [PATCH 1/1] osaf: ensure an error is returned if takeover_request fails [#3023]

ack, review only/Thanks HansN -Original Message- From: Gary Lee Sent: den 26 mars 2019 02:05 To: Minh Hon Chau ; Hans Nordebäck Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: ensure an error is returned if takeover_request fails [#3023] if we cannot

Re: [devel] [PATCH 1/1] osaf: improve response time in etcd3.plugin [#3016]

Hi Gary, ack, review only. /BR HansN On 3/12/19 01:32, Gary Lee wrote: > if the initial call to watch takeover request in etcd3.plugin > is made when etcd has already been shutdown (for example, > when etcd is running locally and the node is being shutdown), > the plugin should return 0 with a

Re: [devel] [PATCH 1/1] dtm: Fix dtm close socket due to duplication of adding node IP info [#2984]

Hi Canh, ack, review only. I think it would be good to separate the re-factoring part in a separate ticket though. /BR Hans On 12/18/18 08:25, Canh Van Truong wrote: > During cluster start, one node (node 1) broadcast up msg to other node. The > remote node (node 2) get this msg and send the

Re: [devel] [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]

Hi Vu, ack, with one comment below. /BR HansN On 3/1/19 10:07, Vu Minh Nguyen wrote: > There is a dependency b/w svc_monitor_thread and spawn_services. > The coredump happens when spawn_services is executed while > the thread has not yet started. In this case, data is sent to the > pipe but no

Re: [devel] [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]

Hi Vu, fine, perhaps also changing the static bool svc_monitor_thread_running = false to std::atomic?/BR Hans From: Vu Minh Nguyen Sent: den 28 februari 2019 09:30 To: Hans Nordebäck ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net Subject: RE: [PATCH 1/1] nid: fix opensafd crashed

Re: [devel] [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]

the svc_monitor_thread goes to ready state? Is it mandatory for monitoring thread to enter ready state before spawning SAF services? Regards, Vu -Original Message- From: Hans Nordebäck <mailto:hans.nordeb...@ericsson.com> Sent: Wednesday, February 27, 2019 8:23 PM To: Vu Minh

Re: [devel] [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]

Hi Vu, I discussed a bit with Anders, likely it should work if the socketpair is changed to socketpair(AF_UNIX, SOCK_DGRAM .. from SOCK_STREAM. /BR Hans -Original Message- From: Hans Nordebäck Sent: den 27 februari 2019 11:55 To: 'Vu Minh Nguyen' ; Gary Lee Cc: opensaf-devel

Re: [devel] [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013]

Hi Vu, ack, code review only/Thanks HansN -Original Message- From: Vu Minh Nguyen Sent: den 27 februari 2019 11:48 To: Hans Nordebäck ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen Subject: [PATCH 1/1] nid: fix opensafd crashed during start-up [#3013

Re: [devel] [PATCH 1/1] base: fix warnings [#3006]

Hi Gary, ack, review only/Thanks HansN On 2/9/19 04:11, Gary Lee wrote: > fix warnings about unused variables and add SA_RESTART > --- > src/base/daemon.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/base/daemon.c b/src/base/daemon.c > index

Re: [devel] [PATCH 1/2] fmd: improve failover response time [#3008]

Hi Gary, ack, review only/BR HansN On 2/19/19 05:10, Gary Lee wrote: > Improve failover response time if split brain prevention is enabled > but FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE is set to 0. > > Also, return immediately if node promotion fails to avoid > sending active role to RDA. > --- >

Re: [devel] [PATCH 2/2] rded: do not send SUCCESS to main thread [#3008]

Hi Gary, a question, why was the return's added? /BR HansN On 2/19/19 05:10, Gary Lee wrote: > do not send RDE_MSG_ACTIVE_PROMOTION_SUCCESS to > main thread if lock cannot be obtained > --- > src/rde/rded/role.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/rde/rded/role.cc

Re: [devel] [PATCH 1/1] clm: Incorrect encode/decode time_super [#3007]

Hi Thanh, ack, review only/Thanks HansN On 2/20/19 06:19, Thanh Nguyen wrote: > Changing ecoding of time_super using 64 bit instead of 32 bit. > --- > src/clm/clmd/clms_mds.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/clm/clmd/clms_mds.cc

Re: [devel] [PATCH 1/1] osaf: Call opensaf_quick_reboot if failed to set active role in consensus [#3001]

Hi Minh, ack, review only/Thanks HansN On 2/15/19 10:51, Minh Chau wrote: > --- > src/fm/fmd/fm_rda.cc | 4 ++-- > src/rde/rded/rde_main.cc | 8 +++- > src/rde/rded/role.cc | 8 > 3 files changed, 9 insertions(+), 11 deletions(-) > > diff --git a/src/fm/fmd/fm_rda.cc

Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split network [#3001]

Hi Vu, see my comment below/Hans On 1/28/19 10:59, Vu Minh Nguyen wrote: > Hi Hans, > > Thanks for your comments. See my comment inline. Thanks > > Regards, Vu > >> -Original Message- >> From: Hans Nordebäck >> Sent: Monday, January 28, 2019 4:37 PM &g

Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split network [#3001]

Hi Vu, See one more comment below/Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 28 januari 2019 10:15 To: Vu Minh Nguyen ; Gary Lee ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] osaf: do quick local node reboot when split

Re: [devel] [PATCH 1/2] osaf: update etcd v2 plugin [#3003]

ack, review only/Thanks HansN On 1/24/19 02:17, Gary Lee wrote: > 'etcdctl watch' will return if connection to the etcd server is lost. > If that occurs, send a 'fake' takeover request to rded so rded > will reboot the node. This is in alignment with the etcd v3 plugin. > --- >

Re: [devel] [PATCH 2/2] osaf: update sample plugin [#3003]

ack, code review only/Thanks HansN On 1/24/19 02:17, Gary Lee wrote: > --- > src/osaf/consensus/plugins/sample.plugin | 20 +++- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/src/osaf/consensus/plugins/sample.plugin >

Re: [devel] [PATCH 5/5] rded: add relaxed node promotion feature [#2996]

ack, review only, one question below/Thanks HansN On 1/21/19 04:52, Gary Lee wrote: > Allow promotion of node to active at cluster startup, even if the > consensus service is unavailable, if the peer SC can be seen. > > During normal cluster operation, if the consensus service becomes >

Re: [devel] [PATCH 2/5] fmd: add configuration parameters [#2996]

ack, review only/Thanks HansN On 1/21/19 04:52, Gary Lee wrote: > Add parameters FMS_TAKEOVER_PRIORITISE_PARTITION_SIZE and > FMS_RELAXED_NODE_PROMOTION. > --- > src/fm/fmd/fmd.conf | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/src/fm/fmd/fmd.conf

Re: [devel] [PATCH 1/5] osaf: update etcd3 to poll instead of watch [#2996]

ack, review only/Thanks HansN On 1/21/19 04:52, Gary Lee wrote: > The 'watch' command does not return if the etcd server goes down. > We need to poll the etcd server to properly check we still have > connectivity to the etcd server. > --- > src/osaf/consensus/plugins/etcd3.plugin | 50 >

Re: [devel] [PATCH 1/1] amfd: Only start clm track for 2N Opensaf SU in failover [#2980]

Hi Minh, ack, review only/Thanks HansN On 12/10/18 07:00, Minh Chau wrote: > --- > src/amf/amfd/sg_2n_fsm.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amf/amfd/sg_2n_fsm.cc b/src/amf/amfd/sg_2n_fsm.cc > index a218786..91ffc63 100644 > ---

Re: [devel] [PATCH 1/1] amfd: Update the assignment counters after restore absent assignment from imm [#2977]

Hi Minh, ack, code review only/Thanks HansN On 12/3/18 04:29, Minh Chau wrote: > AMF performs headless recovery by syncing the assignments from AMFND(s) and > re-create them in AMFD's db and IMM. Next step, AMFD compares the assignment > objects from IMM and from AMFND(s) to figure out the

Re: [devel] [PATCH 0/4] Review Request for clm: add new test cases in clm apitest [#2914]

Hi Mohan, ack, review only/Thanks HansN On 11/6/18 11:19, Mohan Kanakam wrote: > Summary: clm: add new test case of API saClmClusterNotificationFree_4() of > apitest [#2914] > Review request for Ticket(s): 2914-1 > Peer Reviewer(s):Anders, Hans, Ravi > Pull request to: *** LIST THE PERSON WITH

Re: [devel] [PATCH 1/1] osaf: Set sticky bit for socket and pipe files [#2953]

Hi Minh, the "sticky" bit here is in fact  the "restricted deletion bit", it is used on directories, e.g. the /tmp directory where several users have r/w access but when the 't' bit is set only the file owners may delete its files. It should not be set on files only directories and I don't

Re: [devel] [PATCH 1/1] mds: Send NCSMDS_DOWN with vdest if there is no any adest [#2941]

Hi Minh, ack, code review and mdstest run. One minor comment below. /Thanks HansN On 10/25/18 04:40, Minh Chau wrote: > If split brain happens and network merges back, at this point in time > there are a few mds events coming to payloads, which are the SVC UP > from the other controller; SVC

Re: [devel] [PATCH 1/1] amfd: reset snd_msg_id in LostFound state [#2952]

Ack, review only/Thanks HansN Från: Gary Lee Skickat: den 2 november 2018 06:23:09 Till: nagendra @ hasolutions . in; Minh Hon Chau; Hans Nordebäck Kopia: opensaf-devel@lists.sourceforge.net; Gary Lee Ämne: [PATCH 1/1] amfd: reset snd_msg_id in LostFound state

Re: [devel] [PATCH 1/1] imm: fix osafimmnd coredump genereted during sanity test [#2947]

Ack, review only/Thanks HansN -Original Message- From: Vu Minh Nguyen Sent: den 29 oktober 2018 10:15 To: Hans Nordebäck ; Lennart Lund ; Gary Lee Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen Subject: [PATCH 1/1] imm: fix osafimmnd coredump genereted during sanity test

Re: [devel] [PATCH 1/4] amfd: add class definitions for new timers [#2918]

ack, code review only/Thanks HansN On 10/24/18 14:26, Gary Lee wrote: > osafAmfDelayNodeFailoverTimeout - the number of seconds we wait > after MDS down is received before we consider it truly down. > > osafAmfDelayNodeFailoverNodeUpWait - the number of seconds we > wait for Node Up after

Re: [devel] [PATCH 3/4] amfd: add checkpointing of node failover state [#2918]

ack, review only/Thanks HansN On 10/24/18 14:26, Gary Lee wrote: > --- > src/amf/amfd/chkop.cc| 10 ++ > src/amf/amfd/ckpt.h | 3 ++- > src/amf/amfd/ckpt_dec.cc | 40 +++- > src/amf/amfd/ckpt_enc.cc | 26 -- >

Re: [devel] [PATCH 2/4] amfnd: allow reboot from any director [#2918]

ack, review only/Thanks HansN On 10/24/18 14:26, Gary Lee wrote: > allow reboot msg to be sent from any director, for > split brain recovery situations > --- > src/amf/amfnd/mds.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/amf/amfnd/mds.cc

Re: [devel] [PATCH 1/4] amfd: add class definitions for new timers [#2918]

ack, review only/Thanks HansN On 10/24/18 14:26, Gary Lee wrote: > osafAmfDelayNodeFailoverTimeout - the number of seconds we wait > after MDS down is received before we consider it truly down. > > osafAmfDelayNodeFailoverNodeUpWait - the number of seconds we > wait for Node Up after receving MDS

Re: [devel] [PATCH 1/1] imm: add an admin operation to regenerate db from memory [#2940]

Hi Vu, ack, code review only. /BR HansN On 10/19/18 05:58, Vu Minh Nguyen wrote: > After split-brain recovery, there is possibility of having inconsistencies > between IMM data model in memory held by IMMND and one in the back-end > database (sqlite). > > That could happen as we might have 02

Re: [devel] [PATCH 1/1] amfnd: change log message severity [#2945]

ack/Thanks Hans On 10/25/18 07:28, Gary Lee wrote: > --- > src/amf/amfnd/clm.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amf/amfnd/clm.cc b/src/amf/amfnd/clm.cc > index f1f65bcef..06eb229c7 100644 > --- a/src/amf/amfnd/clm.cc > +++ b/src/amf/amfnd/clm.cc >

Re: [devel] [PATCH 1/1] imm: fix coredump is generated after split-brain recovery [#2942]

Hi Vu, ack review only. One minor comment below. /Thanks HansN On 10/19/18 10:16, Vu Minh Nguyen wrote: After split-recovery, there is possibility of having epoch counters mismatched b/w one on IMMND veteran located at this partition and one from active IMMD on another partition. With that,

Re: [devel] [PATCH 1/1] uml: add support for plm to run under uml [#2922]

ack, review only. (Run ok with the legacy uml without plm enabled). Minor comment, the function cmd_build/install_container_testprog() is part of ticket #70? /BR HansN On 09/17/2018 09:53 PM, Alex Jones wrote: > Add support for plm to run under uml. > --- > src/plm/config/openhpi.conf

Re: [devel] [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912]

Ack, (code review only)/Thanks Hans -Original Message- From: Gary Lee Sent: den 17 augusti 2018 02:00 To: Hans Nordebäck ; Minh Hon Chau ; Anders Widell Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] osaf: modify log severity level in Consensus::Demote [#2912

Re: [devel] [PATCH 1/1] amf: remove assignment for NPI component with enable DisableRestart [#2879]

Hi Thang, Ack, review only. I think you should keep V1, with the comments, my only suggestion was to correct the misspelled "thus SU" to "this SU". /Thanks HansN -Original Message- From: thang.nguyen Sent: den 8 augusti 2018 08:49 To: Hans Nordebäck ; Gary Lee

Re: [devel] [PATCH 1/1] imm: attrDefaultValue is set to NULL if no default value is given [#2901]

Hi Vu, yes, reinterpret_cast should be avoided if possible, in this case static_cast is better. You can ignore my comment about passing `attrDefaultValueBuffer` directly, it is not valid,. /Thanks HansN -Original Message- From: Vu Minh Nguyen Sent: den 7 augusti 2018 05:33 To: Hans

Re: [devel] [PATCH 1/1] amfd: remove redundant const_cast [#2907]

Ack, review only/Thanks HansN -Original Message- From: Gary Lee Sent: den 1 augusti 2018 05:47 To: Hans Nordebäck ; Minh Hon Chau Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] amfd: remove redundant const_cast [#2907] --- src/amf/amfd/clm.cc | 4 ++-- 1

Re: [devel] [PATCH 1/1] amfd: put sync jobs into queue if IMM is busy [#2863]

Hi Gary, You can remove all const_cast's in functions where the const parameter has been removed, e.g. AVD_CL_CB parameter ClmTrackStart::Exec etc. /Thanks HansN -Original Message- From: Gary Lee Sent: den 4 juli 2018 03:16 To: Minh Hon Chau ; Hans Nordebäck Cc: opensaf-devel

Re: [devel] [PATCH 1/1] rded: run controller promotion code in new thread [#2857]

Ack /Thanks HansN -Original Message- From: Gary Lee Sent: den 24 maj 2018 07:57 To: Hans Nordebäck ; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net; Gary Lee Subject: [PATCH 1/1] rded: run controller promotion code in new thread [#2857] Currently, the consensus

Re: [devel] [PATCH 1/1] base: Destructor of TraceLog causes coredump V2 [#2860]

Hi Minh, yes you are right about the possibility for a segv, but using a std::shared_ptr instead of the naked ptr may be an option ? /Thanks Hans Från: Minh Hon Chau <minh.c...@dektech.com.au> Skickat: den 24 maj 2018 02:34:13 Till: Hans Nordebäck;

Re: [devel] [PATCH 1/1] imm: inform status to NID before exit during start-up phrase [#2845]

Hi Vu, I'll revise my comment a bit, before sending nid_notify, the fifo monitoring is not started. So removing the exit should not be necessary, good if you can test this. /Thanks HansN -Original Message- From: Hans Nordebäck Sent: den 8 maj 2018 15:06 To: 'Vu Minh Nguyen' <vu.m.

Re: [devel] [PATCH 1/1] imm: inform status to NID before exit during start-up phrase [#2845]

2018 12:20 To: ravisekhar.ko...@oracle.com; Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; Lennart Lund <lennart.l...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen <vu.m.ngu...@dektech.com.au> Subject:

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

Hi Alex, Agree, adding a comment in nid.conf and 00-README.conf is good. The backtrace below looks normal, can you share the syslogs? /BR HansN From: Alex Jones [mailto:ajo...@rbbn.com] Sent: den 2 maj 2018 15:43 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <a

Re: [devel] [PATCH 1/1] clmd: Increase message priority of CLMSV_CLMS_MDS_NODE_EVT to be sent to main thread [#2842]

Ack, review only. /Thanks HansN -Original Message- From: Minh Chau [mailto:minh.c...@dektech.com.au] Sent: den 26 april 2018 01:22 To: Anders Widell <anders.wid...@ericsson.com>; Hans Nordebäck <hans.nordeb...@ericsson.com>; ravisekhar.ko...@oracle.com Cc: o

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

:05 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: SV: [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839] Hi Hans, There must be a hole here, then. Because

Re: [devel] [PATCH 1/1] amfd: if rootCauseEntity is PLM entity don't engage lock/lock-in [#2835]

Hi Alex, Ack, code review and legacy tests run. I added some comments below. /Thanks HansN From: Alex Jones [mailto:ajo...@rbbn.com] Sent: den 23 april 2018 16:05 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Gary Lee <gary@dektech.com.au>; ravisekhar.ko...@oracle.com Cc: o

Re: [devel] [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839]

: Alex Jones <ajo...@rbbn.com> Skickat: den 19 april 2018 17:27:27 Till: Hans Nordebäck; Anders Widell Kopia: opensaf-devel@lists.sourceforge.net; Alex Jones Ämne: [PATCH 1/1] nid: restart opensafd on failure when systemd enabled [#2839] Under certain circumstances opensafd fails to start

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

complete header file. /Thanks HansN ____ Från: Hans Nordebäck <hans.nordeb...@ericsson.com> Skickat: den 18 april 2018 20:43:22 Till: Minh Hon Chau; Anders Widell; ravisekhar.ko...@oracle.com Kopia: opensaf-devel@lists.sourceforge.net Ämne: Re: [devel] [PATCH 1/2]

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

logtrace.h as before. /Regards HansN Från: Minh Hon Chau <minh.c...@dektech.com.au> Skickat: den 18 april 2018 16:09:35 Till: Hans Nordebäck; Anders Widell; ravisekhar.ko...@oracle.com Kopia: opensaf-devel@lists.sourceforge.net Ämne: Re: [PATCH 1/2] base: Add s

Re: [devel] [PATCH 1/2] base: Add support to direct OpenSAF logging to local node file [#2306]

Hi Minh, See my comments below. /Thanks HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 18 april 2018 15:20 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; ravisekhar.ko...@oracle.com

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

Hi Gary, in general const member functions and using logical constness is to prefer, I think. (If needed mutable can be used). /Regards HansN -Original Message- From: Gary Lee [mailto:gary@dektech.com.au] Sent: den 13 april 2018 09:45 To: Hans Nordebäck <hans.nor

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

ssing here is link flickering  when remote fencing is not enabled, Also remote fencing using Stonith is valid only in Virtualization environments. I have not tested using Stonith enabled as the use case is in the case where remote fencing is disabled. Thanks, Ravi *From:*Hans

Re: [devel] [PATCH 0/5] Review Request for split-brain: select active SC from largest network partition V3 [#2795]

Hi, On 04/12/2018 04:15 PM, Gary Lee wrote: Hi On 12/04/18 23:34, Anders Widell wrote: Ack with comments: * There is no need to use "const" when passing function arguments by value. E.g. the argument "const uint64_t cluster_size" should be "uint64_t cluster_size". [GL] Sure, but it

Re: [devel] [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

ane. Have you tested with stonith enabled? /Regards HansN Från: ravi-sekhar <ravisekhar.ko...@oracle.com> Skickat: den 12 april 2018 15:29:13 Till: Hans Nordebäck; Anders Widell Kopia: opensaf-devel@lists.sourceforge.net; ravi-sekhar Ämne: [PATCH 1/1] osaf:

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

ack, review only. /Thanks HansN On 04/05/2018 04:39 AM, Vu Minh Nguyen wrote: The allocated memory is not freed before returning from the function ImmModel::setCcbErrorString(). --- src/imm/immnd/ImmModel.cc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [devel] [PATCH 1/1] build: Add support for google gmock framework V2 [#2823]

Hi Anders, I'll remove the turtle example. Perhaps we also can add a git pull if the repo is older than some date? /Thanks HansN On 04/09/2018 10:09 AM, Anders Widell wrote: Ack with comments: 1) You must replace the turtle example with something that you have written yourself, to avoid

Re: [devel] [PATCH 1/1] base: Check return code from unlink in nid_create_ipc [#2829]

Hi Anders, yes, I'll change to you suggestion. /Thanks HansN On 04/06/2018 04:10 PM, Anders Widell wrote: Ack with minor comment: instead of calling access(), you could maybe simply check for the ENOENT errno value from unlink()? regards, Anders Widell On 04/05/2018 11:53 AM, Hans

Re: [devel] [PATCH 1/1] amfnd: unlock before releasing the monitoring thread to avoid deadlock [#2818]

Hi Ravi, ack, review only. (I agree, NCS_TASK_RELEASE should not be called with the mutex taken as pthread_mutex_lock is not a cancellation point). /Regards HansN On 03/29/2018 07:59 AM, ravi-sekhar wrote: --- src/amf/amfnd/mon.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

len, errorString, vl) >= 0); } when there are variable arguments. BR, Zoran -Original Message- From: Hans Nordebäck Sent: den 4 april 2018 08:25 To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; Anders Widell <anders.wid...@ericsson.com>; ravisekhar.ko...@oracle.com

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

ail. I pressed wrong keys... Regards, Vu -Original Message- From: Anders Widell [mailto:anders.wid...@ericsson.com] Sent: Tuesday, April 3, 2018 7:07 PM To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; ravisekhar.ko...@oracle.com

Re: [devel] [PATCH 1/1] imm: fix memory leaked in immnd [#2825]

Hi Vu, few minor comments below. /Thanks HansN On 04/03/2018 11:43 AM, Vu Minh Nguyen wrote: The allocated memory is not freed before returning from the function ImmModel::setCcbErrorString(). --- src/imm/immnd/ImmModel.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[devel] VB: [PATCH 1/1] log: Handling of IMM OI BAD HANDLE in log server is incorrect [#2799]

Hi Lennart, I have one question below marked [HansN]. /Regards HansN Från: Lennart Lund Skickat: den 29 mars 2018 16:04 Till: Vu Minh Nguyen; Canh Van Truong Kopia: opensaf-devel@lists.sourceforge.net Ämne: [devel] [PATCH 1/1] log:

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

ack, review only. /Thanks HansN On 03/27/2018 10:34 AM, Hoa Le wrote: - Remove thread-local declaration of svc_to_mds_info --- src/mds/apitest/mdstipc_api.c | 7 ++- src/mds/apitest/mdstipc_conf.c | 43 +- 2 files changed, 27 insertions(+), 23

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest - part 2 [#2746]

: Hoa Le [mailto:hoa...@dektech.com.au] Sent: den 27 mars 2018 03:47 To: Anders Widell <anders.wid...@ericsson.com>; Hans Nordebäck <hans.nordeb...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net; Hoa Le <hoa...@dektech.com.au> Subject: [PATCH 1/1] mds: improve thread

Re: [devel] [PATCH 1/1] base: Add functions for parsing a string as an integer [#2814]

ack, review only. Minor comment below. /Thanks HansN On 03/22/2018 03:13 PM, Anders Widell wrote: The new functions StrToInt64 and StrToUint64 parse a string as a signed and unsigned 64-bit integer, respectively. Prefixes 0 for octal and 0x for hexadecimal are supported, as well as suffixes

Re: [devel] [PATCH 1/1] mds: improve thread safety in mdstest [#2746]

ers.wid...@ericsson.com>; Hans Nordebäck<hans.nordeb...@ericsson.com> Cc:opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1/1] mds: improve thread safety in mdstest [#2746] - Correct helgrind issues in mds/apitest --- src/mds/apitest/mdstest.c | 7 +- src/mds/apite

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Minh, Yes, that will be ok. /Regards HansN -Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 20 mars 2018 12:53 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; ravisekhar.ko...@oracle.com

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

-Original Message- From: Minh Hon Chau [mailto:minh.c...@dektech.com.au] Sent: den 20 mars 2018 08:29 To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

" and 0, 1, 2, ..etc, but the usage of 2nd parameter of strtol is more generalized So I think the check of strcmp is not needed? Thanks, Minh On 19/03/18 18:00, Hans Nordebäck wrote: Hi Minh, my comment was that this check could be added: if (strcmp(pentry->d_name, ".") == 0

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

: Hi! See my comments below, marked AndersW2>. regards, Anders Widell On 03/16/2018 12:39 PM, Hans Nordebäck wrote: Hi Minh, ack with some comments, (on top of AndersW comments). /Thanks HansN On 03/15/2018 07:50 AM, Minh Chau wrote: ---   src/base/os_defs.c | 25

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

AndersW2>. regards, Anders Widell On 03/16/2018 12:39 PM, Hans Nordebäck wrote: Hi Minh, ack with some comments, (on top of AndersW comments). /Thanks HansN On 03/15/2018 07:50 AM, Minh Chau wrote: ---   src/base/os_defs.c | 25 -   1 file changed, 20 insertions(+)

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Minh, ack with some comments, (on top of AndersW comments). /Thanks HansN On 03/15/2018 07:50 AM, Minh Chau wrote: --- src/base/os_defs.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/base/os_defs.c b/src/base/os_defs.c index

Re: [devel] [PATCH 1/1] base: Only close inherited fd(s) after fork() in child process [#2805]

Hi Minh, I'll review the patch shortly, (today)/Thanks HansN On 03/16/2018 06:17 AM, Minh Hon Chau wrote: Thanks Anders for your comments. Hi Hans, Ravi, Is there any comment you would like to add, otherwise I update the patch with Anders' comments. Thanks, Minh On 16/03/18 01:41,

  1   2   3   4   5   6   7   >