Hi Surbhi,
ACK with minor comment.
Short commit msg should be "ntf: ..."
Best Regards,
ThuanTr
-Original Message-
From: Surbhi Tripathi
Sent: Tuesday, November 24, 2020 10:11 AM
To: Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Surbhi Tripathi
Subject: [PATCH 1/1
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, November 12, 2020 5:16 PM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] imm: prevent override delimiter value
Hi Quang,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Quang Xuan Nhat Nghiem
Sent: Wednesday, November 11, 2020 3:50 PM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Quang Xuan Nhat Nghiem
Subject: [PATCH 1/1] ntf: fix coredump while
Hi Quang,
One comment inline.
Best Regards,
ThuanTr
-Original Message-
From: Quang Xuan Nhat Nghiem
Sent: Wednesday, November 11, 2020 12:56 PM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Quang Xuan Nhat Nghiem
Subject: [PATCH 1/1] ntf: fix coredump
Hi Minh,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Wednesday, October 28, 2020 5:43 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Minh Hon Chau
Subject: [PATCH 1/1] base: Use non-blocking socketpair in sysf_exc
Hi Thang,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, October 22, 2020 2:34 PM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amf: fix coredump in start up [#3186
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, October 20, 2020 11:16 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] amf: Increase sync node size equal
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Monday, October 19, 2020 9:58 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] amf: Increase sync node size equal
-intro rsp.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Friday, September 18, 2020 9:11 AM
To: Thuan Tran ; Thang Duc Nguyen
; Thanh Nguyen ;
Thien Minh Huynh
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] imm: fix immnd crash in multi
ng Duc Nguyen ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] imm: Enhance deep clone of Imm Attr values in immutil
[#3215]
1) Reuse existing functionality for deep clone of Imm Attr values.
2) Publish immutil internal memory managem
Hi Thanh,
ACK with minor comments inline.
Best Regards,
ThuanTr
-Original Message-
From: Thanh Nguyen
Sent: Wednesday, September 2, 2020 10:49 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] imm
Hi Minh,
Thanks for comments. See my replies inline.
Regards,
Thuan
From: Minh Hon Chau
Sent: Friday, August 28, 2020, 06:16
To: Thuan Tran; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] mds: fix receiving old msg under flow
Hi Thang,
NULL is already checked inside m_MMGR_FREE_BUFR_LIST()
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, August 18, 2020 8:40 AM
To: Thuan Tran ; Minh Hon Chau
; Thanh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] mbc
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Thursday, August 13, 2020 10:26 AM
To: Thuan Tran ; Minh Hon Chau
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] pyosaf: Support python3
Hi Thanh,
Thank you. Yes, please continue with next ticket.
Best Regards,
ThuanTr
-Original Message-
From: Thanh Nguyen
Sent: Monday, August 17, 2020 10:43 AM
To: Thuan Tran ; Thang Duc Nguyen
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] osaf
Hi Thanh,
Here is V2 patch.
Best Regards,
ThuanTr
-Original Message-
From: Thuan Tran
Sent: Tuesday, August 11, 2020 1:08 PM
To: Thanh Nguyen ; Thang Duc Nguyen
; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thuan Tran
Subject: [PATCH 1/1] osaf: move common functions
Best Regards,
ThuanTr
From: Thang Duc Nguyen
Sent: Thursday, August 13, 2020 3:45 PM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] rde: allow node start first to be promoted in relax
mode [#3191]
Hi Thuan,
One comment in code review
Hi Thang,
See my reply inline.
Best Regards,
ThuanTr
From: Thang Duc Nguyen
Sent: Thursday, August 13, 2020 8:07 AM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] rde: allow node start first to be promoted in relax
mode [#3191]
Hi Thuan,
See
) to decide
give up or not.
This calculated pending time is later sent to peer B as peer A info.
By this way, to make decisions are made by two peers have no confliction.
Best Regards,
Thuan
From: Thang Duc Nguyen
Sent: Wednesday, August 12, 2020 3:50:24 PM
To: Thuan Tran
Hi Minh,
Thanks. I will include it and push.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Sunday, August 9, 2020 9:15 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] nid: fix opensafd fail to start under
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, July 29, 2020 12:15 PM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] clm: fix memory leak reported by valgrind
Hi Thien,
Good work! Some comments inline.
Also, commit message typo: "reeported" -> "reported"
Best Regards,
ThuanTr
-Original Message-
From: thien.m.huynh
Sent: Tuesday, July 28, 2020 9:27 AM
To: Thang Duc Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourcefo
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, July 14, 2020 4:50 PM
To: Vu Minh Nguyen ; Thuan Tran
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] saflogger: avoid saflogger
Hi Thien,
Check my inline comments.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, July 14, 2020 12:03 PM
To: Vu Minh Nguyen ; Thuan Tran
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] saflogger
Hi Thanh,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thanh Nguyen
Sent: Friday, July 10, 2020 3:27 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] ntf: Enhance attribute change
Hi Minh,
Thanks, I will add comment for ex_immd_node_id and check spelling in README.
I will send V2 with AMF patch as our verbal discussion.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Friday, July 10, 2020 9:56 AM
To: Thuan Tran ; Thang Duc Nguyen
; Vu Minh
Hi Phuc,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Phuc Hoang Chau
Sent: Friday, July 10, 2020 11:04 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Phuc Hoang Chau
Subject: [PATCH 1/1] imm: fix memory leak reported by valgrind
Hi Minh,
See my responses in line with [T2]
I will send out V2 under #2936 umbrella.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Friday, July 10, 2020 9:50 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1
Hi Thanh,
ACK with some minor comments inline.
Best Regards,
ThuanTr
-Original Message-
From: Thanh Nguyen
Sent: Wednesday, July 8, 2020 2:52 PM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: [PATCH 1/1] ntf
Hi Minh,
Yes, #3185 is only help for multi partition cluster rejoin.
As verbal discussion, I will move this patch under #2936 umbrella.
See my replies for inline comments.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Thursday, July 9, 2020 8:39 PM
To: Thuan Tran
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Phuc Hoang Chau
Subject: [PATCH 1/1] imm: fix memory leak reeported by valgrind [#3199]
Fix definitely lost reported by valgrind.
---
src/imm/immd/immd_proc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/imm/immd/immd_proc.c b/src
Hi Thang,
ACK from me.
P/s: maybe also need another ticket for NTF since ntfs_exit() do similar this
one.
ntfs_exit("Cold sync failed", SA_AMF_COMPONENT_RESTART);
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, July 2, 2020 2:26 PM
To:
Hi Thang,
Some comments inline.
One concern, LOG ticket but change src/base/daemon.c
Is it acceptable? Or need create different ticket?
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, June 2, 2020 5:53 PM
To: Vu Minh Nguyen ; Thien Minh Huynh
; Thuan
Hi Peter,
ACK.
Best Regards,
ThuanTr
-Original Message-
From: Peter McIntyre
Sent: Monday, June 1, 2020 1:23 PM
To: Minh Hon Chau ; Vu Minh Nguyen
; Thang Duc Nguyen ;
Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Peter McIntyre
Subject: [PATCH 1/1] imm: add checking
Hi David,
Please ignore this mail. I mistake it with #3192.
Best Regards,
ThuanTr
-Original Message-
From: Thuan Tran
Sent: Thursday, May 28, 2020 9:53 AM
To: Minh Hon Chau ; Thang Duc Nguyen
; Gary Lee ; Hoyt,
David
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel
Hi David,
Please help ACK the review as you have verified the patch.
Thank you.
P/S: you can give comment if any.
Best Regards,
ThuanTr
-Original Message-
From: Thuan Tran
Sent: Tuesday, May 26, 2020 1:31 PM
To: Minh Hon Chau ; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thuan
Hi David,
Please help ACK the review as you have verified the patch.
Thank you.
P/S: you can give comment if any.
Best Regards,
ThuanTr
-Original Message-
From: Thuan Tran
Sent: Monday, May 25, 2020 5:40 PM
To: Minh Hon Chau ; Thang Duc Nguyen
; Gary Lee
Cc: opensaf-devel
nt: Friday, May 22, 2020 7:12 AM
To: Thuan Tran ; Thang Duc Nguyen
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] rde: avoid dual active controllers in relax promotion
mode [#3188]
Hi Thuan,
the role_ being checked in this PromoteNode thread can be changed to
QUI
Hi Thang,
OK, will move it up before push.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Monday, May 18, 2020 11:34 AM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] osaf: fix coding issue identified
access '/srv/shared/saflog/croot/testRoot'.
Increase sleep 2s to make sure all directory are created successfully.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Wednesday, May 13, 2020 2:35 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Hi Thien,
ACK from me.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday, May 12, 2020 1:33 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Thien Minh Huynh
Subject: [PATCH 1/1] lgs: map the CkptPushAsync to the right memory
Best Regards,
Thuan
From: Thien Minh Huynh
Sent: Monday, May 11, 2020 2:51 PM
To: Vu Minh Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] lgs: fix data CkptPushAsync equals with encode cold
sync [#3183]
Hi Vu,
Thanks for your co
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] ntf: fix ntfimcn fail to send notification with no
space error [#3181]
Hi Thuan
Ack with comment. I think we need to check the max value of unit32t for
ntf_var_data_limit when we source from the env var
Hi Thang,
ACK
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, April 22, 2020 11:47 AM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] ntf: set operation invoke name to unknown if failed
Hi Thang,
Some comments inline.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, April 21, 2020 5:49 PM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] ntf: set operation invoke name
l 21, 2020 8:39 AM
To: Thang Duc Nguyen ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178]
Update.
If we accept to avoid coredump, there is @operation_invoke_name that needs to
,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, April 16, 2020 10:51 AM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation
invoke name [#3178]
Hi Thuan,
Thanks for your
-
From: Thang Duc Nguyen
Sent: Wednesday, April 15, 2020 3:43 PM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] ntf: restart ntfimcnd if it fails to get operation invoke
name [#3178]
If ntfimcnd is restarted during ccb
Hi Thang,
ACK.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Tuesday, April 14, 2020 9:16 PM
To: Thuan Tran ; Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amfnd: correct checking su assignement pending flag
e name is not hhmmss format
// Return 0 if last part of file name is not ".log"
// Return 1 when file name is completely matching the format.
return 1
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Monday, April 13, 2020 11:29 AM
To: Thang Duc Nguyen ; Thuan Tran
Hi Thien,
ACK with minor comment inline.
Best Regards,
ThuanTr
-Original Message-
From: Vu Minh Nguyen
Sent: Tuesday, April 7, 2020 5:27 PM
To: Thien Minh Huynh ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] log: log content is placed in a file
me_find_g + "_[0-9]+_[0-9]+_[0-9]+_[0-9]+.log");
if (std::regex_match(finfo->d_name, pattern1) ||
std::regex_match(finfo->d_name, pattern2)) {
...
}
Not yet verify, just the idea.
Best Regards,
ThuanTr
-Original Message-
From: Thien Minh Huynh
Sent: Tuesday,
Sent: Tuesday, March 31, 2020 10:01 AM
To: Thuan Tran ; Minh Hon Chau
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck
forever [#3169]
Hi Thuan,
I have a minor comment and also an ACK.
Dealing with event
Hi Minh,
See my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Tuesday, March 31, 2020 8:05 AM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown() stuck forever
Hi Minh,
Thanks for reviewing. See my replies inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Monday, March 30, 2020 5:00 PM
To: Thuan Tran ; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] mds: fix mds_tipc_fctrl_shutdown
Hi Minh,
Thanks for late comments.
See my reply inline.
Best Regards,
ThuanTr
-Original Message-
From: Minh Hon Chau
Sent: Friday, March 20, 2020 9:27 AM
To: Thuan Tran ; Thang Duc Nguyen
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thanh Nguyen
Subject: Re: [PATCH 1/1
Hi Phuc,
ACK.
Best Regards,
ThuanTr
-Original Message-
From: Phuc Hoang Chau
Sent: Monday, March 9, 2020 5:42 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Phuc Hoang Chau
Subject: [PATCH 1/1] imm: enhance "immlist --help" output more a
Hi Thang,
But in roaming SC with many quiesced SCs, it will become spam.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Friday, March 6, 2020 8:36 AM
To: Thuan Tran ; Gary Lee ;
Minh Hon Chau
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] fm
Hi Thang,
ACK with minor comment.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, March 5, 2020 3:48 PM
To: Gary Lee ; Minh Hon Chau
; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] fm: ignore unexpected
Hi Thang,
ACK with minor comment.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Wednesday, March 4, 2020 9:03 AM
To: Minh Hon Chau ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amfnd: reset component register
Hi Phuc,
ACK.
Best Regards,
ThuanTr
-Original Message-
From: Phuc Hoang Chau
Sent: Monday, March 2, 2020 2:49 PM
To: Vu Minh Nguyen ; Thuan Tran
; Thang Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net; Phuc Hoang Chau
Subject: [PATCH 1/1] imm: imm_list tool add new option
Hi Thang,
I have 2 comments inline.
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, February 27, 2020 1:19 PM
To: Minh Hon Chau ; Thuan Tran
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amfnd: handle comp
e-
From: Phuc Hoang Chau
Sent: Wednesday, February 26, 2020 10:53 AM
To: Vu Minh Nguyen ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] imm: imm_list tool add new option --delimeter [#3155]
Hi ,
Due to I changed mode of the file , I have updated the old
two)?
Best Regards,
ThuanTr
-Original Message-
From: Thang Duc Nguyen
Sent: Thursday, February 20, 2020 1:28 PM
To: Minh Hon Chau ; Thuan Tran
; Gary Lee
Cc: opensaf-devel@lists.sourceforge.net; Thang Duc Nguyen
Subject: [PATCH 1/1] amfnd: correct handling "terminate success&q
}
+ } while (rc != NCSCC_RC_SUCCESS && retry++ < 1);
Best Regards,
ThuanTr
From: Gary Lee
Sent: Tuesday, February 18, 2020 2:18 PM
To: Thuan Tran ; Vu Minh Nguyen
; Minh Hon Chau ; Thang
Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] clmd: retry once to send messag
Hi Vu,
Thanks, I will update and send out new version.
See my replies inline.
Best Regards,
ThuanTr
From: Nguyen Minh Vu
Sent: Monday, February 17, 2020 12:29 PM
To: Thuan Tran ; Minh Hon Chau
; Thang Duc Nguyen ;
Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1
Hi Vu,
Thanks for comments. Please check my replies inline.
Best Regards,
ThuanTr
From: Nguyen Minh Vu
Sent: Thursday, February 13, 2020 5:50 PM
To: Thuan Tran ; Minh Hon Chau
; Thang Duc Nguyen ;
Gary Lee
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] base: add serial
Hi Alex,
See my comment in line with [Thuan].
Best Regards,
ThuanTr
From: Alex Jones
Sent: Saturday, February 8, 2020 4:10 AM
To: Gary Lee ; Thuan Tran
Cc: opensaf-devel@lists.sourceforge.net; Alex Jones
Subject: [PATCH 1/1] amfd: fix calculating standby rank for SIrankedSU with
non-unique
Hi Alex,
OK, you can keep strncpy with len + 1.
No more comment from me.
From: Alex Jones
Sent: Tuesday, February 4, 2020 9:40 PM
To: Thuan Tran ; Vu Minh Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 5/5] build: fix compile errors with gcc 9.x [#3134]
Hi ThuanTr
ot;, i_node.c_str());
return false;
}
}
}
LOG_NO("%s: className '%s'", __FUNCTION__, className);
return true;
Thanks
Lennart
-Original Message-
From: thuan.tran
Sent: den 25 september 2018 09:04
To: Lennart Lund ; Gary Lee
Cc: opensaf-devel@lists.sourcefor
70 matches
Mail list logo