Hi,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 29 augusti 2016 06:17
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Create
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 28 augusti 2016 04:30
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Avoid
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 28 augusti 2016 08:21
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review
Other n
Comments (indicate scope for each "y" above):
-
changeset 27ad8b8847e90995f47c638369b13312b37a615c
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 26 Aug 2016 16:05:37 +0200
cl
tests/clmsv/Makefile.am |4 +-
tests/clmsv/tet_ClmLongRdn.c | 480 +++
2 files changed, 483 insertions(+), 1 deletions(-)
The patch contains tests for testing long RDN support in CLM.
Long DN allowed must be allowed in IMM to pass new CLM tests.
s a memory leak.
Otherwise I don't see that the ticket is valid.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 26 augusti 2016 13:30
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Reque
Hi Hung,
Reviewed and tested the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 augusti 2016 10:30
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 2
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 11 augusti 2016 08:53
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review
Hi Hung,
Same comments as Neelakanta.
Without #1948, the patch is incomplete.
The patch #1948 is going to be pushed, so ACK from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 11 augusti 2016 09:10
To: Zoran Milinkovic
n
Comments (indicate scope for each "y" above):
-
changeset 974ebb83278f3e1621f991d518dfee815848bbdf
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 18 Aug 2016 14:00:59 +0200
imm: f
osaf/services/saf/immsv/immnd/ImmModel.cc | 8
1 files changed, 4 insertions(+), 4 deletions(-)
Fix string format for size_t type that IMM can be compiled with 32-bit compiler.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 16 augusti 2016 12:52
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1] Review
n
Comments (indicate scope for each "y" above):
-
changeset 9a2b473cc2bc9ec744bd330a1b250f2b2a6688d0
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 16 Aug 2016 11:28:24 +0200
clm: fix string format
10:07
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 3 of 5] imm: Checking of Imm limits [#195]
Hi Zoran,
All the attribute definition will be moved to the top of the file.
The response for the remaining comments.
Thanks,
Neel.
On 2016/08/12 07
Hi Mathi,
I just sent the fix to the review.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 16 augusti 2016 08:37
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: osafclmna[5375]: ER Exiting
Hi Zoran Milinkovic
n
Comments (indicate scope for each "y" above):
-
changeset 441e348fe941b66019c49c31d0e4bd73efd8d094
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 16 Aug 2016 09:57:11 +0200
clm: fix decoding for SaN
osaf/libs/common/clmsv/clmsv_enc_dec.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
Add null-terminated string to the end of decoded string for SaNameT type.
diff --git a/osaf/libs/common/clmsv/clmsv_enc_dec.c
b/osaf/libs/common/clmsv/clmsv_enc_dec.c
---
Hi Hung,
The new parameter does not have effect on IMM object, and it's ok. Admin owner
on IMM object should never be released.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 9 augusti 2016 10:19
To: Zoran Milinkovic
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 21 juli 2016 11:50
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Fix
quot;headless" term in
the documentation.
Any opinion regarding this ?
Should we go with one term instead of using more terms ?
Beside this comment, the patch is ok.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 25 juli 2016 12:
Hi Neelakanta,
Reviewed the patch,
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 28 juli 2016 12:37
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Hi Neelakanta,
Find my comments inline
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 27 juli 2016 10:32
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 3 of 5] imm: Checking of Imm limits
Hi Neelakanta,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 10 augusti 2016 11:44
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm:send 2PBE preload
ed in the patch.
Shouldn't "cb->immd_remote_id" be set to 0 in NCSMDS_RED_DOWN event when
"cb->immd_remote_up" is set to FALSE ?
Other minor comments inline.
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 26 juli 201
Comments (indicate scope for each "y" above):
-
changeset 95f06964c2a6117d839fd33e1b334cd01ee803a9
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 15 Jul 2016 23:50:34 +0200
clm: add support for long RDN
osaf/services/saf/clmsv/clms/clms_imm.c | 73 +++
osaf/services/saf/clmsv/clms/clms_main.c | 5 ++
osaf/services/saf/clmsv/clms/clms_util.c | 7 +++
3 files changed, 75 insertions(+), 10 deletions(-)
Add support for long RDN to support RDN values longer than 64
osaf/libs/agents/saf/clma/clma_api.c | 85 -
osaf/libs/agents/saf/clma/clma_util.c | 14 +
osaf/libs/common/clmsv/clmsv_enc_dec.c | 32
3 files changed, 96 insertions(+), 35 deletions(-)
Add support for long RDN to support RDN values longer
Comments (indicate scope for each "y" above):
-
changeset 7ebdd0d9fdca85fc6eb6604aed3c76f2db6a7fc2
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 15 Jul 2016 23:51:02 +0200
clm: add support for long RDN
osaf/services/saf/clmsv/clms/clms_imm.c | 73 +++
osaf/services/saf/clmsv/clms/clms_main.c | 5 ++
osaf/services/saf/clmsv/clms/clms_util.c | 7 +++
3 files changed, 75 insertions(+), 10 deletions(-)
Add support for long RDN to support RDN values longer than 64
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 2d9a4cf1beefaedfc2b6ff16cf6c76f4838298b5
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 15 Jul 2016 12:37:48 +0200
osaf/services/saf/clmsv/clms/clms_imm.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
Wrong used error codes SA_AIS_ERR_NOT_SUPPORTED and SA_AIS_ERR_INAVLID_PARAM
are replaced with SA_AIS_ERR_BAD_OPERATION.
diff --git a/osaf/services/saf/clmsv/clms/clms_imm.c
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 4 juli 2016 12:39
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Return
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 11 juli 2016 09:04
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 3] Review
Hi Mahesh,
It looks like long DN is no allowed in IMM.
Check how you have configured IMM.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 8 juli 2016 11:00
To: Vu Minh Nguyen; Lennart Lund
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re:
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Duc Nguyen
Sent: den 14 juni 2016 12:38
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Allow admo hard finalize messages
Hi Hung,
Neelakanta pointed that IMMD_EVT_ND2D_INTRO can be sent only to active IMMD.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 5 juli 2016 16:01
To: Hung Duc Nguyen; reddy.neelaka...@oracle.com
Cc: opensaf
but veteran_sync_lock must be initialized in the beginning.
Otherwise there might be a problem in immd_mds_rcv().
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 juli 2016 15:42
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 juli 2016 14:28
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Remove
juli 2016 14:37
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm: Fix the startup delay in IMMD [#1896]
Hi Zoran,
It was protected by "cb->fully_initialized".
MDS/MBC is initialized only once, so vete
Hi Hung,
What if switch over is initiated ?
BR,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 5 juli 2016 14:37
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] imm: Fix the startup delay in IMMD
:50
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Fix the startup delay in IMMD [#1896]
osaf/services/saf/immsv/immd/immd_main.c | 60 ---
1 files changed, 31 insertions(+), 29 deleti
une 29, 2016 8:21 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Fix the problem with IMMND killing itself [#1899]
osaf/services/saf/immsv/immnd/immnd_proc.c | 2 +-
1 files changed, 1
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 24, 2016 1:37 PM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 17, 2016 6:34 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
acle.com]
Sent: Monday, June 27, 2016 7:26 AM
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 5] Review Request for imm: Fix cppcheck warnings
[#1883]
Hi Hung,
Revie
Hi Hung,
I have the same comment as Neelakanta for the missing replacement with strdup.
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, June 22, 2016 6:31 AM
To: Zoran Milinkovic <zoran.mili
Hi Hung,
Reviewed and tested the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 17, 2016 6:34 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, June 17, 2016 6:34 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 3] imm: Remove conditional stateme
Hi Hung,
Ignore it.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Tuesday, June 14, 2016 12:25 PM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1 of 1] immtool
Hi Hung,
param->paramName alsp need to be freed.
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Tuesday, June 14, 2016 10:37 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
redd
between tests.
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, May 06, 2016 8:10 AM
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf
n
Other n
Comments (indicate scope for each "y" above):
-
changeset b9df62ef69fb782e0be7d05b7fa5ad2f9556c16b
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 27 May 2016 14:39:30 +0
osaf/libs/common/immsv/immsv_evt.c | 20 ++--
osaf/libs/common/immsv/include/immsv_api.h | 1 +
2 files changed, 11 insertions(+), 10 deletions(-)
Change limit for number of admin op parameters to 1023
diff --git a/osaf/libs/common/immsv/immsv_evt.c
osaf/services/saf/immsv/immnd/immnd_evt.c | 1 +
osaf/services/saf/immsv/immnd/immnd_proc.c | 6 +-
2 files changed, 6 insertions(+), 1 deletions(-)
The patch fixes memory leaks in immnd_introduceMe and
immnd_evt_proc_imm_resurrect, and releases allocated memory.
diff --git
n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 1c1617cf6b60f089886d89adcfbc7b53842459f2
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, May 18, 2016 6:21 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm
Hi Hung,
Neither I have a better solution to this.
Good work.
Ack from me.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, May 13, 2016 4:23 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1
,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, May 13, 2016 2:34 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Dont verify mDying on veterans when finalizing
sync
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Tuesday, April 26, 2016 7:47 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm
Hi,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, April 06, 2016 12:40 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1
Good work Hung,
Nicely use of qsort and bsearch to improve immcfg performance.
Reviewed and tested the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, April 07, 2016 12:14 PM
To: Zoran Milinkovic
Hi Anders,
Reviewed patches.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: Friday, April 08, 2016 6:09 PM
To: Hung Duc Nguyen; reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 2] Review Request for imm
osaf/services/saf/immsv/README | 93 ++
1 files changed, 93 insertions(+), 0 deletions(-)
Update README with IMM enhancements
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++
nt: Friday, April 01, 2016 1:58 PM
To: Zoran Milinkovic
Cc: anders.bjornerst...@telia.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 3] Review Request for imm: support for
transactional safe read [#48]
Hi zoran,
we are already checking in accessor_get_common:
if(bU
, April 01, 2016 1:49 PM
To: Zoran Milinkovic
Cc: anders.bjornerst...@telia.com; opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 0 of 3] Review Request for imm: support for
transactional safe read [#48]
Hi zoran,
In future there may be chance of calling accessor_get_common(), with ccb
osaf/services/saf/immsv/README | 44 ++
osaf/services/saf/immsv/immnd/ImmModel.cc | 631 +++-
osaf/services/saf/immsv/immnd/ImmModel.hh | 10 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 162 +++-
osaf/services/saf/immsv/immnd/immnd_init.h |3
tests/immsv/common/immtest.c |2 +
tests/immsv/common/immtest.h |1 +
tests/immsv/implementer/test_saImmOiAugmentCcbInitialize.c | 63 +-
tests/immsv/management/test_saImmOmCcbInitialize.c |7 +
n
Comments (indicate scope for each "y" above):
-
changeset 339c2755f9cf83bdaee6689c6c129982c628e8e6
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 31 Mar 2016 09:49:45 +0200
imm: add suppor
osaf/libs/agents/saf/imma/imma_cb.h |1 +
osaf/libs/agents/saf/imma/imma_db.c | 15 +-
osaf/libs/agents/saf/imma/imma_oi_api.c |2 +-
osaf/libs/agents/saf/imma/imma_om_api.c | 422 ++-
osaf/libs/agents/saf/imma/imma_proc.c
() methods
return SA_AIS_OK.
This is wrong to remove the flag in ::deleteObject() method.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, March 30, 2016 8:06 AM
To: Zoran Milinkovic; anders.bjornerst...@telia.com; reddy.neelaka
[mailto:anders.bjornerst...@telia.com]
Sent: Tuesday, March 29, 2016 11:09 AM
To: Hung Duc Nguyen; reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 2 of 3] imm: add support to IMM service for
transactional safe read [#48]
Hi Hung
I forgot ack from me.
Thanks,
Zoran
-Original Message-
From: Zoran Milinkovic
Sent: Tuesday, March 29, 2016 3:09 PM
To: 'reddy.neelaka...@oracle.com'; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1 of 1] imm: honour return code when ncs_sel_obj_create
Hi Neelakanta,
Reviewed the patch.
I agree with Hung's comments.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: Tuesday, March 29, 2016 12:04 PM
To: Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
osaf/libs/agents/saf/imma/imma_cb.h |3 +-
osaf/libs/agents/saf/imma/imma_db.c | 14 +-
osaf/libs/agents/saf/imma/imma_oi_api.c |2 +-
osaf/libs/agents/saf/imma/imma_om_api.c | 415 ++-
osaf/services/saf/immsv/README | 44 ++
osaf/services/saf/immsv/immnd/ImmModel.cc | 608 +++-
osaf/services/saf/immsv/immnd/ImmModel.hh |7 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 169 +++-
osaf/services/saf/immsv/immnd/immnd_init.h |3
n
Comments (indicate scope for each "y" above):
-
changeset 67286ab0ebf4673cec9518beecd560018bf7d8c5
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 23 Mar 2016 17:42:45 +0100
imm: add suppor
Hi Hung,
Reviewed and tested the patch.
Cannot reproduce the problem.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, March 10, 2016 8:27 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel
Hi Hung,
Reviewed the patch.
Ac from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Tuesday, March 08, 2016 11:57 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm
Hi Anders,
Ack with minor inline comments.
-Original Message-
From: Anders Widell
Sent: Monday, February 29, 2016 3:56 PM
To: Hung Duc Nguyen; reddy.neelaka...@oracle.com; Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 2] imm: Support AMF configurations
Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Monday, February 15, 2016 8:26 AM
To: Zoran Milinkovic; anders.bjornerst...@telia.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for
immoite
To: Zoran Milinkovic; Anders Widell; Hung Duc Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: changing from system time to monotonic time [#1617]
osaf/libs/core/common/include/osaf_time.h| 20 +++
osaf/services/saf/immsv/immnd/ImmModel.cc| 29
Hi Anders,
Your comment can be done in a new ticket.
Ticket #1617 is to switch from system to monotonic time.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: Wednesday, March 16, 2016 10:44 AM
To: reddy.neelaka...@oracle.com; Zoran Milinkovic; Hung Duc Nguyen
Cc: opensaf
Hi Hung,
Ack with a minor inline comment.
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Friday, February 05, 2016 10:57 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Send all
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Tuesday, February 16, 2016 10:10 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 0 of 1
osaf/services/saf/immsv/immd/immd_cb.h| 2 +-
osaf/services/saf/immsv/immd/immd_evt.c | 3 -
osaf/services/saf/immsv/immd/immd_mbcsv.c | 56 ++-
3 files changed, 56 insertions(+), 5 deletions(-)
SC absence allowed part will prevent that controllers don't
osaf/services/saf/immsv/immd/immd_cb.h| 2 +-
osaf/services/saf/immsv/immd/immd_evt.c | 3 -
osaf/services/saf/immsv/immd/immd_mbcsv.c | 56 ++-
3 files changed, 56 insertions(+), 5 deletions(-)
SC absence allowed part will prevent that controllers don't
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 1ad29ffda8578a73a36ac44219593a4e4b4e5840
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 01 Mar 2016 11:04:20 +0100
Hi Hung,
Find my comments inline started with [Zoran]
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, February 03, 2016 12:36 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 3 of 5] imm: add IMMD
Hi Hung,
The comment is done.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Thursday, February 04, 2016 10:41 AM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 4 of 5] imm: add IMMND support
Hi Hung,
The OpenSAF version in the comment is fixed.
Thanks,
Zoran
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: Wednesday, February 03, 2016 12:36 PM
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 5
Hi Neelakanta,
Find my comments inline started with [Zoran]
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, February 12, 2016 12:38 PM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 5] Review Request
n
Comments (indicate scope for each "y" above):
-
changeset ef29dcad3910fb9eb628f0c88845426780f58d58
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 23 Feb 2016 16:46:18 +0100
imm: regener
n
Comments (indicate scope for each "y" above):
-
changeset b97205d232f408a696d56f77924e88a0c580a8ce
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 23 Feb 2016 16:38:05 +0100
imm: fix review
osaf/libs/common/immsv/immpbe_dump.cc | 1 +
osaf/libs/common/immsv/include/immsv_evt.h | 2 +-
osaf/services/saf/immsv/immd/immd_cb.h | 2 +-
osaf/services/saf/immsv/immd/immd_evt.c| 26 --
osaf/services/saf/immsv/immd/immd_proc.c | 2 +-
Hi Neelakanta,
Since it's a config parameter, the cluster restart is necessary.
BR,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: Friday, February 19, 2016 2:28 PM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re
samples/immsv/OpensafImm_Upgrade_5.0.xml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/samples/immsv/OpensafImm_Upgrade_5.0.xml
b/samples/immsv/OpensafImm_Upgrade_5.0.xml
--- a/samples/immsv/OpensafImm_Upgrade_5.0.xml
+++ b/samples/immsv/OpensafImm_Upgrade_5.0.xml
@@
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 83f640ea41840db815d85f3da8dd0b99b53a0570
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Dat
AM
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 0 of 1] Review Request for imm: move immloadd and immpbed
to node director package in opensaf.spec [#1625]
Hi Zoran,
The following are the additional comments on #1625.patch:
1. All the patches published
n
Comments (indicate scope for each "y" above):
-
changeset 542e136ca92ba7a2c7319f9f513679a34e61992f
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 19 Feb 2016 11:45:03 +0100
imm: fix buildin
osaf/services/saf/immsv/immnd/ImmModel.cc | 8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
The patch adds missing code from ticket #801 that is required for IMM SC
absence allowed
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
201 - 300 of 678 matches
Mail list logo
