Re: [devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-17 Thread Zoran Milinkovic
Hi Rafael, Reviewed the patch, but didn't test. Ack from me. Thanks, Zoran -Original Message- From: Rafael Odzakow Sent: den 16 oktober 2017 13:53 To: Zoran Milinkovic ; Hans Nordebäck Cc:

[devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-16 Thread Rafael Odzakow
Moving the setup_env caused ubuntu 14.04 systems to fail as they dont have the /var/lock/subsys directory by default. --- src/nid/opensafd.in | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in index d7035f5..ed7818f 100644 ---

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-12 Thread Hans Nordebäck
Hi Rafael, not tested, minor comment/question below. Regards /Hans On 10/10/2017 02:08 PM, Rafael Odzakow wrote: Previously named function "check_env" overwrites pid file. Move it to after running pidofproc for amfnd pid. --- src/nid/opensafd.in | 4 ++-- 1 file changed, 2 insertions(+),

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-10 Thread Rafael Odzakow
Just tried it that was not the case for patch, still got the "*" c0b25cd7a1a94d386d813735c72d22abded8583b base: Atomically create pid file from temporary pid file V2 [#2432] On 10/10/2017 02:39 PM, Zoran Milinkovic wrote: Hi, Reviewed and tested the patch. Ack from me with minor comment.

Re: [devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-10 Thread Zoran Milinkovic
Hi, Reviewed and tested the patch. Ack from me with minor comment. When OpenSAF is started the second time, it exits with "*". It would be good to write some text why OpenSAF didn't succeed to start, as it was a case with Hans's patch earlier. Thanks, Zoran -Original Message- From:

[devel] [PATCH 1/1] base: double start failed [#2622]

2017-10-10 Thread Rafael Odzakow
Previously named function "check_env" overwrites pid file. Move it to after running pidofproc for amfnd pid. --- src/nid/opensafd.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in index effe87d..d7035f5 100644 ---