Hi Anders,
as discussed in ticket #2094 where it is suggested to:
"document that admin needs to perform clm admin lock of standby
controller before repairing"
this could be complemented with:
"document that admin needs to perform clm admin lock of standby
controller before repairing or execut
Hi Praveen
I think it’s unlikely there is a set_leds in the queue. That would have been
sent from the ‘old’ amfd, before the ‘new’ amfd sends node_up. So the set_leds
would likely have been processed first.
The patch is just making the behaviour the same as receiving NCSMDS_UP.
Thanks
Gary
>
If we are going to require a CLM node lock before stopping OpenSAF (as
per my original proposal in the ticket), then maybe this patch should
look at the node admin state rather than the membership status? This
would remove the race between CLM and FM.
regards,
Anders Widell
On 11/14/2016 09:
But still when AMFND will send the sync information to AMFD with this patch?
Those are generally the first messages and they are still in that if
block. Am I missing something?
Thanks,
Praveen
On 14-Nov-16 2:26 PM, Gary Lee wrote:
> Hi Praveen
>
> I think it’s unlikely there is a set_leds in the
Hi Praveen,
I have tested with the patch for #2112. With the patch for #2112, I am
not able to reproduce the problem anymore.
I think we can ignore this ticket.
Thanks so much,
Long Nguyen.
On 11/10/2016 11:23 AM, Long Nguyen wrote:
> Hi Praveen,
>
> Thanks for your information. I will recheck
I just moved avnd_send_node_up_msg() outside the if block. The
compsci and susi messages are sent in the same conditions as before?
Quoting praveen malviya :
> But still when AMFND will send the sync information to AMFD with this patch?
> Those are generally the first messages and they are sti
Summary: log: implement SaLogFilterSetCallbackT [#2146]
Review request for Trac Ticket(s): #2146
Peer Reviewer(s): Vu, Lennart, Mahesh, Anders
Pull request to: Vu
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
--
osaf/libs/agents/saf/lga/lga.h|7 +-
osaf/libs/agents/saf/lga/lga_api.c|4 +-
osaf/libs/agents/saf/lga/lga_mds.c| 72 +-
osaf/libs/agents/saf/lga/lga_util.c | 58 -
osaf/libs/common/logsv/include/lgsv_msg.h |8 +
osaf/libs/saf/include/saLog
On 14-Nov-16 4:00 PM, Gary Lee wrote:
> I just moved avnd_send_node_up_msg() outside the if block. The compsci
> and susi messages are sent in the same conditions as before?
But when that if condition will hit. After headless state when first
controller comes up within MDS timer limit we Will g
In that case please mark the ticket invalid with milestone "never".
Thanks
Praveen
On 14-Nov-16 3:59 PM, Long Nguyen wrote:
> Hi Praveen,
>
> I have tested with the patch for #2112. With the patch for #2112, I am
> not able to reproduce the problem anymore.
> I think we can ignore this ticket.
>
Hi Alex
Ack with comment
See my comments/questions inline [Lennart]
Thanks
Lennart
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: den 11 november 2016 20:50
> To: reddy.neelaka...@oracle.com; Lennart Lund
> ; Rafael Odzakow
>
> Cc: opensaf-devel@lists.source
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 4 november 2016 05:42
To: Zoran Milinkovic ;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm: Fix
Hi Lennart,
Yes, ntfFinalize does uninstall any subscriptions. I'm just being
explicit here, by putting it in the destructor.
Do you want me to remove it before pushing?
Alex
On 11/14/2016 07:55 AM, Lennart Lund wrote:
> --
Hi Alex
I think that calling ntfFinalize() is enough. If you want to add a comment
about that all subscriptions are unistalled it's ok.
I hope you saw my mail about a possible NBC
Thanks
Lennart
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: den 14 november
Hi Alex
After I posted this ack I and Rafael found a possible Non backwards
compatibility (NBC) problem. If so this must be solved before pushing.
I believe this change introduce a new behavior when campaigns are executed if a
component is failing. If I am right this could be solved by introduc
Hi Lennart,
I'm not sure I understand this. Can you explain why you think this is
not backwards compatible?
This new functionality will put the campaign into "suspended by error
detected" if any new/upgraded SU (or component in the SU) fails during
the campaign (after it has been upgraded).
Hi Alex
Your code adds a not previously implemented behavior correctly according to the
AIS. The problem is that I think this new correct behavior differs from the
'legacy' behavior. So even if the new behavior is correct and the old is not it
is still NBC since some existing system using SMF m
Hi Lennart,
The only way this new code would be different from the legacy behavior
is if there is a bug in the newly updated software. If the software that
was just updated goes into AMF DISABLED operational state while the
campaign is still running, the campaign would then go into
"suspended-by
Hi Praveen
If an amfd is available before MDS timer expires, we get NCSMDS_NEW_ACTIVE.
That is the part I am changing.
The current code is:
if (evt->info.mds.i_change == NCSMDS_NEW_ACTIVE &&
cb->is_avd_down) {
if (cb->led_state == AVND_LED_STATE_GREEN) {
Hi Anders Widel,
Sorry I was on vacation last week , will get back to soon.
-AVM
On 11/9/2016 8:50 PM, Anders Widell wrote:
> When looking more closely at this patch I notice that there is a risk
> for starvation here. We ought to have a message counter and break out
> of the receive loop aft
Hi,
Sorry I was on vacation last week , will get back to soon.
-AVM
On 11/10/2016 4:58 PM, Anders Widell wrote:
> Summary: mds: Use the SOCK_CLOEXEC flag when creating sockets [#2181]
> Review request for Trac Ticket(s): 2181
> Peer Reviewer(s): Mahesh
> Pull request to:
> Affected branch(es):
Hi Canh Van Truong,
Sorry I was on vacation last week , will get back to soon.
-AVM
On 11/14/2016 4:12 PM, Canh Van Truong wrote:
> osaf/libs/agents/saf/lga/lga.h|7 +-
> osaf/libs/agents/saf/lga/lga_api.c|4 +-
> osaf/libs/agents/saf/lga/lga_mds.c| 72
Hi Gary,
Ack from me.
I was highlighting a scenario based on the commit log and ticket
description when AMFND has not marked the led state Green because it did
not receive the message. In that case that "if block" will not be
executed in NEW_ACTIVE event. But I think this is possible only when
Summary: cpd check null pointer before use [#2187]
Review request for Trac Ticket(s): #2187
Peer Reviewer(s): mahesh.va...@oracle.com; anders.wid...@ericsson.com
Pull request to: mahesh.va...@oracle.com
Affected branch(es): default
Development branch: default
Impac
osaf/services/saf/cpsv/cpd/cpd_red.c | 5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/cpsv/cpd/cpd_red.c
b/osaf/services/saf/cpsv/cpd/cpd_red.c
--- a/osaf/services/saf/cpsv/cpd/cpd_red.c
+++ b/osaf/services/saf/cpsv/cpd/cpd_red.c
@@ -322,6 +322,11 @@ v
Hi Alex,
I am waiting #2144 to be pushed(fixed) before this. Testing the #2145
requires #2144 to be fixed.
The patch may not be backward compatible.
while upgrading from 5.1 to 5.2, consider the campaign having
applications along with middle-ware components.
There may be a chance that the (appl
Ack, code review only/Thanks HansN
-Original Message-
From: Gary Lee
Sent: den 11 november 2016 06:47
To: Gary Lee ; praveen.malv...@oracle.com; Minh Hon
Chau ; Hans Nordebäck ;
nagendr...@oracle.com; Long Hong Buu Nguyen
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1]
27 matches
Mail list logo
