[devel] [PATCH 1/5] osaf: add consensus API [#64]

--- src/osaf/consensus/Makefile | 18 +++ src/osaf/consensus/keyvalue.cc | 221 ++ src/osaf/consensus/keyvalue.h| 66 src/osaf/consensus/plugins/etcd.plugin | 253 ++ src/osaf/consensus/plugins/samp

[devel] [PATCH 2/5] rded: add split brain prevention support [#64]

* consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disabled) --- src/rde/Makefile.am | 3 ++- src/rde/rded/osaf-rded.in | 4 src/rde/rded/rde_cb.h | 4 +++- sr

[devel] [PATCH 0/5] Review Request for Add support for split brain prevention V3 [#64]

Summary: Add support for split brain prevention V3 [#64] Review request for Ticket(s): 64 Peer Reviewer(s): Anders, Hans Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-64 Base revision: c5db5d0352af060cb94028b3b9b95e54d87cffb

[devel] [PATCH 3/5] amfd: update consensus service when performing SI swap [#64]

When a node goes down and split-brain prevention is enabled, check that we still have write access to the consensus service. If not and fencing is disabled, reboot the node to prevent split brain. --- src/amf/amfd/ndproc.cc| 12 +++- src/amf/amfd/osaf-amfd.in | 4 src/amf/amfd/ro

[devel] [PATCH 4/5] fmd: update consensus service during controller failover [#64]

--- src/fm/Makefile.am| 1 + src/fm/fmd/fm_main.cc | 37 +++-- src/fm/fmd/fm_rda.cc | 13 + src/fm/fmd/fmd.conf | 6 ++ 4 files changed, 51 insertions(+), 6 deletions(-) diff --git a/src/fm/Makefile.am b/src/fm/Makefile.am index d48a9146c..

[devel] [PATCH 5/5] doc: update README and makefiles [#64]

--- 00-README.conf | 56 Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files changed, 65 insertions(+), 3 deletions(-) diff --git a/00-README.conf b/00-README.conf index a8848e632..6c3cff1dd 100644 --- a/00-README.

Re: [devel] [PATCH 5/5] doc: update README and makefiles [#64]

Hi One comment from Quyen about the readme. Revised paragraph below, please see [Gary]. On 23/01/18 19:06, Gary Lee wrote: --- 00-README.conf | 56 Makefile.am | 4 +++- src/osaf/Makefile.am | 8 ++-- 3 files chang

Re: [devel] [PATCH 1/5] osaf: add consensus API [#64]

Ack for this patch with comments below, marked AndersW>. An additional comment is that Makefiles should be updated in the same patch that adds the new files, e.g. under osaf/consensus. Currently, the files are added in this patch but Makefile.am is updated in patch number 5, so the Makefile.am

Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

Ack for this patch with comments, marked AndersW> regards, Anders Widell On 01/23/2018 09:06 AM, Gary Lee wrote: * consult with consensus service before promoting node to active * add watch thread and self-fence if it detects active controller has been changed (if remote fencing is disable

Re: [devel] [PATCH 0/3] Review Request for ntf: Checkpoint and cold sync reader information [#2757]

Hi Lennart, I tested the APIs between versions with/without the changes. I will send out for review the README and PR change after the code review is done. One limitation is that both active and standby require the patches to work. Thanks, Minh > Hi Minh > > Ack. I have not tested much > > Have

Re: [devel] [PATCH 1/5] osaf: add consensus API [#64]

Hi Anders Thanks for the feedback. Will change before pushing. Gary On 24/01/18 01:22, Anders Widell wrote: Ack for this patch with comments below, marked AndersW>. An additional comment is that Makefiles should be updated in the same patch that adds the new files, e.g. under osaf/consensus.

Re: [devel] [PATCH 2/5] rded: add split brain prevention support [#64]

Hi Anders Will change according to your comments, one comment below: On 24/01/18 01:53, Anders Widell wrote: Ack for this patch with comments, marked AndersW> regards, Anders Widell +   case RDE_MSG_NEW_ACTIVE_CALLBACK: +  { +    const std::string my_node = base::Conf::NodeName();