Summary: amfd: set node failover state correctly on standby [#2963]
Review request for Ticket(s): 2963
Peer Reviewer(s): Hans, Minh, Nagu
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2963
Base revision:
---
src/amf/amfd/node_state_machine.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amf/amfd/node_state_machine.cc
b/src/amf/amfd/node_state_machine.cc
index 478ad2a48..c5d86d33c 100644
--- a/src/amf/amfd/node_state_machine.cc
+++ b/src/amf/amfd/node_state_machine.cc
Hi, Ack (code review). Thanks/Minh
> ---
> src/amf/amfd/node_state_machine.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amf/amfd/node_state_machine.cc
> b/src/amf/amfd/node_state_machine.cc
> index 478ad2a48..c5d86d33c 100644
> ---
Hi Minh
Please ignore. I will send another patch.
On 16/11/18 4:16 pm, Gary Lee wrote:
On the standby, receiving events in 'End' state is not entirely unexpected,
depending
on when the checkpoint arrives from the active. We should just log a message
instead
of asserting.
2018-11-16
Summary: amfd: do not assert when events are received in End state [#2963]
Review request for Ticket(s): 2963
Peer Reviewer(s): Minh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2963
Base revision:
On the standby, receiving events in 'End' state is not entirely unexpected,
depending
on when the checkpoint arrives from the active. We should just log a message
instead
of asserting.
2018-11-16 00:49:22.096 SC-2 osafamfd[252]: NO Node 'PL-3' not found in
failover_list. Create new entry
Hi Gary,
Ack.
Thanks
-Nagendra
High Availability Solutions
www.hasolutions.in
cont...@hasolutions.in
Hyderabad, India: +91-9866424860 | Delaware, USA: +1 508-422-7725
-Original Message-
From: Gary Lee [mailto:gary@dektech.com.au]
Sent: 16 November 2018 05:08
To:
Summary: amfd: add node to failover_list before calling SetState [#2963]
Review request for Ticket(s): 2963
Peer Reviewer(s): Minh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development branch: ticket-2963
Base revision:
node must be added to failover_list before SetState() is called.
If the state is 'end', then it will be deleted by SetState().
Otherwise, we will leave a node in 'End' state mistakenly in
failover_list.
---
src/amf/amfd/ckpt_dec.cc | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff
Hi Vu
Ack, with minor comments below. See [Lennart]
I have not tested and I have not analyzed the delay mechanism to see if the
logic is correct.
In general functionality in the code is too distributed/spread out (things that
is part of the same logic function e.g. handling this delay is
Hi Minh
Ack (review)
> On 14 Nov 2018, at 3:37 pm, Minh Chau wrote:
>
> If the SU is unlock-in/unlock before the node joins cluster, the SU is
> instantiated
> and in unlocked state. However, when the node completes joining the cluster,
> amfd
> assumes all applications' SU uninstantiated
Hi Mohan,
I have pushed the patches.
Thanks
Minh
On 14/11/18 6:19 pm, mo...@hasolutions.in wrote:
Hi minh,
I republished those patches.
please check it and push into the community.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message
Hi Lennart , Vu,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/7] Review Request for
log: add new test cases in log apitest [#2915]
From: "Mohan Kanakam"
Date: 11/9/18 12:27 pm
Hi Hans/Vu/Gary/Alex,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/7] Review Request for
ckpt: add new test cases in apitest [#2939]
From: "Mohan Kanakam"
Date: 10/13/18 4:31 pm
Hi Hans/Vu/Gary/Alex,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/3] Review Request for
ckpt: add new test cases in apitest [#2939]
From: "Mohan Kanakam"
Date: 10/12/18 7:00
Hi Hans/Vu/Gary/Alex,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: RE: [PATCH 0/3] Review Request
for ckpt: add new test cases in apitest [#2939]
From: mo...@hasolutions.in
Date:
Hi Hans/Vu/Gary/Alex,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/1] Review Request for
ckpt: add new test case of API saCkptInitialize() of apitest v2 [#2913]
From: "Mohan
Hi Hans,
polite reminder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/5] Review Request for
clm: add new test cases in clm apitest [#2914]
From: "Mohan Kanakam"
Date: 11/6/18 1:23 pm
To:
Hi Hans, Vu,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/3] Review Request for
imm: add new test cases of apitest [#2951]
From: "Mohan Kanakam"
Date: 11/1/18 1:57 pm
To:
Hi Hans/Vu/Gary/Alex,
Polite remainder for review.
Thanks
Mohan
High Availability Solutions Pvt. Ltd.
www.hasolutions.in
- Original Message - Subject: [PATCH 0/4] Review Request for
ckpt: add new test cases in apitest [#2939]
From: "Mohan Kanakam"
Date: 10/12/18 3:28
Hi Mohan,
Note, this is not a complete review but I have taken a quick look at the code
below.
Often when creating functions it may be enough to use a descriptive name to
document what the function do. However for test cases (function that implements
the actual test) there should always be a
21 matches
Mail list logo
