Ack with comment: The commit message should say what the patch does, so
you should rephrase it to something like "osaf: Add two missing model
files to the spec file [#1711]"
regards,
Anders Widell
On 03/28/2016 11:44 AM, Vu Minh Nguyen wrote:
> opensaf.spec.in | 2 ++
> 1
Hi!
See my replies below.
regards,
Anders Widell
On 03/29/2016 02:55 PM, ramesh betham wrote:
> My initial comments..
>
> 1. Can avoid peer discovery waiting state to certain fixed period
> by defining the spare-count in xml. What do you say..
>
I am not sure what yo
ranslate slot_id 0x1 to node_id 0x1. To make things worse, there are
some places in OpenSAF that have been hard-coded to expect the two
system controllers to have node_id 0x2010f and 0x2020f, respectively.
Maybe we can make it work somehow, but I anticipate there could be
problems during an upgrade.
re
unfortunately is very
much involved in upgrades. But the good thing is that thanks to ticket
[#79], SMF will automatically discover the node_id of system controllers
in OpenSAF 5.0. Thus, only pre-5.0 versions of SMF are problematic. It
/might/ work, so let's try it!
regards,
Anders Widell
On 03/29/2016
Here is a patch that addresses the review comments from Hans and
Praveen. It should be applied on top of the AMF patch that was sent out
for review.
thanks,
Anders Widell
On 03/30/2016 04:35 PM, Anders Widell wrote:
Hi!
See my replies inline, marked [AndersW].
regards,
Anders Widell
On 03
n
Comments (indicate scope for each "y" above):
-
changeset 4ce61bd73140d355a173cd26997dd7ce8d463918
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 08 Apr 2016 17:51:58 +0200
immtools: Correct
tests/immsv/management/test_saImmOmCcbObjectCreate_2.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Remove dead code to fix the following compilation error discovered when using
GCC 6:
test_saImmOmCcbObjectCreate_2.c:20:30: error: 'nonExistingClassName' defined
but not used
osaf/tools/safimm/immdump/imm_dumper.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Correct code indentation to fix the following compilation error discovered when
using GCC 6:
imm_dumper.cc: In function 'int main(int, char**)':
imm_dumper.cc:149:5: error: this 'if' clause does
osaf/services/saf/logsv/lgs/lgs_stream.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Initialize the errno_save output parameters in all code paths in the function
fileclose_h(), to fix the following compilation error discovered when using GCC
6:
In file included from
We don't actually have any global configuration file; nid.conf is only
common for the NID started services. I think we can wait until OpenSAF
5.1 and maybe introduce a global configuration file in that release.
regards,
Anders Widell
On 04/07/2016 06:15 PM, Mathivanan Naickan Palanivelu wrote
must be configurable and off by default, so that we don't
risk breaking compatibility.
regards,
Anders Widell
On 04/04/2016 03:02 PM, Anders Widell wrote:
> See comments marked [AndersW].
>
> regards,
> Anders Widell
>
> On 04/04/2016 01:51 PM, praveen malviya wrote:
>>
Hi!
Have you had time to look at this yet?
regards,
Anders Widell
On 03/18/2016 05:14 PM, Anders Widell wrote:
> 00-README.conf | 14 ++
> README | 17 +
> 2 files changed, 19 insertions(+), 12 deletions(-)
>
>
> diff --git a/0
00-README.conf | 32
README | 22 --
2 files changed, 44 insertions(+), 10 deletions(-)
Update the README files to reflect the fact that the number of system controller
nodes in the cluster is no longer limited to two. Also mention
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 122360a4ca9fdb19576861a6a698b8ad11c8a091
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 12 Apr 2016 17:38:56 +0200
osaf/services/infrastructure/nid/config/nodeinit.conf.controller | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Since standby and spare system controllers will hang in clmna until the active
CLM server accepts them into the cluster, the default clmna time-out has to be
set high
osaf/services/saf/amf/amfd/role.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
AMFD now orders a reboot of the standby SC in all cases when a failover STANDBY
-> ACTIVE fails. Previously, the case when the failover failed because the
standby AMFD was not in sync was handled
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 3feb042e5bcc1e07fd7baef42c10321cb2223175
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 07 Apr 2016 12:41:30 +0200
clm: Decr
osaf/services/saf/clmsv/config/clmna.conf| 5 +++--
osaf/services/saf/clmsv/nodeagent/election_starter.h | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
For backwards compatibility reasons, decrease the default election delay time to
200 ms. Previously, the default
See comments below.
thanks,
Anders Widell
On 03/17/2016 12:32 PM, Neelakanta Reddy wrote:
> Hi Anders,
>
> Comments inline.
>
> On Wednesday 16 March 2016 05:22 PM, Anders Widell wrote:
>> Ack with two comments:
>>
>> 1) I think we should use nanosecond
n
Comments (indicate scope for each "y" above):
-
changeset caa76ee1a58ad96ad1e8a4f37279ef118f69eab6
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 18 Mar 2016 16:52:44 +0100
osaf: Update readme f
n
Comments (indicate scope for each "y" above):
-
changeset 7226c686f89c4cca5b4c238af753fe410b1619c7
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 18 Mar 2016 16:54:12 +0100
base: Remove old macros and
osaf/libs/common/mqsv/include/mqa_db.h | 4 +++-
osaf/libs/common/mqsv/include/mqsv_common.h | 2 +-
osaf/libs/common/mqsv/mqsv_common.c | 9 ++---
osaf/services/saf/mqsv/mqd/mqd_mds.c| 3 ++-
4 files changed, 8 insertions(+), 10 deletions(-)
Use the new support
osaf/services/saf/plmsv/plms/plms_mds.c | 6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
Use the new support function GetSlotSubslotIdFromNodeId() to extract a 32-bit
integer containing the slot ID and subslot ID from a Node ID.
diff --git a/osaf/services/saf/plmsv/plms/plms_mds.c
(indicate scope for each "y" above):
-
changeset 625f4c12ce04cb7a0d36439fc5a47967c1a0dcf7
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 18 Mar 2016 16:49:28 +0100
ckpt: Support up to 4095 nodes [#1613]
osaf/libs/core/mds/include/mds_dt.h | 26 +-
osaf/libs/core/mds/mds_c_db.c | 26 --
2 files changed, 29 insertions(+), 23 deletions(-)
Support up to 4095 nodes in the flat addressing scheme for TIPC, by encoding the
slot ID in the lower
osaf/libs/common/cpsv/include/cpd_cb.h | 1 -
osaf/services/saf/cpsv/cpd/cpd_db.c| 15 ++-
osaf/services/saf/cpsv/cpnd/cpnd_db.c | 15 ++-
3 files changed, 4 insertions(+), 27 deletions(-)
Use the new support function GetSlotSubslotIdFromNodeId() to extract a
(indicate scope for each "y" above):
-
changeset a76b8ccba5ef05273b7f05a3d8d8472694b9c44b
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 18 Mar 2016 16:51:56 +0100
nid: Support up to 4095 nodes [#1613]
Su
osaf/services/saf/immsv/immd/immd_db.c | 13 ++---
1 files changed, 2 insertions(+), 11 deletions(-)
Use the new support function GetSlotSubslotIdFromNodeId() to extract a 32-bit
integer containing the slot ID and subslot ID from a Node ID.
diff --git
osaf/services/saf/smfsv/smfd/smfd_cb.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/smfsv/smfd/smfd_cb.h
b/osaf/services/saf/smfsv/smfd/smfd_cb.h
--- a/osaf/services/saf/smfsv/smfd/smfd_cb.h
+++ b/osaf/services/saf/smfsv/smfd/smfd_cb.h
@@ -43,7 +43,6
00-README.conf | 14 ++
README | 17 +
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/00-README.conf b/00-README.conf
--- a/00-README.conf
+++ b/00-README.conf
@@ -112,7 +112,9 @@ Notes:
In the case of 'make install', do the steps
Do you think this could be caused by a change you have made, or is it a
completely separate bug?
Another question: is this solution in-service upgradeable?
regards,
Anders Widell
On 12/01/2015 05:10 PM, Alex Jones wrote:
> osaf/libs/common/glsv/glsv_edu.c | 3 +
> osaf/libs/common/glsv/inclu
Isolation should happen immediately, but it is the recovery and repair
actions that can sometimes be postponed until the system controllers are
back.
regards,
Anders Widell
On 03/02/2016 12:18 PM, Mathivanan Naickan Palanivelu wrote:
> Thanks for the explanation. My query was independ
osaf/services/infrastructure/fm/config/fmd.conf | 2 +-
osaf/services/infrastructure/fm/fms/fm_main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
The default activation supervision time-out was set too low, which could cause
it to expire e.g. on systems with a large number of
Other n
Comments (indicate scope for each "y" above):
-
changeset b6dc1b8476f3a52347ca65071b819ef8cb298791
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 02 Mar 2016 14:13:41 +0100
fm: Incr
could
be that the patches have been corrupted by the mail system. In such a
case I could send them in e.g. a ZIP file.
regards,
Anders Widell
On 03/08/2016 11:17 AM, Neelakanta Reddy wrote:
> Hi Anders,
>
> While applying rde patch the following errors are observed:
>
> patching
I just realized that the symptoms you see could be caused by using a too
old "patch" tool. Please try either with a newer version of the "patch"
command, or by using Mercurial for applying the patches (e.g. "hg
qimport patch_file.diff; hg qpush").
regards,
Anders
size you can scale down to. It doesn't necessarily have
to be two; maybe someone wishes to disallow any configuration with less
than five nodes.
regards,
Anders Widell
On 04/01/2016 03:05 PM, Mathivanan Naickan Palanivelu wrote:
> We could tie the symmetry to the 'deploy-standlone' opt
Hi!
See my comments inline, marked [AndersW].
regards,
Anders Widell
On 04/04/2016 12:50 PM, A V Mahesh wrote:
> Hi Anders Widell ,
>
> *Thank for the review , please find my responses .*
>
> On 4/4/2016 3:51 PM, Anders Widell wrote:
>> Hi!
>>
>> Here are my co
See my comments inline, marked [AndersW].
regards,
Anders Widell
On 04/04/2016 02:11 PM, praveen malviya wrote:
>
>
> On 02-Apr-16 4:51 PM, Anders Widell wrote:
>> Hi!
>>
>> This change makes NTF depend on CLM. CLM already depends on NTF, so it
>> means
a look before I push?
thanks,
Anders Widell
On 03/31/2016 07:28 AM, A V Mahesh wrote:
ACK tested
-AVM
On 3/18/2016 9:32 PM, Anders Widell wrote:
osaf/libs/common/cpsv/include/cpd_cb.h | 1 -
osaf/services/saf/cpsv/cpd/cpd_db.c| 15 ++-
osaf/services/saf/cpsv/cpnd/cpnd_db.c
addresses from the full range of 4095 possible
values. It could be that you have something similar to a DHCP server
that dynamically assigns each node an address. It could be that you
don't want to re-cycle old addresses too quickly when nodes come and go.
regards,
Anders Widell
On 03/30/2016 01
with two controllers and two payloads. Then rename
PL-3 to PL-998 and PL-4 to PL-999 in the generated imm.xml file.
regards,
Anders Widell
On 03/30/2016 11:20 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
> Please find my comments
>
> On 3/29/2016 2:49 PM, Anders Widell wrote:
Hi!
I have implemented the completely flat addressing in the attached patch,
but haven't tested if it causes any problems during an upgrade. It
should be applied on top of the patches for ticket [#1613]. Please feel
free to try it out!
/ Anders Widell
On 03/29/2016 06:09 PM, Anders Widell
Hi!
See my replies inline, marked [AndersW].
regards,
Anders Widell
On 03/17/2016 11:32 AM, praveen malviya wrote:
> Hi Anders,
>
> Please find some comments and queries inline with [Praveen]
>
> Thanks,
> Praveen
>
>
> On 29-Feb-16 8:44 PM, Anders Widell wrote:
&g
ould
mean that AMF will reject removal of any of the last two system
controller nodes - IF the cluster has payload nodes. What do you think
about this approach? I am not sure how easy this would be to implement,
but I can give it a try.
regards,
Anders Widell
On 03/31/2016 03:05 PM, praveen mal
> Cheers,
> Mathi.
>
>
>> -Original Message-
>> From: Anders Widell [mailto:anders.wid...@ericsson.com]
>> Sent: Monday, February 29, 2016 8:39 PM
>> To: Mathivanan Naickan Palanivelu
>> Cc: opensaf-devel@lists.sourceforge.net
>> Subject: [PATCH 2 of
pointers back and forth
between void* and whatever data type you use. It is both ugly and error
prone.
regards,
Anders Widell
On 03/31/2016 08:26 PM, Mathivanan Naickan Palanivelu wrote:
> Hi Anders,
>
> Thanks. But I don't intend to use this patch yet. The reasons being I have
>
from makes little sense to me. Suppose that the second
node has been physically removed, so that you really have only one
single node. What harm would it do to update the OpenSAF configuration
to reflect this fact of reality?
regards,
Anders Widell
On 04/01/2016 12:54 PM, Mathivanan Naickan
s to scale better than TCP.
This patch is only addressing the limit for the address space, which was
previously eight bits and thus limited to at most 255 nodes. The
scalability issues is a separate problem.
regards,
Anders Widell
On 03/29/2016 10:21 AM, A V Mahesh wrote:
> Hi,
>
>
when you get it from saClmDispatch(), and re-initialize the CLM handle
if you get this error code.
regards,
Anders Widell
On 03/29/2016 11:02 AM, praveen.malv...@oracle.com wrote:
> Summary: ntf: Integrate NTF service with CLM {#1639] V2
> Review request for Trac Ticket(s): #1639
> Peer
No, I haven't pushed it yet. It required re-basing and I sent out the
rebased version.
regards,
Anders Widell
On 04/04/2016 05:23 PM, A V Mahesh wrote:
> Have you pushed cpsv ?
> If yes ,how this patch is still getting applied on today's staging ?
>
> -AVM
>
> On 4/4/2016 8:25
Yes, I agree let's push it. I have also tested running with old and new
versions of the LCK service in the same cluster, and didn't encounter
any visible problems (though I suspect this is due to pure luck. :-)).
regards,
Anders Widell
On 03/31/2016 02:33 PM, Alex Jones wrote:
> Hi And
n
Other y
Comments (indicate scope for each "y" above):
-
changeset 718eafbec9d88ee9765440f75a780bb6c6c0812b
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 31 Mar 2016 13:05:48 +0200
I agree with Gary that the full solution (outlined in tickets [#1607]
and [#1609]) is too big to introduce in a maintenance release (OpenSAF
5.0.1). It will have to wait until the next major release.
regards,
Anders Widell
On 05/19/2016 12:08 PM, Gary Lee wrote:
>
> That is why I
Makefile.common | 12
1 files changed, 12 insertions(+), 0 deletions(-)
Add a "shellcheck" build target that can be used in any subdirectory in the
OpenSAF source tree. Use the following command to run it:
make shellcheck
diff --git a/Makefile.common b/Makefile.common
---
n
Comments (indicate scope for each "y" above):
-
changeset 8b13d7a766e9c427fd92bff3d7d9bb8a5491100c
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Mon, 16 May 2016 16:20:14 +0200
fm: Start activa
osaf/services/infrastructure/fm/fms/fm_main.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
Two bugs have been fixed related to starting the activation supervision timer:
1) There was a cut-and-paste bug where the conditions are checking the status of
the promote
Other n
Comments (indicate scope for each "y" above):
-
changeset 3fbfc9ad1f06df92ed6a4a079c57e4a284176972
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Thu, 21 Apr 2016 10:13:17 +0200
cl
osaf/services/saf/clmsv/nodeagent/election_starter.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
The empty() method should be used to check if a set is empty, instead of
comparing the result of the size() method with zero. Depending on the STL
implementation, the
Other n
Comments (indicate scope for each "y" above):
-
changeset a706f9a889420a0c8e21990175c6065ae9d63f24
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 25 May 2016 14:47:31 +0200
build: A
Makefile.common | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
Add a "cpplint" build target that can be used in any subdirectory in the
OpenSAF source tree. Use the following command to run it:
make cpplint
diff --git a/Makefile.common b/Makefile.common
---
be adapted to the extended SaNameT
type in the same way as ordinary applications as described in
OpenSAF_Extensions_PR.odt.
/ Anders Widell
On 07/11/2016 07:17 AM, Vu Minh Nguyen wrote:
> Hi Mahesh,
>
> I would like to add Anders in for his comment.
>
> Your below concern be
om inside the
initialize_for_assignment() function)? Could you try it? :-)
8) In C++, please use nullptr instead of NULL and 0 (when the type is
supposed to be a pointer). So e.g. clm_callbacks should have have
nullptr instead if 0 in its first position, and lgs_clm_init_thread
ought to return n
se
spaces [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:140: Tab found; better to use
spaces [whitespace/tab] [1]
./osaf/services/saf/logsv/lgs/lgs_clm.cc:141: Tab found; better to use
spaces [whitespace/tab] [1]
regards,
Anders Widell
On 08/02/2016 10:17 AM, mahesh.va...@oracle
I will push this tomorrow if there are no comments.
regards,
Anders Widell
On 08/02/2016 09:57 AM, Anders Widell wrote:
> Hi Ramesh!
>
> Have you had a chance to look at this patch yet?
>
> regards,
>
> Anders Widell
>
> On 07/08/2016 02:39 PM, Anders Widell wro
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 225af50325cddf52d2a51a6ea1ece1035c9ca2f0
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Wed, 03 Aug 2016 16:56:39 +0200
osaf/services/infrastructure/dtms/dtm/dtm_read_config.c | 36 +++-
1 files changed, 32 insertions(+), 4 deletions(-)
The IPv4 broadcast address is sometimes not configured when running in some
container environments (e.g. docker). In these cases, derive the broadcast
address from
whitespace at the end of the lines. Hint: You can do this by
marking all the text and then typing M-x delete-trailing-whitespace
thanks,
Anders Widell
On 08/03/2016 12:28 PM, Vu Minh Nguyen wrote:
> Hi Lennart,
>
> Please see my responses in line, started with [Vu].
> I will create a new
One comment: in the prototype patch the feature was on by default, but
it ought to be off by default when we introduce this feature officially.
/ Anders Widell
On 06/30/2016 10:32 AM, Anders Widell wrote:
> Hi!
>
> This patch is actually identical to the prototype code tha
osaf/services/infrastructure/dtms/scripts/osaf-dtm.in | 28
+++---
osaf/services/infrastructure/dtms/scripts/osaf-transport-monitor.in | 10 +-
osaf/services/infrastructure/dtms/scripts/osaf-transport.in | 4 +-
osaf/services/infrastructure/fm/fms/scripts/osaf-fmd.in
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 8542d91153376d37a41ad862045b59ddeb5d8e02
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 19 Jul 201
Ack with minor comments:
1) In the short line commit message: change "libs/core:" to "base:"
2) The scope of the variable "int i" in osaf_encode_sanamet() can be
reduced (i.e. move it into the two for-loops: for (int i = ...).
thanks,
Anders Widell
On 07/19
osaf/libs/core/leap/os_defs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Use INFO level syslog priority when we are unable to set real-time scheduling
priority. Otherwise syslog can be filled up with warning messages e.g. if an
opensaf command-line tool is used many times.
diff
on a locked node! It must differentiate between
middleware- and non-middleware clients.
By the way, saClmInitialize_4() and saClmSelectionObjectGet() should not
return ERR_UNAVAILABLE on configured non-member nodes - they shall only
return ERR_UNAVAILABLE on unconfigured nodes.
regards,
Anders
an ACTIVE or STANDBY assignment from RDE or AMF. Once it receives such
an assignment, it will perform the rest of the initialization.
regards,
Anders Widell
On 07/05/2016 04:00 PM, Zoran Milinkovic wrote:
> Hi Hung,
>
> All that is correct for called register function once.
> My poi
n
Other n
Comments (indicate scope for each "y" above):
-
changeset d6a6b95b4b5d707a66fb3ddf3549ed1833dd56fe
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Fri, 08 Jul 2016 10:17:27 +0200
rd
osaf/services/infrastructure/rde/rde_mds.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
RDE may fail to send MDS messages to its peer, e.g. when the peer node is down.
This should not be considered an error and therefore the syslog messages should
not have ER priority. The
Hi Ramesh!
Have you had a chance to look at this patch yet?
regards,
Anders Widell
On 07/08/2016 02:39 PM, Anders Widell wrote:
> Summary: rde: Change syslog priority from ER to WA when MDS send fails [#1907]
> Review request for Trac Ticket(s): 1907
> Peer Reviewer(s): Ramesh
>
Hi Mahesh!
The files lgs_clm.cc and lgs_clm.h seem to be missing in these patches.
Could you please resend?
thanks,
Anders Widell
On 08/02/2016 07:18 AM, mahesh.va...@oracle.com wrote:
> Summary:lga: agent Cluster Membership (CLM) integration [#1638] V2
> Review request for Trac Ti
node lock.
regards,
Anders Widell
On 07/22/2016 02:16 PM, praveen malviya wrote:
> Such a configured non-member node will be notified only for node local
> changes in track callback and not cluster wide changes. This is one
> reason clm lock of active controller node is not allow
old handle.
Do you think it would work if you defer creating these background
threads until we get an ACTIVE/STANDBY assignment?
regards,
Anders Widell
On 07/22/2016 12:20 PM, minh chau wrote:
> Hi,
>
> I think Praveen's comment on #1812 was worrying about amfd hanging
> when ini
Interesting!
How do you intend to implement this? Will OpenSAF rely on OpenHPI for
remote fencing also when running inside virtual machines? Does OpenHPI
support that today?
regards,
Anders Widell
On 06/30/2016 04:11 PM, Alex Jones wrote:
> Hi Hans,
>
> For what it
is enabled and FM on the standby fails to fence the
(previous) active, then maybe the standby should not take over as
active? Instead it could re-try until fencing is successful, or maybe
reboot itself?
/ Anders Widell
On 06/23/2016 07:31 AM, Hans Nordeback wrote:
> 00-README.c
Hi!
This patch is actually identical to the prototype code that I wrote and
attached to the ticket, so I am not sure if I am supposed to also review
it... anyways it is ack from from me for the first patch. :-)
regards,
Anders Widell
On 06/23/2016 07:31 AM, Hans Nordeback wrote:
> o
Ok, I see. Will PLM use libvirt for something else than fencing in such
a configuration?
regards,
Anders Widell
On 06/30/2016 05:02 PM, Alex Jones wrote:
> Hi Anders,
>
> I have a basic working implementation which uses libvirt, but it's
> not yet ready to send out for ot
of them, or both at the same time). If you link with
both libraries, would it be possible at run-time to probe the system and
select the correct one to use?
regards,
Anders Widell
On 06/30/2016 05:29 PM, Alex Jones wrote:
> Yes, it uses libvirt for all the EE admin operations perfor
src/nid/opensafd.in | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Skip the check for the tipc-config tool when OPENSAF_MANAGE_TIPC is not set to
"yes" in nid.conf.
diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in
--- a/src/nid/opensafd.in
+++ b/src/nid/opensafd.in
@@ -60,7
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 59f061316a12a69b3cab8e59fc9defab36590e5b
Author: Anders Widell <anders.wid...@ericsson.com>
Date: Tue, 31 Jan 201
Ack.
regards,
Anders Widell
On 02/03/2017 10:54 AM, Hans Nordeback wrote:
> tools/cluster_sim_uml/build_uml | 16 ++--
> 1 files changed, 10 insertions(+), 6 deletions(-)
>
>
> diff --git a/tools/cluster_sim_uml/build_uml b/tools/cluster_sim_uml/build_um
Ack.
regards,
Anders Widell
On 02/02/2017 06:19 AM, Gary Lee wrote:
> src/base/osaf_secutil.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/src/base/osaf_secutil.c b/src/base/osaf_secutil.c
> --- a/src/base/osaf_secutil.c
> +++ b/sr
Ack.
regards,
Anders Widell
On 02/03/2017 10:23 AM, praveen.malv...@oracle.com wrote:
> src/clm/clmd/clms_imm.c | 24 ++--
> src/clm/clmd/clms_mbcsv.c | 23 +++
> src/clm/clmd/clms_mbcsv.h | 1 +
> 3 files changed, 34 inser
Good work! We will re-test with the correction applied.
thanks,
Anders Widell
On 02/03/2017 10:23 AM, praveen.malv...@oracle.com wrote:
> Summary: clmd: checkpoint full node record in CCB modify cbk [#2265]
> Review request for Trac Ticket(s): #2265
> Peer Reviewer(s): Anders Wide
Mercurial. More information about the transition
to GIT will be sent out when we tag OpenSAF 5.2.FC.
regards,
Anders Widell
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot
I have created ticket [#2275] for removing this stuff.
regards,
Anders Widell
On 01/24/2017 10:58 AM, Zoran Milinkovic wrote:
> Hi Anders,
>
> I'll add your comment when I push the patch.
>
> Thanks,
> Zoran
>
> -Original Message-----
> From: Anders Widell
> S
Ok, I will create a new ticket for removing these calls.
Ack from me.
regards,
Anders Widell
On 01/24/2017 10:52 AM, Zoran Milinkovic wrote:
> Hi Anders,
>
> No, we can't.
> If we are going to remove ncslpg_*, then we need another ticket.
>
> Thanks,
> Zoran
>
in the timer implementation and not anywhere else.
regards,
Anders Widell
On 01/25/2017 05:22 AM, ramesh betham wrote:
> Hi Anders,
>
> Quick comments.
>
> The purpose of having ncslpg_<...>() functions in sysf_tmr is to
> make sure to go through gr
estruction of the timer data structures.
regards,
Anders Widell
On 01/25/2017 11:56 AM, ramesh betham wrote:
> Hi Anders,
>
> Across OpenSAF code, ncshm_<...>_hdl() functions are serving the
> similar purpose.
>
> The reason for not noticing inconsistency in handling ncsl
src/base/Makefile.am| 16 +-
src/base/hash.cc| 239
src/base/hash.h | 32 +
src/base/tests/hash_test.cc | 109
4 files changed, 390 insertions(+), 6 deletions(-)
Add a function that
Hi!
See replies marked AndersW>.
regards,
Anders Widell
On 02/21/2017 01:31 PM, Zoran Milinkovic wrote:
> Hi Anders,
>
> I have few comments to the patch
>
> The hash function will not work on big endian systems.
> Do we support only little endian systems or OpenSAF cod
Widell
On 02/20/2017 10:56 AM, A V Mahesh wrote:
> Hi Anders Widell,
>
>
> On 2/20/2017 2:25 PM, Anders Widell wrote:
>> Yes, the HOSTNAME field of the log record should contain the fully
>> qualified domain name (i.e. the host name followed by the domain
>> name).
301 - 400 of 823 matches
Mail list logo
