ttrName.c_str(), objectName.c_str());
err = SA_AIS_ERR_INVALID_PARAM;
break; // out of for switch
}
The same code can be applied for other changes.
BR,
Zoran
-Original Message-
From: Danh Vo [mailto:danh.c...@dektech.com.au]
Sent: den 15 mars 2018 11:54
To:
den 4 april 2018 08:25
To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; Anders Widell
<anders.wid...@ericsson.com>; ravisekhar.ko...@oracle.com; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; Lennart Lund <lennart.l...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.ne
what’s in for loops. I don’t think that because of that rwlock
is needed.
BR,
Zoran
From: Hans Nordebäck
Sent: den 22 mars 2018 14:21
To: Hoa Le <hoa...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; Anders Widell <anders.wid...@ericsson.com>
Hi,
According to the patch (I haven't checked the code), I don't see the reason for
using rwlock. Pthread mutex will even work better than rwlock in the patch.
Reasons for using mutex:
1. Mutex is much faster than rwlock in Linux, around 10 times faster, if I
remember correctly
2. Here, we are
Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 7 mars 2018 08:32
To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [devel] [PATCH 1/1] imm: not al
Hi Vu,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 24 januari 2018 15:47
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh
u]
Sent: den 30 januari 2018 15:24
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au>
Subject: [PATCH 1/1] imm: not allow creating reserved IMM class names [#
gip...@oracle.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] imm: return correct error code when working on more
than 1 objects [#2359]
Hi Srinivas,
I see you added new error code type to the function ` immsv_evt_enc_n
Hi Vu,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 31 januari 2018 12:20
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
<
-Original Message-
From: and...@acm.org [mailto:anders.bjornerst...@telia.com]
Sent: den 26 januari 2018 13:05
To: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi Vu,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 24 januari 2018 15:02
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
ravisekhar.ko...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Vu,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 27 december 2017 11:32
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
<vu.m.ngu...@dekte
Importance log level is changed from error to warning level due to no reaction
from IMMD.
---
src/imm/immd/immd_evt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
index a0d9319..4c1999b 100644
--- a/src/imm/immd/immd_evt.c
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision fc0757f36c0e803840fca62a06b612a82c6d6d9d
Author: Zoran
Hi Nguyen,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Nguyen Luu [mailto:nguyen.tk@dektech.com.au]
Sent: den 14 december 2017 09:24
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sou
/sbin/shutdown is added to /etc/sudoers for the configuration steps in
00-README.conf
---
00-README.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/00-README.conf b/00-README.conf
index 2a7ce96..5de2862 100644
--- a/00-README.conf
+++ b/00-README.conf
@@ -21,7 +21,7 @@
revision e7ff736355ec63b8a1dea8a592d3b61f3571d2a5
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 5 Dec 2017 14:36:53 +0100
osaf: add /sbin/shutdown to sudoers file in 00-README.conf [#2729]
/sbin/shutdown is added to /etc/sudoers for the configuration steps in
Hi Vu,
Ack from me.
Please correct the output in my second comment.
You can correct it when you puch the code.
Thanks,
Zoran
From: Vu Minh Nguyen <vu.m.ngu...@dektech.com.au>
Sent: Tuesday, November 14, 2017 7:16:29 AM
To: Zoran Milinkovic
Cc: opensaf
Hi Vu,
Find my comments inline
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 1 november 2017 12:29
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Vu Minh Nguyen
<vu.m.ngu...@dektech.com.au
Add two sections.
The section that describes the new flag for enabling features in 5.17.11,
and the section that describes the removal of disconnected appliers
Rename IMM schema from OpensafImm_Upgrade_5.17.10.xml to
OpensafImm_Upgrade_5.17.11.xml
---
uot; above):
-
revision b1c4e0f471066da278eedfbe27f585a644fabeb8
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 6 Nov 2017 17:25:22 +0100
imm: update README with IMM changes in OpenSAF 5.17.11 and rename IMM schema
[#2665]
Add two sections.
The section that d
Hi Vu,
That paragraph is talking about implementer names, and it's still valid.
Ticket #2579 is about appliers.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 3 november 2017 11:31
To: Zoran Milinkovic <zoran.milinko...@ericsson.
Add two sections.
The section that describes the new flag for enabling features in 5.17.11,
and the section that describes the removal of disconnected appliers
---
src/imm/README | 66 ++
1 file changed, 66 insertions(+)
diff --git
revision e9e63b8ee8486063421c1063d6155b91fb78307e
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 2 Nov 2017 15:12:38 +0100
imm: update README with IMM changes in OpenSAF 5.17.11 [#2665]
Add two sections.
The section that describes the new flag for enabling fea
IMMND will reduce the number of object deleted messages to PBE with sending
only one message containing the root object name instead of sending one message
for each delete object.
---
src/imm/common/immpbe_dump.cc | 541 ++
src/imm/immnd/ImmModel.cc |
revision ce29d3b5a78f4d250ff39d9fc8b60c53191c35c3
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 1 Nov 2017 15:35:50 +0100
imm: improve the cascade delete [#2667]
IMMND will reduce the number of object deleted messages to PBE with sending
only one message containing the root object name instead of sen
Hi Hans,
Find my comments inline
-Original Message-
From: Hans Nordebäck
Sent: den 27 oktober 2017 15:01
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] clm: add new admin operations [#2649]
Hi Zoran,
ack
Hi Anders,
Find my comments inline.
-Original Message-
From: Anders Widell
Sent: den 27 oktober 2017 13:52
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hans Nordebäck
<hans.nordeb...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PA
Hi,
This solution is not safe and is NBC.
If a new node with earlier release join the cluster, the whole cluster will be
rebooted.
For example, this is dangerous if a node with an older OpenSAF release reboot
during SMF upgrade. Then the whole cluster will be restarted before the
campaign is
Hi,
base/process.h cannot be used in C code.
The patch copies the pattern for execution of all other scripts.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 26 oktober 2017 13:35
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hans Nordebäck
<ha
Due to long execution of immadm in a separated thread and possible timeout in
poll, the executing immadm command for locking, unlocking and shutting down
nodes is replaced with calling IMM admin operation function.
---
src/clm/apitest/clmtest.c | 92
revision 56ee9e7557c84416367e0510c0dc3023f29be9ad
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 25 Oct 2017 17:14:43 +0200
clm: replace immadm command with admin op call in clm test [#2654]
Due to long execution of immadm in a separated thread and possible timeout in
pol
Hi Vu,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 25 oktober 2017 06:20
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hans Nordebäck
<hans.nordeb...@ericsson.com>
Cc: opensaf-devel@lists.sourcef
Hi Vu,
Find my comments inline.
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 24 oktober 2017 10:56
To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourcef
Hi Vu,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 24 oktober 2017 09:58
To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>; A
Hi Vu,
Find my comments inline
-Original Message-
From: Vu Minh Nguyen [mailto:vu.m.ngu...@dektech.com.au]
Sent: den 24 oktober 2017 09:43
To: Hans Nordebäck <hans.nordeb...@ericsson.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.
Add two new admin operations to CLM.
1. Node reboot will use the same openation id as cluster reboot, but the DN
will contain CLM node
Example for rebooting SC2:
immadm -o 4 safNode=SC-2,safCluster=myClmCluster
2. Execute action on remote nodei(s) with operation id 5.
Action is a
revision 139140322c7fb0674763fcc3ab802e9aeb608794
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 23 Oct 2017 16:29:44 +0200
clm: add new admin operations [#2649]
Add two new admin operations to CLM.
1. Node reboot will use the same openation id as cluster reboot, but the DN
will
oktober 2017 12:11
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Vijay Roy <vijay@oracle.com>
Subject: [PATCH 1/1] amf: immxml-configure utility (tool) is failing with UTF-8
encoding [#2632]
The fix is to support UTF-8 unicode validat
Hi Rafael,
Reviewed the patch, but didn't test.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Rafael Odzakow
Sent: den 16 oktober 2017 13:53
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hans Nordebäck
<hans.nordeb...@ericsson.com>
Cc: opensaf-devel@lists.sou
-
From: Rafael Odzakow
Sent: den 10 oktober 2017 14:08
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hans Nordebäck
<hans.nordeb...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Rafael Odzakow
<rafael.odza...@ericsson.com>
Subject: [PATCH 1/1] base: double star
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 2 oktober 2017 08:47
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<hung.d.ngu...@dekte
Hi Hung,
Good catch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 26 september 2017 05:04
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<h
n you push the code.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 14 september 2017 06:42
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<hung.d.ngu...@dektech.co
revision b843838c0f947dedc53410729d4fb9c600501000
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 11 Sep 2017 17:46:23 +0200
imm: remove disconnected appliers [#2579]
When an applier is disconnected, it will be removed from the system after time
period set in minApplierTimeout attribute in IMM obj
When an applier is disconnected, it will be removed from the system after time
period set in minApplierTimeout attribute in IMM object.
If the time is set to 0, it will work as it works today, and it will never be
removed from the system.
The time set in minApplierTimeout attribute guarantees
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 6 september 2017 12:55
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<h
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 6 september 2017 13:42
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<hung.d.ngu...@dekte
Peddavandla
<reddy.neelaka...@oracle.com>; Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] smf: fix to avoid core dump during smf upgrade while
imm sync [#2550]
Hi Lennart,
Thanks for you inputs. I completely agree
29d
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Thu, 17 Aug 2017 14:53:23 +0200
imm: change log level from error to warning in PBE [#2559]
In #2491, the log message if logged always with error log level.
If a cluster goes headless, this case is very likely to be happen
wi
In #2491, the log message if logged always with error log level.
If a cluster goes headless, this case is very likely to be happen
with ERR_TRY_AGAIN, but that's expected behavior when the cluster
goes headless.
---
src/imm/common/immpbe_dump.cc | 12 +---
1 file changed, 9 insertions(+),
where
immnd_cb->clm_hdl is set to 0.
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 16 augusti 2017 05:59
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] imm: fix imm
revision 13fd2be582b9445bc8ea9ca20e281f0a3e39cd29
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Mon, 14 Aug 2017 14:30:53 +0200
imm: regenerate PBE in verifyClassPBE only if database is corrupted [#2491]
In verifyClassPBE(), the patch makes distinguish between IMM issue and database
corruption.
Fo
In verifyClassPBE(), the patch makes distinguish between IMM issue and database
corruption.
For IMM issue, PBE will not be regenerated, while for database corruption, PBE
will be regenerated.
---
src/imm/common/immpbe_dump.cc | 18 ++
1 file changed, 14 insertions(+), 4
Initially CLM handle is set to 0. When CLM handle is initialized,
it can be initialized again only when saClmDispatch returns
SA_AIS_ERR_BAD_HANDLE.
This will prevent coredumps with initialized CLM handle
caused with MDS UP message for AMF and CLM services.
---
src/imm/immnd/immnd_clm.c | 7
6f8
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 9 Aug 2017 13:37:11 +0200
imm: fix immnd coredump due to initialized CLM handle [#2549]
Initially CLM handle is set to 0. When CLM handle is initialized,
it can be initialized again only when saClmDispatch returns
SA_AI
CLM selection object is initially set to -1. Included CLM selection
object in poll will be ignored until CLM selection object is created
and set to fds[FD_CLM].
---
src/imm/immnd/immnd_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/imm/immnd/immnd_main.c
462ae70282
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 14 Jul 2017 15:07:12 +0200
clm: handle ERR_BAD_HANDLE for saImmOmSearchInitialize [#2528]
CLM handles ERR_BAD_HANDLE for saImmOmSearchInitialize in
clms_cluster_config_get.
As part of this patch, handling of IMM ver
CLM handles ERR_BAD_HANDLE for saImmOmSearchInitialize in
clms_cluster_config_get.
As part of this patch, handling of IMM version is improved in the same function.
---
src/clm/clmd/clms_imm.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git
PBE will be regenerated on SQL constraint error code.
---
src/imm/common/immpbe_dump.cc | 17 +
1 file changed, 17 insertions(+)
diff --git a/src/imm/common/immpbe_dump.cc b/src/imm/common/immpbe_dump.cc
index 5185bb4..100222f 100644
--- a/src/imm/common/immpbe_dump.cc
+++
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 306efaabb70225703f57645adc2b645802e23d44
Aut
The patch removes dependencies between CLM tests. CLM tests can be run more
times now.
Duplicated CLM tests are removed from clmtest.
---
src/clm/apitest/clmtest.c | 15
src/clm/apitest/tet_saClmClusterTrack.c | 130 +++-
2 files changed, 94
d55
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 5 Jul 2017 16:44:24 +0200
clm: make CLM tests independent of other CLM tests [#2520]
The patch removes dependencies between CLM tests. CLM tests can be run more
times now.
Duplicated CLM tests are removed from clmt
Hi Praveen,
I checked saImmOmClassDescriptionGet_2() and the function returns
ERR_UNAVAILABLE only if IMM handle is initialized with A.2.18 and above version.
The problem here is that first OI handle is initialized with imm_version
variable, which version is A.2.12. Then OM handle is
Send IMM_FINALIZE message to immnd when dispatch functions returns
ERR_BAD_HANDLE.
IMM_FINALIZE will release all allocated resources of a handle on IMM service
side.
---
src/imm/agent/imma_proc.cc | 51 ++
1 file changed, 51 insertions(+)
diff --git
When active or standby nodes are introduced with request message, there is no
need to wait more for requesting the active role.
When standby node is introduced, then we are sure that there is an active node
somewhere in the cluster. So, changing the peer state is safe.
---
42bb4d0da1
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Wed, 28 Jun 2017 13:25:29 +0200
rde: allow early role change when active or standby nodes are introduced [#2513]
When active or standby nodes are introduced with request message, there is no
need to wait more for reque
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 9 juni 2017 08:41
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Hu
Thanks,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 14 juni 2017 12:13
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] imm: fix counting timeouts for old critical CCBs
[#2495]
Hi
The patch fix counting timeouts for old critical CCBs
---
src/imm/immnd/ImmModel.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/imm/immnd/ImmModel.cc b/src/imm/immnd/ImmModel.cc
index 25f8621..d76142e 100644
--- a/src/imm/immnd/ImmModel.cc
+++
OpenSAF servicesn
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision dcd53316bf6a294b439403a81daa25715fa022c7
Aut
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 6 juni 2017 09:41
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; mahesh.va...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<h
are write-only (W_AVAILABLE state).
While veteran nodes are in R_AVAILABLE state, they only check their data with
syncing data, but do not update any data.
BR,
Zoran
-Original Message-
From: A V Mahesh [mailto:mahesh.va...@oracle.com]
Sent: den 5 juni 2017 12:13
To: Zoran
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 29 maj 2017 12:34
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc
--
revision 6d71bc3ef6fae9b601853f34c173eaecce7beee2
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Fri, 19 May 2017 14:35:12 +0200
imm: change log level to warning for "ER Problem in sending to IMMD over MDS"
[#2465]
Log level for message "ER Problem in sending to IMMD ov
Log level for message "ER Problem in sending to IMMD over MDS" is changed from
error to warning.
---
src/imm/immnd/immnd_evt.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/imm/immnd/immnd_evt.c b/src/imm/immnd/immnd_evt.c
index cacf4d5..21d8671 100644
---
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 17 maj 2017 09:53
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Ack from me.
Please, add in the comment and update the ticket that you also discard search
impl continuation.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 17 maj 2017 09:40
To: Zoran Milinkovic <zoran.mili
[mailto:hung.d.ngu...@dektech.com.au]
Sent: den 10 maj 2017 08:41
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] imm: Remove CcbErrStrings that are set only on nodes
with OI/PBE [#2446]
Hi
Hi Hung,
Reviewed the code.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 9 maj 2017 10:29
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Hi Lennart,
You have a typo in the comment you've changed.
SMF is only interested in longDnsAllowed attribute, and not in
opensafNetworkName
Thanks,
Zoran
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: den 27 april 2017 15:10
To:
Hi Hieu,
Reviewed the patch and IMM code again.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com]
Sent: den 25 april 2017 13:33
To: Hieu Thanh Nguyen <hieu.t.ngu...@dektech.com.au>;
reddy.neelaka...@oracle.com; Hung Duc
n
Sent: den 25 april 2017 05:01
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com; Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] imm: Improve ccb error string handling [#2367]
Hi Zoran,
B
Hi Hieu,
This code will not work with CCB error strings related with PBE.
PBE can be running on a different node than the originating node.
Thanks,
Zoran
-Original Message-
From: Hieu Nguyen [mailto:hieu.t.ngu...@dektech.com.au]
Sent: den 21 april 2017 09:27
To: Zoran Milinkovic
gu...@dektech.com.au]
Sent: den 21 april 2017 08:45
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Subject: [PATCH 1/1] imm: Add more details to no dangling CcbError
Hi Anders,
I'll add your comments when I push the code.
Thanks,
Zoran
-Original Message-
From: Anders Widell
Sent: den 18 april 2017 16:06
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; ramesh.bet...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel]
Hi Hung,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 11 april 2017 14:08
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourcefor
Hi Hung,
Ack with a minor inline comment.
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 13 april 2017 10:52
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.net; Hung Duc Nguyen
<h
Hi Hoang,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
Sent: den 14 april 2017 10:44
To: 'A V Mahesh' <mahesh.va...@oracle.com>; Zoran Milinkovic
<zoran.milinko...@ericsson.com>
Cc: opensaf-devel@lists.sourceforge.
libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
revision 0ba8847949ad2ea3517e782c5c277bf37b14af24
Author: Zoran Milinkovic <zoran.milinko...
When a node with active or standby role sends peer info request, the node role
will be saved.
This will avoid setting the active role to the new starting node.
---
src/rde/rded/rde_main.cc | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/rde/rded/rde_main.cc b/src/rde/rded/rde_main.cc
Hi Hung,
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hung Nguyen [mailto:hung.d.ngu...@dektech.com.au]
Sent: den 4 april 2017 09:10
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH
Hi Hieu,
Fix indentation. In C files, we use TAB instead of spaces.
Ack from me.
Thanks,
Zoran
-Original Message-
From: Hieu Nguyen [mailto:hieu.t.ngu...@dektech.com.au]
Sent: den 3 april 2017 07:26
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>;
reddy.neelaka...@orac
Hi Neelakanta,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 21 mars 2017 12:15
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.c
2017 10:29
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc Nguyen
<hung.d.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] imm :decrement the pending reply when error is other
than SA_AIS_OK when newCcbId is called [#2386]
s
Hi Neelakanta,
Reviewed the patch.
Ack from me.
Thanks,
Zoran
-Original Message-
From: reddy.neelaka...@oracle.com [mailto:reddy.neelaka...@oracle.com]
Sent: den 20 mars 2017 10:36
To: Hung Duc Nguyen <hung.d.ngu...@dektech.com.au>; Zoran Milinkovic
<zoran.milinko...@ericsso
== possibly lost: 120 bytes in 4 blocks
==21333==still reachable: 263,815 bytes in 5 blocks
==21333== suppressed: 0 bytes in 0 blocks
Thanks,
Zoran
-Original Message-
From: Vo Minh Hoang [mailto:hoang.m...@dektech.com.au]
Sent: den 8 mars 2017 05:49
To: Zoran Milinkovic
Hi Mahesh,
Reviewed and tested the patch.
The patch silently fix IMMA UP bug.
Ack from me.
Thanks,
Zoran
-Original Message-
From: mahesh.va...@oracle.com [mailto:mahesh.va...@oracle.com]
Sent: den 3 mars 2017 06:42
To: Zoran Milinkovic <zoran.milinko...@ericsson.com>; Hung Duc
src/imm/immnd/immnd_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
If saClmDispatch fails with SA_AIS_ERR_BAD_HANDLE error, the message will be
logged with warning level and CLM handle will be reinitialized.
All other saClmDispatch errors will be logged with error level.
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 7174f12861a545a4cbb542d9834e9976f7840493
Author: Zoran Milinkovic <zoran.milinko...@ericsson.com>
Date: Tue, 07 Mar 2017 17:02:07 +0100
1 - 100 of 678 matches
Mail list logo
