[devel] [PATCH 0 of 1] Review Request for Respect saAmfSGNumPrefAssignedSUs configuration in nway and nway-active [#584]

2014-03-06 Thread Minh Hon Chau
b8e1bd794bbb4492b03237d619c1e00e490d0c8f Author: Minh Hon Chau minh.c...@dektech.com.au Date: Fri, 07 Mar 2014 13:30:29 +1100 Respect saAmfSGNumPrefAssignedSUs configuration in nway and nway-active [#584] Complete diffstat: -- osaf/services/saf/amf/amfd/include/sg.h | 2

[devel] [PATCH 0 of 1] Review Request for amfd: Respect saAmfSGNumPrefAssignedSUs configuration in nway and nway-active [#584]

2014-03-06 Thread Minh Hon Chau
n Other n Comments (indicate scope for each y above): - changeset b8e1bd794bbb4492b03237d619c1e00e490d0c8f Author: Minh Hon Chau minh.c...@dektech.com.au Date: Fri, 07 Mar 2014 13:30:29 +1100 amfd

[devel] [PATCH 1 of 1]

2014-03-06 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/include/sg.h | 2 +- osaf/services/saf/amf/amfd/sg.cc | 21 + osaf/services/saf/amf/amfd/sg_nway_fsm.cc| 5 + osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 6 ++ 4 files changed, 33 insertions(+), 1 deletions(-)

[devel] [PATCH 0 of 1] Review Request for amfnd: saAmfSGCompRestartProb timer is not stopped after the relevant model had been deleted [#831]

2014-04-15 Thread Minh Hon Chau
n Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset b6408ccc8279b3c712331efbecc1cc669d578ae0 Author: Minh Hon Chau minh.c...@dektech.com.au Date

[devel] [PATCH 0 of 1] Review Request for v2 amfnd: saAmfSGCompRestartProb timer is not stopped after the relevant model had been deleted [#831]

2014-05-04 Thread Minh Hon Chau
Samples n Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 45930abd103a9958433662bd95edeef6b89b7f61 Author: Minh Hon Chau minh.c

[devel] [PATCH 1 of 1] v2 amfnd: saAmfSGCompRestartProb timer is not stopped after the relevant model had been deleted [#831]

2014-05-04 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/su.cc | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) Problem: If the timer is started, delete the model, load model again, and kill component in order to escalate to the su restart. Then if the previous timer event comes during the

[devel] [PATCH 0 of 1] Review Request for v3 amfnd: saAmfSGCompRestartProb timer is not stopped after the relevant model had been deleted [#831]

2014-05-06 Thread Minh Hon Chau
Samples n Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 2335193f09ef673375748ed672204db8b99d3523 Author: Minh Hon Chau minh.c

[devel] [PATCH 1 of 1] amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/err.cc | 13 ++--- osaf/services/saf/amf/amfnd/susm.cc | 24 ++-- 2 files changed, 28 insertions(+), 9 deletions(-) Problem: In case of npi su restart recovery, the condition to change su presence state is not sufficient. If the

[devel] [PATCH 0 of 1] Review Request for amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-13 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 06851db87ea919eb1b0b3b781202a04e5a64f6a7 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Tue, 13 May

[devel] [PATCH 0 of 1] Review Request for v2 amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-14 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset e14c2a7f2a637c94a14e3877b675dce1b8b77da5 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Thu, 15

[devel] [PATCH 1 of 1] v2 amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-14 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/susm.cc | 7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Problem: In case of npi su restart recovery, the condition to change su presence state is not sufficient. If the component of the last csi in csi_list has been restarted first due to

[devel] [PATCH 1 of 1] v3 amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-15 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/susm.cc | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) In case of npi su restart recovery, the condition to change su presence state is not sufficient. If the component of the last csi in csi_list has been restarted first due to

[devel] [PATCH 0 of 1] Review Request for v3 amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-15 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset a2473ce5b6af3a8729432b10e5561d2e7a41f3af Author: Minh Hon Chau minh.c...@dektech.com.au Date: Thu, 15

[devel] [PATCH 0 of 1] Review Request for v4 amfnd: Not all npi-components are restarted during SuRestart escalation [#885]

2014-05-15 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset a3dc7063d6180d87d8feadef0f4b05dbc3c34be1 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Thu, 15

[devel] [PATCH 1 of 1] amfd: Send notification when cold sync is completed [#860]

2014-06-02 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/chkop.cc | 1 + osaf/services/saf/amf/amfd/include/ntf.h | 14 +++- osaf/services/saf/amf/amfd/ntf.cc| 54 ++- 3 files changed, 64 insertions(+), 5 deletions(-) This is enhancement that standby amfd sends notification

[devel] [PATCH 0 of 1] Review Request for v2 amfd: Send notifications when cold sync is completed [#860]

2014-06-02 Thread Minh Hon Chau
n Other n Comments (indicate scope for each y above): - This is V2 changeset 30dbc07ea849af8a24530414fe82e838a0e6fb68 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Tue, 03 Jun 2014 15:08:52 +1000 amfd: Send

[devel] [PATCH 0 of 5] Review Request for NTF: Support DNs longer than 255 bytes [#873]

2014-07-01 Thread Minh Hon Chau
n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 41e23a90f5b4afddc96f1ff19cfc38fd543e8f50 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Wed, 02 Jul 2014 15:40:51 +1000 NTF

[devel] [PATCH 4 of 5] NTF: Adapt NTF osaf service to support long DNs [#873]

2014-07-01 Thread Minh Hon Chau
osaf/services/saf/ntfsv/ntfs/Makefile.am | 1 + osaf/services/saf/ntfsv/ntfs/NtfFilter.cc | 34 +- osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 5 +++- osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 5 ++- osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 5 5

[devel] [PATCH 3 of 5] NTF: Adapt NTFIMCND to support long DNs [#873]

2014-07-01 Thread Minh Hon Chau
osaf/services/saf/ntfsv/ntfimcnd/Makefile.am| 2 + osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_imm.c | 91 +++- osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_notifier.c | 54 ++-- 3 files changed, 78 insertions(+), 69 deletions(-) diff --git

[devel] [PATCH 1 of 5] NTF: Adapt NTF API to support long DNs [#873]

2014-07-01 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/Makefile.am | 1 + osaf/libs/agents/saf/ntfa/ntfa_api.c | 25 - osaf/libs/saf/libSaNtf/Makefile.am| 1 + 3 files changed, 18 insertions(+), 9 deletions(-) diff --git a/osaf/libs/agents/saf/ntfa/Makefile.am

[devel] [PATCH 5 of 7] NTF: Adapt NTF common library to support long DNs [#873] v2

2014-07-08 Thread Minh Hon Chau
osaf/libs/common/ntfsv/Makefile.am |1 + osaf/libs/common/ntfsv/include/ntfsv_mem.h |7 + osaf/libs/common/ntfsv/ntfsv_enc_dec.c | 37 -- osaf/libs/common/ntfsv/ntfsv_mem.c | 152 +++- 4 files changed, 176 insertions(+), 21 deletions(-)

[devel] [PATCH 0 of 7] Review Request for NTF: Support DNs longer than 255 bytes [#873] V2

2014-07-08 Thread Minh Hon Chau
95f86bfa9ce44e0d54c6bc366a4705a727bccc28 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Wed, 09 Jul 2014 14:35:06 +1000 NTF: Adapt NTF tools (ntfread, ntfsend, ntfsubscribe) to support long DNs [#873] changeset 745302d173e2b2149b8d7b18ee30d3c97dc54076 Author: Minh Hon Chau minh.c

[devel] [PATCH 7 of 7] Temporary patch to solve compilation dependency

2014-07-08 Thread Minh Hon Chau
osaf/tools/safimm/src/immutil.c | 57 ++-- osaf/tools/saflog/src/saflog.c | 10 +- 2 files changed, 34 insertions(+), 33 deletions(-) This patch is not part of #873, it's made to solve the dependency since NTF is using immutil.c and saflog.c. NOTE that

[devel] [PATCH 3 of 7] NTF: Adapt NTFIMCND to support long DNs [#873]

2014-07-08 Thread Minh Hon Chau
osaf/services/saf/ntfsv/ntfimcnd/Makefile.am| 2 + osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_imm.c | 91 +++- osaf/services/saf/ntfsv/ntfimcnd/ntfimcn_notifier.c | 54 ++-- 3 files changed, 78 insertions(+), 69 deletions(-) diff --git

[devel] [PATCH 2 of 7] NTF: Adapt NTF osaf service to support long DNs [#873]

2014-07-08 Thread Minh Hon Chau
osaf/services/saf/ntfsv/ntfs/Makefile.am | 1 + osaf/services/saf/ntfsv/ntfs/NtfFilter.cc | 34 +- osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 5 +++- osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 5 ++- osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 5 5

[devel] [PATCH 2 of 7] NTF: Adapt NTF common library to support long DNs [#873] v3

2014-07-15 Thread Minh Hon Chau
osaf/libs/common/ntfsv/Makefile.am |1 + osaf/libs/common/ntfsv/include/ntfsv_mem.h |7 + osaf/libs/common/ntfsv/ntfsv_enc_dec.c | 37 -- osaf/libs/common/ntfsv/ntfsv_mem.c | 151 +++- 4 files changed, 175 insertions(+), 21 deletions(-)

[devel] [PATCH 7 of 7] Temporary patch to solve compilation dependency

2014-07-15 Thread Minh Hon Chau
osaf/tools/safimm/src/immutil.c | 57 ++-- osaf/tools/saflog/src/saflog.c | 10 +- 2 files changed, 34 insertions(+), 33 deletions(-) This patch is not part of #873, it's made to solve the dependency since NTF is using immutil.c and saflog.c. NOTE that

[devel] [PATCH 5 of 7] NTF: Adapt NTF tools (ntfread, ntfsend, ntfsubscribe) to support long DNs [#873] v2

2014-07-15 Thread Minh Hon Chau
osaf/tools/safntf/include/ntfclient.h | 3 +- osaf/tools/safntf/ntfread/Makefile.am | 6 +- osaf/tools/safntf/ntfread/ntfread.c | 23 +- osaf/tools/safntf/ntfsend/Makefile.am | 6 +- osaf/tools/safntf/ntfsend/ntfsend.c | 29 ++---

[devel] [PATCH 0 of 7] Review Request for NTF: Support DNs longer than 255 bytes [#873] V3

2014-07-15 Thread Minh Hon Chau
for AdditionalInfo with extended SaNameT changeset 41e6acf50d610229b7dbf1590a5d98d9d2e80dae Author: Minh Hon Chau minh.c...@dektech.com.au Date: Tue, 15 Jul 2014 15:50:16 +1000 NTF: Adapt NTF API to support long DNs [#873] changeset c6092d94fae5c0db5b98e91bc68d0d58dc066c31 Author: Minh Hon

[devel] [PATCH 3 of 7] NTF: Adapt NTF osaf service to support long DNs [#873]

2014-07-15 Thread Minh Hon Chau
osaf/services/saf/ntfsv/ntfs/Makefile.am | 1 + osaf/services/saf/ntfsv/ntfs/NtfFilter.cc | 34 +- osaf/services/saf/ntfsv/ntfs/NtfLogger.cc | 5 +++- osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 5 ++- osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 5 5

[devel] [PATCH 6 of 7] NTF: Add ntftest test cases for notification with long dn objects [#873] v2

2014-07-15 Thread Minh Hon Chau
tests/ntfsv/Makefile.am |3 +- tests/ntfsv/tet_longDnObject_notification.c | 957 tests/unit_test_fw/inc/util.h |5 +- tests/unit_test_fw/src/Makefile.am |1 + tests/unit_test_fw/src/util.c | 14

[devel] [PATCH 0 of 6] Review Request for NTF: Support DNs longer than 255 bytes [#873] V4

2014-08-08 Thread Minh Hon Chau
y Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 79eb61e69d36d54808a60190613be8e59ef8c6bf Author: Minh Hon Chau minh.c...@dektech.com.au Date: Fri, 08 Aug 2014 16:28:29 +1000

[devel] [PATCH 1 of 6] NTF: Adapt NTF API to support long DNs [#873] V2

2014-08-08 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/Makefile.am | 1 + osaf/libs/agents/saf/ntfa/ntfa.h | 1 + osaf/libs/agents/saf/ntfa/ntfa_api.c | 53 +++--- osaf/libs/agents/saf/ntfa/ntfa_util.c | 30 +-- osaf/libs/saf/libSaNtf/Makefile.am| 1 + 5 files

[devel] [PATCH 5 of 6] Adapt NTF tools (ntfread, ntfsend, ntfsubscribe) to support long DNs[#873] V3

2014-08-08 Thread Minh Hon Chau
osaf/tools/safntf/include/ntfclient.h | 3 +- osaf/tools/safntf/ntfread/Makefile.am | 1 + osaf/tools/safntf/ntfread/ntfread.c | 23 ++- osaf/tools/safntf/ntfsend/Makefile.am | 1 + osaf/tools/safntf/ntfsend/ntfsend.c | 29 ++

[devel] [PATCH 6 of 6] NTF: Add ntftest test cases for notification with long dn objects [#873] V3

2014-08-08 Thread Minh Hon Chau
tests/ntfsv/Makefile.am |3 +- tests/ntfsv/test_ntf_imcn.c | 508 ++- tests/ntfsv/tet_longDnObject_notification.c | 972 tests/unit_test_fw/inc/util.h |5 +- tests/unit_test_fw/src/Makefile.am

[devel] [PATCH 0 of 1] Review Request for Revise inappropriate code [#873]

2014-08-21 Thread Minh Hon Chau
Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset c5ce1bfee8adcfd7b506322ade0bcd3afd83efbc Author: Minh Hon Chau minh.c...@dektech.com.au Date: Fri, 22 Aug 2014 14:45:21 +1000 NTF: Revise inappropriate

[devel] [PATCH 1 of 1] NTF: Revise inappropriate code [#873]

2014-08-21 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/ntfa_api.c | 1 + osaf/services/saf/ntfsv/ntfs/NtfAdmin.cc | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) (1) Assert the dataSize must be larger than 2 (2) Replace delete by free due to memory allocation by malloc/calloc diff --git

[devel] [PATCH 0 of 2] Review Request for NTF: Unadapted LongDns consumer crashes due to read/subsribe long dn notification [#1114]

2014-09-27 Thread Minh Hon Chau
n Tests y Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 6aa5e3fb070779a0e1ba0f464e58398e8075da44 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Sun

[devel] [PATCH 2 of 2] NTF: Add protection against longDn notification for unadapted producer/consumer [#1114]

2014-09-27 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/ntfa_api.c | 380 +++- osaf/libs/agents/saf/ntfa/ntfa_util.c | 33 ++- osaf/libs/common/ntfsv/ntfsv_enc_dec.c | 75 - osaf/libs/common/ntfsv/ntfsv_mem.c |1 + 4 files changed, 306 insertions(+), 183 deletions(-) Currently

[devel] [PATCH 0 of 3] Review Request for NTF: Unadapted LongDns consumer crashes due to read/subsribe long dn notification [#1114] V2

2014-09-30 Thread Minh Hon Chau
d5e2e895479d191630c11f07a620ea77fa90f4ca Author: Minh Hon Chau minh.c...@dektech.com.au Date: Wed, 01 Oct 2014 13:31:56 +1000 NTF: Add description of long DNs support to osaf/services/saf/ntfsv/README This should be added together with #873, but now it's a chance to get in with #1114

[devel] [PATCH 2 of 3] NTF: Add notification to test unadapted consumer in ntftest 36 1[#1114]

2014-09-30 Thread Minh Hon Chau
tests/ntfsv/tet_longDnObject_notification.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) Send additional notification with shortDn for notificationObject and notifyingObject but having extended SaNameT in AdditionalInfo, to test whether the unadapted consumer can receives this

[devel] [PATCH 1 of 3] NTF: Add description of long DNs support to osaf/services/saf/ntfsv/README

2014-09-30 Thread Minh Hon Chau
osaf/services/saf/ntfsv/README | 70 ++ 1 files changed, 70 insertions(+), 0 deletions(-) This should be added together with #873, but now it's a chance to get in with #1114 diff --git a/osaf/services/saf/ntfsv/README b/osaf/services/saf/ntfsv/README

[devel] [PATCH 3 of 3] NTF: Add protection against longDn notification for unadapted producer/consumer [#1114] V2

2014-09-30 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/ntfa_api.c | 532 +++-- osaf/libs/agents/saf/ntfa/ntfa_util.c | 39 ++- osaf/libs/common/ntfsv/ntfsv_mem.c|1 + 3 files changed, 412 insertions(+), 160 deletions(-) Currently if any unadapted longDn consumer receives notification

[devel] [PATCH 1 of 1] NTF: Add documentary description for functions introduced in #1114

2014-10-05 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/ntfa_api.c | 55 +++- 1 files changed, 54 insertions(+), 1 deletions(-) diff --git a/osaf/libs/agents/saf/ntfa/ntfa_api.c b/osaf/libs/agents/saf/ntfa/ntfa_api.c --- a/osaf/libs/agents/saf/ntfa/ntfa_api.c +++

[devel] [PATCH 1 of 1] AMF: Update SI dependencies after SU Failover for NpM SG [#1101]

2014-10-13 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) As the NpM SU needs to be failed-over, the current code is seeking the standby SUs that can take over the Active assignments. But if no such standby SU is found, the SI depedency has not yet

[devel] [PATCH 0 of 1] Review Request for AMF: Update SI dependencies after SU Failover for NpM SG [#1101]

2014-10-13 Thread Minh Hon Chau
n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 2728c236ee592ee09b0b1bdca245a1157264fcc9 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Tue, 14 Oct 2014 11:05:53 +1100 AMF

[devel] [PATCH 0 of 1] Review Request for AMF: Update SI dependencies after SU Failover for NpM SG [#1101] V2

2014-10-20 Thread Minh Hon Chau
n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 48b946d635ab6d0624010a875484d42c36765ab9 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Tue, 21 Oct 2014 11:37:32 +1100 AMF

[devel] [PATCH 1 of 1] AMF: Update SI dependencies after SU Failover for NpM SG [#1101] V2

2014-10-20 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) As the NpM SU needs to be failed-over, the current code is seeking the standby SUs that can take over the Active assignments. But if no such standby SU is found, the SI

[devel] [PATCH 0 of 1] Review Request for AMF: Add support to change saAmfSIRank [#1162]

2014-10-30 Thread Minh Hon Chau
n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 36048cbc15d78916e948020f912d92022173f9e9 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Thu, 30 Oct 2014 23:13:12 +1100 AMF: Add support

[devel] [PATCH 1 of 1] AMF: Add support to change saAmfSIRank at runtime [#1162]

2014-10-30 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/include/sg.h | 5 +- osaf/services/saf/amf/amfd/include/si.h | 4 +- osaf/services/saf/amf/amfd/include/si_dep.h | 1 + osaf/services/saf/amf/amfd/sg.cc| 19 ++--- osaf/services/saf/amf/amfd/si.cc| 81 -

[devel] [PATCH 0 of 1] Review Request for amfd: Re-align SG if NodeFailover happens at quiesced assignment during si-swap [#1312]

2015-04-16 Thread Minh Hon Chau
n Tests n Other n Comments (indicate scope for each y above): - This patch is for 4.5 branch changeset 8b8bcfc89b497e2e84bc9bb691263ad894bbbee3 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Fri

[devel] [PATCH 1 of 1] amfd: Re-align SG if NodeFailover happens at quiesced assignment during si-swap [#1312]

2015-04-16 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 43 +++- 1 files changed, 36 insertions(+), 7 deletions(-) During si-swap, node-failover happens on the node which's su just finishes quiesced assignment, and su on the other node has not done active assignment. Then if

[devel] [PATCH 1 of 1] AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386]

2015-06-18 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 83 +--- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 9 ++ osaf/services/saf/amf/amfnd/sidb.cc | 2 +- osaf/services/saf/amf/amfnd/susm.cc | 24 ++- 4 files changed, 90 insertions(+), 28

[devel] [PATCH 0 of 1] Review Request for Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V4

2015-08-05 Thread Minh Hon Chau
state only if these csi(s) are not marked to suspend assignment changeset aa6280b43b3f1afd47bd02a9aaa3179b74af57d2 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Thu, 06 Aug 2015 14:40:57 +1000 AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386

[devel] [PATCH 1 of 1] AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V4

2015-08-05 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 47 ++--- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 9 osaf/services/saf/amf/amfnd/sidb.cc | 2 +- osaf/services/saf/amf/amfnd/susm.cc | 55 +++- 4 files changed, 92

[devel] [PATCH 0 of 1] Review Request for Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V2

2015-07-14 Thread Minh Hon Chau
0715af9e4b05c455a6fa8db76aa3c34b379ea224 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Wed, 15 Jul 2015 13:49:20 +1000 AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V2 If su-si active assignment is on-going, some csi(s) may get assigned

[devel] [PATCH 1 of 1] AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi [#1386] V2

2015-07-14 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 37 osaf/services/saf/amf/amfnd/include/avnd_comp.h | 9 ++ osaf/services/saf/amf/amfnd/sidb.cc | 2 +- osaf/services/saf/amf/amfnd/susm.cc | 24 ++-- 4 files changed, 61

[devel] [PATCH 2 of 2] amfnd: Cleaning code as part of #1557

2015-10-27 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) The patch for cleaning code after fix of #1557: Ensure TRACE_LEAVE2 is called Remove unused env_attr_val diff --git a/osaf/services/saf/amf/amfnd/clc.cc

[devel] [PATCH 1 of 2] amfnd: Do not run same clc commands at once [#1557]

2015-10-27 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 10 ++ osaf/services/saf/amf/amfnd/include/avnd_comp.h | 3 ++- 2 files changed, 12 insertions(+), 1 deletions(-) Currently if two errors happen at once, amfnd calls two clc cleanup commands in a row, and component fails into

[devel] [PATCH 0 of 2] Review Request for Do not run same clc commands at once [#1557]

2015-10-27 Thread Minh Hon Chau
changeset ea670980b3604a3d84a7fcd19f7b091511165894 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Wed, 28 Oct 2015 11:52:21 +1100 amfnd: Do not run same clc commands at once [#1557] Currently if two errors happen at once, amfnd calls two clc cleanup commands in a row, and component fails in

[devel] [PATCH 0 of 2] Review Request for Do not run same clc commands at once [#1557] V2

2015-11-03 Thread Minh Hon Chau
nformative changeset e7a782c016af602869fccdb0f838f83f87859e59 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Tue, 03 Nov 2015 20:13:02 +1100 amfnd: Do not run same clc commands at once [#1557] Currently if two errors happen at once, amfnd calls two clc cleanup commands

[devel] [PATCH 1 of 2] amfnd: Do not run same clc commands at once [#1557]

2015-11-03 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 10 ++ osaf/services/saf/amf/amfnd/include/avnd_comp.h | 3 ++- 2 files changed, 12 insertions(+), 1 deletions(-) Currently if two errors happen at once, amfnd calls two clc cleanup commands in a row, and component fails into

[devel] [PATCH 2 of 2] amfnd: Cleaning code as part of #1557

2015-11-03 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 18 ++ 1 files changed, 6 insertions(+), 12 deletions(-) The patch for cleaning code after fix of #1557: Ensure TRACE_LEAVE2 is called Remove unused env_attr_val diff --git a/osaf/services/saf/amf/amfnd/clc.cc

[devel] [PATCH 0 of 1] Review Request for Request for amfd: Standby controller reboots if adding additional SI in N+M model [#1457]

2015-08-25 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each y above): - EXPLAIN/COMMENT THE PATCH SERIES HERE changeset 1736c73e54ff1d3dd9cec016887dde5ea4289df9 Author: Minh Hon Chau minh.c...@dektech.com.au Date: Wed, 26 Aug

[devel] [PATCH 1 of 1] amfd: Standby controller reboots if adding additional SI in N+M model [#1457]

2015-08-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/si.cc | 89 +++- 1 files changed, 88 insertions(+), 1 deletions(-) As N+M SU(s) are unlocked and having assignment, if dynamically adding an SI (without specified saAmfSIAdminState) that causes the standby controller reboots If

[devel] [PATCH 0 of 3] Review Request for Fix amf_demo crahes when calling SaAmfHAStateGet [#1437, #1444]

2015-09-15 Thread Minh Hon Chau
ple, so it's only attached to for testing, not for commit. changeset afa759cbb7aff51868ea73230046650e89435307 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Wed, 16 Sep 2015 15:11:40 +1000 sample: Handle HA transition in amf_demo [#1437] changeset 4a42c4627aa0a15b5a5af9d5d7ba60

[devel] [PATCH 3 of 3] amfnd: Correct ha_state before returns to comp for saAmfHAStateGet [#1444]

2015-09-15 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) Currently amfnd always returns SA_AMF_HA_QUIESCING to component even if component succeeds with saAmfCSIQuiescingComplete() amfnd should return SA_AMF_HA_QUIESCED to component as amfnd

[devel] [PATCH 2 of 3] sample: Handle HA transition in amf_demo [#1437]

2015-09-15 Thread Minh Hon Chau
samples/amf/sa_aware/amf_demo.c | 186 +-- tools/cluster_sim_uml/build_uml |2 +- 2 files changed, 139 insertions(+), 49 deletions(-) diff --git a/samples/amf/sa_aware/amf_demo.c b/samples/amf/sa_aware/amf_demo.c --- a/samples/amf/sa_aware/amf_demo.c +++

[devel] [PATCH 0 of 1] Review Request for amfnd: Delete comp_curr_info if comp fails into TERMINATION_FAILED [#1500]

2015-12-14 Thread Minh Hon Chau
Tests n Other n Comments (indicate scope for each "y" above): - <> changeset d7df94a697aa1258c1ed38f2bc59c4bb95c0d055 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Tue, 15 D

[devel] [PATCH 1 of 1] amfnd: Delete comp_curr_info if comp fails into TERMINATION_FAILED [#1500]

2015-12-14 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Escalation is configured in the way that just one component restart can lead to su failover. If the clc cleanup script returns error, the component fails into TERMINATION_FAILED state. The AMF repair

[devel] [PATCH 1 of 1] amfnd: Simplify if statement for qualified assignment component [#1538]

2015-12-13 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 71 +--- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 +- 2 files changed, 40 insertions(+), 33 deletions(-) There's a compound *if* conditions to determine whether a component can be assigned/removed for a csi.

[devel] [PATCH 0 of 1] Review Request for amfnd: Simplify if statement for qualified assignment component [#1538]

2015-12-13 Thread Minh Hon Chau
n Other n Comments (indicate scope for each "y" above): - <> changeset f68c9a8e6fbc9e76dc13eaada506f9f7323035c1 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Mon, 14 Dec 2015 10:55:39 +1100

[devel] [PATCH 3 of 5] amfd: Add support for cloud resilience at common libs [#1620]

2016-01-05 Thread Minh Hon Chau
osaf/libs/common/amf/d2nedu.c| 311 -- osaf/libs/common/amf/d2nmsg.c| 266 +++ osaf/libs/common/amf/include/Makefile.am |1 + osaf/libs/common/amf/include/amf_d2nedu.h| 16 +

[devel] [PATCH 4 of 5] amfnd: Add support for cloud resilience at node director [#1620]

2016-01-05 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 100 +++-- osaf/services/saf/amf/amfnd/clm.cc | 11 +- osaf/services/saf/amf/amfnd/comp.cc | 46 ++- osaf/services/saf/amf/amfnd/compdb.cc | 45 ++- osaf/services/saf/amf/amfnd/di.cc | 419

[devel] [PATCH 0 of 5] Review Request for amf: Add support for cloud resilience [#1620]

2016-01-05 Thread Minh Hon Chau
ions along the changes for more info changeset 7edea60f9786f1eaaca79a6736ac478ec7f4b20a Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Wed, 06 Jan 2016 00:10:44 +1100 amfd: Add README file for cloud resilience support [#1620] changeset cc768f5ce161443c014962f09adcdc2d377fb32f

[devel] [PATCH 2 of 5] amfd: Add saAmfUnassignedAlarmStatus attribute to memorize the alarm_sent status [#1620]

2016-01-05 Thread Minh Hon Chau
osaf/services/saf/amf/config/amf_classes.xml | 8 1 files changed, 8 insertions(+), 0 deletions(-) If the SI Unassigned Alarm is raised before headless by locking SU for instance, then after cluster recovers from headless and unlocking the SU, this alarm is not cleared. As the

[devel] [PATCH 1 of 5] amfd: Add README file for cloud resilience support [#1620]

2016-01-05 Thread Minh Hon Chau
osaf/services/saf/amf/README-HEADLESS | 62 +++ 1 files changed, 62 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README-HEADLESS b/osaf/services/saf/amf/README-HEADLESS new file mode 100644 --- /dev/null +++

[devel] [PATCH 3 of 5] NTF: Add new README file for description of cloud resilience support [#1180]

2015-12-22 Thread Minh Hon Chau
osaf/services/saf/ntfsv/README.HYDRA | 110 +++ 1 files changed, 110 insertions(+), 0 deletions(-) Add description regarding general solution and API implementation for cloud resilience support in NTF diff --git a/osaf/services/saf/ntfsv/README.HYDRA

[devel] [PATCH 2 of 5] NTF: Add support cloud resilience for NTF libs common [#1180]

2015-12-22 Thread Minh Hon Chau
osaf/libs/common/ntfsv/include/ntfsv_mem.h |7 + osaf/libs/common/ntfsv/include/ntfsv_msg.h |1 + osaf/libs/common/ntfsv/ntfsv_mem.c | 159 + 3 files changed, 167 insertions(+), 0 deletions(-) The patch contains support for cloud resilience feature

[devel] [PATCH 0 of 5] Review Request for ntf: Add cloud resilience support [#1180]

2015-12-22 Thread Minh Hon Chau
n Comments (indicate scope for each "y" above): - <> changeset ee355e909a4b0790ef6ae0ce1c04f44f0242c18c Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Wed, 23 Dec 2015 14:56:14 +1100 NTF: Add su

[devel] [PATCH 5 of 5] NTF: Add wrapper for usage of NTF API in ntftools to handle TRY_AGAIN [#1180]

2015-12-22 Thread Minh Hon Chau
osaf/tools/safntf/include/ntfclient.h | 25 osaf/tools/safntf/ntfread/ntfread.c | 16 +- osaf/tools/safntf/ntfsend/ntfsend.c | 24 +- osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 22 +- osaf/tools/safntf/src/ntfclient.c | 158

[devel] [PATCH 0 of 1] Review Request for amfnd: Simplify if statement for qualified assignment component [#1538]

2016-01-11 Thread Minh Hon Chau
n Other n Comments (indicate scope for each "y" above): - <> changeset 521d8f3e383e57ef0e8165f760fdc70b712715ec Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Tue, 12 J

[devel] [PATCH 1 of 1] amfnd: Simplify if statement for qualified assignment component [#1538]

2016-01-11 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/comp.cc | 71 +--- osaf/services/saf/amf/amfnd/include/avnd_comp.h | 2 +- 2 files changed, 40 insertions(+), 33 deletions(-) There's a compound *if* conditions to determine whether a component can be assigned/removed for a csi.

[devel] [PATCH 1 of 1] AMFD: Update RTA saAmfSUHostedByNode after headless [#1720] V2

2016-06-06 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/siass.cc | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) After being headless, the RTA saAmfSUHostedByNode of SU has not been updated. That will cause the messaging to SU in wrong node. While performing recovery from headless, the saAmfSUHostedByNode of

[devel] [PATCH 0 of 1] Review Request for Unexpected NCSMDS_DOWN coming from Agent to NTFD [#1818] V2

2016-05-29 Thread Minh Hon Chau
n Other n Comments (indicate scope for each "y" above): - This V2 is the same V1, it updates the patch description changeset d0f03e346a8196f65dfb3c42aa4245e9da02e384 Author: Minh Hon Chau <minh.c...@dektech.com.au>

[devel] [PATCH 1 of 1] ntfa: Lower intialize req message [#1818] V2

2016-05-29 Thread Minh Hon Chau
osaf/libs/agents/saf/ntfa/ntfa_mds.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) When running life cycle APIs from multiple handles in multiple threads, ntfd processes the previous NCSMDS_DOWN event from last finalize after processes following initialze. This will

[devel] [PATCH 10 of 15] amfnd: Resend pg information after headless [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/di.cc | 36 + osaf/services/saf/amf/amfnd/include/avnd_di.h | 1 + osaf/services/saf/amf/amfnd/verify.cc | 38 +-- 3 files changed, 38 insertions(+), 37 deletions(-) If SC comes back from

[devel] [PATCH 06 of 15] amfd: Support delayed failover [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/cluster.cc| 11 ++ osaf/services/saf/amf/amfd/include/sg.h | 14 ++ osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 140 +++ osaf/services/saf/amf/amfd/sg_nored_fsm.cc |6 + osaf/services/saf/amf/amfd/sg_npm_fsm.cc |

[devel] [PATCH 04 of 15] amfnd: Add support for cloud resilience at node director [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/clc.cc | 100 +++-- osaf/services/saf/amf/amfnd/clm.cc | 11 +- osaf/services/saf/amf/amfnd/comp.cc | 42 ++- osaf/services/saf/amf/amfnd/compdb.cc | 45 ++- osaf/services/saf/amf/amfnd/di.cc | 419

[devel] [PATCH 13 of 15] amfd: Reboot cluster at data inconsistency [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/include/util.h | 1 + osaf/services/saf/amf/amfd/siass.cc | 9 - osaf/services/saf/amf/amfd/util.cc| 22 ++ osaf/services/saf/amf/amfnd/amfnd.cc | 3 ++- osaf/services/saf/amf/amfnd/mds.cc| 3 ++- 5 files

[devel] [PATCH 11 of 15] amf: Fix various amfnd coredump and mapping SU [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/role.cc | 10 osaf/services/saf/amf/amfd/sgproc.cc | 2 +- osaf/services/saf/amf/amfd/siass.cc | 4 ++- osaf/services/saf/amf/amfnd/err.cc | 37 ++- osaf/services/saf/amf/amfnd/susm.cc | 20 -- 5

[devel] [PATCH 01 of 15] amfd: Add support for cloud resilience at common libs [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/libs/common/amf/d2nedu.c| 311 -- osaf/libs/common/amf/d2nmsg.c| 266 +++ osaf/libs/common/amf/include/Makefile.am |1 + osaf/libs/common/amf/include/amf_d2nedu.h| 16 +

[devel] [PATCH 03 of 15] amfd: Add support for cloud resilience at director [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/cluster.cc| 48 +++- osaf/services/saf/amf/amfd/comp.cc |8 +- osaf/services/saf/amf/amfd/csi.cc| 105 +++ osaf/services/saf/amf/amfd/imm.cc| 58 osaf/services/saf/amf/amfd/include/cb.h

[devel] [PATCH 05 of 15] amfnd: Support component/su failover [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/err.cc | 80 +++--- 1 files changed, 40 insertions(+), 40 deletions(-) If any error escalates to component/su failover during headless, amfnd reboot node. The issue is other healthy SUs get affected by this reboot, and this degrades

[devel] [PATCH 00 of 15] Review Request for AMF: Add support for cloud resilience [#1620] V4

2016-02-25 Thread Minh Hon Chau
nt_si.diff changeset 8c96f8cb52f1608911eeaa8977c64c740ce76af3 Author: Minh Hon Chau <minh.c...@dektech.com.au> Date: Thu, 25 Feb 2016 19:18:55 +1100 amfd: Add support for cloud resilience at common libs [#1620] Outlined changes: . Introduce messages sisu_state_info and cs

[devel] [PATCH 12 of 15] amfd: Don't disable healthy SU [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/su.cc | 8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) This scenario happen if unlock-in SU before going headless. After headless, amfnd sends SU oper state DISABLE in recovery data. The patch comments out the suspicious setting SU's oper state to

[devel] [PATCH 08 of 15] amfd: Adjust uncompleted admin command after headless [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfd/cluster.cc | 6 + osaf/services/saf/amf/amfd/include/node.h | 6 +- osaf/services/saf/amf/amfd/include/sg.h | 2 +- osaf/services/saf/amf/amfd/node.cc| 35 +++ osaf/services/saf/amf/amfd/nodegroup.cc | 16 +

[devel] [PATCH 09 of 15] amfnd: Return TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/amfnd/pg.cc | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) Patch returns TRY_AGAIN for saAmfProtectionGroupTrack and saAmfProtectionGroupTrackStop during headless since the proctection group tracking requires amfd's presence diff --git

[devel] [PATCH 02 of 15] amfd: Add saAmfUnassignedAlarmStatus attribute to memorize the alarm_sent status [#1620]

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/config/amf_classes.xml | 8 1 files changed, 8 insertions(+), 0 deletions(-) If the SI Unassigned Alarm is raised before headless by locking SU for instance, then after cluster recovers from headless and unlocking the SU, this alarm is not cleared. As the

[devel] [PATCH 15 of 15] imported patch 1620_README_V4.diff

2016-02-25 Thread Minh Hon Chau
osaf/services/saf/amf/README_HEADLESS | 172 ++ 1 files changed, 172 insertions(+), 0 deletions(-) diff --git a/osaf/services/saf/amf/README_HEADLESS b/osaf/services/saf/amf/README_HEADLESS new file mode 100644 --- /dev/null +++

  1   2   3   4   >