[tickets] [opensaf:tickets] #3113 log: coding issues identified by codechecker
- **status**: accepted --> review --- ** [tickets:#3113] log: coding issues identified by codechecker** **Status:** review **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:06 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:06 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3115 imm: coding issues identified by codechecker
- **Part**: lib --> - --- ** [tickets:#3115] imm: coding issues identified by codechecker ** **Status:** review **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:30 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:57 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3115 imm: coding issues identified by codechecker
- **status**: accepted --> review --- ** [tickets:#3115] imm: coding issues identified by codechecker ** **Status:** review **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:30 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:30 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3114 ntf: coding issues identified by codechecker
- **status**: accepted --> review --- ** [tickets:#3114] ntf: coding issues identified by codechecker** **Status:** review **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:28 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:28 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3115 imm: coding issues identified by codechecker
--- ** [tickets:#3115] imm: coding issues identified by codechecker ** **Status:** accepted **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:30 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:30 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3114 ntf: coding issues identified by codechecker
--- ** [tickets:#3114] ntf: coding issues identified by codechecker** **Status:** accepted **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:28 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:28 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3113 log: coding issues identified by codechecker
--- ** [tickets:#3113] log: coding issues identified by codechecker** **Status:** accepted **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 07:06 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 07:06 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3112 mds: coding issues identified by codechecker
--- ** [tickets:#3112] mds: coding issues identified by codechecker** **Status:** assigned **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 06:38 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 06:38 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3112 mds: coding issues identified by codechecker
- **status**: assigned --> review --- ** [tickets:#3112] mds: coding issues identified by codechecker** **Status:** review **Milestone:** 5.20.01 **Created:** Mon Nov 04, 2019 06:38 AM UTC by Thuan **Last Updated:** Mon Nov 04, 2019 06:38 AM UTC **Owner:** Thuan Fix coding issues identified by codechecker --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- Attachments has changed: Diff: --- old +++ new @@ -0,0 +1 @@ +mds.log (16.9 kB; application/octet-stream) --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** review **Milestone:** 5.20.01 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Tue Oct 22, 2019 09:17 AM UTC **Owner:** Thuan **Attachments:** - [mds.log](https://sourceforge.net/p/opensaf/tickets/3102/attachment/mds.log) (16.9 kB; application/octet-stream) On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- Attachments has changed: Diff: --- old +++ new @@ -1 +0,0 @@ -mds.log (2.6 kB; application/octet-stream) --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** review **Milestone:** 5.20.01 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Tue Oct 22, 2019 09:17 AM UTC **Owner:** Thuan On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- Attachments has changed: Diff: --- old +++ new @@ -0,0 +1 @@ +mds.log (2.6 kB; application/octet-stream) --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** review **Milestone:** 5.20.01 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Tue Oct 22, 2019 01:00 AM UTC **Owner:** Thuan **Attachments:** - [mds.log](https://sourceforge.net/p/opensaf/tickets/3102/attachment/mds.log) (2.6 kB; application/octet-stream) On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- **status**: accepted --> review --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** review **Milestone:** 5.20.01 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Mon Oct 21, 2019 03:30 AM UTC **Owner:** Thuan On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- **status**: review --> accepted --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** accepted **Milestone:** 5.19.10 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Thu Oct 17, 2019 10:47 AM UTC **Owner:** Thuan On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
- **status**: assigned --> review --- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** review **Milestone:** 5.19.10 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Thu Oct 17, 2019 09:23 AM UTC **Owner:** Thuan On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3102 mds: waste 1.5s in waiting Adest already down to send response message type
--- ** [tickets:#3102] mds: waste 1.5s in waiting Adest already down to send response message type** **Status:** assigned **Milestone:** 5.19.10 **Created:** Thu Oct 17, 2019 09:23 AM UTC by Thuan **Last Updated:** Thu Oct 17, 2019 09:23 AM UTC **Owner:** Thuan On Active SC, do following commands: ~~~ pkill -STOP osafntfd ntfsend & pkill -9 ntfsend pkill -CONT osafntfd ~~~ Check mds.log will see osafntfd stuck in 1.5s to waiting for agent already down to send response message type. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3091 mds: Add more overload test cases for mdstest
- **status**: review --> fixed --- ** [tickets:#3091] mds: Add more overload test cases for mdstest** **Status:** fixed **Milestone:** 5.19.10 **Created:** Wed Sep 25, 2019 04:22 AM UTC by Minh Hon Chau **Last Updated:** Fri Sep 27, 2019 11:03 AM UTC **Owner:** Thuan Add more mdstest for ticket #1960. A suggestion: - mdstest for overload . 2 senders overload one receivers . one sender overloads 2 receivers - mdstest for sna . without overload, mds sender gradually sends more than 65535 messages, and receivers should receive them all . with overload, mds sender sends a burst of greater than 65535 messages, and receivers should receive them all - mdstest for #1960 backward compatibility, in order to test the txprob timer . sender enables, receiver disables . sender enables, receiver enables . sender disables, receiver enables ... --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3091 mds: Add more overload test cases for mdstest
- **status**: assigned --> review --- ** [tickets:#3091] mds: Add more overload test cases for mdstest** **Status:** review **Milestone:** 5.19.10 **Created:** Wed Sep 25, 2019 04:22 AM UTC by Minh Hon Chau **Last Updated:** Wed Sep 25, 2019 06:51 AM UTC **Owner:** Thuan Add more mdstest for ticket #1960. A suggestion: - mdstest for overload . 2 senders overload one receivers . one sender overloads 2 receivers - mdstest for sna . without overload, mds sender gradually sends more than 65535 messages, and receivers should receive them all . with overload, mds sender sends a burst of greater than 65535 messages, and receivers should receive them all - mdstest for #1960 backward compatibility, in order to test the txprob timer . sender enables, receiver disables . sender enables, receiver enables . sender disables, receiver enables ... --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3091 mds: Add more overload test cases for mdstest
- **status**: unassigned --> assigned - **assigned_to**: Thuan - **Part**: lib --> tests --- ** [tickets:#3091] mds: Add more overload test cases for mdstest** **Status:** assigned **Milestone:** 5.19.10 **Created:** Wed Sep 25, 2019 04:22 AM UTC by Minh Hon Chau **Last Updated:** Wed Sep 25, 2019 04:22 AM UTC **Owner:** Thuan Add more mdstest for ticket #1960. A suggestion: - mdstest for overload . 2 senders overload one receivers . one sender overloads 2 receivers - mdstest for sna . without overload, mds sender gradually sends more than 65535 messages, and receivers should receive them all . with overload, mds sender sends a burst of greater than 65535 messages, and receivers should receive them all - mdstest for #1960 backward compatibility, in order to test the txprob timer . sender enables, receiver disables . sender enables, receiver enables . sender disables, receiver enables ... --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3087 optimize mdstest suite 27
- **status**: review --> fixed --- ** [tickets:#3087] optimize mdstest suite 27** **Status:** fixed **Milestone:** 5.19.10 **Created:** Mon Sep 23, 2019 09:23 AM UTC by Thuan **Last Updated:** Tue Sep 24, 2019 08:36 AM UTC **Owner:** Thuan Current mdstest suite 27 (a part of #1960) allocate a 100MB message buffer to verify TIPC overload can work with #1960 solution. But test can be optimized to just allocate a small message buffer but still create TIPC overload scenario and verify messsage receive as expected. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3015 Amf: node can not join the cluster
- **status**: assigned --> review - **assigned_to**: Thang Duc Nguyen --> Thuan - **Type**: enhancement --> defect - **Priority**: major --> minor --- ** [tickets:#3015] Amf: node can not join the cluster** **Status:** review **Milestone:** 5.19.10 **Created:** Fri Mar 01, 2019 04:34 AM UTC by Thang Duc Nguyen **Last Updated:** Mon Jul 22, 2019 11:56 PM UTC **Owner:** Thuan When the pbe was hung on ACTIVE SC, a PL node start then stop then start at during that time. The AMF will be TIMEOUT when update runtime in the first start. After timeout, AMFD on ACTIVE will process event and it can process the events in the below order and it causes the PL can not join the cluster. - clm_track_cb was called to process the first node down event. - clm_track_cb was called to process the node up event. - avd_mds_avnd_down_evh was called to first amfnd down event -> it sets PL NOT a member of cluster. - So the PL was stucked with the below message *2019-02-26 14:11:36.879 SC-1 osafamfd[285]: NO Received nodeup from 2040f: msgid 1 2019-02-26 14:11:36.880 SC-1 osafamfd[285]: WA Not a Cluster Member dropping the msg 2019-02-26 14:11:37.985 SC-1 osafamfd[285]: NO Received nodeup from 2040f: msgid 1 2019-02-26 14:11:37.986 SC-1 osafamfd[285]: WA Not a Cluster Member dropping the msg 2019-02-26 14:11:39.079 SC-1 osafamfd[285]: NO Received nodeup from 2040f: msgid 1 2019-02-26 14:11:39.081 SC-1 osafamfd[285]: WA Not a Cluster Member dropping the msg* In this case, AMFD should ignore the AMFND down event if that node is absent. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3074 Add serial number arithmetic (RFC1982) to /base code
- **status**: assigned --> review --- ** [tickets:#3074] Add serial number arithmetic (RFC1982) to /base code** **Status:** review **Milestone:** 5.19.10 **Created:** Mon Aug 26, 2019 06:44 AM UTC by Thuan **Last Updated:** Mon Aug 26, 2019 06:44 AM UTC **Owner:** Thuan The sna should be supported in /base code for uint16_t, uint32_t, since the sequence number are being used in some other services. mds will adapt the sna 16bit for flow control from /base --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3074 Add serial number arithmetic (RFC1982) to /base code
--- ** [tickets:#3074] Add serial number arithmetic (RFC1982) to /base code** **Status:** assigned **Milestone:** 5.19.10 **Created:** Mon Aug 26, 2019 06:44 AM UTC by Thuan **Last Updated:** Mon Aug 26, 2019 06:44 AM UTC **Owner:** Thuan The sna should be supported in /base code for uint16_t, uint32_t, since the sequence number are being used in some other services. mds will adapt the sna 16bit for flow control from /base --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3070 mbc: some minor coding errors
- **status**: review --> fixed
---
** [tickets:#3070] mbc: some minor coding errors**
**Status:** fixed
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 10:10 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 10:18 AM UTC
**Owner:** Thuan
Some minor coding errors:
static const char *disc_trace[] = {"Peer UP msg", "Peer DOWN msg",
"Peer INFO msg", "Peer INFO resp msg",
"Peer Role change msg" ** // Missing comma
" , "**
"Invalid peer discovery msg"};
uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG \*arg)
uint32t mbcsv_process_chg_role_request(NCSMBCSVARG \*arg)
uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG \*arg)
~~~
if (NULL ==
(mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
TRACE_2("bad handle specified");
rc = SA_AIS_ERR_BAD_HANDLE;
// Should return here if not NULL pointer access in later code
}
m_NCS_LOCK(_reg->svc_lock, NCS_LOCK_READ);
TRACE("svc_id:%u, pwe_hdl:%u", mbc_reg->svc_id, ckpt_inst->pwe_hdl);
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3069 rde: misc-suspicious-missing-comma
- **status**: review --> fixed
---
** [tickets:#3069] rde: misc-suspicious-missing-comma**
**Status:** fixed
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 09:26 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 09:43 AM UTC
**Owner:** Thuan
const char *rde_msg_name[] = {"-",
"RDE_MSG_PEER_UP(1)",
"RDE_MSG_PEER_DOWN(2)",
"RDE_MSG_PEER_INFO_REQ(3)",
"RDE_MSG_PEER_INFO_RESP(4)",
"RDE_MSG_NEW_ACTIVE_CALLBACK(5)"//Missing " ,
" here
"RDE_MSG_NODE_UP(6)",
"RDE_MSG_NODE_DOWN(7)",
"RDE_MSG_TAKEOVER_REQUEST_CALLBACK(8)",
"RDE_MSG_ACTIVE_PROMOTION_SUCCESS(9)",
"RDE_MSG_CONTROLLER_UP(10)",
"RDE_MSG_CONTROLLER_DOWN(11)"};
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3070 mbc: some minor coding errors
- **status**: assigned --> review
---
** [tickets:#3070] mbc: some minor coding errors**
**Status:** review
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 10:10 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 10:17 AM UTC
**Owner:** Thuan
Some minor coding errors:
static const char *disc_trace[] = {"Peer UP msg", "Peer DOWN msg",
"Peer INFO msg", "Peer INFO resp msg",
"Peer Role change msg" ** // Missing comma
" , "**
"Invalid peer discovery msg"};
uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG \*arg)
uint32t mbcsv_process_chg_role_request(NCSMBCSVARG \*arg)
uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG \*arg)
~~~
if (NULL ==
(mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
TRACE_2("bad handle specified");
rc = SA_AIS_ERR_BAD_HANDLE;
// Should return here if not NULL pointer access in later code
}
m_NCS_LOCK(_reg->svc_lock, NCS_LOCK_READ);
TRACE("svc_id:%u, pwe_hdl:%u", mbc_reg->svc_id, ckpt_inst->pwe_hdl);
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3070 mbc: some minor coding errors
- Description has changed:
Diff:
--- old
+++ new
@@ -6,7 +6,7 @@
uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG \*arg)
-uint32t mbcsvprocesschgrolerequest(NCSMBCSVARG \*arg)
+uint32t mbcsv_process_chg_role_request(NCSMBCSVARG \*arg)
uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG \*arg)
~~~
if (NULL ==
---
** [tickets:#3070] mbc: some minor coding errors**
**Status:** assigned
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 10:10 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 10:10 AM UTC
**Owner:** Thuan
Some minor coding errors:
static const char *disc_trace[] = {"Peer UP msg", "Peer DOWN msg",
"Peer INFO msg", "Peer INFO resp msg",
"Peer Role change msg" ** // Missing comma
" , "**
"Invalid peer discovery msg"};
uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG \*arg)
uint32t mbcsv_process_chg_role_request(NCSMBCSVARG \*arg)
uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG \*arg)
~~~
if (NULL ==
(mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
TRACE_2("bad handle specified");
rc = SA_AIS_ERR_BAD_HANDLE;
// Should return here if not NULL pointer access in later code
}
m_NCS_LOCK(_reg->svc_lock, NCS_LOCK_READ);
TRACE("svc_id:%u, pwe_hdl:%u", mbc_reg->svc_id, ckpt_inst->pwe_hdl);
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3070 mbc: some minor coding errors
---
** [tickets:#3070] mbc: some minor coding errors**
**Status:** assigned
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 10:10 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 10:10 AM UTC
**Owner:** Thuan
Some minor coding errors:
static const char *disc_trace[] = {"Peer UP msg", "Peer DOWN msg",
"Peer INFO msg", "Peer INFO resp msg",
"Peer Role change msg" ** // Missing comma
" , "**
"Invalid peer discovery msg"};
uint32_t mbcsv_process_snd_ckpt_request(NCS_MBCSV_ARG \*arg)
uint32t mbcsvprocesschgrolerequest(NCSMBCSVARG \*arg)
uint32_t mbcsv_process_close_request(NCS_MBCSV_ARG \*arg)
~~~
if (NULL ==
(mbc_reg = (MBCSV_REG *)m_MBCSV_TAKE_HANDLE(arg->i_mbcsv_hdl))) {
TRACE_2("bad handle specified");
rc = SA_AIS_ERR_BAD_HANDLE;
// Should return here if not NULL pointer access in later code
}
m_NCS_LOCK(_reg->svc_lock, NCS_LOCK_READ);
TRACE("svc_id:%u, pwe_hdl:%u", mbc_reg->svc_id, ckpt_inst->pwe_hdl);
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3069 rde: misc-suspicious-missing-comma
---
** [tickets:#3069] rde: misc-suspicious-missing-comma**
**Status:** assigned
**Milestone:** 5.19.10
**Created:** Wed Aug 14, 2019 09:26 AM UTC by Thuan
**Last Updated:** Wed Aug 14, 2019 09:26 AM UTC
**Owner:** Thuan
const char *rde_msg_name[] = {"-",
"RDE_MSG_PEER_UP(1)",
"RDE_MSG_PEER_DOWN(2)",
"RDE_MSG_PEER_INFO_REQ(3)",
"RDE_MSG_PEER_INFO_RESP(4)",
"RDE_MSG_NEW_ACTIVE_CALLBACK(5)"//Missing " ,
" here
"RDE_MSG_NODE_UP(6)",
"RDE_MSG_NODE_DOWN(7)",
"RDE_MSG_TAKEOVER_REQUEST_CALLBACK(8)",
"RDE_MSG_ACTIVE_PROMOTION_SUCCESS(9)",
"RDE_MSG_CONTROLLER_UP(10)",
"RDE_MSG_CONTROLLER_DOWN(11)"};
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3020 amf: assign SI Active to a SU (2N) fail but not try for other SUs
- **status**: review --> fixed --- ** [tickets:#3020] amf: assign SI Active to a SU (2N) fail but not try for other SUs** **Status:** fixed **Milestone:** 5.19.10 **Created:** Mon Mar 18, 2019 07:32 AM UTC by Thuan **Last Updated:** Tue Jul 23, 2019 12:14 AM UTC **Owner:** Thuan No Active SI assignment in following scenario: 2N model 1. Lock then lock-in standby SU 2. Lock SI 3. Add new CSI-B, update old CSI-A to depend on new CSI-B 4. Unlock SI 5. Add new Comp-B for SU 6. Unlock-in then unlock SU Expect SU has new Comp can be assigned Active SI but no active SI assignment. Because current AMF only pick one in-service SU to assign Active SI then fail without trying for other SUs --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3059 mdstest: some test cases fail with tipc transportation
- **status**: review --> fixed --- ** [tickets:#3059] mdstest: some test cases fail with tipc transportation** **Status:** fixed **Milestone:** 5.19.10 **Created:** Tue Jul 16, 2019 09:35 AM UTC by Thuan **Last Updated:** Mon Jul 22, 2019 11:56 PM UTC **Owner:** Thuan **Attachments:** - [mds_13_12_err.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_err.log) (126.9 kB; application/octet-stream) - [mds_13_12_ok.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_ok.log) (143.9 kB; application/octet-stream) === Test failure log == Command: 'mdstest 13 12' rc: 255 - output: Suite 13: Direct Just Send test cases /ntet_initialise_setup: Get an ADEST handle,Create PWE=2 on ADEST,Install EXTMIN and INTMIN svc on ADEST,Install INTMIN,EXTMIN services on ADEST's PWE=2, Create VDEST 100 and VDEST 200,Change the role of VDEST 200 to ACTIVE, Install EXTMIN service on VDEST 100,Install INTMIN, EXTMIN services on VDEST 200 ADEST <2010f309e2a49 > : GET_HDLS is SUCCESSFUL 100 : VDEST_CREATE is SUCCESSFUL 200 : VDEST_CREATE is SUCCESSFUL VDEST_CHANGE ROLE to 1 is SUCCESSFULL PWE_CREATE is SUCCESSFUL : PWE = 2 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL MDS SERVICE SUBSCRIBE is SUCCESSFULL MDS RETRIEVE is SUCCESSFULL Test Case 12: While Await Active Timer ON: Direct send a Low Priority message to Svc EXTMIN on Vdest=200 VDEST_CHANGE ROLE to 2 is SUCCESSFULL Request to ncsmds_api: MDS DIRECT SEND has FAILED === Analysis == OK Flow //subcribe 512 up 512 (vdest=200) role active // user cb UP //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby // user cb NO_ACTIVE //send message: Destination is in await active mode so queuing in await active //Change vdest=200 Standby -> Active -- ERR Flow //subcribe 512 //Not yet up 512 (vdest=200) role active //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby //send message: Subscription Result not present => MDS_SND_RCV:Blocking send //fail with "Destination Route not found even after the DISCOVERY Timer timeout" //Change vdest=200 Standby -> Active === Solution == Add sleep(1) before change vdest role Active -> Standby/Quiesced Similar issue/solution for mdstest 13 13; 6 12; 6 13; 7 12; 7 13 --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3059 mdstest: some test cases fail with tipc transportation
- **status**: assigned --> review --- ** [tickets:#3059] mdstest: some test cases fail with tipc transportation** **Status:** review **Milestone:** 5.19.07 **Created:** Tue Jul 16, 2019 09:35 AM UTC by Thuan **Last Updated:** Tue Jul 16, 2019 09:37 AM UTC **Owner:** Thuan **Attachments:** - [mds_13_12_err.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_err.log) (126.9 kB; application/octet-stream) - [mds_13_12_ok.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_ok.log) (143.9 kB; application/octet-stream) === Test failure log == Command: 'mdstest 13 12' rc: 255 - output: Suite 13: Direct Just Send test cases /ntet_initialise_setup: Get an ADEST handle,Create PWE=2 on ADEST,Install EXTMIN and INTMIN svc on ADEST,Install INTMIN,EXTMIN services on ADEST's PWE=2, Create VDEST 100 and VDEST 200,Change the role of VDEST 200 to ACTIVE, Install EXTMIN service on VDEST 100,Install INTMIN, EXTMIN services on VDEST 200 ADEST <2010f309e2a49 > : GET_HDLS is SUCCESSFUL 100 : VDEST_CREATE is SUCCESSFUL 200 : VDEST_CREATE is SUCCESSFUL VDEST_CHANGE ROLE to 1 is SUCCESSFULL PWE_CREATE is SUCCESSFUL : PWE = 2 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL MDS SERVICE SUBSCRIBE is SUCCESSFULL MDS RETRIEVE is SUCCESSFULL Test Case 12: While Await Active Timer ON: Direct send a Low Priority message to Svc EXTMIN on Vdest=200 VDEST_CHANGE ROLE to 2 is SUCCESSFULL Request to ncsmds_api: MDS DIRECT SEND has FAILED === Analysis == OK Flow //subcribe 512 up 512 (vdest=200) role active // user cb UP //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby // user cb NO_ACTIVE //send message: Destination is in await active mode so queuing in await active //Change vdest=200 Standby -> Active -- ERR Flow //subcribe 512 //Not yet up 512 (vdest=200) role active //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby //send message: Subscription Result not present => MDS_SND_RCV:Blocking send //fail with "Destination Route not found even after the DISCOVERY Timer timeout" //Change vdest=200 Standby -> Active === Solution == Add sleep(1) before change vdest role Active -> Standby/Quiesced Similar issue/solution for mdstest 13 13; 6 12; 6 13; 7 12; 7 13 --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3059 mdstest: some test cases fail with tipc transportation
- Attachments has changed: Diff: --- old +++ new @@ -0,0 +1,2 @@ +mds_13_12_err.log (126.9 kB; application/octet-stream) +mds_13_12_ok.log (143.9 kB; application/octet-stream) - **Comment**: mds.log of OK and ERR case --- ** [tickets:#3059] mdstest: some test cases fail with tipc transportation** **Status:** assigned **Milestone:** 5.19.07 **Created:** Tue Jul 16, 2019 09:35 AM UTC by Thuan **Last Updated:** Tue Jul 16, 2019 09:35 AM UTC **Owner:** Thuan **Attachments:** - [mds_13_12_err.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_err.log) (126.9 kB; application/octet-stream) - [mds_13_12_ok.log](https://sourceforge.net/p/opensaf/tickets/3059/attachment/mds_13_12_ok.log) (143.9 kB; application/octet-stream) === Test failure log == Command: 'mdstest 13 12' rc: 255 - output: Suite 13: Direct Just Send test cases /ntet_initialise_setup: Get an ADEST handle,Create PWE=2 on ADEST,Install EXTMIN and INTMIN svc on ADEST,Install INTMIN,EXTMIN services on ADEST's PWE=2, Create VDEST 100 and VDEST 200,Change the role of VDEST 200 to ACTIVE, Install EXTMIN service on VDEST 100,Install INTMIN, EXTMIN services on VDEST 200 ADEST <2010f309e2a49 > : GET_HDLS is SUCCESSFUL 100 : VDEST_CREATE is SUCCESSFUL 200 : VDEST_CREATE is SUCCESSFUL VDEST_CHANGE ROLE to 1 is SUCCESSFULL PWE_CREATE is SUCCESSFUL : PWE = 2 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL MDS SERVICE SUBSCRIBE is SUCCESSFULL MDS RETRIEVE is SUCCESSFULL Test Case 12: While Await Active Timer ON: Direct send a Low Priority message to Svc EXTMIN on Vdest=200 VDEST_CHANGE ROLE to 2 is SUCCESSFULL Request to ncsmds_api: MDS DIRECT SEND has FAILED === Analysis == OK Flow //subcribe 512 up 512 (vdest=200) role active // user cb UP //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby // user cb NO_ACTIVE //send message: Destination is in await active mode so queuing in await active //Change vdest=200 Standby -> Active -- ERR Flow //subcribe 512 //Not yet up 512 (vdest=200) role active //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby //send message: Subscription Result not present => MDS_SND_RCV:Blocking send //fail with "Destination Route not found even after the DISCOVERY Timer timeout" //Change vdest=200 Standby -> Active === Solution == Add sleep(1) before change vdest role Active -> Standby/Quiesced Similar issue/solution for mdstest 13 13; 6 12; 6 13; 7 12; 7 13 --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3059 mdstest: some test cases fail with tipc transportation
--- ** [tickets:#3059] mdstest: some test cases fail with tipc transportation** **Status:** assigned **Milestone:** 5.19.07 **Created:** Tue Jul 16, 2019 09:35 AM UTC by Thuan **Last Updated:** Tue Jul 16, 2019 09:35 AM UTC **Owner:** Thuan === Test failure log == Command: 'mdstest 13 12' rc: 255 - output: Suite 13: Direct Just Send test cases /ntet_initialise_setup: Get an ADEST handle,Create PWE=2 on ADEST,Install EXTMIN and INTMIN svc on ADEST,Install INTMIN,EXTMIN services on ADEST's PWE=2, Create VDEST 100 and VDEST 200,Change the role of VDEST 200 to ACTIVE, Install EXTMIN service on VDEST 100,Install INTMIN, EXTMIN services on VDEST 200 ADEST <2010f309e2a49 > : GET_HDLS is SUCCESSFUL 100 : VDEST_CREATE is SUCCESSFUL 200 : VDEST_CREATE is SUCCESSFUL VDEST_CHANGE ROLE to 1 is SUCCESSFULL PWE_CREATE is SUCCESSFUL : PWE = 2 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL 256 : SERVICE INSTALL is SUCCESSFULL 512 : SERVICE INSTALL is SUCCESSFULL MDS SERVICE SUBSCRIBE is SUCCESSFULL MDS RETRIEVE is SUCCESSFULL Test Case 12: While Await Active Timer ON: Direct send a Low Priority message to Svc EXTMIN on Vdest=200 VDEST_CHANGE ROLE to 2 is SUCCESSFULL Request to ncsmds_api: MDS DIRECT SEND has FAILED === Analysis == OK Flow //subcribe 512 up 512 (vdest=200) role active // user cb UP //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby // user cb NO_ACTIVE //send message: Destination is in await active mode so queuing in await active //Change vdest=200 Standby -> Active -- ERR Flow //subcribe 512 //Not yet up 512 (vdest=200) role active //Change vdest=200 Active -> Standby up 512 (vdest=200) role standby //send message: Subscription Result not present => MDS_SND_RCV:Blocking send //fail with "Destination Route not found even after the DISCOVERY Timer timeout" //Change vdest=200 Standby -> Active === Solution == Add sleep(1) before change vdest role Active -> Standby/Quiesced Similar issue/solution for mdstest 13 13; 6 12; 6 13; 7 12; 7 13 --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #1042 LOG: out of control file descriptor of log file cause .nfs file generate when log file deleted by rotation mechanism
- Description has changed:
Diff:
--- old
+++ new
@@ -71,11 +71,11 @@
Here is the log:
Aug 22 7:43:05.038105 osaflogd [4110:lgs_stream.c:0740] >> log_file_open
-Aug 22 7:43:05.038111 osaflogd [4110:lgs_stream.c:0750] TR log_file_open -
Opening file
"/storage/no-backup/coremw/var/log/saflog/test/test_20140822_074304.log"
+Aug 22 7:43:05.038111 osaflogd [4110:lgs_stream.c:0750] TR log_file_open -
Opening file
"/storage/no-backup/xxx/var/log/saflog/test/test_20140822_074304.log"
Aug 22 7:43:05.038116 osaflogd [4110:lgs_stream.c:0063] >> fileopen_h
-Aug 22 7:43:05.038121 osaflogd [4110:lgs_stream.c:0074] TR fileopen_h -
filepath
"/storage/no-backup/coremw/var/log/saflog/test/test_20140822_074304.log"
+Aug 22 7:43:05.038121 osaflogd [4110:lgs_stream.c:0074] TR fileopen_h -
filepath "/storage/no-backup/xxx/var/log/saflog/test/test_20140822_074304.log"
Aug 22 7:43:05.038393 osaflogd [4110:lgs_filehdl.c:0448] >> fileopen_hdl
-Aug 22 7:43:05.038417 osaflogd [4110:lgs_filehdl.c:0450] TR fileopen_hdl -
filepath
"/storage/no-backup/coremw/var/log/saflog/test/test_20140822_074304.log"
+Aug 22 7:43:05.038417 osaflogd [4110:lgs_filehdl.c:0450] TR fileopen_hdl -
filepath "/storage/no-backup/xxx/var/log/saflog/test/test_20140822_074304.log"
…
Aug 22 7:43:05.539345 osaflogd [4110:lgs_file.c:0342] TR Timed out before
answer
Aug 22 7:43:05.558948 osaflogd [4110:lgs_stream.c:0085] TR fileopen_h - API
error LGSF_TIMEOUT
- **Blocker**: --> False
---
** [tickets:#1042] LOG: out of control file descriptor of log file cause .nfs
file generate when log file deleted by rotation mechanism**
**Status:** fixed
**Milestone:** 4.4.1
**Created:** Thu Sep 04, 2014 02:30 AM UTC by Thuan
**Last Updated:** Thu Sep 25, 2014 06:51 AM UTC
**Owner:** elunlen
Out of control of file descriptor in LOG service cause many .nfs file generate.
The problem can be reproduced by following steps:
(1) Make a sample to writing log to one log stream.
(2) Execute sample until saLogStreamNumOpeners > 100
(3) Check the applog folder, some .nfs files exist in applog folder, not
frequently happen
Base on my LOG trace, the problem may cause by closing file unsuccessfully but
no checking return code. Here is the log:
Aug 21 6:10:35.015781 osaflogd [4384:lgs_file.c:0287] TR log_file_api -
LGSF_BUSY
Aug 21 6:10:35.015786 osaflogd [4384:lgs_stream.c:1233] TR log_stream_write_h
- API error LGSF_BUSY
Aug 21 6:10:35.015794 osaflogd [4384:lgs_stream.c:1247] IN write
'test_20140821_061033' failed "Success"
Aug 21 6:10:35.015799 osaflogd [4384:lgs_stream.c:0108] >> fileclose_h: fd=27
Aug 21 6:10:35.015902 osaflogd [4384:lgs_file.c:0287] TR log_file_api -
LGSF_BUSY
Aug 21 6:10:35.015914 osaflogd [4384:lgs_stream.c:0119] TR fileclose_h - API
error LGSF_BUSY
Aug 21 6:10:35.015919 osaflogd [4384:lgs_stream.c:0125] << fileclose_h: rc = -1
Aug 21 6:10:35.015924 osaflogd [4384:lgs_stream.c:1275] << log_stream_write_h:
rc=-1
…
Aug 21 6:10:35.016280 osaflogd [4384:lgs_stream.c:1188] >> log_stream_write_h:
safLgStr=testLogStream1,safApp=safLogService
Aug 21 6:10:35.016285 osaflogd [4384:lgs_stream.c:0293] >>
log_initiate_stream_files
Here is the code of log_stream_write_h() function:
if (*stream->p_fd == -1) {
/* Create directory and log files if they were not created at
* stream open or reopen files if bad file descriptor.
*/
log_initiate_stream_files(stream);
…
if ((rc == -1) || (rc == -2)) {
/* If writing failed always invalidate the stream file
descriptor.
*/
/* Careful with log level here to avoid syslog flooding */
LOG_IN("write '%s' failed \"%s\"", stream->logFileCurrent,
strerror(write_errno));
if (*stream->p_fd != -1) {
/* Try to close the file and invalidate the stream fd */
fileclose_h(*stream->p_fd); //===>No check return code
*stream->p_fd = -1;
}
…
So, there is one file descriptor is opened out of control of LOG service.
If LOG service open log file with new fd, when log file rotate mechanism delete
it, .nfs file generated.
I also found .nfs file with size < max size. Because file rename done, then
open new log file time out, actually success, but variable "curFileSize" is not
reset. In next write, log file is open again (2nd fd), will close after 1st
write due to "curFileSize" > max file size. This small log file will become
.nfs when rotation mechanism delete it. So, I think the variable "curFileSize"
should reset 0 after rename succeed and consider about open file api. Here is
the code:
/* Close current log file */
if ((rc = fileclose_h(*stream->p_fd)) == -1) {
LOG_IN("close FAILED: %s", strerror(errno));
[tickets] [opensaf:tickets] #3047 amf: SU get stuck in INSTANTIATING presence state
- **status**: review --> fixed - **Comment**: commit a6cc79cb3f9f5ba530eb2ae4cd7136da82e66e21 Author: thuan.tran Date: Mon Jun 24 10:21:56 2019 +1000 amf: fix SU get stuck in INSTANTIATING presence state [#3047] COMP restart recovery during SU restart recovery can lead to SU stuck in INSTANTIATING without further action. Because COMP instaniated event in RESTARTING does not trigger avnd_su_pres_fsm_run(). --- ** [tickets:#3047] amf: SU get stuck in INSTANTIATING presence state** **Status:** fixed **Milestone:** 5.19.06 **Created:** Fri May 31, 2019 10:41 AM UTC by Thuan **Last Updated:** Mon Jun 03, 2019 07:11 AM UTC **Owner:** Thuan The fix of #3011 is not completed. Scenario: 2N SU, each SU has COMP1, COMP2, COMP3 During any one SU restart recovery: COMP1, COMP2 instantiated and COMP3 still instantiating. COMP1, COMP2 crash then component restart recovery happen. Without fix #3011: COMP1, COMP2 is stuck in RESTARTING without further recovery action. With fix #3011: COMP1, COMP2 recovery but: + If COMP1, COMP2 recovery (instantiated) before COMP3 instantiated, SU move to instantiated and HA assignment proceed. + If COMP1, COMP2 recovery (instantiated) after COMP3 instantiated, SU get stuck in INSTANTIATING and no HA assignment. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3047 amf: SU get stuck in INSTANTIATING presence state
- **status**: assigned --> review --- ** [tickets:#3047] amf: SU get stuck in INSTANTIATING presence state** **Status:** review **Milestone:** 5.19.06 **Created:** Fri May 31, 2019 10:41 AM UTC by Thuan **Last Updated:** Fri May 31, 2019 10:41 AM UTC **Owner:** Thuan The fix of #3011 is not completed. Scenario: 2N SU, each SU has COMP1, COMP2, COMP3 During any one SU restart recovery: COMP1, COMP2 instantiated and COMP3 still instantiating. COMP1, COMP2 crash then component restart recovery happen. Without fix #3011: COMP1, COMP2 is stuck in RESTARTING without further recovery action. With fix #3011: COMP1, COMP2 recovery but: + If COMP1, COMP2 recovery (instantiated) before COMP3 instantiated, SU move to instantiated and HA assignment proceed. + If COMP1, COMP2 recovery (instantiated) after COMP3 instantiated, SU get stuck in INSTANTIATING and no HA assignment. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3047 amf: SU get stuck in INSTANTIATING presence state
--- ** [tickets:#3047] amf: SU get stuck in INSTANTIATING presence state** **Status:** assigned **Milestone:** 5.19.06 **Created:** Fri May 31, 2019 10:41 AM UTC by Thuan **Last Updated:** Fri May 31, 2019 10:41 AM UTC **Owner:** Thuan The fix of #3011 is not completed. Scenario: 2N SU, each SU has COMP1, COMP2, COMP3 During any one SU restart recovery: COMP1, COMP2 instantiated and COMP3 still instantiating. COMP1, COMP2 crash then component restart recovery happen. Without fix #3011: COMP1, COMP2 is stuck in RESTARTING without further recovery action. With fix #3011: COMP1, COMP2 recovery but: + If COMP1, COMP2 recovery (instantiated) before COMP3 instantiated, SU move to instantiated and HA assignment proceed. + If COMP1, COMP2 recovery (instantiated) after COMP3 instantiated, SU get stuck in INSTANTIATING and no HA assignment. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3032 amf: sample build failure
- **status**: review --> fixed --- ** [tickets:#3032] amf: sample build failure** **Status:** fixed **Milestone:** 5.19.06 **Created:** Thu Apr 18, 2019 06:41 AM UTC by Thuan **Last Updated:** Thu Apr 18, 2019 07:06 AM UTC **Owner:** Thuan Incorrect file name in samples/amf/containter/Makefile.am Proposal fix ~~~ diff --git a/samples/amf/container/Makefile.am b/samples/amf/container/Makefile.am index 299a947..dc09721 100644 --- a/samples/amf/container/Makefile.am +++ b/samples/amf/container/Makefile.am @@ -19,7 +19,7 @@ include $(top_srcdir)/Makefile.common MAINTAINERCLEANFILES = Makefile.in EXTRA_DIST = \ - amf_container_demo_script \ + amf_container_script \ AppConfig-container.xml \ AppConfig-contained-2N.xml \ README @@ -31,7 +31,7 @@ amf_container_demo_CPPFLAGS = \ $(AM_CPPFLAGS) amf_container_demo_SOURCES = \ - amf_container_demo.c + amf_container.c amf_container_demo_LDADD = \ @SAF_AIS_AMF_LIBS@ ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3032 amf: sample build failure
- **status**: fixed --> review --- ** [tickets:#3032] amf: sample build failure** **Status:** review **Milestone:** 5.19.06 **Created:** Thu Apr 18, 2019 06:41 AM UTC by Thuan **Last Updated:** Thu Apr 18, 2019 07:05 AM UTC **Owner:** Thuan Incorrect file name in samples/amf/containter/Makefile.am Proposal fix ~~~ diff --git a/samples/amf/container/Makefile.am b/samples/amf/container/Makefile.am index 299a947..dc09721 100644 --- a/samples/amf/container/Makefile.am +++ b/samples/amf/container/Makefile.am @@ -19,7 +19,7 @@ include $(top_srcdir)/Makefile.common MAINTAINERCLEANFILES = Makefile.in EXTRA_DIST = \ - amf_container_demo_script \ + amf_container_script \ AppConfig-container.xml \ AppConfig-contained-2N.xml \ README @@ -31,7 +31,7 @@ amf_container_demo_CPPFLAGS = \ $(AM_CPPFLAGS) amf_container_demo_SOURCES = \ - amf_container_demo.c + amf_container.c amf_container_demo_LDADD = \ @SAF_AIS_AMF_LIBS@ ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3032 amf: sample build failure
- **status**: unassigned --> fixed --- ** [tickets:#3032] amf: sample build failure** **Status:** fixed **Milestone:** 5.19.06 **Created:** Thu Apr 18, 2019 06:41 AM UTC by Thuan **Last Updated:** Thu Apr 18, 2019 06:41 AM UTC **Owner:** Thuan Incorrect file name in samples/amf/containter/Makefile.am Proposal fix ~~~ diff --git a/samples/amf/container/Makefile.am b/samples/amf/container/Makefile.am index 299a947..dc09721 100644 --- a/samples/amf/container/Makefile.am +++ b/samples/amf/container/Makefile.am @@ -19,7 +19,7 @@ include $(top_srcdir)/Makefile.common MAINTAINERCLEANFILES = Makefile.in EXTRA_DIST = \ - amf_container_demo_script \ + amf_container_script \ AppConfig-container.xml \ AppConfig-contained-2N.xml \ README @@ -31,7 +31,7 @@ amf_container_demo_CPPFLAGS = \ $(AM_CPPFLAGS) amf_container_demo_SOURCES = \ - amf_container_demo.c + amf_container.c amf_container_demo_LDADD = \ @SAF_AIS_AMF_LIBS@ ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3032 amf: sample build failure
--- ** [tickets:#3032] amf: sample build failure** **Status:** unassigned **Milestone:** 5.19.06 **Created:** Thu Apr 18, 2019 06:41 AM UTC by Thuan **Last Updated:** Thu Apr 18, 2019 06:41 AM UTC **Owner:** Thuan Incorrect file name in samples/amf/containter/Makefile.am Proposal fix ~~~ diff --git a/samples/amf/container/Makefile.am b/samples/amf/container/Makefile.am index 299a947..dc09721 100644 --- a/samples/amf/container/Makefile.am +++ b/samples/amf/container/Makefile.am @@ -19,7 +19,7 @@ include $(top_srcdir)/Makefile.common MAINTAINERCLEANFILES = Makefile.in EXTRA_DIST = \ - amf_container_demo_script \ + amf_container_script \ AppConfig-container.xml \ AppConfig-contained-2N.xml \ README @@ -31,7 +31,7 @@ amf_container_demo_CPPFLAGS = \ $(AM_CPPFLAGS) amf_container_demo_SOURCES = \ - amf_container_demo.c + amf_container.c amf_container_demo_LDADD = \ @SAF_AIS_AMF_LIBS@ ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3011 amf: comp stuck in RESTARTING presence state
- **status**: review --> fixed
- **Comment**:
commit bac9c3f53f32e12dce0bfc1aa792a844fa8b4f19
Author: thuan.tran
Date: Wed Mar 6 14:59:56 2019 +1100
amf: fix Comp stuck in RESTARTING presence state [#3011]
During SU (many COMPs) restart recovery, if any COMP finish instantiated
then crash while other COMPs are still instantiating, AMF recovery it by
restarting but AMF only cleanup without re-instantiation because AMF see
the COMP is not eligible for instantiation. The error COMP is stuck in
RESTARTING without further action from AMF.
AMF should allow COMP re-instantiation if SU state is INSTANTIATING and
error COMP state is RESTARTING.
---
** [tickets:#3011] amf: comp stuck in RESTARTING presence state**
**Status:** fixed
**Milestone:** 5.19.03
**Created:** Mon Feb 25, 2019 02:41 AM UTC by Thuan
**Last Updated:** Mon Feb 25, 2019 03:13 AM UTC
**Owner:** Thuan
When a SU (has many comp) is instantatiating for SU restart recovery, some comp
are instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them are not eligible for
instantiation.
~~~
if (isRestartSet(comp->su)) { // SU is restarting (RESTART admin op or
// recovery policy).
if (isFailed(comp->su)) { // SU is failed (case surestart recovery).
/*During surestart recovery, after cleanup of all components, amfnd
starts
instantiation of components. A component may fault at this stage. Such
a
component is eligible for instantiation.*/
if ((comp->pres == SA_AMF_PRESENCE_INSTANTIATING) &&
(comp->su->pres ==
SA_AMF_PRESENCE_INSTANTIATING))
return true;
~~~
These comp are stuck in RESTATING presence state without further action from
AMF.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3011 amf: comp stuck in RESTARTING presence state
- **status**: assigned --> review
---
** [tickets:#3011] amf: comp stuck in RESTARTING presence state**
**Status:** review
**Milestone:** 5.19.03
**Created:** Mon Feb 25, 2019 02:41 AM UTC by Thuan
**Last Updated:** Mon Feb 25, 2019 02:51 AM UTC
**Owner:** Thuan
When a SU (has many comp) is instantatiating for SU restart recovery, some comp
are instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them are not eligible for
instantiation.
~~~
if (isRestartSet(comp->su)) { // SU is restarting (RESTART admin op or
// recovery policy).
if (isFailed(comp->su)) { // SU is failed (case surestart recovery).
/*During surestart recovery, after cleanup of all components, amfnd
starts
instantiation of components. A component may fault at this stage. Such
a
component is eligible for instantiation.*/
if ((comp->pres == SA_AMF_PRESENCE_INSTANTIATING) &&
(comp->su->pres ==
SA_AMF_PRESENCE_INSTANTIATING))
return true;
~~~
These comp are stuck in RESTATING presence state without further action from
AMF.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3011 amf: comp stuck in RESTARTING presence state
- Description has changed:
Diff:
--- old
+++ new
@@ -1,4 +1,4 @@
-When a SU (has many comp) is instantatiating for SU restart recovery, some
comp is instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them is not eligible for
instantiation.
+When a SU (has many comp) is instantatiating for SU restart recovery, some
comp are instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them are not eligible for
instantiation.
~~~
if (isRestartSet(comp->su)) { // SU is restarting (RESTART admin op or
// recovery policy).
@@ -11,4 +11,4 @@
return true;
~~~
-These comp is stuck in RESTATING presence state without further action from
AMF.
+These comp are stuck in RESTATING presence state without further action from
AMF.
---
** [tickets:#3011] amf: comp stuck in RESTARTING presence state**
**Status:** assigned
**Milestone:** 5.19.03
**Created:** Mon Feb 25, 2019 02:41 AM UTC by Thuan
**Last Updated:** Mon Feb 25, 2019 02:41 AM UTC
**Owner:** Thuan
When a SU (has many comp) is instantatiating for SU restart recovery, some comp
are instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them are not eligible for
instantiation.
~~~
if (isRestartSet(comp->su)) { // SU is restarting (RESTART admin op or
// recovery policy).
if (isFailed(comp->su)) { // SU is failed (case surestart recovery).
/*During surestart recovery, after cleanup of all components, amfnd
starts
instantiation of components. A component may fault at this stage. Such
a
component is eligible for instantiation.*/
if ((comp->pres == SA_AMF_PRESENCE_INSTANTIATING) &&
(comp->su->pres ==
SA_AMF_PRESENCE_INSTANTIATING))
return true;
~~~
These comp are stuck in RESTATING presence state without further action from
AMF.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #3011 amf: comp stuck in RESTARTING presence state
---
** [tickets:#3011] amf: comp stuck in RESTARTING presence state**
**Status:** assigned
**Milestone:** 5.19.03
**Created:** Mon Feb 25, 2019 02:41 AM UTC by Thuan
**Last Updated:** Mon Feb 25, 2019 02:41 AM UTC
**Owner:** Thuan
When a SU (has many comp) is instantatiating for SU restart recovery, some comp
is instantiated then crash, AMF recovery them by restarting but AMF only
cleanup without re-instantiation them because AMF see them is not eligible for
instantiation.
~~~
if (isRestartSet(comp->su)) { // SU is restarting (RESTART admin op or
// recovery policy).
if (isFailed(comp->su)) { // SU is failed (case surestart recovery).
/*During surestart recovery, after cleanup of all components, amfnd
starts
instantiation of components. A component may fault at this stage. Such
a
component is eligible for instantiation.*/
if ((comp->pres == SA_AMF_PRESENCE_INSTANTIATING) &&
(comp->su->pres ==
SA_AMF_PRESENCE_INSTANTIATING))
return true;
~~~
These comp is stuck in RESTATING presence state without further action from AMF.
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2983 tests: test.sh should checkout release tag of googletest for stable
- **status**: review --> fixed - **Comment**: commit c68d843d99087cebe15c9c67f46b9045fb753059 Author: thuan.tran Date: Wed Dec 12 14:17:11 2018 +0700 tests: test.sh should checkout release tag of googletest for stable [#2983] --- ** [tickets:#2983] tests: test.sh should checkout release tag of googletest for stable** **Status:** fixed **Milestone:** 5.19.03 **Created:** Wed Dec 12, 2018 07:15 AM UTC by Thuan **Last Updated:** Wed Jan 09, 2019 09:26 PM UTC **Owner:** Thuan Currently, test.sh fetch the latest commit of googletest on github to build which is not so stable. It should use the stable or release tagged commit to build instead. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2983 tests: test.sh should checkout release tag of googletest for stable
- **status**: assigned --> review --- ** [tickets:#2983] tests: test.sh should checkout release tag of googletest for stable** **Status:** review **Milestone:** 5.18.12 **Created:** Wed Dec 12, 2018 07:15 AM UTC by Thuan **Last Updated:** Wed Dec 12, 2018 07:15 AM UTC **Owner:** Thuan Currently, test.sh fetch the latest commit of googletest on github to build which is not so stable. It should use the stable or release tagged commit to build instead. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2983 tests: test.sh should checkout release tag of googletest for stable
--- ** [tickets:#2983] tests: test.sh should checkout release tag of googletest for stable** **Status:** assigned **Milestone:** 5.18.12 **Created:** Wed Dec 12, 2018 07:15 AM UTC by Thuan **Last Updated:** Wed Dec 12, 2018 07:15 AM UTC **Owner:** Thuan Currently, test.sh fetch the latest commit of googletest on github to build which is not so stable. It should use the stable or release tagged commit to build instead. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2978 mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport
- Attachments has changed: Diff: --- old +++ new @@ -0,0 +1,2 @@ +mds.log.err (4.7 MB; application/octet-stream) +mds.log.ok (1.9 MB; application/octet-stream) --- ** [tickets:#2978] mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport** **Status:** review **Milestone:** 5.18.12 **Created:** Thu Nov 29, 2018 08:22 AM UTC by Thuan **Last Updated:** Fri Nov 30, 2018 02:16 AM UTC **Owner:** Thuan **Attachments:** - [mds.log.err](https://sourceforge.net/p/opensaf/tickets/2978/attachment/mds.log.err) (4.7 MB; application/octet-stream) - [mds.log.ok](https://sourceforge.net/p/opensaf/tickets/2978/attachment/mds.log.ok) (1.9 MB; application/octet-stream) MDS TEST Suite 4 test 11 (tet_svc_subscr_VDEST_11) sometimes fail with TIPC transport Test failure log (added some debug log) Subscribing for the services MDS SERVICE SUBSCRIBE is SUCCESSFULL Changing the role of vdest to active VDEST_CHANGE ROLE to 1 is SUCCESSFULL Retrieving the events The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 600 with svc pvt ver = 1 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f The Subscriber Service id = 500 is on ADEST NO ACTIVE: Received NO ACTIVE Event In the system no active instance of Subscribed srv= 600 with svc pvt ver = 1 on dest= <3e9> found The Subscriber Service id = 500 is on ADEST DOWN: Subscribed Svc = 600 with svc pvt ver = 1 is DOWN on dest= <3e9> anchor= <0> role= 2 with PWE id = 1 on node = 0 The Subscriber Service id = 500 is on ADEST NEW ACTIVE: Received NEW_ACTIVE Event In the system atleast one active instance of Subscribed service = 600 with svc pvt ver = 1 on destinatin = <3e9> found The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 700 with svc pvt ver = 2 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f MDS RETRIEVE is SUCCESSFULL Verifying for the versions for UP event gl_tet_adest.svc[0].svc_id=500 subscr_count=2 svcevt[0].svc_id=600 .event=2 .rem_svc_pvt_ver=1 False: req_svc_id=600, change=3, svc_pvt_ver=1 // expect UP but got NEW ACTIVE svcevt[1].svc_id=700 .event=3 .rem_svc_pvt_ver=2 Fail Analysis ERR flow subscribe then change vdest to active up 600 role active // user cb UP up 600 role standby // user cb NO_ACTIVE up 700 role standby down 600 role standby // user cb DOWN up 600 role active // user cb NEW_ACTIVE up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) - 600: UP -> NO_ACTIVE -> DOWN -> NEW_ACTIVE (but test expect UP) 700: UP (same test expect) OK flow -- 500 subscribe 600,700 up 600 role standby up 700 role standby (add sleep 1s before) change vdest to active up 600 role active // user cb UP down 600 role standby // skip as ROLE MISMATCH up 600 role active // Discard (Duplicate) up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) 600: UP (same test expect) 700: UP (same test expect) The problem is TIPC published event received is not as order MDS service install service 600 got published role active before role standby even install role standby before role active. The simplest and safe solution is add sleep 1s before change vdest role active. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2978 mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport
- **status**: assigned --> review --- ** [tickets:#2978] mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport** **Status:** review **Milestone:** 5.18.12 **Created:** Thu Nov 29, 2018 08:22 AM UTC by Thuan **Last Updated:** Thu Nov 29, 2018 08:22 AM UTC **Owner:** Thuan MDS TEST Suite 4 test 11 (tet_svc_subscr_VDEST_11) sometimes fail with TIPC transport Test failure log (added some debug log) Subscribing for the services MDS SERVICE SUBSCRIBE is SUCCESSFULL Changing the role of vdest to active VDEST_CHANGE ROLE to 1 is SUCCESSFULL Retrieving the events The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 600 with svc pvt ver = 1 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f The Subscriber Service id = 500 is on ADEST NO ACTIVE: Received NO ACTIVE Event In the system no active instance of Subscribed srv= 600 with svc pvt ver = 1 on dest= <3e9> found The Subscriber Service id = 500 is on ADEST DOWN: Subscribed Svc = 600 with svc pvt ver = 1 is DOWN on dest= <3e9> anchor= <0> role= 2 with PWE id = 1 on node = 0 The Subscriber Service id = 500 is on ADEST NEW ACTIVE: Received NEW_ACTIVE Event In the system atleast one active instance of Subscribed service = 600 with svc pvt ver = 1 on destinatin = <3e9> found The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 700 with svc pvt ver = 2 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f MDS RETRIEVE is SUCCESSFULL Verifying for the versions for UP event gl_tet_adest.svc[0].svc_id=500 subscr_count=2 svcevt[0].svc_id=600 .event=2 .rem_svc_pvt_ver=1 False: req_svc_id=600, change=3, svc_pvt_ver=1 // expect UP but got NEW ACTIVE svcevt[1].svc_id=700 .event=3 .rem_svc_pvt_ver=2 Fail Analysis ERR flow subscribe then change vdest to active up 600 role active // user cb UP up 600 role standby // user cb NO_ACTIVE up 700 role standby down 600 role standby // user cb DOWN up 600 role active // user cb NEW_ACTIVE up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) - 600: UP -> NO_ACTIVE -> DOWN -> NEW_ACTIVE (but test expect UP) 700: UP (same test expect) OK flow -- 500 subscribe 600,700 up 600 role standby up 700 role standby (add sleep 1s before) change vdest to active up 600 role active // user cb UP down 600 role standby // skip as ROLE MISMATCH up 600 role active // Discard (Duplicate) up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) 600: UP (same test expect) 700: UP (same test expect) The problem is TIPC published event received is not as order MDS service install service 600 got published role active before role standby even install role standby before role active. The simplest and safe solution is add sleep 1s before change vdest role active. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2978 mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport
--- ** [tickets:#2978] mdstest: tet_svc_subscr_VDEST_11() sometimes fail with TIPC transport** **Status:** assigned **Milestone:** 5.18.12 **Created:** Thu Nov 29, 2018 08:22 AM UTC by Thuan **Last Updated:** Thu Nov 29, 2018 08:22 AM UTC **Owner:** Thuan MDS TEST Suite 4 test 11 (tet_svc_subscr_VDEST_11) sometimes fail with TIPC transport Test failure log (added some debug log) Subscribing for the services MDS SERVICE SUBSCRIBE is SUCCESSFULL Changing the role of vdest to active VDEST_CHANGE ROLE to 1 is SUCCESSFULL Retrieving the events The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 600 with svc pvt ver = 1 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f The Subscriber Service id = 500 is on ADEST NO ACTIVE: Received NO ACTIVE Event In the system no active instance of Subscribed srv= 600 with svc pvt ver = 1 on dest= <3e9> found The Subscriber Service id = 500 is on ADEST DOWN: Subscribed Svc = 600 with svc pvt ver = 1 is DOWN on dest= <3e9> anchor= <0> role= 2 with PWE id = 1 on node = 0 The Subscriber Service id = 500 is on ADEST NEW ACTIVE: Received NEW_ACTIVE Event In the system atleast one active instance of Subscribed service = 600 with svc pvt ver = 1 on destinatin = <3e9> found The Subscriber Service id = 500 is on ADEST UP: Subscribed Svc = 700 with svc pvt ver = 2 is UP on dest= <3e9> anchor= <0> role= 1 with PWE id = 1 on node = 2010f MDS RETRIEVE is SUCCESSFULL Verifying for the versions for UP event gl_tet_adest.svc[0].svc_id=500 subscr_count=2 svcevt[0].svc_id=600 .event=2 .rem_svc_pvt_ver=1 False: req_svc_id=600, change=3, svc_pvt_ver=1 // expect UP but got NEW ACTIVE svcevt[1].svc_id=700 .event=3 .rem_svc_pvt_ver=2 Fail Analysis ERR flow subscribe then change vdest to active up 600 role active // user cb UP up 600 role standby // user cb NO_ACTIVE up 700 role standby down 600 role standby // user cb DOWN up 600 role active // user cb NEW_ACTIVE up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) - 600: UP -> NO_ACTIVE -> DOWN -> NEW_ACTIVE (but test expect UP) 700: UP (same test expect) OK flow -- 500 subscribe 600,700 up 600 role standby up 700 role standby (add sleep 1s before) change vdest to active up 600 role active // user cb UP down 600 role standby // skip as ROLE MISMATCH up 600 role active // Discard (Duplicate) up 700 role active // user cb UP down 700 role standby // Discard (ROLE MISMATCH) up 700 role active // Discard (Duplicate) 600: UP (same test expect) 700: UP (same test expect) The problem is TIPC published event received is not as order MDS service install service 600 got published role active before role standby even install role standby before role active. The simplest and safe solution is add sleep 1s before change vdest role active. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2972 amfd: unsafe access to cb
- **status**: fixed --> review --- ** [tickets:#2972] amfd: unsafe access to cb** **Status:** review **Milestone:** 5.18.12 **Created:** Fri Nov 23, 2018 07:23 AM UTC by Gary Lee **Last Updated:** Mon Nov 26, 2018 02:57 AM UTC **Owner:** Thuan The fix for [#2949] seems to have issues. It calls avd_check_nodes_after_reinit_imm() which can modify variables in cb outside the main thread. We should call avd_check_nodes_after_reinit_imm() after getting AVD_IMM_REINITIALIZED in the main thread. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2971 amf: standby amfd crash during failover to become active
- Description has changed: Diff: --- old +++ new @@ -1,5 +1,4 @@ PL-9 was deleted from cluster, but somehow standby amfd still keep the node. -The most possible reason is that standby amfd miss node delete apply callback by somehow. Then when failover happen, standby amfd crash as following: ~~~ Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active @@ -8,3 +7,23 @@ Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'PL-9' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: src/amf/amfd/sgproc.cc:2187: avd_node_down_mw_susi_failover: Assertion 'avnd->list_of_ncs_su.empty() != true' failed. ~~~ +The root cause is amfnd down on SC-2 vs checkpoint from SC-1 +~~~ +<143>1 2018-11-24T14:43:17.870243+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7238"] 261:amf/amfd/ndfsm.cc:779 >> avd_mds_avnd_down_evh: 2050f, 0x563eacfe3b50 +<143>1 2018-11-24T14:43:17.870254+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7239"] 261:amf/amfd/ndfsm.cc:853 << avd_mds_avnd_down_evh + +<143>1 2018-11-24T14:43:17.874433+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22818"] 285:amf/amfd/ndfsm.cc:779 >> avd_mds_avnd_down_evh: 2050f, 0x5601d0d9cb90 +<143>1 2018-11-24T14:43:17.874439+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22819"] 285:amf/amfd/ndproc.cc:1235 >> avd_node_failover: 'safAmfNode=PL-5,safAmfCluster=myAmfCluster' +<143>1 2018-11-24T14:43:17.874443+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22820"] 285:amf/amfd/ndfsm.cc:1149 >> avd_node_mark_absent + +<141>1 2018-11-24T14:43:17.88228+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22908"] 285:amf/amfd/ndfsm.cc:1154 NO Node 'PL-5' left the cluster +<143>1 2018-11-24T14:43:17.882284+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22909"] 285:mbc/mbcsv_api.c:798 >> mbcsv_process_snd_ckpt_request: Sending checkpoint data to all STANDBY peers, as per the send-type specified + +<143>1 2018-11-24T14:43:17.882637+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22943"] 285:amf/amfd/ndfsm.cc:1168 << avd_node_mark_absent + +<143>1 2018-11-24T14:43:17.900529+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7564"] 261:amf/amfd/ckpt_updt.cc:49 >> avd_ckpt_node: update - 'safAmfNode=PL-5,safAmfCluster=myAmfCluster' +<143>1 2018-11-24T14:43:17.900575+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7577"] 261:amf/amfd/ckpt_updt.cc:78 << avd_ckpt_node: 1 + +<143>1 2018-11-24T14:43:39.417927+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="8716"] 261:amf/amfd/node.cc:500 >> node_ccb_completed_delete_hdlr: 'safAmfNode=PL-5,safAmfCluster=myAmfCluster' +<143>1 2018-11-24T14:43:39.417932+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="8717"] 261:amf/amfd/imm.cc:2306 TR Node 'safAmfNode=PL-5,safAmfCluster=myAmfCluster' is still cluster member +~~~ --- ** [tickets:#2971] amf: standby amfd crash during failover to become active** **Status:** accepted **Milestone:** 5.18.12 **Created:** Fri Nov 23, 2018 01:15 AM UTC by Thuan **Last Updated:** Sat Nov 24, 2018 08:48 AM UTC **Owner:** Gary Lee PL-9 was deleted from cluster, but somehow standby amfd still keep the node. Then when failover happen, standby amfd crash as following: ~~~ Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'SC-1' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active DONE! Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'PL-9' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: src/amf/amfd/sgproc.cc:2187: avd_node_down_mw_susi_failover: Assertion 'avnd->list_of_ncs_su.empty() != true' failed. ~~~ The root cause is amfnd down on SC-2 vs checkpoint from SC-1 ~~~ <143>1 2018-11-24T14:43:17.870243+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7238"] 261:amf/amfd/ndfsm.cc:779 >> avd_mds_avnd_down_evh: 2050f, 0x563eacfe3b50 <143>1 2018-11-24T14:43:17.870254+07:00 SC-2 osafamfd 261 osafamfd [meta sequenceId="7239"] 261:amf/amfd/ndfsm.cc:853 << avd_mds_avnd_down_evh <143>1 2018-11-24T14:43:17.874433+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22818"] 285:amf/amfd/ndfsm.cc:779 >> avd_mds_avnd_down_evh: 2050f, 0x5601d0d9cb90 <143>1 2018-11-24T14:43:17.874439+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22819"] 285:amf/amfd/ndproc.cc:1235 >> avd_node_failover: 'safAmfNode=PL-5,safAmfCluster=myAmfCluster' <143>1 2018-11-24T14:43:17.874443+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22820"] 285:amf/amfd/ndfsm.cc:1149 >> avd_node_mark_absent <141>1 2018-11-24T14:43:17.88228+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22908"] 285:amf/amfd/ndfsm.cc:1154 NO Node 'PL-5' left the cluster <143>1 2018-11-24T14:43:17.882284+07:00 SC-1 osafamfd 285 osafamfd [meta sequenceId="22909"] 285:mbc/mbcsv_api.c:798 >> mbcsv_process_snd_ckpt_request: Sending checkpoint data to all STANDBY peers, as per the send-type specified <143>1 2018-11-24T14:43:17.882637+07:00 SC-1 osafamfd 285 osafamfd [meta
[tickets] [opensaf:tickets] #2972 amfd: unsafe access to cb
- **status**: review --> fixed --- ** [tickets:#2972] amfd: unsafe access to cb** **Status:** fixed **Milestone:** 5.18.12 **Created:** Fri Nov 23, 2018 07:23 AM UTC by Gary Lee **Last Updated:** Fri Nov 23, 2018 12:48 PM UTC **Owner:** Thuan The fix for [#2949] seems to have issues. It calls avd_check_nodes_after_reinit_imm() which can modify variables in cb outside the main thread. We should call avd_check_nodes_after_reinit_imm() after getting AVD_IMM_REINITIALIZED in the main thread. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2971 amf: standby amfd crash during failover to become active
Full bt of coredump Attachments: - [osafamfd.5079.SC-2.core.txt](https://sourceforge.net/p/opensaf/tickets/_discuss/thread/8423ebbdf9/8c16/attachment/osafamfd.5079.SC-2.core.txt) (10.6 kB; text/plain) --- ** [tickets:#2971] amf: standby amfd crash during failover to become active** **Status:** review **Milestone:** 5.18.12 **Created:** Fri Nov 23, 2018 01:15 AM UTC by Thuan **Last Updated:** Fri Nov 23, 2018 04:00 AM UTC **Owner:** Thuan PL-9 was deleted from cluster, but somehow standby amfd still keep the node. The most possible reason is that standby amfd miss node delete apply callback by somehow. Then when failover happen, standby amfd crash as following: ~~~ Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'SC-1' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active DONE! Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'PL-9' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: src/amf/amfd/sgproc.cc:2187: avd_node_down_mw_susi_failover: Assertion 'avnd->list_of_ncs_su.empty() != true' failed. ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2971 amf: standby amfd crash during failover to become active
--- ** [tickets:#2971] amf: standby amfd crash during failover to become active** **Status:** unassigned **Milestone:** 5.18.12 **Created:** Fri Nov 23, 2018 01:15 AM UTC by Thuan **Last Updated:** Fri Nov 23, 2018 01:15 AM UTC **Owner:** Thuan PL-9 was deleted from cluster, but somehow standby amfd still keep the node. The most possible reason is that standby amfd miss node delete apply callback by somehow. Then when failover happen, standby amfd crash as following: ~~~ Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'SC-1' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: NO FAILOVER StandBy --> Active DONE! Nov 20 04:09:14 SC-2 osafamfd[5079]: NO Node 'PL-9' left the cluster Nov 20 04:09:14 SC-2 osafamfd[5079]: src/amf/amfd/sgproc.cc:2187: avd_node_down_mw_susi_failover: Assertion 'avnd->list_of_ncs_su.empty() != true' failed. ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2962 smf: unexpected callbacks for Balanced Procedures
- **status**: unassigned --> wontfix --- ** [tickets:#2962] smf: unexpected callbacks for Balanced Procedures** **Status:** wontfix **Milestone:** 5.18.12 **Created:** Thu Nov 15, 2018 09:22 AM UTC by Thuan **Last Updated:** Mon Nov 19, 2018 03:27 AM UTC **Owner:** nobody Unexpected callbacks for Balanced Procedures. Example 1: Proc_A: onFirstStep callback A, onEveryStep callback A, onLastStep callback A. -> Balanced Procedures: Proc_A1: onFirstStep callback A, onEveryStep callback A, onLastStep callback A Proc_A2: onFirstStep callback A,onEveryStep callback A, onLastStep callback A -> Expect: Proc_A1: onFirstStep callback A, onEveryStep callback A Proc_A2: onEveryStep callback A, onLastStep callback A Example 2: Proc_A: onFirstStep callback A, onEveryStep callback A Proc_B: onFirstStep callback B, onEveryStep callback B Proc_C: onFirstStep callback C, onEveryStep callback C -> Balanced Procedures: Proc_AB: onFirstStep callback A, onFirstStep callback B, onEveryStep callback A, onEveryStep callback B Proc_AC: onFirstStep callback A, onFirstStep callback C, onEveryStep callback A, onEveryStep callback C -> Expect: Proc_AB: onFirstStep callback A, onFirstStep callback B, onEveryStep callback A, onEveryStep callback B Proc_AC: onFirstStep callback C, onEveryStep callback A, onEveryStep callback C --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2962 smf: unexpected callbacks for Balanced Procedures
--- ** [tickets:#2962] smf: unexpected callbacks for Balanced Procedures** **Status:** unassigned **Milestone:** 5.18.12 **Created:** Thu Nov 15, 2018 09:22 AM UTC by Thuan **Last Updated:** Thu Nov 15, 2018 09:22 AM UTC **Owner:** nobody Unexpected callbacks for Balanced Procedures. Example 1: Proc_A: onFirstStep callback A, onEveryStep callback A, onLastStep callback A. -> Balanced Procedures: Proc_A1: onFirstStep callback A, onEveryStep callback A, onLastStep callback A Proc_A2: onFirstStep callback A,onEveryStep callback A, onLastStep callback A -> Expect: Proc_A1: onFirstStep callback A, onEveryStep callback A Proc_A2: onEveryStep callback A, onLastStep callback A Example 2: Proc_A: onFirstStep callback A, onEveryStep callback A Proc_B: onFirstStep callback B, onEveryStep callback B Proc_C: onFirstStep callback C, onEveryStep callback C -> Balanced Procedures: Proc_AB: onFirstStep callback A, onFirstStep callback B, onEveryStep callback A, onEveryStep callback B Proc_AC: onFirstStep callback A, onFirstStep callback C, onEveryStep callback A, onEveryStep callback C -> Expect: Proc_AB: onFirstStep callback A, onFirstStep callback B, onEveryStep callback A, onEveryStep callback B Proc_AC: onFirstStep callback C, onEveryStep callback A, onEveryStep callback C --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2949 amf: standby amfd keep crash and node reboot cyclically
- **status**: review --> fixed --- ** [tickets:#2949] amf: standby amfd keep crash and node reboot cyclically** **Status:** fixed **Milestone:** 5.18.12 **Created:** Tue Oct 30, 2018 06:20 AM UTC by Thuan **Last Updated:** Tue Oct 30, 2018 08:56 AM UTC **Owner:** Thuan Standby AMFD crash because: ~~~ Oct 26 19:30:53 sc-2 osafamfd[3555]: WA avd_node_get FAILED for 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' Oct 26 19:30:53 sc-2 osafamfd[3555]: src/amf/amfd/ckpt_dec.cc:2200: dec_cs_node_config: Assertion 'status == NCSCC_RC_SUCCESS' failed. ~~~ In scenario that user delete node (scale-in). Then Standby SC just boot up. But Active AMFD miss node CCB delete apply callback because AMFD got IMM bad handle right before. So, Active AMFD still not update node db and checkpoint to standby SC still have the node which not exist anymore in IMM database. It make Standby AMFD stuck in crash and reboot loop. ~~~ <143>1 2018-10-26T19:29:14.68+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500306"] 12883:amf/amfd/node.cc:532 >> node_ccb_completed_delete_hdlr: 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' <143>1 2018-10-26T19:29:14.680268+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500313"] 12883:amf/amfd/node.cc:664 << node_ccb_completed_delete_hdlr <143>1 2018-10-26T19:29:21.747664+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528336"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:21.747668+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528337"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:21.747678+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528338"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:21.747683+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528339"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:28.621939+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528340"] 12885:amf/amfd/timer.cc:152 >> avd_tmr_exp <143>1 2018-10-26T19:29:28.621967+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528341"] 12885:amf/amfd/timer.cc:175 << avd_tmr_exp <143>1 2018-10-26T19:29:31.757918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528342"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.757932+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528343"] 12883:amf/amfd/imm.cc:263 TR TIMEOUT <143>1 2018-10-26T19:29:31.75794+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528344"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.758198+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528361"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:31.758205+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528362"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:31.758214+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528363"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:31.758221+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528364"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:31.758898+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528365"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.758918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528366"] 12883:amf/amfd/imm.cc:266 TR BADHANDLE <143>1 2018-10-26T19:29:31.758924+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528367"] 12883:amf/amfd/imm.cc:2194 >> avd_imm_reinit_bg <141>1 2018-10-26T19:29:31.758944+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528368"] 12883:amf/amfd/imm.cc:2207 NO Re-initializing with IMM <143>1 2018-10-26T19:29:31.758997+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528369"] 6394:amf/amfd/imm.cc:2090 >> avd_imm_reinit_bg_thread <143>1 2018-10-26T19:29:31.759021+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528370"] 6394:imm/agent/imma_oi_api.cc:701 >> saImmOiFinalize <143>1 2018-10-26T19:29:31.7591+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528371"] 12883:amf/amfd/imm.cc:2227 << avd_imm_reinit_bg <143>1 2018-10-26T19:29:31.759112+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528372"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.759118+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528373"] 12883:amf/amfd/imm.cc:426 << execute: 2 <143>1 2018-10-26T19:29:31.759211+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528374"] 6394:imm/agent/imma_proc.cc:150 >> imma_callback_ipc_destroy <143>1 2018-10-26T19:29:31.759235+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528375"] 6394:imm/agent/imma_proc.cc:0 <<
[tickets] [opensaf:tickets] #2955 base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN
- **status**: review --> fixed
---
** [tickets:#2955] base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN**
**Status:** fixed
**Milestone:** 5.18.12
**Created:** Mon Nov 05, 2018 07:01 AM UTC by Thuan
**Last Updated:** Mon Nov 05, 2018 07:30 AM UTC
**Owner:** Thuan
Valgrind detect memleak in OM agent as following:
~~~
0x4C2A0F3 mallocvalgrind/valgrind-3.13.0/coregrind/m_replacemalloc
vg_replace_malloc.c 299
0x714C7C3 ncs_os_taskopensaf/src/base os_defs.c 231
0x7156110 ncs_task_createopensaf/src/base sysf_tsk.c 62
0x714BDB7 sysfTmrCreateopensaf/src/base ncssysf_tmr.cc 165
0x7152824 leap_env_initopensaf/src/base sysf_def.c 97
0x7149363 ncs_leap_startupopensaf/src/base ncs_main_pub.c 155
0x7149676 ncs_core_agents_startupopensaf/src/base ncs_main_pub.c
261
0x7149968 ncs_agents_startupopensaf/src/base ncs_main_pub.c 107
0x7831BC4 imma_startup(ncsmds_svc_id)opensaf/src/imm/agent
imma_init.cc 281
0x7848FDD initialize_common(unsigned long long*, imma_client_node*,
SaVersionT*)opensaf/src/imm/agent imma_om_api.cc 246
0x7849CF9 saImmOmInitializeopensaf/src/imm/agent imma_om_api.cc 228
~~~
Proposal fix:
~~~
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
index fbca376..da38cd7 100644
--- a/src/base/os_defs.c
+++ b/src/base/os_defs.c
@@ -307,9 +307,11 @@ unsigned int ncs_os_task(NCS_OS_TASK *task,
NCS_OS_TASK_REQUEST request)
if (pthread_join(*(pthread_t *)task->info.release.i_handle,
) != 0) {
+ free(task->info.release.i_handle);
return (NCSCC_RC_FAILURE);
}
+ free(task->info.release.i_handle);
} break;
case NCS_OS_TASK_DETACH:
if (pthread_detach(*(pthread_t *)task->info.release.i_handle) !=
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2955 base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN
- **status**: assigned --> review
---
** [tickets:#2955] base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN**
**Status:** review
**Milestone:** 5.18.12
**Created:** Mon Nov 05, 2018 07:01 AM UTC by Thuan
**Last Updated:** Mon Nov 05, 2018 07:16 AM UTC
**Owner:** Thuan
Valgrind detect memleak in OM agent as following:
~~~
0x4C2A0F3 mallocvalgrind/valgrind-3.13.0/coregrind/m_replacemalloc
vg_replace_malloc.c 299
0x714C7C3 ncs_os_taskopensaf/src/base os_defs.c 231
0x7156110 ncs_task_createopensaf/src/base sysf_tsk.c 62
0x714BDB7 sysfTmrCreateopensaf/src/base ncssysf_tmr.cc 165
0x7152824 leap_env_initopensaf/src/base sysf_def.c 97
0x7149363 ncs_leap_startupopensaf/src/base ncs_main_pub.c 155
0x7149676 ncs_core_agents_startupopensaf/src/base ncs_main_pub.c
261
0x7149968 ncs_agents_startupopensaf/src/base ncs_main_pub.c 107
0x7831BC4 imma_startup(ncsmds_svc_id)opensaf/src/imm/agent
imma_init.cc 281
0x7848FDD initialize_common(unsigned long long*, imma_client_node*,
SaVersionT*)opensaf/src/imm/agent imma_om_api.cc 246
0x7849CF9 saImmOmInitializeopensaf/src/imm/agent imma_om_api.cc 228
~~~
Proposal fix:
~~~
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
index fbca376..da38cd7 100644
--- a/src/base/os_defs.c
+++ b/src/base/os_defs.c
@@ -307,9 +307,11 @@ unsigned int ncs_os_task(NCS_OS_TASK *task,
NCS_OS_TASK_REQUEST request)
if (pthread_join(*(pthread_t *)task->info.release.i_handle,
) != 0) {
+ free(task->info.release.i_handle);
return (NCSCC_RC_FAILURE);
}
+ free(task->info.release.i_handle);
} break;
case NCS_OS_TASK_DETACH:
if (pthread_detach(*(pthread_t *)task->info.release.i_handle) !=
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2955 base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN
- Description has changed:
Diff:
--- old
+++ new
@@ -16,15 +16,18 @@
Proposal fix:
~~~
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
-index fbca376..91744ba 100644
+index fbca376..da38cd7 100644
--- a/src/base/os_defs.c
+++ b/src/base/os_defs.c
-@@ -310,6 +310,8 @@ unsigned int ncs_os_task(NCS_OS_TASK *task,
NCS_OS_TASK_REQUEST request)
+@@ -307,9 +307,11 @@ unsigned int ncs_os_task(NCS_OS_TASK *task,
NCS_OS_TASK_REQUEST request)
+
+if (pthread_join(*(pthread_t *)task->info.release.i_handle,
+ ) != 0) {
++ free(task->info.release.i_handle);
return (NCSCC_RC_FAILURE);
}
+ free(task->info.release.i_handle);
-+
} break;
case NCS_OS_TASK_DETACH:
if (pthread_detach(*(pthread_t *)task->info.release.i_handle)
!=
---
** [tickets:#2955] base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN**
**Status:** assigned
**Milestone:** 5.18.12
**Created:** Mon Nov 05, 2018 07:01 AM UTC by Thuan
**Last Updated:** Mon Nov 05, 2018 07:05 AM UTC
**Owner:** Thuan
Valgrind detect memleak in OM agent as following:
~~~
0x4C2A0F3 mallocvalgrind/valgrind-3.13.0/coregrind/m_replacemalloc
vg_replace_malloc.c 299
0x714C7C3 ncs_os_taskopensaf/src/base os_defs.c 231
0x7156110 ncs_task_createopensaf/src/base sysf_tsk.c 62
0x714BDB7 sysfTmrCreateopensaf/src/base ncssysf_tmr.cc 165
0x7152824 leap_env_initopensaf/src/base sysf_def.c 97
0x7149363 ncs_leap_startupopensaf/src/base ncs_main_pub.c 155
0x7149676 ncs_core_agents_startupopensaf/src/base ncs_main_pub.c
261
0x7149968 ncs_agents_startupopensaf/src/base ncs_main_pub.c 107
0x7831BC4 imma_startup(ncsmds_svc_id)opensaf/src/imm/agent
imma_init.cc 281
0x7848FDD initialize_common(unsigned long long*, imma_client_node*,
SaVersionT*)opensaf/src/imm/agent imma_om_api.cc 246
0x7849CF9 saImmOmInitializeopensaf/src/imm/agent imma_om_api.cc 228
~~~
Proposal fix:
~~~
diff --git a/src/base/os_defs.c b/src/base/os_defs.c
index fbca376..da38cd7 100644
--- a/src/base/os_defs.c
+++ b/src/base/os_defs.c
@@ -307,9 +307,11 @@ unsigned int ncs_os_task(NCS_OS_TASK *task,
NCS_OS_TASK_REQUEST request)
if (pthread_join(*(pthread_t *)task->info.release.i_handle,
) != 0) {
+ free(task->info.release.i_handle);
return (NCSCC_RC_FAILURE);
}
+ free(task->info.release.i_handle);
} break;
case NCS_OS_TASK_DETACH:
if (pthread_detach(*(pthread_t *)task->info.release.i_handle) !=
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2955 base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN
- **summary**: base: memleak in sysfTmrCreate/sysfTmrDestroy --> base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN --- ** [tickets:#2955] base: memleak in ncs_os_task() case NCS_OS_TASK_JOIN** **Status:** assigned **Milestone:** 5.18.12 **Created:** Mon Nov 05, 2018 07:01 AM UTC by Thuan **Last Updated:** Mon Nov 05, 2018 07:01 AM UTC **Owner:** Thuan Valgrind detect memleak in OM agent as following: ~~~ 0x4C2A0F3 mallocvalgrind/valgrind-3.13.0/coregrind/m_replacemalloc vg_replace_malloc.c 299 0x714C7C3 ncs_os_taskopensaf/src/base os_defs.c 231 0x7156110 ncs_task_createopensaf/src/base sysf_tsk.c 62 0x714BDB7 sysfTmrCreateopensaf/src/base ncssysf_tmr.cc 165 0x7152824 leap_env_initopensaf/src/base sysf_def.c 97 0x7149363 ncs_leap_startupopensaf/src/base ncs_main_pub.c 155 0x7149676 ncs_core_agents_startupopensaf/src/base ncs_main_pub.c 261 0x7149968 ncs_agents_startupopensaf/src/base ncs_main_pub.c 107 0x7831BC4 imma_startup(ncsmds_svc_id)opensaf/src/imm/agent imma_init.cc 281 0x7848FDD initialize_common(unsigned long long*, imma_client_node*, SaVersionT*)opensaf/src/imm/agent imma_om_api.cc 246 0x7849CF9 saImmOmInitializeopensaf/src/imm/agent imma_om_api.cc 228 ~~~ Proposal fix: ~~~ diff --git a/src/base/os_defs.c b/src/base/os_defs.c index fbca376..91744ba 100644 --- a/src/base/os_defs.c +++ b/src/base/os_defs.c @@ -310,6 +310,8 @@ unsigned int ncs_os_task(NCS_OS_TASK *task, NCS_OS_TASK_REQUEST request) return (NCSCC_RC_FAILURE); } + free(task->info.release.i_handle); + } break; case NCS_OS_TASK_DETACH: if (pthread_detach(*(pthread_t *)task->info.release.i_handle) != ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2955 base: memleak in sysfTmrCreate/sysfTmrDestroy
--- ** [tickets:#2955] base: memleak in sysfTmrCreate/sysfTmrDestroy** **Status:** assigned **Milestone:** 5.18.12 **Created:** Mon Nov 05, 2018 07:01 AM UTC by Thuan **Last Updated:** Mon Nov 05, 2018 07:01 AM UTC **Owner:** Thuan Valgrind detect memleak in OM agent as following: ~~~ 0x4C2A0F3 mallocvalgrind/valgrind-3.13.0/coregrind/m_replacemalloc vg_replace_malloc.c 299 0x714C7C3 ncs_os_taskopensaf/src/base os_defs.c 231 0x7156110 ncs_task_createopensaf/src/base sysf_tsk.c 62 0x714BDB7 sysfTmrCreateopensaf/src/base ncssysf_tmr.cc 165 0x7152824 leap_env_initopensaf/src/base sysf_def.c 97 0x7149363 ncs_leap_startupopensaf/src/base ncs_main_pub.c 155 0x7149676 ncs_core_agents_startupopensaf/src/base ncs_main_pub.c 261 0x7149968 ncs_agents_startupopensaf/src/base ncs_main_pub.c 107 0x7831BC4 imma_startup(ncsmds_svc_id)opensaf/src/imm/agent imma_init.cc 281 0x7848FDD initialize_common(unsigned long long*, imma_client_node*, SaVersionT*)opensaf/src/imm/agent imma_om_api.cc 246 0x7849CF9 saImmOmInitializeopensaf/src/imm/agent imma_om_api.cc 228 ~~~ Proposal fix: ~~~ diff --git a/src/base/os_defs.c b/src/base/os_defs.c index fbca376..91744ba 100644 --- a/src/base/os_defs.c +++ b/src/base/os_defs.c @@ -310,6 +310,8 @@ unsigned int ncs_os_task(NCS_OS_TASK *task, NCS_OS_TASK_REQUEST request) return (NCSCC_RC_FAILURE); } + free(task->info.release.i_handle); + } break; case NCS_OS_TASK_DETACH: if (pthread_detach(*(pthread_t *)task->info.release.i_handle) != ~~~ --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2949 amf: standby amfd keep crash and node reboot cyclically
- **status**: assigned --> review --- ** [tickets:#2949] amf: standby amfd keep crash and node reboot cyclically** **Status:** review **Milestone:** 5.18.12 **Created:** Tue Oct 30, 2018 06:20 AM UTC by Thuan **Last Updated:** Tue Oct 30, 2018 06:20 AM UTC **Owner:** Thuan Standby AMFD crash because: ~~~ Oct 26 19:30:53 sc-2 osafamfd[3555]: WA avd_node_get FAILED for 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' Oct 26 19:30:53 sc-2 osafamfd[3555]: src/amf/amfd/ckpt_dec.cc:2200: dec_cs_node_config: Assertion 'status == NCSCC_RC_SUCCESS' failed. ~~~ In scenario that user delete node (scale-in). Then Standby SC just boot up. But Active AMFD miss node CCB delete apply callback because AMFD got IMM bad handle right before. So, Active AMFD still not update node db and checkpoint to standby SC still have the node which not exist anymore in IMM database. It make Standby AMFD stuck in crash and reboot loop. ~~~ <143>1 2018-10-26T19:29:14.68+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500306"] 12883:amf/amfd/node.cc:532 >> node_ccb_completed_delete_hdlr: 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' <143>1 2018-10-26T19:29:14.680268+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500313"] 12883:amf/amfd/node.cc:664 << node_ccb_completed_delete_hdlr <143>1 2018-10-26T19:29:21.747664+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528336"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:21.747668+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528337"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:21.747678+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528338"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:21.747683+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528339"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:28.621939+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528340"] 12885:amf/amfd/timer.cc:152 >> avd_tmr_exp <143>1 2018-10-26T19:29:28.621967+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528341"] 12885:amf/amfd/timer.cc:175 << avd_tmr_exp <143>1 2018-10-26T19:29:31.757918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528342"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.757932+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528343"] 12883:amf/amfd/imm.cc:263 TR TIMEOUT <143>1 2018-10-26T19:29:31.75794+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528344"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.758198+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528361"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:31.758205+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528362"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:31.758214+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528363"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:31.758221+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528364"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:31.758898+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528365"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.758918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528366"] 12883:amf/amfd/imm.cc:266 TR BADHANDLE <143>1 2018-10-26T19:29:31.758924+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528367"] 12883:amf/amfd/imm.cc:2194 >> avd_imm_reinit_bg <141>1 2018-10-26T19:29:31.758944+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528368"] 12883:amf/amfd/imm.cc:2207 NO Re-initializing with IMM <143>1 2018-10-26T19:29:31.758997+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528369"] 6394:amf/amfd/imm.cc:2090 >> avd_imm_reinit_bg_thread <143>1 2018-10-26T19:29:31.759021+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528370"] 6394:imm/agent/imma_oi_api.cc:701 >> saImmOiFinalize <143>1 2018-10-26T19:29:31.7591+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528371"] 12883:amf/amfd/imm.cc:2227 << avd_imm_reinit_bg <143>1 2018-10-26T19:29:31.759112+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528372"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.759118+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528373"] 12883:amf/amfd/imm.cc:426 << execute: 2 <143>1 2018-10-26T19:29:31.759211+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528374"] 6394:imm/agent/imma_proc.cc:150 >> imma_callback_ipc_destroy <143>1 2018-10-26T19:29:31.759235+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528375"]
[tickets] [opensaf:tickets] #2949 amf: standby amfd keep crash and node reboot cyclically
--- ** [tickets:#2949] amf: standby amfd keep crash and node reboot cyclically** **Status:** assigned **Milestone:** 5.18.12 **Created:** Tue Oct 30, 2018 06:20 AM UTC by Thuan **Last Updated:** Tue Oct 30, 2018 06:20 AM UTC **Owner:** Thuan Standby AMFD crash because: ~~~ Oct 26 19:30:53 sc-2 osafamfd[3555]: WA avd_node_get FAILED for 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' Oct 26 19:30:53 sc-2 osafamfd[3555]: src/amf/amfd/ckpt_dec.cc:2200: dec_cs_node_config: Assertion 'status == NCSCC_RC_SUCCESS' failed. ~~~ In scenario that user delete node (scale-in). Then Standby SC just boot up. But Active AMFD miss node CCB delete apply callback because AMFD got IMM bad handle right before. So, Active AMFD still not update node db and checkpoint to standby SC still have the node which not exist anymore in IMM database. It make Standby AMFD stuck in crash and reboot loop. ~~~ <143>1 2018-10-26T19:29:14.68+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500306"] 12883:amf/amfd/node.cc:532 >> node_ccb_completed_delete_hdlr: 'safAmfNode=PL-13,safAmfCluster=myAmfCluster' <143>1 2018-10-26T19:29:14.680268+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="500313"] 12883:amf/amfd/node.cc:664 << node_ccb_completed_delete_hdlr <143>1 2018-10-26T19:29:21.747664+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528336"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:21.747668+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528337"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:21.747678+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528338"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:21.747683+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528339"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:28.621939+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528340"] 12885:amf/amfd/timer.cc:152 >> avd_tmr_exp <143>1 2018-10-26T19:29:28.621967+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528341"] 12885:amf/amfd/timer.cc:175 << avd_tmr_exp <143>1 2018-10-26T19:29:31.757918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528342"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.757932+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528343"] 12883:amf/amfd/imm.cc:263 TR TIMEOUT <143>1 2018-10-26T19:29:31.75794+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528344"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.758198+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528361"] 12883:amf/amfd/imm.cc:240 >> exec: Update 'safSi=NoRed3,safApp=OpenSAF' saAmfUnassignedAlarmStatus <143>1 2018-10-26T19:29:31.758205+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528362"] 12883:amf/amfd/imm.cc:750 >> object_name_to_class_type: safSi=NoRed3,safApp=OpenSAF <143>1 2018-10-26T19:29:31.758214+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528363"] 12883:amf/amfd/imm.cc:798 << object_name_to_class_type: 24 <143>1 2018-10-26T19:29:31.758221+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528364"] 12883:imm/agent/imma_oi_api.cc:2556 >> rt_object_update_common <143>1 2018-10-26T19:29:31.758898+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528365"] 12883:imm/agent/imma_oi_api.cc:2849 << rt_object_update_common <143>1 2018-10-26T19:29:31.758918+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528366"] 12883:amf/amfd/imm.cc:266 TR BADHANDLE <143>1 2018-10-26T19:29:31.758924+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528367"] 12883:amf/amfd/imm.cc:2194 >> avd_imm_reinit_bg <141>1 2018-10-26T19:29:31.758944+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528368"] 12883:amf/amfd/imm.cc:2207 NO Re-initializing with IMM <143>1 2018-10-26T19:29:31.758997+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528369"] 6394:amf/amfd/imm.cc:2090 >> avd_imm_reinit_bg_thread <143>1 2018-10-26T19:29:31.759021+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528370"] 6394:imm/agent/imma_oi_api.cc:701 >> saImmOiFinalize <143>1 2018-10-26T19:29:31.7591+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528371"] 12883:amf/amfd/imm.cc:2227 << avd_imm_reinit_bg <143>1 2018-10-26T19:29:31.759112+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528372"] 12883:amf/amfd/imm.cc:275 << exec <143>1 2018-10-26T19:29:31.759118+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528373"] 12883:amf/amfd/imm.cc:426 << execute: 2 <143>1 2018-10-26T19:29:31.759211+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528374"] 6394:imm/agent/imma_proc.cc:150 >> imma_callback_ipc_destroy <143>1 2018-10-26T19:29:31.759235+02:00 SC-1 osafamfd 12883 osafamfd [meta sequenceId="528375"] 6394:imm/agent/imma_proc.cc:0 << imma_callback_ipc_destroy
[tickets] [opensaf:tickets] #1960 MDS: MDS does not handle dropped TIPC packages
- **status**: accepted --> assigned - **assigned_to**: Hans Nordebäck --> Thuan - **Blocker**: --> False - **Milestone**: 5.17.08 --> future --- ** [tickets:#1960] MDS: MDS does not handle dropped TIPC packages ** **Status:** assigned **Milestone:** future **Created:** Fri Aug 19, 2016 08:39 AM UTC by Hans Nordebäck **Last Updated:** Mon Apr 10, 2017 01:40 PM UTC **Owner:** Thuan TIPC is run in connection less mode by OpenSAF, i.e. SOCK_RDM, reliable datagram where ordering is guaranteed but packages can be dropped at e.g. overload situations. This is not handled by OpenSAF and may cause undetermined behaviour in the system. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2933 imm: incorrect set isCoord both SCs when coordinator on payload crash
- **status**: assigned --> review
---
** [tickets:#2933] imm: incorrect set isCoord both SCs when coordinator on
payload crash**
**Status:** review
**Milestone:** 5.18.12
**Created:** Tue Oct 02, 2018 01:13 AM UTC by Thuan
**Last Updated:** Tue Oct 02, 2018 01:13 AM UTC
**Owner:** Thuan
IMMND Coordinator is set incorrectly by following code
~~~
// Election priority:
// 1) Coordinator on active node
// 2) Coordinator on standby node
// 3) Coordinator on PL node if SC absence is allowed.
while (immnd_info_node) {
key = immnd_info_node->immnd_dest;
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
}
}
immd_immnd_info_node_getnext(>immnd_tree, ,
_info_node);
}
~~~
When current coordinator is on payload (after headless) crash with both SC-1
and SC-2 are ready and SC-2 is active, above loop can set isCoord true for both
SC-1 and SC-2 instead of only SC-2.
Proposal fix:
~~~
diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c
index b28506ba5..c16232d2d 100644
--- a/src/imm/immd/immd_proc.c
+++ b/src/imm/immd/immd_proc.c
@@ -346,7 +346,6 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
- immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
@@ -358,7 +357,9 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
}
immnd_info_node = candidate_coord_node;
- if (!immnd_info_node && cb->mScAbsenceAllowed) {
+ if (immnd_info_node != NULL) {
+ immnd_info_node->isCoord = true;
+ } else if (cb->mScAbsenceAllowed) {
/* If SC absence is allowed and no SC based IMMND is
available then elect an IMMND coord at a payload.
Note this means that an IMMND at a payload may be
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2933 imm: incorrect set isCoord both SCs when coordinator on payload crash
- **status**: unassigned --> assigned
- **assigned_to**: Thuan
---
** [tickets:#2933] imm: incorrect set isCoord both SCs when coordinator on
payload crash**
**Status:** assigned
**Milestone:** 5.18.12
**Created:** Tue Oct 02, 2018 01:13 AM UTC by Thuan
**Last Updated:** Tue Oct 02, 2018 01:13 AM UTC
**Owner:** Thuan
IMMND Coordinator is set incorrectly by following code
~~~
// Election priority:
// 1) Coordinator on active node
// 2) Coordinator on standby node
// 3) Coordinator on PL node if SC absence is allowed.
while (immnd_info_node) {
key = immnd_info_node->immnd_dest;
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
}
}
immd_immnd_info_node_getnext(>immnd_tree, ,
_info_node);
}
~~~
When current coordinator is on payload (after headless) crash with both SC-1
and SC-2 are ready and SC-2 is active, above loop can set isCoord true for both
SC-1 and SC-2 instead of only SC-2.
Proposal fix:
~~~
diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c
index b28506ba5..c16232d2d 100644
--- a/src/imm/immd/immd_proc.c
+++ b/src/imm/immd/immd_proc.c
@@ -346,7 +346,6 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
- immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
@@ -358,7 +357,9 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
}
immnd_info_node = candidate_coord_node;
- if (!immnd_info_node && cb->mScAbsenceAllowed) {
+ if (immnd_info_node != NULL) {
+ immnd_info_node->isCoord = true;
+ } else if (cb->mScAbsenceAllowed) {
/* If SC absence is allowed and no SC based IMMND is
available then elect an IMMND coord at a payload.
Note this means that an IMMND at a payload may be
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2933 imm: incorrect set isCoord both SCs when coordinator on payload crash
---
** [tickets:#2933] imm: incorrect set isCoord both SCs when coordinator on
payload crash**
**Status:** unassigned
**Milestone:** 5.18.12
**Created:** Tue Oct 02, 2018 01:13 AM UTC by Thuan
**Last Updated:** Tue Oct 02, 2018 01:13 AM UTC
**Owner:** nobody
IMMND Coordinator is set incorrectly by following code
~~~
// Election priority:
// 1) Coordinator on active node
// 2) Coordinator on standby node
// 3) Coordinator on PL node if SC absence is allowed.
while (immnd_info_node) {
key = immnd_info_node->immnd_dest;
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
}
}
immd_immnd_info_node_getnext(>immnd_tree, ,
_info_node);
}
~~~
When current coordinator is on payload (after headless) crash with both SC-1
and SC-2 are ready and SC-2 is active, above loop can set isCoord true for both
SC-1 and SC-2 instead of only SC-2.
Proposal fix:
~~~
diff --git a/src/imm/immd/immd_proc.c b/src/imm/immd/immd_proc.c
index b28506ba5..c16232d2d 100644
--- a/src/imm/immd/immd_proc.c
+++ b/src/imm/immd/immd_proc.c
@@ -346,7 +346,6 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
if ((immnd_info_node->isOnController) &&
(immnd_info_node->epoch == cb->mRulingEpoch)) {
candidate_coord_node = immnd_info_node;
- immnd_info_node->isCoord = true;
if (immnd_info_node->immnd_key == cb->node_id) {
/* Found a new candidate on active SC */
break;
@@ -358,7 +357,9 @@ bool immd_proc_elect_coord(IMMD_CB *cb, bool new_active)
}
immnd_info_node = candidate_coord_node;
- if (!immnd_info_node && cb->mScAbsenceAllowed) {
+ if (immnd_info_node != NULL) {
+ immnd_info_node->isCoord = true;
+ } else if (cb->mScAbsenceAllowed) {
/* If SC absence is allowed and no SC based IMMND is
available then elect an IMMND coord at a payload.
Note this means that an IMMND at a payload may be
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #1353 smf: step undoing is in progress forever until cluster reset
- **status**: accepted --> review --- ** [tickets:#1353] smf: step undoing is in progress forever until cluster reset** **Status:** review **Milestone:** 5.18.09 **Created:** Tue Apr 28, 2015 01:33 PM UTC by Neelakanta Reddy **Last Updated:** Tue Sep 25, 2018 06:18 AM UTC **Owner:** Thuan **Attachments:** - [1353.tgz](https://sourceforge.net/p/opensaf/tickets/1353/attachment/1353.tgz) (475.2 kB; application/octet-stream) - [messages_step_undo](https://sourceforge.net/p/opensaf/tickets/1353/attachment/messages_step_undo) (111.1 kB; application/octet-stream) Test description: 1. rolling middle-ware upgrade(4.5->4.6) campaign is ran 2. one of the upgrade node(PL-4) the new rpms(4.6) are kept empty and the node comes up without opensaf installation 3. the step rollback is taken approximately two hours to describe the campaign as EXECUTION_FAILED 4. attaching syslog of SC-1 Apr 24 18:36:55 SLES1 osafamfd[2289]: NO Node 'PL-4' left the cluster Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer connected: 47 (MsgQueueService132111) <2280, 2010f> Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer locally disconnected. Marking it as doomed 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer disconnected 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:58 SLES1 kernel: [ 172.812065] TIPC: Resetting link <1.1.1:eth0-1.1.4:eth0>, peer not responding Apr 24 18:36:58 SLES1 kernel: [ 172.812071] TIPC: Lost link <1.1.1:eth0-1.1.4:eth0> on network plane A Apr 24 18:36:58 SLES1 kernel: [ 172.812075] TIPC: Lost contact with <1.1.4> Apr 24 18:37:15 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 18:37:36 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster --- -- -- Apr 24 20:36:00 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:22 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:44 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:06 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found whitin time limit for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Failed to online install old bundles Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Step undoing failed Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Step safSmfStep=0004 in procedure safSmfProc=OpenSAF-upgrade failed, step result 5 Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO CAMP: Procedure safSmfProc=OpenSAF-upgrade returned FAILED --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #1353 smf: step undoing is in progress forever until cluster reset
- **Milestone**: future --> 5.18.09 --- ** [tickets:#1353] smf: step undoing is in progress forever until cluster reset** **Status:** accepted **Milestone:** 5.18.09 **Created:** Tue Apr 28, 2015 01:33 PM UTC by Neelakanta Reddy **Last Updated:** Tue Sep 25, 2018 06:14 AM UTC **Owner:** Thuan **Attachments:** - [1353.tgz](https://sourceforge.net/p/opensaf/tickets/1353/attachment/1353.tgz) (475.2 kB; application/octet-stream) - [messages_step_undo](https://sourceforge.net/p/opensaf/tickets/1353/attachment/messages_step_undo) (111.1 kB; application/octet-stream) Test description: 1. rolling middle-ware upgrade(4.5->4.6) campaign is ran 2. one of the upgrade node(PL-4) the new rpms(4.6) are kept empty and the node comes up without opensaf installation 3. the step rollback is taken approximately two hours to describe the campaign as EXECUTION_FAILED 4. attaching syslog of SC-1 Apr 24 18:36:55 SLES1 osafamfd[2289]: NO Node 'PL-4' left the cluster Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer connected: 47 (MsgQueueService132111) <2280, 2010f> Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer locally disconnected. Marking it as doomed 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer disconnected 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:58 SLES1 kernel: [ 172.812065] TIPC: Resetting link <1.1.1:eth0-1.1.4:eth0>, peer not responding Apr 24 18:36:58 SLES1 kernel: [ 172.812071] TIPC: Lost link <1.1.1:eth0-1.1.4:eth0> on network plane A Apr 24 18:36:58 SLES1 kernel: [ 172.812075] TIPC: Lost contact with <1.1.4> Apr 24 18:37:15 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 18:37:36 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster --- -- -- Apr 24 20:36:00 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:22 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:44 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:06 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found whitin time limit for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Failed to online install old bundles Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Step undoing failed Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Step safSmfStep=0004 in procedure safSmfProc=OpenSAF-upgrade failed, step result 5 Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO CAMP: Procedure safSmfProc=OpenSAF-upgrade returned FAILED --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #1353 smf: step undoing is in progress forever until cluster reset
- **status**: unassigned --> accepted - **assigned_to**: Thuan - **Blocker**: --> False --- ** [tickets:#1353] smf: step undoing is in progress forever until cluster reset** **Status:** accepted **Milestone:** future **Created:** Tue Apr 28, 2015 01:33 PM UTC by Neelakanta Reddy **Last Updated:** Tue Sep 20, 2016 06:04 PM UTC **Owner:** Thuan **Attachments:** - [1353.tgz](https://sourceforge.net/p/opensaf/tickets/1353/attachment/1353.tgz) (475.2 kB; application/octet-stream) - [messages_step_undo](https://sourceforge.net/p/opensaf/tickets/1353/attachment/messages_step_undo) (111.1 kB; application/octet-stream) Test description: 1. rolling middle-ware upgrade(4.5->4.6) campaign is ran 2. one of the upgrade node(PL-4) the new rpms(4.6) are kept empty and the node comes up without opensaf installation 3. the step rollback is taken approximately two hours to describe the campaign as EXECUTION_FAILED 4. attaching syslog of SC-1 Apr 24 18:36:55 SLES1 osafamfd[2289]: NO Node 'PL-4' left the cluster Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer connected: 47 (MsgQueueService132111) <2280, 2010f> Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer locally disconnected. Marking it as doomed 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:55 SLES1 osafimmnd[2237]: NO Implementer disconnected 47 <2280, 2010f> (MsgQueueService132111) Apr 24 18:36:58 SLES1 kernel: [ 172.812065] TIPC: Resetting link <1.1.1:eth0-1.1.4:eth0>, peer not responding Apr 24 18:36:58 SLES1 kernel: [ 172.812071] TIPC: Lost link <1.1.1:eth0-1.1.4:eth0> on network plane A Apr 24 18:36:58 SLES1 kernel: [ 172.812075] TIPC: Lost contact with <1.1.4> Apr 24 18:37:15 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 18:37:36 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster --- -- -- Apr 24 20:36:00 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:22 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:36:44 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:06 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Failed to get node dest for clm node safNode=PL-4,safCluster=myClmCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found whitin time limit for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO no node destination found for node safAmfNode=PL-4,safAmfCluster=myAmfCluster Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Failed to online install old bundles Apr 24 20:37:28 SLES1 osafsmfd[2318]: ER Step undoing failed Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO Step safSmfStep=0004 in procedure safSmfProc=OpenSAF-upgrade failed, step result 5 Apr 24 20:37:28 SLES1 osafsmfd[2318]: NO CAMP: Procedure safSmfProc=OpenSAF-upgrade returned FAILED --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2927 smf: crash in CcbApplyCallback() due to NULL access
- **status**: assigned --> review
---
** [tickets:#2927] smf: crash in CcbApplyCallback() due to NULL access**
**Status:** review
**Milestone:** 5.18.09
**Created:** Mon Sep 17, 2018 10:57 AM UTC by Thuan
**Last Updated:** Mon Sep 17, 2018 10:57 AM UTC
**Owner:** Thuan
SMFD crash in following code:
src/smf/smfd/SmfImmApplierHdl.cc
static void CcbApplyCallback(SaImmOiHandleT immOiHandle, SaImmOiCcbIdT
ccbId) {
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
if (attribute_name.compare(attribute.attrName) != 0) {_
// Not found
attrMod = opdata->param.modify.attrMods[i];
attribute = attrMod->modAttr; <= CRASH HERE
continue;
}
Proposal solution:
~~~
--- a/src/smf/smfd/SmfImmApplierHdl.cc
+++ b/src/smf/smfd/SmfImmApplierHdl.cc
@@ -446,14 +446,13 @@ static void CcbApplyCallback(SaImmOiHandleT immOiHandle,
SaImmOiCcbIdT ccbId) {
*/
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
- attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
+attribute = attrMod->modAttr;
if (attribute_name_.compare(attribute.attrName) != 0) {
// Not found
attrMod = opdata->param.modify.attrMods[i];
- attribute = attrMod->modAttr;
continue;
}
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2927 smf: crash in CcbApplyCallback() due to NULL access
---
** [tickets:#2927] smf: crash in CcbApplyCallback() due to NULL access**
**Status:** assigned
**Milestone:** 5.18.09
**Created:** Mon Sep 17, 2018 10:57 AM UTC by Thuan
**Last Updated:** Mon Sep 17, 2018 10:57 AM UTC
**Owner:** Thuan
SMFD crash in following code:
src/smf/smfd/SmfImmApplierHdl.cc
static void CcbApplyCallback(SaImmOiHandleT immOiHandle, SaImmOiCcbIdT
ccbId) {
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
if (attribute_name.compare(attribute.attrName) != 0) {_
// Not found
attrMod = opdata->param.modify.attrMods[i];
attribute = attrMod->modAttr; <= CRASH HERE
continue;
}
Proposal solution:
~~~
--- a/src/smf/smfd/SmfImmApplierHdl.cc
+++ b/src/smf/smfd/SmfImmApplierHdl.cc
@@ -446,14 +446,13 @@ static void CcbApplyCallback(SaImmOiHandleT immOiHandle,
SaImmOiCcbIdT ccbId) {
*/
TRACE("%s: Read value in attributes", __FUNCTION__);
attrMod = opdata->param.modify.attrMods[0];
- attribute = attrMod->modAttr;
for (int i = 1; attrMod != nullptr; i++) {
/* Get the value */
+attribute = attrMod->modAttr;
if (attribute_name_.compare(attribute.attrName) != 0) {
// Not found
attrMod = opdata->param.modify.attrMods[i];
- attribute = attrMod->modAttr;
continue;
}
~~~
---
Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is
subscribed to https://sourceforge.net/p/opensaf/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.___
Opensaf-tickets mailing list
Opensaf-tickets@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
[tickets] [opensaf:tickets] #2632 amf: immxml-configure utility (tool) is failing with "UTF-8" encoding
Hi, commit mesage should be "imm", not "amf", isn't it? /Thuan --- ** [tickets:#2632] amf: immxml-configure utility (tool) is failing with "UTF-8" encoding** **Status:** fixed **Milestone:** 5.17.10 **Created:** Tue Oct 17, 2017 07:28 AM UTC by Vijay Roy **Last Updated:** Thu Oct 19, 2017 08:15 AM UTC **Owner:** Vijay Roy **Issue:** immxml-configure utility (tool) is failing when upper case "UTF-8" is supplied by user. Code changes goes at - /src/imm/tools/immxml-merge while validating. --- Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Opensaf-tickets mailing list Opensaf-tickets@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-tickets
