33 defects pointed out by Coverity Tool for SMF in default branch.
7 defects ignored since those were not relevant.
26 defects fixed by the scope of this ticket.
Coverity tool doesn't show any defects for SMF in default branch at the moment.
---
** [tickets:#1154] smf: defects detected by
8\. SmfUpgradeStep::modifyInformationModel(): there is no logically dead code
at the end of while loop. Constructing of SmfRollbackCcb cannot be moved out
from the while loop and put before it, because doImmOperations adds to it
each turn of the loop.
---
** [tickets:#1154] smf: defects
8\. SmfUpgradeStep::modifyInformationModel(): logically dead code at the end of
while loop. If statement handles 3 cases (continue/return/break) where none of
them let to reach the bottom of while loop. Coverity complaining about not
running the destructor of the instance of SmfRollbackCcb
5\. some places: setenv(): return value not checked.
6\. smfsv_evt.c: smf_enc_cbk_req(): branch_past_initialization problem for
length variable: this problem is shown only by coverity so far. It is better
to fix since it can cause problems with some compilers.
Proposal is to initialize at the
- **Comment**:
2\. smfd_smfnd.c: smfnd_up(): there are 2 problems.
-return value not checked and caller function proc_mds_info() steps the
no_of_smfnd counter anyway.
-memory leak in case when saClmInitialize() returns other than SA_AIS_OK.
Proposed solution: free memory if
Separate tickets created for 2 defects:
#1199 smf: fault in parsing some combinations of parent and type in
activationUnitTemplate
#1241 smf: node iterator is not stepped correctly
Smaller problems handled directly within this ticket.
A common patch is planned to be created. That will fix
- **status**: unassigned -- assigned
- **assigned_to**: Robert Apanowicz
---
** [tickets:#1154] smf: defects detected by Coverity tool should be fixed**
**Status:** assigned
**Milestone:** 4.6.FC
**Created:** Mon Oct 06, 2014 11:38 AM UTC by Robert Apanowicz
**Last Updated:** Mon Oct 06, 2014
---
** [tickets:#1154] smf: defects detected by Coverity tool should be fixed**
**Status:** unassigned
**Milestone:** 4.6.FC
**Created:** Mon Oct 06, 2014 11:38 AM UTC by Robert Apanowicz
**Last Updated:** Mon Oct 06, 2014 11:38 AM UTC
**Owner:** nobody
This ticket is the placeholder for all
