On Wed, Sep 26, 2012 at 10:24:34AM -0700, B. Scott Michel wrote:
> On 9/22/2012 12:04 AM, Andreas Jellinghaus wrote:
> >
> > > Do not "fix" unused param warnings. The correct way to fix them is to
> > > remove the parameter.
> >
> > Well, with c style object orientation we have interfaces that all
On 9/22/2012 12:04 AM, Andreas Jellinghaus wrote:
>
> > Do not "fix" unused param warnings. The correct way to fix them is to
> > remove the parameter.
>
> Well, with c style object orientation we have interfaces that all card
> drivers must implement, even if they don't use all function parameter
2012/9/22 B. Scott Michel :
> I'm not a fan of rejected and resubmitted patches -- I prefer to discuss
> first before issuing the pull request. That way, the receiver ends up
> understanding the intent of the patch versus reacting to the patch.
> Neither I nor the patch reviewer can read each other
Am 21.09.2012 09:41 schrieb "Ludovic Rousseau" :
>
> Hello,
>
> 2012/9/20 B. Scott Michel :
> > I'm debating whether to submit a pull request on github with patches to
> > reduce gcc's warnings to a minimum (actually, completely eliminated.)
> > However, the patches violate the coding rules by mark
On 9/21/2012 12:40 AM, Ludovic Rousseau wrote:
> Hello,
>
> 2012/9/20 B. Scott Michel :
>> I'm debating whether to submit a pull request on github with patches to
>> reduce gcc's warnings to a minimum (actually, completely eliminated.)
>> However, the patches violate the coding rules by marking unu
Hello,
2012/9/20 B. Scott Michel :
> I'm debating whether to submit a pull request on github with patches to
> reduce gcc's warnings to a minimum (actually, completely eliminated.)
> However, the patches violate the coding rules by marking unused
> parameters in static functions -- the "marking" i
I'm debating whether to submit a pull request on github with patches to
reduce gcc's warnings to a minimum (actually, completely eliminated.)
However, the patches violate the coding rules by marking unused
parameters in static functions -- the "marking" is very explicit and
very visible.
I also to
