Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > indra/newview/llviewertexturelist.cpp, lines 719-721 > > > > > > * No check for mInitialized before accessing sRenderThreadID. > > * I don't quite get

[opensource-dev] Daily Scrum Summary - Thursday, April 14

Sprint 14, ends 04.25.11 Thursday, April 14 General Notes -- - Remember to look in 'Fix Version: open development' queue in STORM and VWR - those are the issues we'll be really happy to see you take :) - MM: Oz - Grumpity OOO 4/15 Team Status -

Re: [opensource-dev] Windows compiling problem

I was finally able to solve my problem. I went back to a pre viewer-development version of autobuild and tried to compile that and got an error about unable to find winres.h (see storm-859). Then it was a matter of adjusting my include list to specify where that file is for vs2010 Express and bot

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > indra/newview/llviewertexturelist.cpp, lines 502-517 > > > > > > Almost every line of this method is a potential crasher. > > Are you sure we should ha

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 3:48 p.m., Boroondas Gupte wrote: > > indra/newview/llviewertexturelist.h, line 191 > > > > > > Any reason for this to be BOOL instead of bool? > > Also, remove the space between the name and th

Re: [opensource-dev] Review Request: partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions

> On March 25, 2011, 6:20 p.m., Merov Linden wrote: > > indra/newview/llappviewer.cpp, lines 1417-1420 > > > > > > Aren't we in danger of immediate crash when called? If so, what happens > > if we return here? Do we

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 3:48 p.m., Boroondas Gupte wrote: > > indra/newview/llviewertexturelist.h, line 191 > > > > > > Any reason for this to be BOOL instead of bool? > > Also, remove the space between the name and th

Re: [opensource-dev] Review Request: fix for STORM-973: [crashhunters] crash at LLViewerTextureList::removeImageFromList(LLViewerFetchedTexture *)7

> On April 8, 2011, 12:53 p.m., Vadim ProductEngine wrote: > > indra/newview/llviewertexturelist.cpp, lines 502-517 > > > > > > Almost every line of this method is a potential crasher. > > Are you sure we should ha

Re: [opensource-dev] PO Review Build

2011/4/13 Oz Linden (Scott Lawrence) > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/226501/index.html > > > STORM-413 The presentation > of IM sessions in message well depends on method that was used for ope

Re: [opensource-dev] Windows compiling problem

Had the bad luck to run into a sketchy update among the ones released this past Patch Tuesday, so in case anyone else is seeing the same thing: If Windows Update can't seem to install KB2455033, there's a workaround [1] going around saying to install KB2519277 first - but *don't* do that. If you d

Re: [opensource-dev] PO Review Build

On Thu, Apr 14, 2011 at 21:35, Anya Kanevsky wrote: > OO, are you seeing STORM-842 as well? I'm seeing completely inconsistent behaviour. Maybe I'm seeing multiple issues which mix up. Add some networking issues which makes saving Landmarks even less reliable... Anyway, the feature doesn't workin

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

> On April 14, 2011, 12:37 p.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/panel_people.xml, lines 117-127 > > > > > > I'd prefer to have the attributes ordered semantically (i.e. 'name' > > first,

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review603 --- Ship it! Looks fine and works well for me, however I don't quite

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

> On April 14, 2011, 12:37 p.m., Boroondas Gupte wrote: > > indra/newview/skins/default/xui/en/panel_people.xml, lines 117-127 > > > > > > I'd prefer to have the attributes ordered semantically (i.e. 'name' > > first,

Re: [opensource-dev] PO Review Build

since i cant get the favorites to poulate on my two mains period, i was about to say i couldnt help but then i checked one of my other alts using a totally differant machine. I can reliably reproduce both storm-1145 and storm-842. (and would comment in the jiras if i were able to do so) From:

Re: [opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/#review602 --- Ship it! Already giving a 'Ship it', as all my comments below add

Re: [opensource-dev] PO Review Build

Can I solicit some help from the class on this one and STORM-842 "Start at" list isn't populated with favorites if user name is typed in fashion "firstname.lastname" ? They work perfectly for me, and Trillo, and I can't seem to repro the bug with this b

Re: [opensource-dev] PO Review Build

On Wed, Apr 13, 2011 at 20:46, Oz Linden (Scott Lawrence) wrote: > STORM-1145 Changes to Favorites are not reflected on the login locations > menu As I commented in JIRA, I still see the problem. Does this fix cover old-style usernames as well? (I log in as "Opensource Obscure") Opensource Obs

[opensource-dev] Review Request: STORM-1103 Nearby sidebar minimap should be optional

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/265/ --- Review request for Viewer. Summary --- Patch makes the map in the Near

[opensource-dev] Daily Scrum Summary - Wednesday, April 13

Sprint 14, ends 04.25.11 Wednesday, April 13 General Notes -- - Remember to look in 'Fix Version: open development' queue in STORM and Open development candidates in VWR - those are the issues we'll be really happy to see you take :) - MM: Oz - Grumpity

[opensource-dev] Daily Scrum Summary - Tuesday, April 12

Sprint 14, ends 04.25.11 Tuesday, April 12 General Notes -- - MMOTD: Oz Team Status -- Oz Linden -- *PAST* - Sprint Planning - Configured project viewer build for Windlight *FUTURE* - PO Review b