Re: [opensource-dev] Question about BUG-41029 and 64 bit usage

FWIW, those particular units types were introduced as part of the LLTrace metrics update and found several cases where the incorrect units were being recorded, resulting in skewed/invalid metrics. The point is not that it is hard to multiply by a constant to do unit conversion...it is that

Re: [opensource-dev] XML schema

That wiki page relies on being manually kept up to date, which is not something we've been doing.  While there is currently no official schema for XUI files, that will change in the future.  The parameter blocks as defined in code are theoretically able to generate their own schemata at runtime.  

Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

> On Nov. 9, 2012, 2:05 p.m., Richard Nelson wrote: > > indra/newview/llappviewer.cpp, line 3376 > > <http://codereview.secondlife.com/r/607/diff/1/?file=8087#file8087line3376> > > > > Structurally, it seems like this would be cleaner if opening the file,

Re: [opensource-dev] Review Request: Put the viewer version into marker files, and report errors only when the version matches

at the file needs to be opened before being passed into recordMarkerVersion and closed afterwards. Just picking a nit, sorry. - Richard Nelson On Nov. 2, 2012, 1:55 p.m., Oz Linden wrote: > > --- > This is an automatica

Re: [opensource-dev] "Adding a dialog" outdated

Yes, LLFloaterReg is the current mechanism for creating and displaying new types of floaters (windows).There is a separate mechanism for "notification" style dialogs, in llnotifications*.h/cpp, appropriately enough.  Unfortunately, I don't think there is good documentation in the wiki for that yet

Re: [opensource-dev] XUI Cleanup Project

n Fri, 03 Aug 2012 16:47:35 -0700, Kadah wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 8/3/2012 3:36 PM, Richard Nelson wrote: >> There is already code to round-trip XUI files through the param >> block mechanism such that invalid attributes and defa

Re: [opensource-dev] XUI Cleanup Project

There is already code to round-trip XUI files through the param block mechanism such that invalid attributes and default values are dropped and formatting is normalized. That code hasn't been exercised in a few years, though, so it probably won't run correctly right away, but it does provide

Re: [opensource-dev] Review Request: STORM-1899: Avatar hand poses randomly get stuck in spread position

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/592/#review1240 --- Ship it! Ship It! - Richard Nelson On July 25, 2012, 3:12

Re: [opensource-dev] Review Request: STORM-1899: Avatar hand poses randomly get stuck in spread position

ttp://codereview.secondlife.com/r/592/#comment1136> you probably don't want to write to this memory if you are getting bad values. Best to warn and then do nothing. - Richard Nelson On July 19, 2012, 2:11 p.m., Ansariel Hiller wrote: > > ---

Re: [opensource-dev] Review Request: STORM-1713: Mouse pointer flickers when hovering over any active/clickable UI item

nd up testing this on all 3 platforms during the merge process, so hopefully all goes well. - Richard Nelson On Dec. 5, 2011, 2:43 p.m., Ansariel Hiller wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [opensource-dev] Review Request: STORM-1713: Mouse pointer flickers when hovering over any active/clickable UI item

3> I know this is reverting to older behavior, but the older behavior is wrong in tying the ability to set cursors to the mouse_opaque attribute. - Richard Nelson On Dec. 5, 2011, 9:20 a.m., Ansariel Hiller wrote: > > --- >

Re: [opensource-dev] Review Request: STORM-1713: Mouse pointer flickers when hovering over any active/clickable UI item

. setting tooltip, changing mouse cursor, etc.) is that by default the leafmost view wins. In this case, the proper fix is to store the current mouse cursor in your LLWindow* implementation and then only set it once a frame in LLWindow*::gatherInput() - Richard Nelson On Dec. 5, 2011, 9:20 a.m

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

> On Nov. 23, 2011, 8:18 a.m., Richard Nelson wrote: > > Quick comment regarding behavior...we really should not play any audio > > during the teleport blackout as it is disconcerting to feel like you are > > still in an area (hearing the audio) but not be able to see

Re: [opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/520/#review1090 --- Quick comment regarding behavior...we really should not play any

Re: [opensource-dev] Review Request: STORM-1615 Please update language support for Viewer

. 11, 2011, 10:48 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > - Added Traditional Chinese to the Language dropdown menu in Preferences / > General. > The language is already supported, it just wasn't in the menu. > - Added su

Re: [opensource-dev] Review Request: STORM-1615 Please update language support for Viewer

To reply, visit: > http://codereview.secondlife.com/r/490/ > --- > > (Updated Oct. 11, 2011, 10:48 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > - Added Traditiona

Re: [opensource-dev] Review Request: EXP-625 New user remains a cloud for an extended period on first login in Advanced mode

t. 10, 2011, 5:05 p.m.) > > > Review request for Viewer, Oz Linden, Nyx Linden, Jenn, Richard Nelson, Aura > Linden, and Brad Payne. > > > Summary > --- > > A new user logging in for the first time will remain a cloud for an > unfortunate period of time. Turns out thi

Re: [opensource-dev] Review Request: Texture Picker: Making the preview "widget" a little more flexible.

ct. 4, 2011, 8:11 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Update: would appreciate a LL yes or no to this, as it's one of the issues > that's holding back STORM-64. > > > Texture picker's preview

Re: [opensource-dev] Review Request: Texture Picker: Making the preview "widget" a little more flexible.

nerated e-mail. To reply, visit: > http://codereview.secondlife.com/r/474/ > --- > > (Updated Oct. 4, 2011, 7:26 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Upd

Re: [opensource-dev] Review Request: STORM-1600 Error in focus while naming a new item - may lead to content loss

Sept. 16, 2011, 9:14 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Folder view stole "Delete" key presses from the line editor when renaming a > newly created inventory item. > > Reason: > LLFocusMgr::se

Re: [opensource-dev] Review Request: STORM-1578, STORM-1589: Away improvements

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/473/#review1026 --- Ship it! great! - Richard On Sept. 14, 2011, 12:20 p.m., Oz L

Re: [opensource-dev] Review Request: LLProxy bugfixes and cleanup.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/463/#review1016 --- Ship it! Looks good! - Richard On Sept. 7, 2011, 7:49 a.m., L

Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review1006 --- Ship it! my comments were mostly about style and making the code

Re: [opensource-dev] Review Request: STORM-1112 Support SOCKS 5 proxy in the viewer (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/374/#review1005 --- indra/llcommon/llsingleton.h

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review1002 --- Ship it! thanks - Richard On Aug. 27, 2011, 3:01 a.m., Vadim

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review998 --- do not ship until fixing the pointer problem - Richard On Aug.

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review997 --- indra/newview/llviewermenu.cpp

Re: [opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

g. 25, 2011, 2:23 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > In busy mode offered inventory items are now moved to trash. > > There were two bugs: > > 1. When auto-discarding inventory offers we looked up missing Busy bu

Re: [opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

ereview.secondlife.com/r/444/ > --- > > (Updated Aug. 22, 2011, 4:10 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > In busy mode offered inventory items are now moved to trash. > > There wer

Re: [opensource-dev] Review Request: STORM-1268 Viewer update resets some viewer settings

g. 19, 2011, 3:55 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Bug: > Settings for ignorable dialogs were reset during deferred auto-upgrade. > > Reason: > In case of deferred upgrade (i.e. when you select "Lat

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

g. 12, 2011, 5:38 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Disallow showing URL-like avatar display names as Web links in the > ShareItemsConfirmation notification. > > Updating the tag parsing regexp to enable

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/#review970 --- We picked the precision values for those spinners based on what wo

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

> On Aug. 11, 2011, 12:29 p.m., Richard Nelson wrote: > > indra/llui/llurlentry.cpp, line 1137 > > <http://codereview.secondlife.com/r/433/diff/1/?file=6909#file6909line1137> > > > > This regexp will not allow nested tags. I'm not sure if we can handle

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

> http://codereview.secondlife.com/r/433/ > --- > > (Updated Aug. 10, 2011, 8:25 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Disallow showing URL-like avatar display names as Web links in the > ShareItemsC

Re: [opensource-dev] Review Request: STORM-1521 [previously VWR-25588]: Zi's proposed fix for FIRE-543 - Hovertext renders as overlay on top of everything else

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/405/#review938 --- Ship it! Looks good - Richard On July 21, 2011, 2:55 a.m., Bor

Re: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review885 --- Ship it! Looks good, let's try it without the change to settings.

Re: [opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character

w.secondlife.com/r/394/ > --- > > (Updated July 13, 2011, 9:06 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed text editor selection which was skipping the last character in line. >

Re: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review854 --- Please don't use code to manually set focus unless you know for su

Re: [opensource-dev] Review Request: Enable watchdog timer for Beta crash hunting.

> > Review request for Viewer, Alain Linden, Richard Nelson, and Nat Goodspeed. > > > Summary > --- > > Enable watchdog timer for Beta release to get tracebacks for classes of > crashes for which we currently have little data. > > Setting timer to 20 seconds

Re: [opensource-dev] Review Request: VWR-25862 Fix viewer caches not being cleared.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/315/#review716 --- Ship it! looks good to me. - Richard On May 27, 2011, 1:04 p.m

Re: [opensource-dev] Review Request: VWR-25609 crash on shutdown in LLGLNamePool::sInstances destructor

May 2, 2011, 4:30 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > The error is due to the fact that the instances of subclasses of LLGLNamePool > (e.g. LLVertexBuffer::sStreamVBOPool) were having their destructors run after > the dest

Re: [opensource-dev] Review Request: (STORM-229) Loading Scripts takes a long time and stalls Viewer

ed April 18, 2011, 11:25 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Partial fix for selected text indentation in script editor stalling the > viewer: disabled updating text segments until all indentation commands are >

Re: [opensource-dev] Review Request: (STORM-320) Script Editor in Viewer 2.0+ "tabs" incorrectly

il 19, 2011, 3:16 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed navigation with arrow keys through the text with enabled word-wrapping. > > Steps to repro at > https://jira.sec

Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

To reply, visit: > http://codereview.secondlife.com/r/169/ > --- > > (Updated March 4, 2011, 10:30 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed text editor to di

Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

> On March 3, 2011, 11:45 a.m., Richard Nelson wrote: > > indra/llui/lltextbase.cpp, line 604 > > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line604> > > > > this will still display views that are partially outside of the visible &

Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review409 --- indra/llui/lltextbase.cpp

Re: [opensource-dev] opensource-dev Digest, Vol 9, Issue 27

Just create a combo_box like this: and put it in the proper spot in floater_tools.xml and everything should just work. FWIW, I recommend doing development of XUI in your OS-equivalent Application Data directory: on Windows 7, for example, copy floater_to

Re: [opensource-dev] How is the XUI part of the interface designed?

Unfortunately there is no GUI editor for UI layout. We currently hand-edit XML. A GUI editor is something I've wanted to do for a while, and the framework is mostly in place. But it is still a pretty large task to undertake. R. On Wed, 06 Oct 2010 17:02:26 -0700, Robert Martin wrote: