[openssl.org #2488] Fwd: [PATCHv2] Crypto: Eliminate the unneccesary sk_PKCS7_RECIP_INFO_value call

2011-04-08 Thread Laszlo Papp via RT
Hi, From the code: http://cvs.openssl.org/fileview?f=openssl/crypto/pkcs7/pk7_doit.cv=1.79.2.1 Can this line be removed ? ri=sk_PKCS7_RECIP_INFO_value(rsk,0); The value is asked again 2 lines bottom. sk_value is only a getter, thus it does not even change the value which could modify the

[openssl.org #2489] [PATCH] Crypto: Eliminate the unneccesary sig variable usage

2011-04-08 Thread Laszlo Papp via RT
Hi, From the code: http://cvs.openssl.org/fileview?f=openssl/crypto/ocsp/ocsp_cl.cv=1.5.4.1 Can the 'sig' be removed as far as it is not used anywhere ? if (!(req-optionalSignature = sig = OCSP_SIGNATURE_new())) goto err; (also sig declaration removal) I do not see any reason for keeping that

[openssl.org #2490] [PATCH] Crypto: Eliminate the unneccesary tmp_bn variable usage

2011-04-08 Thread Laszlo Papp via RT
Hi, From the code: http://cvs.openssl.org/fileview?f=openssl/crypto/ec/ecp_nist.cv=1.32 Can the 'tmp_bn' be removed as far as it is not used anywhere ? if ((tmp_bn = BN_CTX_get(ctx)) == NULL) goto err; (also declaration removal) Please englighten me if I am mistaken about it and thank you in

11 year old file

2011-04-08 Thread Gisle Vanem
It's quite an achievement for a open-source project to not touch a file for 11 years :) The 'crypto\cast\cast_s.h' file is still missing a header guard. Just a FYI: --- openssl-SNAP-20110407\crypto\cast\cast_s.h Tue Feb 15 20:00:20 2000 +++ crypto\cast\cast_s.hWed Feb 16 18:33:28 2011

SSL 3.0 specification

2011-04-08 Thread Stanisław Findeisen
Hi Where can I find up to date SSL 3.0 specification? -- Eisenbits - proven software solutions: http://www.eisenbits.com/ OpenPGP: E3D9 C030 88F5 D254 434C 6683 17DD 22A0 8A3B 5CC0 signature.asc Description: OpenPGP digital signature

Re: SSL 3.0 specification

2011-04-08 Thread Brad Hards
On Saturday 09 April 2011 08:02:08 Stanisław Findeisen wrote: Hi Where can I find up to date SSL 3.0 specification? There isn't one. The up to date specification would be TLS 1.2. There was a proposal for SSL 3 to become an IETF doc: http://tools.ietf.org/html/draft-ietf-tls-ssl-version3-00

Re: Crypto conf api remark

2011-04-08 Thread Laszlo Papp
On Sat, Apr 9, 2011 at 6:06 AM, Ben Laurie b...@links.org wrote: On 06/04/2011 10:11, Laszlo Papp wrote: Hi, From the code: http://cvs.openssl.org/fileview?f=openssl/crypto/conf/conf_api.cv=1.18.2.1 I think 'vv' could also be eliminated from the last function (_CONF_new_section) there and