Excerpts from Radomir Dopieralski's message of 2013-11-12 00:53:40 -0800:
> On 11/11/13 20:47, Christopher Armstrong wrote:
> [...]
> > It would be so much nicer if there were some easy way for the reviewer
> > himself to fix the typos directly (in a way that can trivially be
> > accepted by the su
On Mon 11 Nov 2013 (19:28), Tim Bell wrote:
>
> As a speaker of the Queen's English, I find flavor to be incorrect.
> Does that mean I can -1 any patch that does not use flavour ?
>
> At CERN, we are working with 130 countries in a single community.
> The value of the contribution of non-english
On 11/11/13 20:47, Christopher Armstrong wrote:
[...]
> It would be so much nicer if there were some easy way for the reviewer
> himself to fix the typos directly (in a way that can trivially be
> accepted by the submitter of the patch into his own patch -- with a
> click of a button).
Well, you c
On Mon, Nov 11, 2013 at 11:02 AM, John Griffith wrote:
>
> Seems to me there's a middle ground here, but honestly if you're value
> add to the review process is catching grammatical or spelling errors
> in comments and commit messages I'd argue that in most cases it would
> be nice to have more s
Excerpts from Sean Dague's message of 2013-11-11 14:19:41 -0800:
> On 11/11/2013 02:28 PM, Tim Bell wrote:
> >
> > As a speaker of the Queen's English, I find flavor to be incorrect. Does
> > that mean I can -1 any patch that does not use flavour ?
> >
> > At CERN, we are working with 130 countr
Excerpts from Tim Bell's message of 2013-11-11 11:28:46 -0800:
>
> As a speaker of the Queen's English, I find flavor to be incorrect. Does that
> mean I can -1 any patch that does not use flavour ?
>
PEP8 states that "English" should be used. In "English" either spelling
is correct because no
From: Christopher Yeoh [mailto:cbky...@gmail.com]
Sent: Monday, November 11, 2013 3:06 PM
To: openst...@nemebean.com; OpenStack Development Mailing List (not for usage
questions)
Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
On Tue, Nov 12, 2013 at 6:24 AM, Ben Nemec
> reviewers and I'm requesting here that the native speakers step up to write
> things down. I hadn't realized how many non-native speakers we have, it's
> awesome, so let's accommodate while still valuing good communication.
>
> Thanks,
> Anne
>
>
>>
On Tue, Nov 12, 2013 at 6:24 AM, Ben Nemec wrote:
> On 2013-11-11 13:28, Tim Bell wrote:
>
>> As a speaker of the Queen's English, I find flavor to be incorrect.
>> Does that mean I can -1 any patch that does not use flavour ?
>>
>> At CERN, we are working with 130 countries in a single community
On Tue, Nov 12, 2013 at 6:19 AM, Sean Dague wrote:
> On 11/11/2013 02:28 PM, Tim Bell wrote:
> >
> > As a speaker of the Queen's English, I find flavor to be incorrect. Does
> that mean I can -1 any patch that does not use flavour ?
> >
> > At CERN, we are working with 130 countries in a single c
On 11/11/2013 02:28 PM, Tim Bell wrote:
>
> As a speaker of the Queen's English, I find flavor to be incorrect. Does that
> mean I can -1 any patch that does not use flavour ?
>
> At CERN, we are working with 130 countries in a single community. The value
> of the contribution of non-english sp
On Mon, Nov 11, 2013 at 2:42 PM, Anne Gentle wrote:
> Related to the v3 Nova API - I would also like to see a wiki page that
> outlines our preferred wording and spelling so that reviewers have a "final
> say" wiki page to refer to. For example, I heard we want to move towards
> "servers" rather
On 11/11/2013 02:28 PM, Tim Bell wrote:
As a speaker of the Queen's English, I find flavor to be incorrect.
Does that mean I can -1 any patch that does not use flavour ?
If the project had a policy that British English is the only acceptable
spelling, yes. Since it doesn't, no. (Unless we di
ge-
> > From: John Griffith [mailto:john.griff...@solidfire.com]
> > Sent: 11 November 2013 20:03
> > To: OpenStack Development Mailing List (not for usage questions)
> > Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
> >
> > On Tue, Nov
f us are desperately unrehearsed.
-- Sean O'Casey
From: Ben Nemec
To: openstack-dev@lists.openstack.org,
Date: 11/11/2013 02:05 PM
Subject: Re: [openstack-dev] [qa] Policy on spelling and gramm
On 2013-11-11 13:28, Tim Bell wrote:
As a speaker of the Queen's English, I find flavor to be incorrect.
Does that mean I can -1 any patch that does not use flavour ?
At CERN, we are working with 130 countries in a single community. The
value of the contribution of non-english speakers far excee
On Mon, Nov 11, 2013 at 12:19 PM, Clint Byrum wrote:
> Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
> > I have seen a wide variety of -1'ing (and in many cases approving)
> > patches for minor spelling or grammatical errors and think we need a
> > policy about this. Given the
e questions)
> Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
>
> On Tue, Nov 12, 2013 at 2:49 AM, James Slagle wrote:
> > -1 from me as well.
> >
> > When I first started with OpenStack, I probably would have agreed with
> > letting small grammar m
On Tue, Nov 12, 2013 at 2:49 AM, James Slagle wrote:
> -1 from me as well.
>
> When I first started with OpenStack, I probably would have agreed with
> letting small grammar mistakes and typos slide by.
>
> However, I now feel that getting commit messages right is more
> important. Also keep in m
-- Sean O'Casey
From: Clint Byrum
To: openstack-dev ,
Date: 11/11/2013 12:21 PM
Subject: Re: [openstack-dev] [qa] Policy on spelling and grammar
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
> I have seen a wi
-1 from me as well.
When I first started with OpenStack, I probably would have agreed with
letting small grammar mistakes and typos slide by.
However, I now feel that getting commit messages right is more
important. Also keep in mind that with small grammar mistakes, the
intent may be obvious to
On 2013-11-11 12:21, Collins, Sean (Contractor) wrote:
As long as the -1's include a correction that can be copied
and pasted, I think they're OK.
I know I would be grateful if someone were to
proofread my work, if I had to document in a second-language.
+1 to this as well. I figure that as a
On 2013-11-11 12:19, Clint Byrum wrote:
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
I have seen a wide variety of -1'ing (and in many cases approving)
patches for minor spelling or grammatical errors and think we need a
policy about this. Given the large number of contribut
I am in favor/favour of the -1 with suggestions on what to change. The
more input we can provide on a review the better.
Thanks
Gary
On 11/11/13 8:21 PM, "Collins, Sean (Contractor)"
wrote:
>As long as the -1's include a correction that can be copied
>and pasted, I think they're OK.
>
>I know I
As long as the -1's include a correction that can be copied
and pasted, I think they're OK.
I know I would be grateful if someone were to
proofread my work, if I had to document in a second-language.
--
Sean M. Collins
___
OpenStack-dev mailing list
Op
Excerpts from David Kranz's message of 2013-11-11 09:58:59 -0800:
> I have seen a wide variety of -1'ing (and in many cases approving)
> patches for minor spelling or grammatical errors and think we need a
> policy about this. Given the large number of contributors for whom
> English is not thei
I have seen a wide variety of -1'ing (and in many cases approving)
patches for minor spelling or grammatical errors and think we need a
policy about this. Given the large number of contributors for whom
English is not their native language, I would be in favor of rejecting
spelling errors in va
27 matches
Mail list logo
