On 20/08/13 11:24 -0400, Russell Bryant wrote:
On 08/20/2013 11:08 AM, Daniel P. Berrange wrote:
On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote:
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may
-Original Message-
From: Flavio Percoco [mailto:fla...@redhat.com]
Sent: Monday, August 26, 2013 11:41 AM
To: OpenStack Development Mailing List
Subject: Re: [openstack-dev] Code review study
On 20/08/13 11:24 -0400, Russell Bryant wrote:
On 08/20/2013 11:08 AM, Daniel P
On Tue, Aug 20, 2013 at 2:21 PM, Clint Byrum cl...@fewbar.com wrote:
Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700:
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may interest data-driven types here.
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may interest data-driven types here.
https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/
Note specifically the citation of 200-400 lines as the knee of the review
effectiveness curve: that's
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may interest data-driven types here.
https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/
Note specifically the citation of
On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote:
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may interest data-driven types here.
On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin mar...@redhat.com wrote:
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote:
The full study is here:
http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf
I can't find the data they based their numbers on,
Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700:
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote:
This may interest data-driven types here.
https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/
Note specifically the
On Wed, Aug 14, 2013 at 7:12 PM, Robert Collins
robe...@robertcollins.netwrote:
Note specifically the citation of 200-400 lines as the knee of the review
effectiveness curve: that's lower than I thought - I thought 200 was
clearly fine - but no.
This is really interesting. I wish they would
On Tue, Aug 20, 2013 at 5:14 AM, Jay Buffington m...@jaybuff.com wrote:
This is really interesting. I wish they would have explicitly defined
lines of code. Is that git show |wc -l? Just the new lines which
were added? The sum of the lines changed, removed and added? You can
get vastly
but mandatory.
m.
https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages
Sam
From: Christopher Yeoh [mailto:cbky...@gmail.com]
Sent: Thursday, August 15, 2013 7:12 AM
To: OpenStack Development Mailing List
Subject: Re: [openstack-dev] Code review
On 16 August 2013 20:15, Maru Newby ma...@redhat.com wrote:
This pattern has one slight issue, which is:
• Do not assume the reviewer has access to external web services/site.
In 6 months time when someone is on a train/plane/coach/beach/pub
troubleshooting a problem browsing GIT
On Aug 16, 2013, at 2:12 AM, Robert Collins robe...@robertcollins.net wrote:
On 16 August 2013 20:15, Maru Newby ma...@redhat.com wrote:
This pattern has one slight issue, which is:
• Do not assume the reviewer has access to external web services/site.
In 6 months time when someone
That's an interesting article and also meaningful for coders. If I have a
patch more than 200 or 300 lines, to split this may be a good idea.
Some time, an easy patch with a little more lines would prevent more
reviewers to think about it.
On Thu, Aug 15, 2013 at 10:12 AM, Robert Collins
On Thu, Aug 15, 2013 at 7:12 AM, Christopher Yeoh cbky...@gmail.com wrote:
On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins
robe...@robertcollins.net wrote:
This may interest data-driven types here.
https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange
berra...@redhat.comwrote:Commit message quality has improved
somewhat since I first wrote
published
that page, but there's definitely still scope to improve things further.
What
it really needs is for more reviewers to push back against
On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com wrote:
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange
berra...@redhat.comwrote:Commit message quality has improved somewhat since
I first wrote
published
that page, but there's definitely still scope to improve
On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote:
On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com wrote:
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange
berra...@redhat.comwrote:Commit message quality has improved somewhat
since I first wrote
On Thu, Aug 15, 2013 at 9:56 AM, Daniel P. Berrange berra...@redhat.comwrote:
On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote:
On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com
wrote:
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange
On Thu, Aug 15, 2013 at 12:00 PM, Mark Washenberger
mark.washenber...@markwash.net wrote:
On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh cbky...@gmail.comwrote:
On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins
robe...@robertcollins.net wrote:
This may interest data-driven types
formatting and hyperlinks in my
documentation of the commit.
Sam
From: Christopher Yeoh [mailto:cbky...@gmail.com]
Sent: Thursday, August 15, 2013 7:12 AM
To: OpenStack Development Mailing List
Subject: Re: [openstack-dev] Code review study
On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins
robe
21 matches
Mail list logo
