Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
On Mon, Jul 31, 2017 at 09:09:52PM -0500, Matt Riedemann wrote: > On 7/31/2017 5:21 PM, Tony Breeds wrote: > > We need a +1 from the release team (are they okay to accept a late > > release of glance_store); and a +1 from glance (are they okay to do said > > release) > > Glance doesn't actually need this minimum version bump for os-brick, the fix > is for some attached volume extend stuff, which isn't related to Glance, so > does having the minimum bump in glance* matter? Maybe it doesn't I can't think of a scenario where someone will end up with 1.15.1 if the mix glance and nova. If glance_store doesn't take the bump of os-brick before we release pike then they're going to be faced with breaking the "we don't bump minimums on stable branches" or opting out of requirements management for that branch aren't they? Yours Tony. signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
Do it +1 On Mon, Jul 31, 2017 at 7:37 AM, Sean McGinnis wrote: > I am requesting a library release of os-brick during the feature freeze > in order to fix an issue with the recently landed online volume extend > feature across Nova and Cinder. > > Patches have landed in both projects to add this feature. It wasn't until > later that Matt was able to get tempest tests in that found an issue with > some of the logic in the os-brick library. That has now been fixed in the > stable/pike branch in os-brick with this patch: > > https://review.openstack.org/#/c/489227/ > > We can get a new library release out as soon as the freeze is over, but > due to the fact that we do not raise global requirements for stable > branches after release, there could be some deployments that would still > use the old ("broken") lib. We would need to get this release out before > the final pike branching of Cinder and Nova to be able to raise G-R to > make sure the new release is used with this fix. > > I see this change as a low risk for other regression, and it would allow > us to not ship a broken feature. > > Thanks, > Sean > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
On 17-07-31 21:09:52, Matt Riedemann wrote: > On 7/31/2017 5:21 PM, Tony Breeds wrote: > > We need a +1 from the release team (are they okay to accept a late > > release of glance_store); and a +1 from glance (are they okay to do said > > release) > > Glance doesn't actually need this minimum version bump for os-brick, the > fix is for some attached volume extend stuff, which isn't related to > Glance, so does having the minimum bump in glance* matter? > > -- > > Thanks, > > Matt > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev For co-installability between projects it'd be good to be in sync. The same could be said to many of the bumps that go through the requirements project. One of the things we've been working on is divergent requirements, where the goal is to keep making sure all projects test against one set of upper-constraints, but allow each project to manage their requirements outside of that. -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
On 7/31/2017 5:21 PM, Tony Breeds wrote: We need a +1 from the release team (are they okay to accept a late release of glance_store); and a +1 from glance (are they okay to do said release) Glance doesn't actually need this minimum version bump for os-brick, the fix is for some attached volume extend stuff, which isn't related to Glance, so does having the minimum bump in glance* matter? -- Thanks, Matt __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
On Mon, Jul 31, 2017 at 03:00:16PM -0500, Sean McGinnis wrote: > > I am requesting a library release of os-brick during the feature freeze > > in order to fix an issue with the recently landed online volume extend > > feature across Nova and Cinder. > > > > New os-brick 1.15.2 release has been requested here: > > https://review.openstack.org/489370 From a requirements POV I'm fine with that. It affects: Package : os-brick [os-brick>=1.15.1] (used by 8 projects) Also affects : 8 projects openstack/cinder [tc:approved-release] openstack/compute-hyperv [] openstack/freezer [] openstack/fuxi[] openstack/glance_store[] openstack/nova[tc:approved-release] openstack/nova-lxd[] openstack/python-brick-cinderclient-ext [] The one that is *most* problematic is glance_store We already have an FFE for glance_store it's probably ok. We need a +1 from the release team (are they okay to accept a late release of glance_store); and a +1 from glance (are they okay to do said release) Yours Tony. signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
> I am requesting a library release of os-brick during the feature freeze > in order to fix an issue with the recently landed online volume extend > feature across Nova and Cinder. > New os-brick 1.15.2 release has been requested here: https://review.openstack.org/489370 Thanks, Sean __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
Sounds reasonable for me too. Regards, Ivan Kolodyazhny, http://blog.e0ne.info/ On Mon, Jul 31, 2017 at 5:40 PM, Davanum Srinivas wrote: > I'd support this Sean. +1 > > Thanks, > Dims > > On Mon, Jul 31, 2017 at 10:37 AM, Sean McGinnis > wrote: > > I am requesting a library release of os-brick during the feature freeze > > in order to fix an issue with the recently landed online volume extend > > feature across Nova and Cinder. > > > > Patches have landed in both projects to add this feature. It wasn't until > > later that Matt was able to get tempest tests in that found an issue with > > some of the logic in the os-brick library. That has now been fixed in the > > stable/pike branch in os-brick with this patch: > > > > https://review.openstack.org/#/c/489227/ > > > > We can get a new library release out as soon as the freeze is over, but > > due to the fact that we do not raise global requirements for stable > > branches after release, there could be some deployments that would still > > use the old ("broken") lib. We would need to get this release out before > > the final pike branching of Cinder and Nova to be able to raise G-R to > > make sure the new release is used with this fix. > > > > I see this change as a low risk for other regression, and it would allow > > us to not ship a broken feature. > > > > Thanks, > > Sean > > > > > __ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject: > unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > -- > Davanum Srinivas :: https://twitter.com/dims > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
Yep, please submit the review refrencing this thread, lgtm. On 17-07-31 10:40:10, Davanum Srinivas wrote: > I'd support this Sean. +1 > > Thanks, > Dims > > On Mon, Jul 31, 2017 at 10:37 AM, Sean McGinnis wrote: > > I am requesting a library release of os-brick during the feature freeze > > in order to fix an issue with the recently landed online volume extend > > feature across Nova and Cinder. > > > > Patches have landed in both projects to add this feature. It wasn't until > > later that Matt was able to get tempest tests in that found an issue with > > some of the logic in the os-brick library. That has now been fixed in the > > stable/pike branch in os-brick with this patch: > > > > https://review.openstack.org/#/c/489227/ > > > > We can get a new library release out as soon as the freeze is over, but > > due to the fact that we do not raise global requirements for stable > > branches after release, there could be some deployments that would still > > use the old ("broken") lib. We would need to get this release out before > > the final pike branching of Cinder and Nova to be able to raise G-R to > > make sure the new release is used with this fix. > > > > I see this change as a low risk for other regression, and it would allow > > us to not ship a broken feature. > > > > Thanks, > > Sean > > > > __ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > -- > Davanum Srinivas :: https://twitter.com/dims > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Matthew Thode (prometheanfire) signature.asc Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
I'd support this Sean. +1 Thanks, Dims On Mon, Jul 31, 2017 at 10:37 AM, Sean McGinnis wrote: > I am requesting a library release of os-brick during the feature freeze > in order to fix an issue with the recently landed online volume extend > feature across Nova and Cinder. > > Patches have landed in both projects to add this feature. It wasn't until > later that Matt was able to get tempest tests in that found an issue with > some of the logic in the os-brick library. That has now been fixed in the > stable/pike branch in os-brick with this patch: > > https://review.openstack.org/#/c/489227/ > > We can get a new library release out as soon as the freeze is over, but > due to the fact that we do not raise global requirements for stable > branches after release, there could be some deployments that would still > use the old ("broken") lib. We would need to get this release out before > the final pike branching of Cinder and Nova to be able to raise G-R to > make sure the new release is used with this fix. > > I see this change as a low risk for other regression, and it would allow > us to not ship a broken feature. > > Thanks, > Sean > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [Cinder][Nova][Requirements] Lib freeze exception for os-brick
I am requesting a library release of os-brick during the feature freeze in order to fix an issue with the recently landed online volume extend feature across Nova and Cinder. Patches have landed in both projects to add this feature. It wasn't until later that Matt was able to get tempest tests in that found an issue with some of the logic in the os-brick library. That has now been fixed in the stable/pike branch in os-brick with this patch: https://review.openstack.org/#/c/489227/ We can get a new library release out as soon as the freeze is over, but due to the fact that we do not raise global requirements for stable branches after release, there could be some deployments that would still use the old ("broken") lib. We would need to get this release out before the final pike branching of Cinder and Nova to be able to raise G-R to make sure the new release is used with this fix. I see this change as a low risk for other regression, and it would allow us to not ship a broken feature. Thanks, Sean __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev