Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On 2/6/2015 7:20 AM, Sean Dague wrote: Ok, my bad. When I proposed this part of the Nova meeting I was also thinking about "lost" patches where a couple of weeks had gone by without any negative feedback and the patch author got a chance to advocate for it. That's how we used it in Tempest meetings. The theory being that engaging in more communication might help with having patches be a little closer to what's needed for merge. On 02/05/2015 07:46 PM, Michael Still wrote: Certainly it was my intent when I created that agenda item to cover reviews that wouldn't otherwise reach a decision -- either two cores wedged, or something else that we can't resolve trivially in gerrit. Now, I can see that people don't like reviews sitting for a long time, but that's probably too long a list to cover in an IRC meeting. I'm not opposed to trying, but we should set expectations that we're going to talk about only a few important reviews, not the dozens that are unloved. Michael On Fri, Feb 6, 2015 at 9:27 AM, Tony Breeds wrote: On Thu, Feb 05, 2015 at 11:13:50PM +0100, Sylvain Bauza wrote: I was always considering stuck reviews as reviews where 2 or more cores were disagreeing between themselves so that it was needing a debate discussion during the meeting. I was under the same impression. Stuck reviews were for reviewws were there was strong disagreement (amongst cores) Other reviews can be discussed as part of "Open discussion" Yours Tony. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev We also have this [1]. That shows unloved reviews which have been open for a long time (by latest revision, 72 days currently), by oldest revision without a negative score (76 days currently), and oldest reviews since first revision (247 days currently). I don't know if just slapping that link into the nova meeting agenda would help at all, but maybe we could take the top 3 oldest changes out of there and post those for each meeting agenda to get people to focus on them? [1] http://russellbryant.net/openstack-stats/nova-openreviews.html -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
Ok, my bad. When I proposed this part of the Nova meeting I was also thinking about "lost" patches where a couple of weeks had gone by without any negative feedback and the patch author got a chance to advocate for it. That's how we used it in Tempest meetings. The theory being that engaging in more communication might help with having patches be a little closer to what's needed for merge. On 02/05/2015 07:46 PM, Michael Still wrote: > Certainly it was my intent when I created that agenda item to cover > reviews that wouldn't otherwise reach a decision -- either two cores > wedged, or something else that we can't resolve trivially in gerrit. > > Now, I can see that people don't like reviews sitting for a long time, > but that's probably too long a list to cover in an IRC meeting. I'm > not opposed to trying, but we should set expectations that we're going > to talk about only a few important reviews, not the dozens that are > unloved. > > Michael > > On Fri, Feb 6, 2015 at 9:27 AM, Tony Breeds wrote: >> On Thu, Feb 05, 2015 at 11:13:50PM +0100, Sylvain Bauza wrote: >> >>> I was always considering stuck reviews as reviews where 2 or more cores were >>> disagreeing between themselves so that it was needing a debate discussion >>> during the meeting. >> >> I was under the same impression. >> >> Stuck reviews were for reviewws were there was strong disagreement (amongst >> cores) >> Other reviews can be discussed as part of "Open discussion" >> >> Yours Tony. >> >> __ >> OpenStack Development Mailing List (not for usage questions) >> Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >> > > > -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
Certainly it was my intent when I created that agenda item to cover reviews that wouldn't otherwise reach a decision -- either two cores wedged, or something else that we can't resolve trivially in gerrit. Now, I can see that people don't like reviews sitting for a long time, but that's probably too long a list to cover in an IRC meeting. I'm not opposed to trying, but we should set expectations that we're going to talk about only a few important reviews, not the dozens that are unloved. Michael On Fri, Feb 6, 2015 at 9:27 AM, Tony Breeds wrote: > On Thu, Feb 05, 2015 at 11:13:50PM +0100, Sylvain Bauza wrote: > >> I was always considering stuck reviews as reviews where 2 or more cores were >> disagreeing between themselves so that it was needing a debate discussion >> during the meeting. > > I was under the same impression. > > Stuck reviews were for reviewws were there was strong disagreement (amongst > cores) > Other reviews can be discussed as part of "Open discussion" > > Yours Tony. > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > -- Rackspace Australia __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On Thu, Feb 05, 2015 at 11:13:50PM +0100, Sylvain Bauza wrote: > I was always considering stuck reviews as reviews where 2 or more cores were > disagreeing between themselves so that it was needing a debate discussion > during the meeting. I was under the same impression. Stuck reviews were for reviewws were there was strong disagreement (amongst cores) Other reviews can be discussed as part of "Open discussion" Yours Tony. pgpCYUA7Vi0Mh.pgp Description: PGP signature __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
Le 05/02/2015 17:54, Sean Dague a écrit : On 02/05/2015 11:50 AM, Daniel P. Berrange wrote: On Thu, Feb 05, 2015 at 10:42:48AM -0600, Ed Leafe wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 09:02 AM, Alexis Lee wrote: May I suggest stricter moderation? EG a short phase to propose items, then work through them 1 by 1. Or, we take items one by one according to who shouts fastest but ask people not to interrupt. Or how about going through the ones listed on the agenda, rather than having a free-for-all shouting match? Indeed, I thought that was the whole point of putting them in the agenda in the first place :-) Agreed, I think it just got away from us today with lots of first time attendees. We'll just have to be a little clearer next time. -Sean I was always considering stuck reviews as reviews where 2 or more cores were disagreeing between themselves so that it was needing a debate discussion during the meeting. If we're only saying that 'stuck' means a review which hasn't been reviewed since a certain amount of time, then we will be having lots of people jumping in to ask for a review, so it would be counterproductive. -Sylvain __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
LOL :) -- dims On Thu, Feb 5, 2015 at 4:22 PM, Matt Riedemann wrote: > > > On 2/5/2015 10:54 AM, Sean Dague wrote: >> >> On 02/05/2015 11:50 AM, Daniel P. Berrange wrote: >>> >>> On Thu, Feb 05, 2015 at 10:42:48AM -0600, Ed Leafe wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 09:02 AM, Alexis Lee wrote: > May I suggest stricter moderation? EG a short phase to propose > items, then work through them 1 by 1. Or, we take items one by one > according to who shouts fastest but ask people not to interrupt. Or how about going through the ones listed on the agenda, rather than having a free-for-all shouting match? >>> >>> >>> Indeed, I thought that was the whole point of putting them in the >>> agenda in the first place :-) >> >> >> Agreed, I think it just got away from us today with lots of first time >> attendees. We'll just have to be a little clearer next time. >> >> -Sean >> > > Lots of first time attendees on the day of feature freeze? Weird... > > -- > > Thanks, > > Matt Riedemann > > > __ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Davanum Srinivas :: https://twitter.com/dims __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On 2/5/2015 10:54 AM, Sean Dague wrote: On 02/05/2015 11:50 AM, Daniel P. Berrange wrote: On Thu, Feb 05, 2015 at 10:42:48AM -0600, Ed Leafe wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 09:02 AM, Alexis Lee wrote: May I suggest stricter moderation? EG a short phase to propose items, then work through them 1 by 1. Or, we take items one by one according to who shouts fastest but ask people not to interrupt. Or how about going through the ones listed on the agenda, rather than having a free-for-all shouting match? Indeed, I thought that was the whole point of putting them in the agenda in the first place :-) Agreed, I think it just got away from us today with lots of first time attendees. We'll just have to be a little clearer next time. -Sean Lots of first time attendees on the day of feature freeze? Weird... -- Thanks, Matt Riedemann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On 02/05/2015 11:50 AM, Daniel P. Berrange wrote: > On Thu, Feb 05, 2015 at 10:42:48AM -0600, Ed Leafe wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 02/05/2015 09:02 AM, Alexis Lee wrote: >> >>> May I suggest stricter moderation? EG a short phase to propose >>> items, then work through them 1 by 1. Or, we take items one by one >>> according to who shouts fastest but ask people not to interrupt. >> >> Or how about going through the ones listed on the agenda, rather than >> having a free-for-all shouting match? > > Indeed, I thought that was the whole point of putting them in the > agenda in the first place :-) Agreed, I think it just got away from us today with lots of first time attendees. We'll just have to be a little clearer next time. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On Thu, Feb 05, 2015 at 10:42:48AM -0600, Ed Leafe wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 02/05/2015 09:02 AM, Alexis Lee wrote: > > > May I suggest stricter moderation? EG a short phase to propose > > items, then work through them 1 by 1. Or, we take items one by one > > according to who shouts fastest but ask people not to interrupt. > > Or how about going through the ones listed on the agenda, rather than > having a free-for-all shouting match? Indeed, I thought that was the whole point of putting them in the agenda in the first place :-) Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2015 09:02 AM, Alexis Lee wrote: > May I suggest stricter moderation? EG a short phase to propose > items, then work through them 1 by 1. Or, we take items one by one > according to who shouts fastest but ask people not to interrupt. Or how about going through the ones listed on the agenda, rather than having a free-for-all shouting match? - -- - -- Ed Leafe -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) iQIcBAEBAgAGBQJU052HAAoJEKMgtcocwZqLHiIP/A7vIQsh219+7mnxttDPLc4A Av25XW6WJDVciPlR5VIlDIQTdl/Gy2sv2IyArhmmBalnBRiFmWbkjli9lg3/r2IY //EtkRGNiOPSiXRVoWBSF4z/yceO/8iTdmjikVuLOCDtP9TD96Va3wxM8JFVQqa6 YpF05SqEUHoWIB1+sZ0tqK6PsDH07hgWT472kZ4jOjL9ZZUS8abAaX72tltqmt2x V0e/liLdiO9sDD5owRZhOV6ho6AIkSeh76Ng6q9sLIKZC/Tm94s/M4R88kLaSpqE PqaL06z5OTQXEKzBuVu6irV2c389JEdhG3HpmgI+r/b7jQJoy5Ui73V8h6+dNVvG /hbUIoJGTQY+jgZTfDgOq41ceu0ujdhO29bR0WnfcLN9RRc0sz/cTz1c6n1MvBmP knBkYd+TjYbsdgI7m3gD9TIvs1rgS8FQ6OOKaDHoqxrjL19rrGFOn2ZsjcODJSnk m0Bm1Dj6jpPcyzxGZoKWJLlZ2WQvUvR6RRLw52DXWUxdUdYGIqKFpAwHrjbAzSyg LOuyK90vixCR1Nv+iCSguvRqCo0bxGwHZfOua00qf2RQF0ByQh4cbqA+P1PuE+kC GOP8doUbqIHMLuU1aHdIAL5u6q9ussqdc5InN58zaju2o4sdggbh2e1NBwkSM77f KTd+HJNCsApaXhP7mRWS =wUry -END PGP SIGNATURE- __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
On 05/02/15 15:02, Alexis Lee wrote: > Sean Dague said on Wed, Feb 04, 2015 at 09:51:30AM -0500: >> As there has been a bunch of concern around patches getting lost or >> stuck, I wanted to re-announce the fact that we've got a dedicated slot >> at the weekly Nova meeting for just those sorts of things. > > The slot turned into everyone talking at once fairly quickly this week. > That led to several patches not getting a real discussion. > > May I suggest stricter moderation? EG a short phase to propose items, > then work through them 1 by 1. Or, we take items one by one according to > who shouts fastest but ask people not to interrupt. +1 Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK) GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] [nova] stuck patches at the nova IRC meeting
Sean Dague said on Wed, Feb 04, 2015 at 09:51:30AM -0500: > As there has been a bunch of concern around patches getting lost or > stuck, I wanted to re-announce the fact that we've got a dedicated slot > at the weekly Nova meeting for just those sorts of things. The slot turned into everyone talking at once fairly quickly this week. That led to several patches not getting a real discussion. May I suggest stricter moderation? EG a short phase to propose items, then work through them 1 by 1. Or, we take items one by one according to who shouts fastest but ask people not to interrupt. Alexis -- Nova Engineer, HP Cloud. AKA lealexis, lxsli. __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
[openstack-dev] [nova] stuck patches at the nova IRC meeting
As there has been a bunch of concern around patches getting lost or stuck, I wanted to re-announce the fact that we've got a dedicated slot at the weekly Nova meeting for just those sorts of things. https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting The "Stuck reviews" time block is a weekly dedicated slot where a bunch of nova cores will be. If you believe your patch is stuck solely by lack of attention (nothing actually wrong with it), please attend the Nova meeting, add your review to the list (with your IRC handle) and be prepared to give a 60 second pitch about your patch in question. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev