Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[We We]

Hi,
Thank you for your kind reply. 
I'm not thinking enough about this part of my work. I am sorry for that, please 
close the  FFE of the pyspdk.

Thanks,
Helloway
> 在 2018年1月31日，上午1:54，We We  写道：
> 
>> Hi,
> 
>> I have modified and resubmitted  pyspdk to the pypi. Please check it.
> 
>> Thx,
> 
>> Helloway
> 
>> 在 2018年1月30日，下午12:52，We We mailto:simple_...@163.com>> 
>> 写道：
>> 
>> Hi,
>> The pyspdk is a important tool library [1] which  supports Cyborg SPDK 
>> driver [2] to manage the backend SPDK-base app, so we need to upload pyspdk 
>> into the pypi [3]  and then append 'pyspdk>=0.0.1’ item into 
>> ‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built 
>> correctly when zuul runs. However, It's not what we thought it would be, if 
>> we want to  add the new requirements, we should get support from upstream 
>> OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.
>> 
>> I'm sorry for propose the request so late. Please Please help.
>> 
>> 
>> [1] https://review.gerrithub.io/#/c/379741/ 
>> 
>> [2] https://review.openstack.org/#/c/538164/11 
>> 
>> [3] https://pypi.python.org/pypi/pyspdk/0.0.1 
>> 
>> [4] https://github.com/openstack/requirements 
>> 
>> 
>> 
>> Regards,
>> Helloway
>> 
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Jeremy Stanley]

On 2018-01-31 10:44:12 -0600 (-0600), Matthew Thode wrote:
[...]
> Thanks for the link, and yes should probably just be discussed in a
> review.  Missing a setup.py/cfg and license and testing all make it seem
> like a no-go though.

The 0.0.2 sdist on PyPI does contain those, leading me to suspect
that either the GH repo is non-canonical or its Python packaging
files are maintained independent of revision control.
-- 
Jeremy Stanley


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Matthew Thode]

On 18-01-31 10:15:12, Thierry Carrez wrote:
> Doug Hellmann wrote:
> > Excerpts from We We's message of 2018-01-31 01:54:04 +0800:
> >>> Hi,
> >>
> >>> I have modified and resubmitted  pyspdk to the pypi. Please check it.
> >>
> >>> Thx,
> >>
> >>> Helloway
> > 
> > Is there a public source repository for the library somewhere?
> 
> Looks like it lives at:
> https://github.com/hellowaywewe/py-spdk
> 
> Since the primary objections are not really due to the FFE state but
> more due to the nature of the library, this should probably first be
> proposed as a change to openstack/requirements and discussed there...
> 
> When it's ready but blocked by FF we can return to a ML thread to
> discuss it...
> 

Thanks for the link, and yes should probably just be discussed in a
review.  Missing a setup.py/cfg and license and testing all make it seem
like a no-go though.

-- 
Matthew Thode (prometheanfire)


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Thierry Carrez]

Doug Hellmann wrote:
> Excerpts from We We's message of 2018-01-31 01:54:04 +0800:
>>> Hi,
>>
>>> I have modified and resubmitted  pyspdk to the pypi. Please check it.
>>
>>> Thx,
>>
>>> Helloway
> 
> Is there a public source repository for the library somewhere?

Looks like it lives at:
https://github.com/hellowaywewe/py-spdk

Since the primary objections are not really due to the FFE state but
more due to the nature of the library, this should probably first be
proposed as a change to openstack/requirements and discussed there...

When it's ready but blocked by FF we can return to a ML thread to
discuss it...

-- 
Thierry Carrez (ttx)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Doug Hellmann]

Excerpts from We We's message of 2018-01-31 01:54:04 +0800:
> > Hi,
> 
> > I have modified and resubmitted  pyspdk to the pypi. Please check it.
> 
> > Thx,
> 
> > Helloway

Is there a public source repository for the library somewhere?

> 
> > 在 2018年1月30日，下午12:52，We We mailto:simple_...@163.com>> 
> > 写道：
> > 
> > Hi,
> > The pyspdk is a important tool library [1] which  supports Cyborg SPDK 
> > driver [2] to manage the backend SPDK-base app, so we need to upload pyspdk 
> > into the pypi [3]  and then append 'pyspdk>=0.0.1’ item into 
> > ‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built 
> > correctly when zuul runs. However, It's not what we thought it would be, if 
> > we want to  add the new requirements, we should get support from upstream 
> > OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.
> > 
> > I'm sorry for propose the request so late. Please Please help.
> > 
> > 
> > [1] https://review.gerrithub.io/#/c/379741/ 
> > 
> > [2] https://review.openstack.org/#/c/538164/11 
> > 
> > [3] https://pypi.python.org/pypi/pyspdk/0.0.1 
> > 
> > [4] https://github.com/openstack/requirements 
> > 
> > 
> > 
> > Regards,
> > Helloway
> > 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[We We]

> Hi,

> I have modified and resubmitted  pyspdk to the pypi. Please check it.

> Thx,

> Helloway

> 在 2018年1月30日，下午12:52，We We mailto:simple_...@163.com>> 
> 写道：
> 
> Hi,
> The pyspdk is a important tool library [1] which  supports Cyborg SPDK driver 
> [2] to manage the backend SPDK-base app, so we need to upload pyspdk into the 
> pypi [3]  and then append 'pyspdk>=0.0.1’ item into 
> ‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built 
> correctly when zuul runs. However, It's not what we thought it would be, if 
> we want to  add the new requirements, we should get support from upstream 
> OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.
> 
> I'm sorry for propose the request so late. Please Please help.
> 
> 
> [1] https://review.gerrithub.io/#/c/379741/ 
> 
> [2] https://review.openstack.org/#/c/538164/11 
> 
> [3] https://pypi.python.org/pypi/pyspdk/0.0.1 
> 
> [4] https://github.com/openstack/requirements 
> 
> 
> 
> Regards,
> Helloway
> 

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Matthew Thode]

On 18-01-30 11:58:17, Thierry Carrez wrote:
> We We wrote:
> > The pyspdk is a important tool library [1] which  supports Cyborg SPDK
> > driver [2] to manage the backend SPDK-base app, so we need to upload
> > pyspdk into the pypi [3]  and then append 'pyspdk>=0.0.1’ item into
> > ‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built
> > correctly when zuul runs. However, It's not what we thought it would be,
> > if we want to  add the new requirements, we should get support from
> > upstream OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.
> 
> Before we talk FFE, pyspdk looks a bit far away from being something
> OpenStack code can depend on. In particular:
> 
> - it's not clearly licensed under a supported license (no LICENSE file
> in the source code)
> - Missing metadata entries in setup.cfg means we are missing a lot of
> context information about this library
> 
> Those need to be fixed before we can even consider adding this library
> to global requirements...
> 

I agree.  Also, there's no mention of python3 or testing in the repo.
The licence looks like gplv3, which is fine for non-openstack code.
There's also no commit since the initial commit.

Unless I'm looking at the wrong repo, I'm going to say no to this FFE.
https://github.com/lschw/pyspdf

-- 
Matthew Thode (prometheanfire)


signature.asc
Description: PGP signature
__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[Thierry Carrez]

We We wrote:
> The pyspdk is a important tool library [1] which  supports Cyborg SPDK
> driver [2] to manage the backend SPDK-base app, so we need to upload
> pyspdk into the pypi [3]  and then append 'pyspdk>=0.0.1’ item into
> ‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built
> correctly when zuul runs. However, It's not what we thought it would be,
> if we want to  add the new requirements, we should get support from
> upstream OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.

Before we talk FFE, pyspdk looks a bit far away from being something
OpenStack code can depend on. In particular:

- it's not clearly licensed under a supported license (no LICENSE file
in the source code)
- Missing metadata entries in setup.cfg means we are missing a lot of
context information about this library

Those need to be fixed before we can even consider adding this library
to global requirements...

Cheers,

-- 
Thierry Carrez (ttx)

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

[openstack-dev] [requirement][cyborg]FFE - pyspdk requirement dependency

[We We]

Hi,
The pyspdk is a important tool library [1] which  supports Cyborg SPDK driver 
[2] to manage the backend SPDK-base app, so we need to upload pyspdk into the 
pypi [3]  and then append 'pyspdk>=0.0.1’ item into 
‘OpenStack/Cyborg/requirements.txt’ , so that  SPDK driver can be built 
correctly when zuul runs. However, It's not what we thought it would be, if we 
want to  add the new requirements, we should get support from upstream 
OpenStack/requirements [4] to append 'pyspdk>=0.0.1’ item.

I'm sorry for propose the request so late. Please Please help.


[1] https://review.gerrithub.io/#/c/379741/ 

[2] https://review.openstack.org/#/c/538164/11 

[3] https://pypi.python.org/pypi/pyspdk/0.0.1 

[4] https://github.com/openstack/requirements 



Regards,
Helloway

__
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev