Re: [openstack-dev] Code review study

2013-08-26 Thread Flavio Percoco
On 20/08/13 11:24 -0400, Russell Bryant wrote: On 08/20/2013 11:08 AM, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may

Re: [openstack-dev] Code review study

2013-08-26 Thread Gary Kotton
-Original Message- From: Flavio Percoco [mailto:fla...@redhat.com] Sent: Monday, August 26, 2013 11:41 AM To: OpenStack Development Mailing List Subject: Re: [openstack-dev] Code review study On 20/08/13 11:24 -0400, Russell Bryant wrote: On 08/20/2013 11:08 AM, Daniel P

Re: [openstack-dev] Code review study

2013-08-26 Thread Joe Gordon
On Tue, Aug 20, 2013 at 2:21 PM, Clint Byrum cl...@fewbar.com wrote: Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here.

Re: [openstack-dev] Code review study

2013-08-20 Thread Mark McLoughlin
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the citation of 200-400 lines as the knee of the review effectiveness curve: that's

Re: [openstack-dev] Code review study

2013-08-20 Thread Mark McLoughlin
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the citation of

Re: [openstack-dev] Code review study

2013-08-20 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here.

Re: [openstack-dev] Code review study

2013-08-20 Thread Jay Buffington
On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin mar...@redhat.com wrote: On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: The full study is here: http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf I can't find the data they based their numbers on,

Re: [openstack-dev] Code review study

2013-08-20 Thread Clint Byrum
Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the

Re: [openstack-dev] Code review study

2013-08-19 Thread Jay Buffington
On Wed, Aug 14, 2013 at 7:12 PM, Robert Collins robe...@robertcollins.netwrote: Note specifically the citation of 200-400 lines as the knee of the review effectiveness curve: that's lower than I thought - I thought 200 was clearly fine - but no. This is really interesting. I wish they would

Re: [openstack-dev] Code review study

2013-08-19 Thread Michael Davies
On Tue, Aug 20, 2013 at 5:14 AM, Jay Buffington m...@jaybuff.com wrote: This is really interesting. I wish they would have explicitly defined lines of code. Is that git show |wc -l? Just the new lines which were added? The sum of the lines changed, removed and added? You can get vastly

Re: [openstack-dev] Code review study

2013-08-16 Thread Maru Newby
but mandatory. m. https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages Sam From: Christopher Yeoh [mailto:cbky...@gmail.com] Sent: Thursday, August 15, 2013 7:12 AM To: OpenStack Development Mailing List Subject: Re: [openstack-dev] Code review

Re: [openstack-dev] Code review study

2013-08-16 Thread Robert Collins
On 16 August 2013 20:15, Maru Newby ma...@redhat.com wrote: This pattern has one slight issue, which is: • Do not assume the reviewer has access to external web services/site. In 6 months time when someone is on a train/plane/coach/beach/pub troubleshooting a problem browsing GIT

Re: [openstack-dev] Code review study

2013-08-16 Thread Maru Newby
On Aug 16, 2013, at 2:12 AM, Robert Collins robe...@robertcollins.net wrote: On 16 August 2013 20:15, Maru Newby ma...@redhat.com wrote: This pattern has one slight issue, which is: • Do not assume the reviewer has access to external web services/site. In 6 months time when someone

Re: [openstack-dev] Code review study

2013-08-15 Thread Gareth
That's an interesting article and also meaningful for coders. If I have a patch more than 200 or 300 lines, to split this may be a good idea. Some time, an easy patch with a little more lines would prevent more reviewers to think about it. On Thu, Aug 15, 2013 at 10:12 AM, Robert Collins

Re: [openstack-dev] Code review study

2013-08-15 Thread Christopher Yeoh
On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins robe...@robertcollins.netwrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the citation of 200-400 lines as the knee of the review

Re: [openstack-dev] Code review study

2013-08-15 Thread Daniel P. Berrange
On Thu, Aug 15, 2013 at 09:42:09PM +0930, Christopher Yeoh wrote: On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins robe...@robertcollins.netwrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note

Re: [openstack-dev] Code review study

2013-08-15 Thread Anne Gentle
On Thu, Aug 15, 2013 at 7:12 AM, Christopher Yeoh cbky...@gmail.com wrote: On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins robe...@robertcollins.net wrote: This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/

Re: [openstack-dev] Code review study

2013-08-15 Thread Christopher Yeoh
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange berra...@redhat.comwrote:Commit message quality has improved somewhat since I first wrote published that page, but there's definitely still scope to improve things further. What it really needs is for more reviewers to push back against

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com wrote: On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange berra...@redhat.comwrote:Commit message quality has improved somewhat since I first wrote published that page, but there's definitely still scope to improve

Re: [openstack-dev] Code review study

2013-08-15 Thread Daniel P. Berrange
On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com wrote: On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange berra...@redhat.comwrote:Commit message quality has improved somewhat since I first wrote

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 9:56 AM, Daniel P. Berrange berra...@redhat.comwrote: On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh cbky...@gmail.com wrote: On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 12:00 PM, Mark Washenberger mark.washenber...@markwash.net wrote: On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh cbky...@gmail.comwrote: On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins robe...@robertcollins.net wrote: This may interest data-driven types

Re: [openstack-dev] Code review study

2013-08-15 Thread Sam Harwell
formatting and hyperlinks in my documentation of the commit. Sam From: Christopher Yeoh [mailto:cbky...@gmail.com] Sent: Thursday, August 15, 2013 7:12 AM To: OpenStack Development Mailing List Subject: Re: [openstack-dev] Code review study On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins robe