Re: [openstack-dev] Code review study

2013-08-26 Thread Joe Gordon
On Tue, Aug 20, 2013 at 2:21 PM, Clint Byrum wrote: > Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: > > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > > This may interest data-driven types here. > > > > > > > https://www.ibm.com/developerworks/rational/librar

Re: [openstack-dev] Code review study

2013-08-26 Thread Gary Kotton
> -Original Message- > From: Flavio Percoco [mailto:fla...@redhat.com] > Sent: Monday, August 26, 2013 11:41 AM > To: OpenStack Development Mailing List > Subject: Re: [openstack-dev] Code review study > > On 20/08/13 11:24 -0400, Russell Bryant wrote: > >On

Re: [openstack-dev] Code review study

2013-08-26 Thread Flavio Percoco
On 20/08/13 11:24 -0400, Russell Bryant wrote: On 08/20/2013 11:08 AM, Daniel P. Berrange wrote: On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interes

Re: [openstack-dev] Code review study

2013-08-20 Thread Clint Byrum
Excerpts from Mark McLoughlin's message of 2013-08-20 03:26:01 -0700: > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > This may interest data-driven types here. > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifically

Re: [openstack-dev] Code review study

2013-08-20 Thread Jay Buffington
On Tue, Aug 20, 2013 at 8:02 AM, Mark McLoughlin wrote: > On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > > The full study is here: > > > > > http://support.smartbear.com/resources/cc/book/code-review-cisco-case-study.pdf > I can't find the data they based their numbers on, nor their

Re: [openstack-dev] Code review study

2013-08-20 Thread Russell Bryant
On 08/20/2013 11:08 AM, Daniel P. Berrange wrote: > On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: >> On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: >>> On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: This may interest data-driven types here. htt

Re: [openstack-dev] Code review study

2013-08-20 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 04:02:12PM +0100, Mark McLoughlin wrote: > On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > > This may interest data-driven types here. > > > > > > https://www.ibm.com/developerworks/rational/library/

Re: [openstack-dev] Code review study

2013-08-20 Thread Mark McLoughlin
On Tue, 2013-08-20 at 11:26 +0100, Mark McLoughlin wrote: > On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > > This may interest data-driven types here. > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifically the citatio

Re: [openstack-dev] Code review study

2013-08-20 Thread Mark McLoughlin
On Thu, 2013-08-15 at 14:12 +1200, Robert Collins wrote: > This may interest data-driven types here. > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: th

Re: [openstack-dev] Code review study

2013-08-19 Thread Michael Davies
On Tue, Aug 20, 2013 at 5:14 AM, Jay Buffington wrote: > > This is really interesting. I wish they would have explicitly defined > "lines of code." Is that "git show |wc -l"? Just the new lines which > were added? The sum of the lines changed, removed and added? You can > get vastly different

Re: [openstack-dev] Code review study

2013-08-19 Thread Jay Buffington
On Wed, Aug 14, 2013 at 7:12 PM, Robert Collins wrote: > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: that's lower than I thought - I thought 200 was > clearly fine - but no. > This is really interesting. I wish they would have explicitly defin

Re: [openstack-dev] Code review study

2013-08-18 Thread Grant Murphy
On 08/15/2013 12:12 PM, Robert Collins wrote: > This may interest data-driven types here. > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the > review effectiveness curve: that's lower

Re: [openstack-dev] Code review study

2013-08-16 Thread Maru Newby
On Aug 16, 2013, at 2:12 AM, Robert Collins wrote: > On 16 August 2013 20:15, Maru Newby wrote: > >>> This pattern has one slight issue, which is: >>> >>> • Do not assume the reviewer has access to external web services/site. >>> In 6 months time when someone is on a train/plane/coach/be

Re: [openstack-dev] Code review study

2013-08-16 Thread Flavio Percoco
On 15/08/13 22:27 +0930, Christopher Yeoh wrote: On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange wrote:Commit message quality has improved somewhat since I first wrote & published that page, but there's definitely still scope to improve things further. What it really needs is for m

Re: [openstack-dev] Code review study

2013-08-16 Thread Robert Collins
On 16 August 2013 20:15, Maru Newby wrote: >> This pattern has one slight issue, which is: >> >> • Do not assume the reviewer has access to external web services/site. >> In 6 months time when someone is on a train/plane/coach/beach/pub >> troubleshooting a problem & browsing GIT history,

Re: [openstack-dev] Code review study

2013-08-16 Thread Maru Newby
ith them. A dvcs is great and all, but unless one is working in a silo, online resources are all but mandatory. m. > > > https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages > > > > > > Sam > > > > From: Christo

Re: [openstack-dev] Code review study

2013-08-15 Thread Joe Gordon
ommit_messages > ** > > Sam > > ** ** > > *From:* Christopher Yeoh [mailto:cbky...@gmail.com] > *Sent:* Thursday, August 15, 2013 7:12 AM > *To:* OpenStack Development Mailing List > *Subject:* Re: [openstack-dev] Code review study > > ** ** > >

Re: [openstack-dev] Code review study

2013-08-15 Thread Sam Harwell
formatting and hyperlinks in my documentation of the commit. Sam From: Christopher Yeoh [mailto:cbky...@gmail.com] Sent: Thursday, August 15, 2013 7:12 AM To: OpenStack Development Mailing List Subject: Re: [openstack-dev] Code review study On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins mailto:robe

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 12:00 PM, Mark Washenberger < mark.washenber...@markwash.net> wrote: > > > > On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh wrote: > >> >> On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < >> robe...@robertcollins.net> wrote: >> >>> This may interest data-driven types h

Re: [openstack-dev] Code review study

2013-08-15 Thread Mark Washenberger
On Thu, Aug 15, 2013 at 5:12 AM, Christopher Yeoh wrote: > > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < > robe...@robertcollins.net> wrote: > >> This may interest data-driven types here. >> >> >> https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ >> >

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 9:56 AM, Daniel P. Berrange wrote: > On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: > > On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh > wrote: > > > > > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange < > berra...@redhat.com>wrote:Commit message qua

Re: [openstack-dev] Code review study

2013-08-15 Thread Daniel P. Berrange
On Thu, Aug 15, 2013 at 09:46:07AM -0500, Dolph Mathews wrote: > On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh wrote: > > > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange > > wrote:Commit message quality has improved somewhat > > since I first wrote & > > published > > > > that page,

Re: [openstack-dev] Code review study

2013-08-15 Thread Dolph Mathews
On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh wrote: > On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange > wrote:Commit message quality has improved somewhat since > I first wrote & > published > > that page, but there's definitely still scope to improve things further. >> What >> it rea

Re: [openstack-dev] Code review study

2013-08-15 Thread Christopher Yeoh
On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange wrote:Commit message quality has improved somewhat since I first wrote & published > that page, but there's definitely still scope to improve things further. > What > it really needs is for more reviewers to push back against badly written > comm

Re: [openstack-dev] Code review study

2013-08-15 Thread Anne Gentle
On Thu, Aug 15, 2013 at 7:12 AM, Christopher Yeoh wrote: > > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins < > robe...@robertcollins.net> wrote: > >> This may interest data-driven types here. >> >> >> https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ >> >

Re: [openstack-dev] Code review study

2013-08-15 Thread Daniel P. Berrange
On Thu, Aug 15, 2013 at 09:42:09PM +0930, Christopher Yeoh wrote: > On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins > wrote: > > > This may interest data-driven types here. > > > > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > > > Note specifical

Re: [openstack-dev] Code review study

2013-08-15 Thread Christopher Yeoh
On Thu, Aug 15, 2013 at 11:42 AM, Robert Collins wrote: > This may interest data-driven types here. > > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the review > effectiveness curve: th

Re: [openstack-dev] Code review study

2013-08-15 Thread Gareth
That's an interesting article and also meaningful for coders. If I have a patch more than 200 or 300 lines, to split this may be a good idea. Some time, an easy patch with a little more lines would prevent more reviewers to think about it. On Thu, Aug 15, 2013 at 10:12 AM, Robert Collins wrote:

[openstack-dev] Code review study

2013-08-14 Thread Robert Collins
This may interest data-driven types here. https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ Note specifically the citation of 200-400 lines as the knee of the review effectiveness curve: that's lower than I thought - I thought 200 was clearly fine - but no.