Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Fri, Sep 25, 2015 at 3:44 PM, Ihar Hrachyshka wrote: > Hi all, > > releases are approaching, so it’s the right time to start some bike > shedding on the mailing list. > > Recently I got pointed out several times [1][2] that I violate our commit > message requirement [3]

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 06/10/15 06:23, Ben Nemec wrote: On 10/05/2015 12:12 PM, Jeremy Stanley wrote: On 2015-10-05 12:00:31 -0500 (-0500), Ben Nemec wrote: [...] Note that it's best to do this once the change is ready to be approved. If you do it earlier and the committer pushes a new patch set without fixing

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 10/01/2015 02:56 AM, Ghe Rivero wrote: > If anyone disagrees with the commit format, please, go ahead and fix it (It's > really easy using the gerrit web) For such cosmetic changes (and others > similars), we should not wait for the author to do it. Sometimes, for a stupid > comma, and with all

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 10/05/2015 12:12 PM, Jeremy Stanley wrote: > On 2015-10-05 12:00:31 -0500 (-0500), Ben Nemec wrote: > [...] >> Note that it's best to do this once the change is ready to be >> approved. If you do it earlier and the committer pushes a new >> patch set without fixing the commit message, it will

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 2015-10-05 12:00:31 -0500 (-0500), Ben Nemec wrote: [...] > Note that it's best to do this once the change is ready to be > approved. If you do it earlier and the committer pushes a new > patch set without fixing the commit message, it will revert the > fix made through the web interface.

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

If anyone disagrees with the commit format, please, go ahead and fix it (It's really easy using the gerrit web) For such cosmetic changes (and others similars), we should not wait for the author to do it. Sometimes, for a stupid comma, and with all the TZ, a change can need more than a day to be

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

+1 On 10/1/15, 10:56 AM, "Ghe Rivero" wrote: >If anyone disagrees with the commit format, please, go ahead and fix it >(It's >really easy using the gerrit web) For such cosmetic changes (and others >similars), we should not wait for the author to do it. Sometimes, for a

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

+1. From: Ghe Rivero [ghe.riv...@gmail.com] Sent: Thursday, October 01, 2015 12:56 AM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [all] -1 due to line length violation in commit messages If anyone

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 09/25/2015 05:00 PM, Ryan Brown wrote: > I believe the 72 limit is derived from 80-8 (terminal width - tab width) If I'm not mistaking, 72 is because of the email format limitation. Thomas __ OpenStack Development

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

> From: Gorka Eguileor <gegui...@redhat.com> > To: "OpenStack Development Mailing List (not for usage questions)" > <openstack-dev@lists.openstack.org> > Date: 09/29/2015 07:34 AM > Subject: Re: [openstack-dev] [all] -1 due to line length violation > in co

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 29/09/15 12:05, Ihar Hrachyshka wrote: On 25 Sep 2015, at 16:44, Ihar Hrachyshka wrote: Hi all, releases are approaching, so it’s the right time to start some bike shedding on the mailing list. Recently I got pointed out several times [1][2] that I violate our commit

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 28/09, Clint Byrum wrote: > Excerpts from Kevin Benton's message of 2015-09-28 14:29:14 -0700: > > I think a blanket statement about what people's motivations are is not > > fair. We've seen in this thread that some people want to enforce the limit > > of 72 chars and it's not about padding

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

> On 25 Sep 2015, at 16:44, Ihar Hrachyshka wrote: > > Hi all, > > releases are approaching, so it’s the right time to start some bike shedding > on the mailing list. > > Recently I got pointed out several times [1][2] that I violate our commit > message requirement [3]

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 28/09/15 05:47, Gorka Eguileor wrote: On 26/09, Morgan Fainberg wrote: As a core (and former PTL) I just ignored commit message -1s unless there is something majorly wrong (no bug id where one is needed, etc). I appreciate well formatted commits, but can we let this one go? This

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

Excerpts from Kevin Benton's message of 2015-09-28 14:29:14 -0700: > I think a blanket statement about what people's motivations are is not > fair. We've seen in this thread that some people want to enforce the limit > of 72 chars and it's not about padding their stats. > > The issue here is that

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

I think a blanket statement about what people's motivations are is not fair. We've seen in this thread that some people want to enforce the limit of 72 chars and it's not about padding their stats. The issue here is that we have a guideline with a very specific number. If we don't care to enforce

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Mon, Sep 28, 2015 at 12:40 PM, Zane Bitter wrote: > On 28/09/15 05:47, Gorka Eguileor wrote: > >> On 26/09, Morgan Fainberg wrote: >> >>> As a core (and former PTL) I just ignored commit message -1s unless >>> there is something majorly wrong (no bug id where one is

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

Excerpts from Morgan Fainberg's message of 2015-09-26 23:36:09 -0700: > As a core (and former PTL) I just ignored commit message -1s unless there is > something majorly wrong (no bug id where one is needed, etc). > > I appreciate well formatted commits, but can we let this one go? This >

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Mon, Sep 28, 2015 at 4:00 PM, Assaf Muller wrote: > > > On Mon, Sep 28, 2015 at 12:40 PM, Zane Bitter wrote: > >> On 28/09/15 05:47, Gorka Eguileor wrote: >> >>> On 26/09, Morgan Fainberg wrote: >>> As a core (and former PTL) I just ignored commit

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 28/09, Andreas Jaeger wrote: > On 2015-09-28 11:47, Gorka Eguileor wrote: > >On 26/09, Morgan Fainberg wrote: > >>As a core (and former PTL) I just ignored commit message -1s unless there > >>is something majorly wrong (no bug id where one is needed, etc). > >> > >>I appreciate well formatted

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 2015-09-28 11:47, Gorka Eguileor wrote: On 26/09, Morgan Fainberg wrote: As a core (and former PTL) I just ignored commit message -1s unless there is something majorly wrong (no bug id where one is needed, etc). I appreciate well formatted commits, but can we let this one go? This

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

IMO those checks should be automated, as we automate pep8 checks on our python code. I agree, that if we have a rule for this, we should follow it, but it's a waste of time reviewing and enforcing this manually. Best regards. Miguel Ángel. Gorka Eguileor wrote: On 26/09, Morgan Fainberg

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

Le 25/09/2015 17:00, Julien Danjou a écrit : If we wanted to enforce that, we would just have to write a bot setting -1 automatically. I'm getting tired of seeing people doing bots' jobs in Gerrit. It may also help to enhance "git review -s" to install a local post-commit hook to warn if the

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Mon, Sep 28, 2015 at 5:29 PM, Kevin Benton wrote: > I think a blanket statement about what people's motivations are is not > fair. We've seen in this thread that some people want to enforce the limit > of 72 chars and it's not about padding their stats. > I took this

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

> On Sep 28, 2015, at 3:00 PM, Assaf Muller wrote: > > > > On Mon, Sep 28, 2015 at 12:40 PM, Zane Bitter > wrote: > On 28/09/15 05:47, Gorka Eguileor wrote: > On 26/09, Morgan Fainberg wrote: > As a core (and former PTL) I

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 2015-09-28 16:27:19 -0500 (-0500), Kyle Mestery wrote: [...] > I should note that as the previous PTL, for the most part I viewed > stats as garbage. Keep in mind I nominated two new core reviewers > whose stats were lowe but who are incredibly important members of > our community [1]. I did

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

As a core (and former PTL) I just ignored commit message -1s unless there is something majorly wrong (no bug id where one is needed, etc). I appreciate well formatted commits, but can we let this one go? This discussion is so far into the meta-bike-shedding (bike shedding about bike shedding

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

Can I ask a different question - could we reject a few simple-to-check things on the push, like bad commit messages? For things that take 2 seconds to fix and do make people's lives better, it's not that they're rejected, it's that the whole rejection cycle via gerrit review (push/wait for tests

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

+1 for <=80 chars. It will be uniform with the existing coding style. On Fri, Sep 25, 2015 at 8:22 PM, Dmitry Tantsur wrote: > On 09/25/2015 04:44 PM, Ihar Hrachyshka wrote: > >> Hi all, >> >> releases are approaching, so it’s the right time to start some bike >> shedding

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

git tools such as git log and git show indent the commit message in their output, so you don't actually have the full 79/80 character width to work with. That's where the 72 comes from. Doug Excerpts from Vikram Choudhary's message of 2015-09-25 20:25:41 +0530: > +1 for <=80 chars. It will be

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Fri, Sep 25, 2015 at 04:44:59PM +0200, Ihar Hrachyshka wrote: > Hi all, > > releases are approaching, so it’s the right time to start some bike shedding > on the mailing list. > > Recently I got pointed out several times [1][2] that I violate our commit > message requirement [3] for the

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 09/25/2015 04:44 PM, Ihar Hrachyshka wrote: Hi all, releases are approaching, so it’s the right time to start some bike shedding on the mailing list. Recently I got pointed out several times [1][2] that I violate our commit message requirement [3] for the message lines that says:

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 09/25/2015 10:44 AM, Ihar Hrachyshka wrote: Hi all, releases are approaching, so it’s the right time to start some bike shedding on the mailing list. Recently I got pointed out several times [1][2] that I violate our commit message requirement [3] for the message lines that says:

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 2015-09-25 16:44:59 +0200 (+0200), Ihar Hrachyshka wrote: [...] > I believe commit message lines of <=80 chars are absolutely fine > and should not get -1 treatment. I propose to raise the limit for > the guideline on wiki accordingly. [...] As one of those traditionalists who still does all

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Fri, Sep 25, 2015 at 11:05:09AM -0400, Doug Hellmann wrote: > git tools such as git log and git show indent the commit message in > their output, so you don't actually have the full 79/80 character width > to work with. That's where the 72 comes from. It is also commonly done because so that

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

Yeah, and worse, since I never can remember the exact number(72 I guess), I always just round down to 70-1 to be safe. Its silly. Thanks, Kevin From: Ihar Hrachyshka [ihrac...@redhat.com] Sent: Friday, September 25, 2015 7:44 AM To: OpenStack Development

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On Fri, Sep 25 2015, Ihar Hrachyshka wrote: > I agree that very long commit message lines can be bad, f.e. if they > are 200+ chars. But <= 79 chars?.. Don’t think so. Especially since we > have 79 chars limit for the code. Agreed. <= 80 chars should be a rule of thumb and applied in a smart

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

...@jimrollenhagen.com] Sent: Friday, September 25, 2015 8:42 AM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [all] -1 due to line length violation in commit messages On Fri, Sep 25, 2015 at 04:44:59PM +0200, Ihar Hrachyshka wrote: > Hi all, > >

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

+1 for <=80 chars. 72 characters sometimes are not enough Regards, Ivan Kolodyazhny On Fri, Sep 25, 2015 at 6:05 PM, Doug Hellmann wrote: > git tools such as git log and git show indent the commit message in > their output, so you don't actually have the full 79/80

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 09/25/2015 12:15 PM, Fox, Kevin M wrote: > Another option... why are we wasting time on something that a > computer can handle? Why not just let the line length be infinite in > the commit message and have gerrit wrap it to here> length lines on merge? I don't think gerrit should mess with

Re: [openstack-dev] [all] -1 due to line length violation in commit messages

On 2015-09-25 16:15:15 + (+), Fox, Kevin M wrote: > Another option... why are we wasting time on something that a > computer can handle? Why not just let the line length be infinite > in the commit message and have gerrit wrap it to number here> length lines on merge? The commit message