Re: [openstack-dev] removal of v3 in tree testing
2015-03-06 13:49 GMT+08:00 GHANSHYAM MANN ghanshyamm...@gmail.com: Hi Sean, That is very nice idea to keep only 1 set of tests and run those twice via tox. Actually my main goal was- - 1. Create clean sample file structure for V2. V2.1 and micro-versions Something like below- api_samples/ extensions/ v2.0/ - v2 sample files v2.1/- v2.1 sample files v2.2/- v2.2 sample files and so on - 2. Merge sample files between v2 and v2.1. But your idea is much better which almost covers mine (except dir structure for microversion which can/should be work after that). ++ for Sean's idea. One sample tests is best. And in normally we should keep the v2 API sample tests to ensure v2.1 totally compatible with v2. But really like the currently v2.1 API sample tests is each file per extension, not like v2 all the extension in a huge file... So I think we need keep the v2.1 api sample tests, and make the v2 API running on it. As there are many extensions merged/split from v2 - v2.1, we need to twist tests to work for both v2 and v2.1. For exmple, v2 flavor-swap, flavor-disable, flavor-extraData has been merged to single flavor plugin in v2.1. So running v2.1 flavor tests for v2 needs above extensions to be enabled in that tests. It looks something like - https://review.openstack.org/#/c/162016/ Yea...good point and great work! I think all of ours hate those twist, but no choice... Actually for the extension mapping between v2.1 and v2, we already have mapping at: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/plugins/v3/extension_info.py#L29 So can we use this mapping to twist tests in the base class? Then we needn't twist a lot of extension. -- Thanks Regards Ghanshyam Mann On Fri, Mar 6, 2015 at 7:00 AM, Sean Dague s...@dague.net wrote: On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote: Hi Sean, Yes having V3 directory/file names is very confusing now. But current v3 sample tests cases tests v2.1 plugins. As /v3 url is redirected to v21 plugins, v3 sample tests make call through v3 url and test v2.1 plugins. I think we can start cleaning up the *v3* from everywhere and change it to v2.1 or much appropriate name. To cleanup the same from sample files, I was planning to rearrange sample files structure. Please check if that direction looks good (still need to release patch for directory restructure) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z I had another chat with Alex this morning on IRC. I think my confusion is that I don't feel like I understand how we get down to 1 set of API samples in the tree based on that set of posted patches. It seems like there should only be 1 set of samples in docs/ and one set of templates. I would also argue that we should only have 1 set of tests (though that I'm mid term flexible on). It seems that if our concern is that both the v2 and v21 endpoints need to have the same results, we could change the functional tox target to run twice, once with v2 and once with v21 set as the v2 endpoint. Eventually we'll be able to drop v2 on v2. Anyway, in order to both assist my own work unwinding the test tree, and to help review your work there, can you lay out your vision for cleaning this up with all the steps involved? Hopefully that will cut down the confusion and make all this work move faster. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] removal of v3 in tree testing
On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote: Hi Sean, Yes having V3 directory/file names is very confusing now. But current v3 sample tests cases tests v2.1 plugins. As /v3 url is redirected to v21 plugins, v3 sample tests make call through v3 url and test v2.1 plugins. I think we can start cleaning up the *v3* from everywhere and change it to v2.1 or much appropriate name. To cleanup the same from sample files, I was planning to rearrange sample files structure. Please check if that direction looks good (still need to release patch for directory restructure) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z I had another chat with Alex this morning on IRC. I think my confusion is that I don't feel like I understand how we get down to 1 set of API samples in the tree based on that set of posted patches. It seems like there should only be 1 set of samples in docs/ and one set of templates. I would also argue that we should only have 1 set of tests (though that I'm mid term flexible on). It seems that if our concern is that both the v2 and v21 endpoints need to have the same results, we could change the functional tox target to run twice, once with v2 and once with v21 set as the v2 endpoint. Eventually we'll be able to drop v2 on v2. Anyway, in order to both assist my own work unwinding the test tree, and to help review your work there, can you lay out your vision for cleaning this up with all the steps involved? Hopefully that will cut down the confusion and make all this work move faster. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] removal of v3 in tree testing
On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote: Hi Sean, Yes having V3 directory/file names is very confusing now. But current v3 sample tests cases tests v2.1 plugins. As /v3 url is redirected to v21 plugins, v3 sample tests make call through v3 url and test v2.1 plugins. I think we can start cleaning up the *v3* from everywhere and change it to v2.1 or much appropriate name. To cleanup the same from sample files, I was planning to rearrange sample files structure. Please check if that direction looks good (still need to release patch for directory restructure) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z Ok, so I'm confused, because v2 and v2.1 are supposed to be the same. So all the v2 samples tests should be the ones that cover the v2.1 case. I don't see why we'd have 2 versions in the stack. Also these tests use the v3 pipeline, which means they actually use different urls than v2 (that don't include the tenant). This discovery all came with trying to remove the NoAuthMiddlewareV3 class. So, we *definitely* should not have 2 sets of samples in tree. That's just confusing and duplicative. If the answer is retarget all of these to v2 end point, and delete test_api_samples, that's also a good answer. But keeping both through the release seems bad. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] removal of v3 in tree testing
Hi Sean, That is very nice idea to keep only 1 set of tests and run those twice via tox. Actually my main goal was- - 1. Create clean sample file structure for V2. V2.1 and micro-versions Something like below- api_samples/ extensions/ v2.0/ - v2 sample files v2.1/- v2.1 sample files v2.2/- v2.2 sample files and so on - 2. Merge sample files between v2 and v2.1. But your idea is much better which almost covers mine (except dir structure for microversion which can/should be work after that). As there are many extensions merged/split from v2 - v2.1, we need to twist tests to work for both v2 and v2.1. For exmple, v2 flavor-swap, flavor-disable, flavor-extraData has been merged to single flavor plugin in v2.1. So running v2.1 flavor tests for v2 needs above extensions to be enabled in that tests. It looks something like - https://review.openstack.org/#/c/162016/ -- Thanks Regards Ghanshyam Mann On Fri, Mar 6, 2015 at 7:00 AM, Sean Dague s...@dague.net wrote: On 03/04/2015 07:48 PM, GHANSHYAM MANN wrote: Hi Sean, Yes having V3 directory/file names is very confusing now. But current v3 sample tests cases tests v2.1 plugins. As /v3 url is redirected to v21 plugins, v3 sample tests make call through v3 url and test v2.1 plugins. I think we can start cleaning up the *v3* from everywhere and change it to v2.1 or much appropriate name. To cleanup the same from sample files, I was planning to rearrange sample files structure. Please check if that direction looks good (still need to release patch for directory restructure) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z I had another chat with Alex this morning on IRC. I think my confusion is that I don't feel like I understand how we get down to 1 set of API samples in the tree based on that set of posted patches. It seems like there should only be 1 set of samples in docs/ and one set of templates. I would also argue that we should only have 1 set of tests (though that I'm mid term flexible on). It seems that if our concern is that both the v2 and v21 endpoints need to have the same results, we could change the functional tox target to run twice, once with v2 and once with v21 set as the v2 endpoint. Eventually we'll be able to drop v2 on v2. Anyway, in order to both assist my own work unwinding the test tree, and to help review your work there, can you lay out your vision for cleaning this up with all the steps involved? Hopefully that will cut down the confusion and make all this work move faster. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
Re: [openstack-dev] removal of v3 in tree testing
Hi Sean, Yes having V3 directory/file names is very confusing now. But current v3 sample tests cases tests v2.1 plugins. As /v3 url is redirected to v21 plugins, v3 sample tests make call through v3 url and test v2.1 plugins. I think we can start cleaning up the *v3* from everywhere and change it to v2.1 or much appropriate name. To cleanup the same from sample files, I was planning to rearrange sample files structure. Please check if that direction looks good (still need to release patch for directory restructure) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:sample_files_structure,n,z On Wed, Mar 4, 2015 at 11:06 PM, Sean Dague s...@dague.net wrote: I have proposed the following patch series to remove the API v3 direct testing in tree - https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:rm_v3_paste,n,z This also removes the /v3 entry from the paste.ini that we ship. I think it's important that we remove that before kilo releases as I believe it continues to confuse people. This also drops the functional test runs by about 50% in time. I couldn't think of a reason why we still needed this, but if someone does, please speak up. -Sean -- Sean Dague http://dague.net __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -- Thanks Regards Ghanshyam Mann __ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
