Re: [Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread David Sommerseth
On 03/05/12 20:49, Alon Bar-Lev wrote: > If source is located at git repository, acquire branch and > revision of head to be printed at --version output. > > Signed-off-by: Alon Bar-Lev --- Makefile.am > | 25 - configure.ac | 11 >

[Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread Alon Bar-Lev
If source is located at git repository, acquire branch and revision of head to be printed at --version output. Signed-off-by: Alon Bar-Lev --- Makefile.am | 25 - configure.ac | 11 +++ src/openvpn/options.c |6

[Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread Alon Bar-Lev
If source is located at git repository, acquire branch and revision of head to be printed at --version output. Signed-off-by: Alon Bar-Lev --- Makefile.am | 25 - configure.ac | 11 +++ src/openvpn/options.c |6

Re: [Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread Alon Bar-Lev
On Thu, May 3, 2012 at 8:36 PM, Alon Bar-Lev wrote: > If source is located at git repository, acquire branch and revision > of head to be printed at --version output. > > Signed-off-by: Alon Bar-Lev Slowly I get what you need. How is this one?

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-05-03 Thread Alon Bar-Lev
On Thu, May 3, 2012 at 1:53 PM, Samuli Seppänen wrote: > >> On Thu, May 3, 2012 at 10:26 AM, David Sommerseth >> wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> On 27/04/12 14:15, Alon Bar-Lev wrote: 2012/4/27 Samuli

Re: [Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread Fabian Knittel
Hi, 2012/5/3 David Sommerseth : > What I would like to see is something more like what's found in TOR > projects' obfsproxy, where the Makefile generates a micro-version.i, > which is included.  As this file is forced to be (re-)created each > time, it will always

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/05/12 12:21, Gauri Bhave wrote: > Well that's the legacy that i got from the previous developer. So > just wanted to know if it supports UTF8. And it will really help if > you can point out the exact version's of OpenVPN access server and >

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread Gert Doering
Hi, On Thu, May 03, 2012 at 03:51:27PM +0530, Gauri Bhave wrote: > Well that's the legacy that i got from the previous developer. So just > wanted to know if it supports UTF8. No, all versions before 2.3_alpha1 will convert anything non-7bit-ASCII to "_" (as you have observed). > And it will

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread Samuli Seppänen
Access Server and OpenVPN Connect client are commercial offerings based on the OpenVPN 2.1.x tree. As such, they lack many of the features that came in later community versions (2.2.x+). I'd guess they don't support UTF-8, either. I would use OpenVPN 2.3-alpha1 as it should be very stable and has

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-05-03 Thread Samuli Seppänen
> On Thu, May 3, 2012 at 10:26 AM, David Sommerseth > wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 27/04/12 14:15, Alon Bar-Lev wrote: >>> 2012/4/27 Samuli Seppänen : Il 27.04.2012 12:18, Heiko Hund ha scritto: >

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread Gauri Bhave
Well that's the legacy that i got from the previous developer. So just wanted to know if it supports UTF8. And it will really help if you can point out the exact version's of OpenVPN access server and OpenVPN connect client which support UTF8 username's and Passwords. Thanks Gauri Bhave On Thu,

Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/12 20:16, Alon Bar-Lev wrote: > Looks good. If you testing this one, please ensure symbolic links > also works properly... :) Just to confirm, as I forgot to mention that in the 'applied' message earlier on. This was tested with symlinks

[Openvpn-devel] [PATCH] Remove two unused functions

2012-05-03 Thread David Sommerseth
From: David Sommerseth Both is_persist_option() and is_stateful_restart() functions where never used anywhere in the code. Remove them. Signed-off-by: David Sommerseth --- src/openvpn/options.c | 16 src/openvpn/options.h |3 --- 2

Re: [Openvpn-devel] [PATCH] build: add git revision to --version output if build from git repository

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/04/12 20:00, Alon Bar-Lev wrote: > If configure is located at git repository, acquire branch and > revision of head to be printed at --version output. > > Signed-off-by: Alon Bar-Lev --- > configure.ac | 11

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-05-03 Thread Alon Bar-Lev
On Thu, May 3, 2012 at 10:26 AM, David Sommerseth wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 27/04/12 14:15, Alon Bar-Lev wrote: > > 2012/4/27 Samuli Seppänen : > >> Il 27.04.2012 12:18, Heiko Hund ha scritto: > >>> On

Re: [Openvpn-devel] [PATCH] Simplify check_cmd_access() function

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/12 19:54, David Sommerseth wrote: > To avoid confusion between check_file_access() and > check_cmd_access() in the future, remove unneeded arguments from > check_cmd_access() > > As a command will always be a file, it should always check for

Re: [Openvpn-devel] [PATCH] build: windows: convert resources to UTF-8

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/04/12 20:29, Alon Bar-Lev wrote: > Visual Studio 2010 editor supports UTF-8 files, we can store files > in standard encoding. > > Signed-off-by: Alon Bar-Lev --- > src/openvpn/openvpn_win32_resources.rc |4 +++- >

Re: [Openvpn-devel] 2.3alpha1 fails on OS X when the --up argument contains more than an execution path

2012-05-03 Thread David Sommerseth
On 31/03/12 13:47, Jonathan K. Bullard wrote: > On Wed, Mar 28, 2012 at 2:11 PM, David Sommerseth > > > wrote: > > > > Attached is a heavily revised version of my original patch. It uses > > argv_printf() to __check__

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-05-03 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 27/04/12 14:15, Alon Bar-Lev wrote: > 2012/4/27 Samuli Seppänen : >> Il 27.04.2012 12:18, Heiko Hund ha scritto: >>> On Friday 27 April 2012 09:54:15 Samuli Seppänen wrote: Anyways, I cross-compiled latest "master" with

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread Gert Doering
Hi, On Thu, May 03, 2012 at 12:14:28PM +0530, Gauri Bhave wrote: > Can you tell me which version of openvpn started supporting utf8. I am > using openvpn-2.1_rc15 but all my utf8 characters get converted to '_' > (underscores), when i see the log on the server side and AD gives me an > error

Re: [Openvpn-devel] Does OpenVPN Support Unicode Username and Password

2012-05-03 Thread Gauri Bhave
Hi, Can you tell me which version of openvpn started supporting utf8. I am using openvpn-2.1_rc15 but all my utf8 characters get converted to '_' (underscores), when i see the log on the server side and AD gives me an error authentication failed. Please help me Thanks Gauri Bhave On Wed, May 2,