Re: [Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

Hi, > A few questions: > > > This also fixes an issue with --windows-driver wintun overriding > > --ip-win32 manual, the later being perfectly fine choice for Wintun > too. > > We do still have code which forces netsh for wintun: > > if (options->windows_driver == WINDOWS_DRIVER_WINTUN)

Re: [Openvpn-devel] [PATCH] tun.c: fix "use after free" error

Nice catch, Lev. The patch indeed fixes an UAC. Compiled and tested it with MSVC. Acked-by: Simon Rozman Regards, Simon > -Original Message- > From: Lev Stipakov > Sent: Thursday, March 12, 2020 7:08 AM > To: openvpn-devel@lists.sourceforge.net > Cc: Lev Stipakov > Subject:

[Openvpn-devel] Summary of the community meeting (12th March 2020)

Hi, Here's the summary of the IRC meeting. --- COMMUNITY MEETING Place: #openvpn-meeting on irc.freenode.net Date: Thu 12th March 2020 Time: 20:00 CET (19:00 UTC) Planned meeting topics for this meeting were here: Your local

Re: [Openvpn-devel] [PATCH 2/2] tun.c: revise the IPv4 ifconfig flow on Windows

Hi, Looks good, tested with interactive service and without (netsh, ipapi). A few questions: > This also fixes an issue with --windows-driver wintun overriding > --ip-win32 manual, the later being perfectly fine choice for Wintun too. We do still have code which forces netsh for wintun:

[Openvpn-devel] [PATCH] tun.c: fix "use after free" error

From: Lev Stipakov Commit 509c45f has factored out code blocks of open_tun() into separate functions and introduced "use after free" bug: Variable "device_guid" is allocated inside tun_open_device() function and used outside of it. Allocation happens with local gc_arena, which is freed at the

[Openvpn-devel] [PATCH v6 5/5] Normalise ncp-ciphers option and restrict it to 127 bytes

In scenarios of mbed TLS vs OpenSSL we already normalise the ciphers that are send via the wire protocol via OCC to not have a mismatch warning between server and client. This is done by translate_cipher_name_from_openvpn. The same applies also to the ncp-ciphers list. Specifying non normalised

[Openvpn-devel] [PATCH v2] Fix building with --enable-async-push in FreeBSD

This option can be used in FreedBSD with devel/libinotify installed. Detect presence of libinotify and link with its _LIBS variable. Trac #1256 Signed-off-by: Lev Stipakov --- v2: use PKG_CHECK_MODULES instead of hardcoded -linotify configure.ac| 9 +

[Openvpn-devel] [PATCH] Fix building with --enable-async-push in FreeBSD

This option can be used in FreedBSD with devel/libinotify installed, however it requires linkage with -linotify. Trac #1256 Signed-off-by: Lev Stipakov --- configure.ac| 4 src/openvpn/Makefile.am | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git

Re: [Openvpn-devel] [PATCH 1/2] tun.c: reorder IPv6 ifconfig on Windows

Hi, Explanation makes sense and code does what is says - adds address/route/dns and removes in reverse direction. Compiled and smoke-tested with MSVC. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net