[Openvpn-devel] [PATCH applied] Re: Fix OpenSSL private key passphrase notices

2020-03-24 Thread Gert Doering
Your patch has been applied to the master and release/2.4 branch. I haven't done any sort of qualified code review, but I have done a few test builds / t_client test runs, and all looks good. If Steffan says so, *and* it compiles, it's good enough for me anyway :-) Sorry for the delay...

Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-24 Thread Илья Шипицин
вт, 24 мар. 2020 г. в 22:19, Michael Kress : > Am Tue, 24 Mar 2020 11:21:56 +0100 > schrieb Arne Schwabe : > > > Am 23.03.20 um 17:11 schrieb Michael Kress: > > > Hello list, > > > > > > There seems to be some kind of alignment problem in OpenVPN 2.4 > > > versions on ARMv4 based machines (32

Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-24 Thread Michael Kress
Am Tue, 24 Mar 2020 11:21:56 +0100 schrieb Arne Schwabe : > Am 23.03.20 um 17:11 schrieb Michael Kress: > > Hello list, > > > > There seems to be some kind of alignment problem in OpenVPN 2.4 > > versions on ARMv4 based machines (32 bit), especially when lzo > > compression kicks in. > > LZO

Re: [Openvpn-devel] [PATCH v3] travis-ci: add arm64, s390x builds.

2020-03-24 Thread Илья Шипицин
sometimes, arm64 build fails https://travis-ci.org/github/OpenVPN/openvpn/jobs/666389482?utm_medium=notification_source=github_status if that will become often, we will mark it as "allowed failures" thanks to everyone, we have cmocka tests back! вт, 24 мар. 2020 г. в 14:04, Илья Шипицин :

[Openvpn-devel] mbedTLS: Make sure TLS session survives move

2020-03-24 Thread Tom van Leeuwen
From: Tom van Leeuwen When an mbedTLS session is moved in move_session(), the contents of the the tls_session is copied to the new session and the old session is reinitialized. This tls_session contains, amongst other things, an mbedtls_ssl_config and bio_ctx structure. However, the mbedtls

Re: [Openvpn-devel] [PATCH] mbedTLS: Make sure TLS session survives move

2020-03-24 Thread Antonio Quartulli
Hi Tom, you forgot to CC the mailing list :-) I am adding it back. On 24/03/2020 16:44, Tom van Leeuwen wrote: > On 24-03-2020 14:54, Antonio Quartulli wrote: >> Hi, >> >> On 24/03/2020 14:35, Gert Doering wrote: >>> Hi, >>> >>> On Tue, Mar 24, 2020 at 11:42:02AM +0100, Tom van Leeuwen wrote:

[Openvpn-devel] [PATCH applied] Re: travis-ci: add arm64, s390x builds.

2020-03-24 Thread Gert Doering
Thanks. Your patch has been applied to the master branch. commit 072f7d352d4c9b9b58dfac97fc4bb5c95652aa25 Author: Ilya Shipitsin Date: Sun Mar 22 17:35:21 2020 +0500 travis-ci: add arm64, s390x builds. Acked-by: Lev Stipakov Message-Id:

[Openvpn-devel] [PATCH applied] Re: openvpnmsica, tapctl: Revise default hardware ID management

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. Test compiled with MinGW. Change makes sense, code looks reasonable. commit 50d68142f0926850122a78a6ca661d6778efacb3 Author: Simon Rozman Date: Mon Mar 9 14:17:26 2020 +0100 openvpnmsica, tapctl: Revise default hardware ID management

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Extend to support arbitrary HWID network adapters

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. Looks reasonable. Compile tested with MSVC. (It looks a bit incomplete wrt "how to specify the component HWID now?" but this is coming in the next patches, I think) commit d263e4f300553ea77f1bf16538bcd0e81ed2e302 Author: Simon Rozman Date:

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: TAP => TUN/TAP

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. >From a granularity point of view, this one could have been merged into the other big rename fest, 07/12... but anyway. Seems to make sense, compiles with MinGW. commit 8c487854323a23e1fd1bd5e8c2827f28272f74b9 Author: Simon Rozman Date: Mon

[Openvpn-devel] [PATCH applied] Re: openvpnmsica, tapctl: interface => adapter

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. What a search-and-replace orgy :-) - did some staring at the diff, plus a test compile with MinGW commit 52b2414d3234d0fab5c1351f3035cda77a43fa2d Author: Simon Rozman Date: Mon Mar 9 14:17:23 2020 +0100 openvpnmsica, tapctl: interface =>

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Simplify static function names

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. Cursory review agrees :-) - test compiled on MinGW. commit c8de3ddb2a660b96c6176901ac948d7c3b0a57e6 Author: Simon Rozman Date: Mon Mar 9 14:17:22 2020 +0100 openvpnmsica: Simplify static function names Signed-off-by: Simon Rozman

Re: [Openvpn-devel] [PATCH] mbedTLS: Make sure TLS session survives move

2020-03-24 Thread Antonio Quartulli
Hi, On 24/03/2020 14:35, Gert Doering wrote: > Hi, > > On Tue, Mar 24, 2020 at 11:42:02AM +0100, Tom van Leeuwen wrote: >> When an mbedTLS session is moved in move_session(), the contents of the >> the tls_session is copied to the new session and the old session is >> reinitialized. This

[Openvpn-devel] [PATCH applied] Re: openvpnmsica: Revise MSI custom actions interop

2020-03-24 Thread Gert Doering
Your patch has been applied to the master branch. Very cursory review only. Test compiled on MinGW. commit e24049d55644f698a8f1ddc199ba39944394edfa Author: Simon Rozman Date: Mon Mar 9 14:17:21 2020 +0100 openvpnmsica: Revise MSI custom actions interop Signed-off-by: Simon Rozman

Re: [Openvpn-devel] [PATCH] mbedTLS: Make sure TLS session survives move

2020-03-24 Thread Gert Doering
Hi, On Tue, Mar 24, 2020 at 11:42:02AM +0100, Tom van Leeuwen wrote: > When an mbedTLS session is moved in move_session(), the contents of the > the tls_session is copied to the new session and the old session is > reinitialized. This tls_session contains, amongst other things, an >

Re: [Openvpn-devel] [PATCH 10/12] openvpnmsica, tapctl: Revise default hardware ID management

2020-03-24 Thread Lev Stipakov
Hi, > Since we are getting rid of default hwid, shouldn't we do it also for tapctl > and > make "tapctl list" return all adapters? This is fixed in 12/12. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

Re: [Openvpn-devel] [PATCH v2 12/12] tapctl: Support multiple hardware IDs

2020-03-24 Thread Lev Stipakov
Hi, Compiled with msvc and smoke-tested, "tapctl list" returns all relevant adapters. This also resolves my concert from 10/12, so I'll ack that, too. Acked-by: Lev Stipakov ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net

Re: [Openvpn-devel] [PATCH 11/12] openvpnmsica: Merge FindTUNTAPAdapters into FindSystemInfo

2020-03-24 Thread Lev Stipakov
Hi, Compiled with msvc, smoke-tested with rundll32. One thing: > +set_openvpnserv_state(hInstall); > +find_adapters( > +hInstall, > +TEXT("root\\") TEXT(TAP_WIN_COMPONENT_ID), > +TEXT("TAPWINDOWS6ADAPTERS"), > +TEXT("ACTIVETAPWINDOWS6ADAPTERS")); Both

[Openvpn-devel] [PATCH] mbedTLS: Make sure TLS session survives move

2020-03-24 Thread Tom van Leeuwen
When an mbedTLS session is moved in move_session(), the contents of the the tls_session is copied to the new session and the old session is reinitialized. This tls_session contains, amongst other things, an mbedtls_ssl_config and bio_ctx structure. However, the mbedtls context has internal

Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-24 Thread Arne Schwabe
Am 23.03.20 um 18:19 schrieb Michael Kress: > Hi, > > Unfortunatelly it seems, we are stuck to LZO for now, because it has > been configured in the clients, which run 2.3. Most of these clients are > offline most of the time, so reconfiguring or upgrading all of them > before updating the server

Re: [Openvpn-devel] Possible memory alignment Problem in 2.4 ?

2020-03-24 Thread Arne Schwabe
Am 23.03.20 um 17:11 schrieb Michael Kress: > Hello list, > > There seems to be some kind of alignment problem in OpenVPN 2.4 > versions on ARMv4 based machines (32 bit), especially when lzo > compression kicks in. LZO is known to miscompile with gcc 10 and requires -fno-strict-aliasing to

Re: [Openvpn-devel] [PATCH 10/12] openvpnmsica, tapctl: Revise default hardware ID management

2020-03-24 Thread Lev Stipakov
Hi, Since we are getting rid of default hwid, shouldn't we do it also for tapctl and make "tapctl list" return all adapters? Since it defaults to root\tap0901, "tapctl list" doesn't show anything for me, which is a bit confusing: > c:\Users\lev\Projects\openvpn\x64-Output\Debug>tapctl.exe list

Re: [Openvpn-devel] [PATCH v3] travis-ci: add arm64, s390x builds.

2020-03-24 Thread Илья Шипицин
I guess nobody yet reported that issue. Maybe, I'll report. вт, 24 мар. 2020 г. в 14:03, Lev Stipakov : > Yes, I agree that with name is looks much better. > > I wonder why displaying arch requires you to be logged in. > ___ Openvpn-devel mailing list

Re: [Openvpn-devel] [PATCH v3] travis-ci: add arm64, s390x builds.

2020-03-24 Thread Lev Stipakov
Yes, I agree that with name is looks much better. I wonder why displaying arch requires you to be logged in. ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v3] travis-ci: add arm64, s390x builds.

2020-03-24 Thread Lev Stipakov
Hi, Tested with my openvpn github fork - all jobs passed and overall travis dashboard looks nice thanks to added "name" field. It would be even nicer to have "arch" as part of name, because now it looks like gcc | openssl-1.1.1d gcc | openssl-1.1.1d But this is already step forward