Hi,
On Fri, Jun 24, 2022 at 10:37:56AM +0200, Antonio Quartulli wrote:
> diff --git a/src/openvpn/init.c b/src/openvpn/init.c
> index b0a4b252..091cbd24 100644
> --- a/src/openvpn/init.c
> +++ b/src/openvpn/init.c
> @@ -2219,6 +2219,19 @@ do_deferred_p2p_ncp(struct context *c)
> return true;
Acked-by: Gert Doering
Silly code, this...
Before:
2022-07-14 20:50:12 us=826150 MANAGEMENT: Client connected from
[AF_INET]127.0.0.1:0
After:
2022-07-14 20:51:18 us=100211 MANAGEMENT: TCP Socket listening on
[AF_INET]127.0.0.1:49334
2022-07-14 20:51:22 us=443453 MANAGEMENT: Client
Acked-by: Gert Doering
This looks like a useful addition, and it actually works :-)
$ openvpn --verb 4 --dev tun --management :: 0 --management-hold
..
2022-07-14 20:43:01 us=644866 setsockopt(IPV6_V6ONLY=0)
2022-07-14 20:43:01 us=644907 MANAGEMENT: TCP Socket listening on
Nobody has spoken up so far "I REALLY NEED THIS!!", and if you say
it hasn't worked anyway, out it goes... less code, less arguments,
less variables...
I have only skimmed the code change and did a quick test build on
FreeBSD.
Your patch has been applied to the master branch.
commit
Taking the agreement from Arne as formal ACK (checked on IRC).
I'm not sure I grok all the details of this, but I can attest that
unit_tests/test_provider still works (on a 3.0.x build), and that calls
the "xkey_load_generic_key()" function being modified here. So, this
is good. Lev promised
Acked-by: Gert Doering
Trivial enough, and confirmed that it does not break anything.
(Having the "has_digit()" in buffer.*h* when it is only ever called
from tun.c smells like "we might eventually include this in
tun_name_is_fixed() and get rid of the inline helper" - but this is
a patch for
Am 07.07.22 um 05:51 schrieb selva.n...@gmail.com:
From: Selva Nair
The function signature for xkey_load_generic_key had
function pointers defined as function types that seems
to work in gcc but not in msvc.
Fix it by changing the function signatures to what was
intended.
Also revert part of
Hi,
Any thoughts on this? Apart from the broken msvc builds that led to this,
looks like the right thing to do, isn't it?
Selva
On Wed, Jul 6, 2022 at 11:52 PM wrote:
> From: Selva Nair
>
> The function signature for xkey_load_generic_key had
> function pointers defined as function types
Hi,
On Fri, Jun 24, 2022 at 10:37:50AM +0200, Antonio Quartulli wrote:
> Signed-off-by: Antonio Quartulli
> ---
> src/openvpn/init.c | 49
> src/openvpn/ssl_common.h | 23 +++
> 2 files changed, 63 insertions(+), 9 deletions(-)
Hi,
On Tue, Jul 12, 2022 at 11:46:42PM +0200, Antonio Quartulli wrote:
> open_tun_generic already contains the logic required to find a device
> name when not specified b the user. For this reason the DCO case can
> easily leverage on function and avoid code duplication.
>
> Signed-off-by:
10 matches
Mail list logo
