On Tue, Sep 19, 2023 at 05:56:35PM +0200, Frank Lichtenheld wrote:
> These are based on review comments for the 2.6 backport.
> But since they apply to the original master implementation
> as well, I address them in this separate patch.
>
> - Add documentation to contrib/cmake/*.py
> - Fix
These are based on review comments for the 2.6 backport.
But since they apply to the original master implementation
as well, I address them in this separate patch.
- Add documentation to contrib/cmake/*.py
- Fix grammar in README.cmake.md
- Update a TODO in CMakeLists.txt to better reflect
the
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email
to look at the new patch set (#24).
Change subject: Please ignore - Uncrustify code check
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email
to review the following change.
Change subject: Please ignore - Uncrustify code check
uddr has removed d12fk from this change. (
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email )
Change subject: Please ignore - Uncrustify code check
..
Removed cc d12fk .
--
To view, visit
uddr has removed openvpn-devel from this change. (
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email )
Change subject: Please ignore - Uncrustify code check
..
Removed cc openvpn-devel .
--
To view, visit
uddr has removed flichtenheld from this change. (
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email )
Change subject: Please ignore - Uncrustify code check
..
Removed reviewer flichtenheld .
--
To view, visit
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email
to look at the new patch set (#22).
Change subject: Please ignore - Uncrustify code check
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/261?usp=email
to review the following change.
Change subject: Please ignore - Uncrustify code check
Attention is currently required from: d12fk, flichtenheld.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/342?usp=email )
Change subject: CMake: various small non-functional improvements
..
Attention is currently required from: d12fk, flichtenheld.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/342?usp=email )
Change subject: CMake: various small non-functional improvements
..
Attention is currently required from: d12fk, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/313?usp=email )
Change subject: Mock openvpn_exece on win32 also for test_tls_crypt
Attention is currently required from: d12fk, stipa.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/342?usp=email )
Change subject: CMake: various small non-functional improvements
..
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/342?usp=email )
Change subject: CMake: various small non-functional improvements
..
CMake: various small non-functional improvements
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/315?usp=email )
Change subject: CMake: backport CMake buildsystem from master to release/2.6
..
Patch Set 1:
(5 comments)
Patchset:
Attention is currently required from: flichtenheld.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/312?usp=email )
Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant
Attention is currently required from: flichtenheld.
stipa has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/312?usp=email )
Change subject: Make cert_data.h and test_cryptoapi/pkcs11.c MSVC compliant
17 matches
Mail list logo
