Re: [Openvpn-devel] [PATCH 2/2] Permit make dist* targets without py*-docutils

2020-07-17 Thread David Sommerseth
> > # Failsafe - do not delete these files unless we can recreate them > CLEANFILES = \ Thanks! This fixes the 'make distdir', which should also fix the 'make check' issues Gert found [1]. Acked-By: David Sommerseth [1] Message-Id: 20200717131607.gs1...@greenie.muc.de <https:/

Re: [Openvpn-devel] [PATCH] Convert cc_check_return to switch/case

2020-07-17 Thread David Sommerseth
et) { case CC_RET_SUCCEEDED: (*cc_succeeded_count)++; return true; case CC_RET_FAILED: return false; case CC_RET_SKIPPED: return true; default: ASSERT(0); } I generally find this a

[Openvpn-devel] [PATCH] doc/man: Add misssing renegotiation.rst to Makefile.am

2020-07-17 Thread David Sommerseth
such a tarball, it will explode and complain about this missing file. Signed-off-by: David Sommerseth --- doc/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/Makefile.am b/doc/Makefile.am index a1ac02f6..add92198 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -31,6 +31,7

[Openvpn-devel] [PATCH] doc/man: Documentation for --bind-dev / VRFs on Linux

2020-07-17 Thread David Sommerseth
Signed-off-by: Maximilian Wilhelm Signed-off-by: David Sommerseth --- v2 - Added missing entry into Makefile.am --- doc/Makefile.am | 1 + doc/man-sections/network-config.rst | 1 + .../virtual-routing-and-forwarding.rst| 78

Re: [Openvpn-devel] [PATCH applied] Re: doc/man: Replace old man page with generated man page

2020-07-17 Thread David Sommerseth
t,distcheck}" from the *git repo*, python-docutils need to be a mandatory dependency - because we don't check in the prebuilt openvpn.8 and openvpn.html files into the git repo. This logic could probably contains some flaws and can be further improved, but I figured we need to get this tested

[Openvpn-devel] [PATCH v2 5/8] doc/man: Mark compression options as deprecated

2020-07-16 Thread David Sommerseth
-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/doc/man-sections/protocol-options.rst b/doc/man-sections/protocol-options.rst index ae85a25e..a5a1253a 100644 --- a/doc/man-sections/protocol-options.rst

[Openvpn-devel] [PATCH v2 7/8] doc/man: Update --txqueuelen default setting (Now OS default)

2020-07-16 Thread David Sommerseth
From: Richard Bonhomme Signed-off-by: Richard Bonhomme Signed-off-by: David Sommerseth --- doc/man-sections/advanced-options.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/man-sections/advanced-options.rst b/doc/man-sections/advanced-options.rst index dbf7799c

[Openvpn-devel] [PATCH v2 6/8] doc/man: Adopt compression documentation

2020-07-16 Thread David Sommerseth
Commit c67e93b25208be2 updated the man page in reagrds to new compression options and improving existing compression options. This adopts those changes into the .rst format. Signed-off-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 52 ++- 1 file

[Openvpn-devel] [PATCH v2 8/8] doc/man: Documentation for --bind-dev / VRFs on Linux

2020-07-16 Thread David Sommerseth
Signed-off-by: Maximilian Wilhelm Signed-off-by: David Sommerseth --- doc/man-sections/network-config.rst | 1 + .../virtual-routing-and-forwarding.rst| 78 +++ doc/man-sections/vpn-network-options.rst | 4 + 3 files changed, 83 insertions(+) create

[Openvpn-devel] [PATCH v2 0/8] man-page overhaul project - round 2

2020-07-16 Thread David Sommerseth
of that commit, but I wanted to be sure he gets the proper credit somehow. kind regards, David Sommerseth OpenVPN Inc David Sommerseth (7): doc/man: Add an .rst formatted version of the man page doc/man: Replace old man page with generated man page doc/man: Split up and reorganize main man page

Re: [Openvpn-devel] [PATCH v5 14/14] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread David Sommerseth
On 16/07/2020 23:07, Gert Doering wrote: > Hi, > > On Thu, Jul 16, 2020 at 11:04:09PM +0200, David Sommerseth wrote: >> So I'm looking into migrating this text over to the new .rst format ... and I >> have a question ... > > This one *should* be identical to 6/6 fro

Re: [Openvpn-devel] [PATCH v5 14/14] client-connect: Add documentation for the deferred client connect feature

2020-07-16 Thread David Sommerseth
th_control_file/client_connect_deferred_file when using deferred auth method Is this what you intended to say? * OPENVPN_PLUGIN_AUTH_USER_PASS_VERIFY plugin hook and --client-connect scripts to return success/failure via auth_control_file/client_connect_deferred_file when using

[Openvpn-devel] [PATCH 12/16] doc/man: Misc grammar and typo fixes

2020-07-15 Thread David Sommerseth
From: Richard Bonhomme Signed-off-by: Richard Bonhomme Signed-off-by: David Sommerseth --- doc/man-sections/advanced-options.rst| 4 +-- doc/man-sections/client-options.rst | 17 +- doc/man-sections/connection-profiles.rst | 2 +- doc/man-sections/encryption-options.rst

[Openvpn-devel] [PATCH 10/16] doc/man: Moved --reneg-* options to its own section

2020-07-15 Thread David Sommerseth
The options related to renegotiation of the data channel encryption key is not really a link option. As the renegotiation is encryption related but doesn't really fit into the generic, tls or pkcs11 sections, add it into its own section. Signed-off-by: David Sommerseth --- doc/man-sections

[Openvpn-devel] [PATCH 14/16] doc/man: Update --txqueuelen default setting (Now OS default)

2020-07-15 Thread David Sommerseth
From: Richard Bonhomme Signed-off-by: Richard Bonhomme Signed-off-by: David Sommerseth --- doc/man-sections/advanced-options.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/man-sections/advanced-options.rst b/doc/man-sections/advanced-options.rst index dbf7799c

[Openvpn-devel] [PATCH 09/16] doc/man: Move some options from link to advanced section

2020-07-15 Thread David Sommerseth
Moved --persist-local-ip, --persist-remote-ip, --rcvbuf, --sndbuf and --shaper from the link options section to the advanced section. The rationale is that these options are not common to use and is for more advanced use cases where special tweaking is required. Signed-off-by: David Sommerseth

[Openvpn-devel] [PATCH 13/16] doc/man: Adopt compression documentation

2020-07-15 Thread David Sommerseth
Commit c67e93b25208be2 updated the man page in reagrds to new compression options and improving existing compression options. This adopts those changes into the .rst format. Signed-off-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 52 ++- 1 file

[Openvpn-devel] [PATCH 16/16] doc/man: Minor improvements to the plug-in section

2020-07-15 Thread David Sommerseth
Make the valid syntax clearer and apply proper styling of few reference strings. Signed-off-by: David Sommerseth --- doc/man-sections/plugin-options.rst | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/man-sections/plugin-options.rst b/doc/man-sections

[Openvpn-devel] [PATCH 04/16] doc/man: Remove unsupported options in OpenVPN 2.5

2020-07-15 Thread David Sommerseth
This removes the options from the man page which is enlisted as deprecated options in OpenVPN 2.5. To provide some history, a short summary of why they were removed has been put into a new file which is included into its own "UNSUPPORTED OPTIONS" section in the man page. Signed-off

[Openvpn-devel] [PATCH 08/16] doc/man: Mark compression options as deprecated

2020-07-15 Thread David Sommerseth
-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/man-sections/protocol-options.rst b/doc/man-sections/protocol-options.rst index 37e55eb7..5bc072af 100644 --- a/doc/man-sections/protocol

[Openvpn-devel] [PATCH 15/16] doc/man: Fix a few typos and improve style usage

2020-07-15 Thread David Sommerseth
The server returns "AUTH_FAILED". Such strings and code related references should use the :code:`SOME_STRING` style. Signed-off-by: David Sommerseth --- doc/man-sections/client-options.rst | 10 +- doc/man-sections/script-options.rst | 2 +- 2 files changed, 6 insert

[Openvpn-devel] [PATCH 11/16] doc/man: Cleaned up the examples

2020-07-15 Thread David Sommerseth
of the instructions should be fairly OS neutral and is a quick introduction how to get tunnels configured and gradually expand the configuration and improve the security along the way. Signed-off-by: David Sommerseth --- doc/man-sections/examples.rst | 105 -- 1

[Openvpn-devel] [PATCH 07/16] doc/man: Move --dhcp-option from client to vpn-network section

2020-07-15 Thread David Sommerseth
Even though the --dhcp-option is only useful in a client context, it is more related to configuration of the VPN network interface and the related settings. Signed-off-by: David Sommerseth --- doc/man-sections/client-options.rst | 69 doc/man-sections/vpn-network

[Openvpn-devel] [PATCH 06/16] doc/man: Move --bind from generic to link section

2020-07-15 Thread David Sommerseth
This is more related to the configuration of the link, plus --nobind is already placed in the link section. Signed-off-by: David Sommerseth --- doc/man-sections/generic-options.rst | 7 --- doc/man-sections/link-options.rst| 7 +++ 2 files changed, 7 insertions(+), 7 deletions

[Openvpn-devel] [PATCH 03/16] doc/man: Move profiles section

2020-07-15 Thread David Sommerseth
The profile documentation has been enlisted in between all the other OpenVPN options. As is not strictly an option by itself but a grouping mechanism, move it into its own section in the man page. This also makes the HTML rendering look much nicer and better structured. Signed-off-by: David

[Openvpn-devel] [PATCH 00/16] man-page overhaul project

2020-07-15 Thread David Sommerseth
into a single commit, I have no issues with that. kind regards, David Sommerseth OpenVPN Inc David Sommerseth (14): doc/man: Add an .rst formatted version of the man page doc/man: Replace old man page with generated man page doc/man: Move profiles section doc/man: Remove unsupported opti

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-07-02 Thread David Sommerseth
cation between the OpenVPN end-points themselves). The DNS settings and more related to host configuration and similar will be moved into an IV_FEAT field. Except of that, nothing else has changed from the initial mail. The main purpose of that RFC is to ensure we handle DNS and --dhcp-options cons

Re: [Openvpn-devel] [PATCH] New man page corrections - advanced-options.rst

2020-06-26 Thread David Sommerseth
. Defaults to operation system > + Set the TCP/UDP socket send buffer size. Defaults to operating system >default. Thanks again! I've squashed this change into your previous grammar/typo fix commit. -- kind regards, David Sommerseth

Re: [Openvpn-devel] [PATCH] New man page corrections - encryption-options.rst

2020-06-26 Thread David Sommerseth
t;; that would make it a bit difficult to use :) I think what was meant was: "This file should be kept secret *on* the server ..." -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] New man page - Simple corrections

2020-06-26 Thread David Sommerseth
lign it with the other commits in this branch. -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 00/11] man-page overhaul project

2020-06-24 Thread David Sommerseth
On 24/06/2020 20:07, David Sommerseth wrote: > Hi, > > This is the first real review round of the man-page overhaul project. > Since the n/groff based openvpn.8 format is fairly cumbersome to edit, > we agreed at the 2019 Hackathon in Trento to move the man page into > some

[Openvpn-devel] [PATCH 07/11] doc/man: Move --dhcp-option from client to vpn-network section

2020-06-24 Thread David Sommerseth
Even though the --dhcp-option is only useful in a client context, it is more related to configuration of the VPN network interface and the related settings. Signed-off-by: David Sommerseth --- doc/man-sections/client-options.rst | 69 doc/man-sections/vpn-network

[Openvpn-devel] [PATCH 11/11] doc/man: Cleaned up the examples

2020-06-24 Thread David Sommerseth
of the instructions should be fairly OS neutral and is a quick introduction how to get tunnels configured and gradually expand the configuration and improve the security along the way. Signed-off-by: David Sommerseth --- doc/man-sections/examples.rst | 105 -- 1

[Openvpn-devel] [PATCH 10/11] doc/man: Moved --reneg-* options to its own section

2020-06-24 Thread David Sommerseth
The options related to renegotiation of the data channel encryption key is not really a link option. As the renegotiation is encryption related but doesn't really fit into the generic, tls or pkcs11 sections, add it into its own section. Signed-off-by: David Sommerseth --- doc/man-sections

[Openvpn-devel] [PATCH 04/11] doc/man: Remove unsupported options in OpenVPN 2.5

2020-06-24 Thread David Sommerseth
This removes the options from the man page which is enlisted as deprecated options in OpenVPN 2.5. To provide some history, a short summary of why they were removed has been put into a new file which is included into its own "UNSUPPORTED OPTIONS" section in the man page. Signed-off

[Openvpn-devel] [PATCH 03/11] doc/man: Move profiles section

2020-06-24 Thread David Sommerseth
The profile documentation has been enlisted in between all the other OpenVPN options. As is not strictly an option by itself but a grouping mechanism, move it into its own section in the man page. This also makes the HTML rendering look much nicer and better structured. Signed-off-by: David

[Openvpn-devel] [PATCH 09/11] doc/man: Move some options from link to advanced section

2020-06-24 Thread David Sommerseth
Moved --persist-local-ip, --persist-remote-ip, --rcvbuf, --sndbuf and --shaper from the link options section to the advanced section. The rationale is that these options are not common to use and is for more advanced use cases where special tweaking is required. Signed-off-by: David Sommerseth

[Openvpn-devel] [PATCH 08/11] doc/man: Mark compression options as deprecated

2020-06-24 Thread David Sommerseth
-by: David Sommerseth --- doc/man-sections/protocol-options.rst | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/doc/man-sections/protocol-options.rst b/doc/man-sections/protocol-options.rst index 37e55eb7..5bc072af 100644 --- a/doc/man-sections/protocol

[Openvpn-devel] [PATCH 06/11] doc/man: Move --bind from generic to link section

2020-06-24 Thread David Sommerseth
This is more related to the configuration of the link, plus --nobind is already placed in the link section. Signed-off-by: David Sommerseth --- doc/man-sections/generic-options.rst | 7 --- doc/man-sections/link-options.rst| 7 +++ 2 files changed, 7 insertions(+), 7 deletions

[Openvpn-devel] [PATCH 00/11] man-page overhaul project

2020-06-24 Thread David Sommerseth
sections. I will continue to update my own git branch containing this work as review comments come in until this is merged into master. You can find it here: https://gitlab.com/dazo/openvpn/-/tree/dev/man-reformatting/doc kind regards, David Sommerseth OpenVPN Inc. David Sommerseth (11

Re: [Openvpn-devel] Summary of the community meeting (24th June 2020)

2020-06-24 Thread David Sommerseth
ompression > - async cc > - VRF (which is quite trivial) > > The auth-token fixes are corner-cases and it was agreed that that can be > resolved between 2.5-alpha1 and 2.5-beta1. That's also incorrect. We will resolve these issues between the beta1 and rc1 releases. -- kind regard

[Openvpn-devel] [RFC] Challenges with OpenVPN and configuring DNS

2020-06-23 Thread David Sommerseth
what it will be capable of. -- kind regards, Arne Schwabe David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
[resent for the ML inclusion] On 22/06/2020 18:58, Selva Nair wrote: > On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth wrote: [...snip...] >> +ExecStart=@sbindir@/openvpn --status %t/openvpn-server/status-%i.log >> --status-version 2 --suppress-timestamps --cipher AES-256-GC

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
On 22/06/2020 14:43, Steffan Karger wrote: > Hi, > > On 22-06-2020 14:29, David Sommerseth wrote: >> On 22/06/2020 14:21, Arne Schwabe wrote: >>> >>>> PrivateTmp=true >>>> WorkingDirectory=/etc/openvpn/server >>>> -ExecStar

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
On 22/06/2020 19:20, André via Openvpn-devel wrote: > Hi, > > > Sent with ProtonMail Secure Email. > > ‐‐‐ Original Message ‐‐‐ > On Monday 22 June 2020 18:58, Selva Nair wrote: > >> On Mon, Jun 22, 2020 at 7:31 AM David Sommerseth dav...@openvpn.net w

Re: [Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
grade. Do we want do do that? I'm fine with removing BF-CBC, but it is scheduled for removal in OpenVPN 2.6. <https://community.openvpn.net/openvpn/wiki/DeprecatedOptions#Policy:Removalofinsecureciphers:Cipherswithcipherblock-sizelessthan128bitsmostcommonlyBFDESCAST5IDEAandRC2

[Openvpn-devel] [PATCH] systemd: Change the default cipher to AES-256-GCM for server configs

2020-06-22 Thread David Sommerseth
of the OpenVPN binary itself with time. Signed-off-by: David Sommerseth --- Changes.rst | 15 +++ distro/systemd/openvpn-ser...@.service.in | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/Changes.rst b/Changes.rst index 00dd6ed8..e76d3c73

Re: [Openvpn-devel] [Openvpn-users] Multiple DNS search suffixes on Windows

2020-06-21 Thread David Sommerseth
this is more typically a business feature than a consumer VPN feature. There might be a few ones implementing or needing such a feature, but if they don't appear here and raise there concerns here, I don't think we should spend time on them. -- kind regards, David Sommerseth OpenVPN Inc sign

[Openvpn-devel] OpenVPN webinar - 24th June

2020-06-17 Thread David Sommerseth
etails: <https://www.timeanddate.com/worldclock/fixedtime.html?msg=OpenVPN+Access+Server+webinar=20200624T10=224> -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing

Re: [Openvpn-devel] [PATCH v2] Add .git-blame-ignore-revs with reformat commits

2020-06-10 Thread David Sommerseth
gent-demo/management-demo-server.py > b/contrib/managent-demo/management-demo-server.py This looks good. > new file mode 100644 > index ..e69de29b > diff --git a/contrib/ovpnkeys.py b/contrib/ovpnkeys.py > new file mode 100644 >

Re: [Openvpn-devel] [PATCH] Add .git-blame-ignore-revs with reformat commits

2020-05-29 Thread David Sommerseth
t; So a few minor things to look into, otherwise this is really valuable. I would probably also consider to also add a note about this git feature in README. It's not the most ideal file, but I struggle to find a better place currently (I might have overlooked something). We would probably bene

[Openvpn-devel] man page overhaul project

2020-05-28 Thread David Sommerseth
ful information for this day and age is welcome. Looking forward to hear back from you, whenever you have some input how to make the man page better. -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature __

Re: [Openvpn-devel] [PATCH v3 5/5] Implement forwarding client CR_RESPONSE messages to management

2020-05-27 Thread David Sommerseth
| 2 ++ > 6 files changed, 89 insertions(+), 2 deletions(-) > [...] Basing this also on prior testing, looking good. Only done compile testing in this round. Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc signature.

Re: [Openvpn-devel] [PATCH v3 4/5] Implement sending AUTH_PENDING challenges to clients

2020-05-27 Thread David Sommerseth
| 19 + > src/openvpn/push.c | 24 +++ > src/openvpn/push.h | 7 > 6 files changed, 185 insertions(+) > [...] Only compile tested, as I've done quite some testing earlier. Requested changes are in, with the exception of IV_SSO which we can't cha

Re: [Openvpn-devel] [PATCH v3 3/5] Implement sending response to challenge via CR_RESPONSE

2020-05-27 Thread David Sommerseth
with OpenVPN Access Server (already in production) and OpenVPN Cloud (recently released). This is something we can consider change later on, then in cooperation with OpenVPN Access Server and OpenVPN Cloud. Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc _

Re: [Openvpn-devel] [PATCH v3 2/5] Implement support for signalling IV_SSO to server

2020-05-27 Thread David Sommerseth
(e->string,"IV_GUI_VER=",sizeof("IV_GUI_VER=")-1)==0) > + || (strncmp(e->string,"IV_SSO=",sizeof("IV_SSO=")-1)==0) > + ) > && buf_safe(, strlen(e->string)+1)) >

Re: [Openvpn-devel] [PATCH v3 1/5] Implement parsing and sending INFO and INFO_PRE control messages

2020-05-27 Thread David Sommerseth
penvpn/push.c| 32 > src/openvpn/push.h| 3 +++ > 3 files changed, 43 insertions(+) > [...] Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc ___ Openvpn-devel mailing list Openv

Re: [Openvpn-devel] [PATCH] Refuse server mode on Android

2020-05-19 Thread David Sommerseth
ally needs TARGET_ANDROID with server support, lets wait for them to appear so we can clearly define the use-case and design a better solution for a known scenario. Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc ___ Openvpn

Re: [Openvpn-devel] [PATCH v2 5/5] Implement forwarding client CR_RESPONSE messages to management

2020-05-15 Thread David Sommerseth
tion response, invalid data (not base64 encoded, etc) is meaningful. I'm also wondering if it would make sense to validate the base64 response as well. To summarize all patches: - They all look reasonable and fine, but there are a few things to improve. - We should a

Re: [Openvpn-devel] [PATCH v2 4/5] Implement sending SSO challenge to clients

2020-05-15 Thread David Sommerseth
On 15/05/2020 17:36, David Sommerseth wrote: > On 09/11/2019 16:13, Arne Schwabe wrote: >> This implements sending AUTH_PENDING and INFO_PRE messages to clients >> that indicate that the clients should be continue authentication with >> a second factor. This can currently be

Re: [Openvpn-devel] [PATCH v2 4/5] Implement sending SSO challenge to clients

2020-05-15 Thread David Sommerseth
; +size_t len = strlen(extra)+1 + sizeof(info_pre); > +if (len > PUSH_BUNDLE_SIZE) > +{ > +return false; > +} > +struct gc_arena gc = gc_new(); > + > +struct buffer buf = alloc_buf_gc(len, ); > +buf_pr

Re: [Openvpn-devel] [PATCH v2 3/5] Implement sending response to challenge via CR_RESPONSE

2020-05-15 Thread David Sommerseth
; cb.show_net = management_show_net_callback; > cb.proxy_cmd = management_callback_proxy_cmd; > cb.remote_cmd = management_callback_remote_cmd; > +cb.send_cc_message = management_callback_send_cc_mesage; Same typo here in the callback functio

Re: [Openvpn-devel] [PATCH] get rid of TAG_FILE_INLINE constant

2020-05-11 Thread David Sommerseth
} > > return np(str); > So with Antonio's explaination in message-id <6a62b6d2-7870-124f-5b5f-be657ffeb...@unstable.cc> and applying message-id <20200510140017.16837-...@unstable.cc> ([PATCH] tls-crypt-v2: fix testing of inline key, which I just gave an

Re: [Openvpn-devel] [PATCH] tls-crypt-v2: fix testing of inline key

2020-05-11 Thread David Sommerseth
error ------ With this patch, the error messages below the generated key is gone. And since the code changes are not surprising, this is good to go. Acked-by: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc signatur

Re: [Openvpn-devel] [PATCH] get rid of TAG_FILE_INLINE constant

2020-05-10 Thread David Sommerseth
rc/openvpn' CC tls_crypt.o tls_crypt.c: In function ‘tls_crypt_v2_write_client_key_file’: tls_crypt.c:706:27: error: ‘INLINE_FILE_TAG’ undeclared (first use in this function) client_filename = INLINE_FILE_TAG; ^ I haven't dug into if c

Re: [Openvpn-devel] [PATCH] options: fix inlining auth-gen-token-secret file

2020-05-10 Thread David Sommerseth
ions->auth_token_secret_file_inline = p[2]; > -} > } > else if (streq(p[0], "client-connect") && p[1]) > { > Good to see that braintwister of boolean logic go away. I've only done a quick compile test and glared at the code change, w

[Openvpn-devel] [PATCH 2/2] options: Restore --tls-crypt-v2 inline file capability

2020-05-08 Thread David Sommerseth
the option parser rejected --tls-crypt-v2 as inline capable. Second issue was that the 'streq(p[1], INLINE_FILE_TAG)' check makes no longer sense, as at this point p[1] contains the file contents. Instead use the is_inline flag. Signed-off-by: David Sommerseth --- src/openvpn/options.c | 12

[Openvpn-devel] [PATCH 1/2] options: Fix failing inline tls-auth/crypt with persist-key

2020-05-08 Thread David Sommerseth
tion. But in commit cb2e9218f2bc73fa2 this logic had lost the "inline indicator". The result was that the connection entry had the key file content stored in the object but was "tagged" as a normal file (name) not an inline file. Signed-off-by: David Sommerseth --- src/ope

[Openvpn-devel] OpenVPN 3 Linux client - v9 beta released

2020-04-23 Thread David Sommerseth
GitHub pull-request #209 [1] in the SELinux reference policy project for details. -- kind regards, David Sommerseth OpenVPN Inc [0] <https://gitlab.com/openvpn/openvpn3-linux> <https://github.com/OpenVPN/openvpn3-linux> [1] <https://github.com/SELinuxProject/refpolicy/pu

Re: [Openvpn-devel] [PATCH] Support for wolfSSL in OpenVPN

2020-04-15 Thread David Sommerseth
n tested against Windows builds with WolfSSL enabled, like via mingw? -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [Openvpn-users] Removing --disable-server option from OpenVPN

2020-03-29 Thread David Sommerseth
format than what it is today. -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-29 Thread David Sommerseth
On 28/03/2020 12:33, Gert Doering wrote: > Hi, > > On Fri, Mar 27, 2020 at 04:24:00PM +0100, David Sommerseth wrote: >> On 16/11/2019 11:28, Arne Schwabe wrote: >>> Over time some patches slipped in that were not 100% complient to uncrustify >>> This rerun fixes

Re: [Openvpn-devel] [PATCH v2 4/5] Implement sending SSO challenge to clients

2020-03-28 Thread David Sommerseth
also a more advanced authentication method, having good test methods is even more critical. -- kind regards, David Sommerseth OpenVPN Inc ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH] Reformat all source files

2020-03-28 Thread David Sommerseth
-- > 19 files changed, 99 insertions(+), 79 deletions(-) > Only done quick code review and RHEL-7 build. Changes looks reasonable and is by far closer to what I would expect our coding style to look like. Acked-By: David Sommerseth -- kind regards, David S

Re: [Openvpn-devel] [PATCH v2 1/5] Implement parsing and sending INFO and INFO_PRE control messages

2020-03-28 Thread David Sommerseth
management_notify_generic(management, BSTR()); > + > +gc_free(); > +} > +#endif The indent of this #endif is wrong. Wouldn't harm with an "/* ENABLE_MANAGEMENT */" comment as well. This could be fixed at merge time. Otherwise, this looks good. Acked-By: David Sommerseth -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH v2 2/5] Implement support for signalling IV_SSO to server

2020-03-28 Thread David Sommerseth
Sorry, I'm loosing grip of my mailing-list-fu ... Managed to reply only to Arne. On 27/03/2020 21:59, David Sommerseth wrote: > On 09/11/2019 16:13, Arne Schwabe wrote: >> Signed-off-by: Arne Schwabe >> --- >> src/openvpn/ssl.c | 4 +++- >> 1 file changed,

Re: [Openvpn-devel] [PATCH v2 3/5] Implement sending response to challenge via CR_RESPONSE

2020-03-28 Thread David Sommerseth
nagement function to be able to > do this. The answer should be base64 encoded. Could we have some kind of test/sample script demonstrating this feature? It would also help test that this feature works and also useful for regression testing later on. -- kind regards, David Sommerseth OpenVPN In

Re: [Openvpn-devel] [PATCH v6 5/5] Normalise ncp-ciphers option and restrict it to 127 bytes

2020-03-27 Thread David Sommerseth
src/openvpn/ssl_ncp.h | 19 +- > tests/unit_tests/openvpn/test_ncp.c | 54 +++ > 5 files changed, 125 insertions(+), 22 deletions(-) > I've only done quick code review and built it on RHEL7 not finding any issues. Code looks reasonable, so I don't

[Openvpn-devel] OpenVPN git master builds for Fedora/RHEL/CentOS

2020-03-22 Thread David Sommerseth
ersion by doing 'yum downgrade openvpn'. If you have automated updates enabled on your system, you might want to consider to blacklist the openvpn package - as the openvpn git master might not be as stable yet as the released versions. -- kind regards, David Sommerseth OpenVPN Inc signatu

Re: [Openvpn-devel] [PATCH] Document some limitations of --auth-user-pass

2020-03-17 Thread David Sommerseth
ption (in this case the one set by the GUI) > to override a previous one. Anyway we do already ignore it if the file > is "stdin". Agreed! -- kind regards, David Sommerseth OpenVPN Inc signature.asc Description: OpenPGP digital signature ___

Re: [Openvpn-devel] [PATCH] Document some limitations of --auth-user-pass

2020-03-16 Thread David Sommerseth
way complain to their IT department regardless, for using outdated security software). I would just rephrase it to say: OpenVPN GUI v11 and newer uses its own internal username/password storage independent of the --auth-user-pass file provided. The file argument is ignored on such

[Openvpn-devel] [PATCH] build: Remove --disable-server from ./configure

2020-02-27 Thread David Sommerseth
the options_postprocess_mutate_invariant() function, the #ifdef P2MP_SERVER and #ifdef _WIN32 blocks where slightly reworked to make the _WIN32 block more continous and avoiding having an empty if(options->mode == MODE_SERVER) block. Signed-off-by: David Sommerseth [1] https://www.mail-archive.

Re: [Openvpn-devel] [PATCH v4 4/5] Move NCP related function into a seperate file and add unit tests

2020-02-20 Thread David Sommerseth
s_list 1 FAILED TEST(S) We can't have any failing tests ;-) This is tested on RHEL-7.7 (openssl-1.0.2k-19) which I also do know have AES-GCM support. -- kind regards, David Sommerseth OpenVPN Inc ___ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH applied] Fix possibly uninitialized return value in GetOpenvpnSettings()

2020-02-20 Thread David Sommerseth
-by: Selva Nair Acked-by: Lev Stipakov Message-Id: <1582159777-2437-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19479.html Signed-off-by: David Sommerseth - -- kind regards, David Sommerseth -BEG

Re: [Openvpn-devel] [PATCH applied] Warn about insecure ciphers also in init_key_type

2020-02-20 Thread David Sommerseth
Acked-by: Steffan Karger Message-Id: <20200219112153.13013-1-a...@rfc2549.org> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19476.html Signed-off-by: David Sommerseth - -- kind regards, David Sommerseth -BEGIN PGP SIGNATURE- V

Re: [Openvpn-devel] [PATCH applied] Fix possible access of uninitialized pipe handles

2020-02-20 Thread David Sommerseth
Acked-by: Lev Stipakov Message-Id: <1582163803-3342-1-git-send-email-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19480.html Signed-off-by: David Sommerseth - -- kind regards, David Sommerseth -BEGIN PGP SIG

Re: [Openvpn-devel] [PATCH applied] re-implement argv_printf_*()

2020-02-20 Thread David Sommerseth
Sommerseth Acked-by: Arne Schwabe Message-Id: <20200206132103.15977-2-dav...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19380.html - -- kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.22 (GNU

Re: [Openvpn-devel] [PATCH applied] Documented all the argv related code with minor refactoring

2020-02-20 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Your patch has been applied to the master branch commit 3226c2edaf0ddd1b4541ce81ebce97a9ae9ecd2a Author: David Sommerseth Date: Thu Feb 6 14:21:03 2020 +0100 Documented all the argv related code with minor refactoring Signed-off

Re: [Openvpn-devel] [PATCH applied] Add gc_arena to struct argv to save allocations

2020-02-20 Thread David Sommerseth
Signed-off-by: David Sommerseth Acked-by: Arne Schwabe Message-Id: <20200206132103.15977-4-dav...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19376.html - -- kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version:

Re: [Openvpn-devel] [PATCH applied] argv: do fewer memory re-allocations

2020-02-20 Thread David Sommerseth
-by: David Sommerseth Acked-by: Arne Schwabe Message-Id: <20200206132103.15977-3-dav...@openvpn.net> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19378.html - -- kind regards, David Sommerseth -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.2

Re: [Openvpn-devel] OpenVPN 3 Linux client - v8 beta released

2020-02-12 Thread David Sommerseth
On 10/02/2020 23:32, David Sommerseth wrote: > > Hi, > > The OpenVPN 3 Linux v8 beta is now released. > > This is available in our git repositories [0] and URLs for source tarballs > are listed later in this e-mail. We have pre-built binaries for the > follo

Re: [Openvpn-devel] [PATCH] openssl: alternative names support for --verify-x509-name CN checks

2020-02-12 Thread David Sommerseth
I'm not happy about this at all. This should be possible to achieve with mbed TLS as well: <https://tls.mbed.org/api/structmbedtls__x509__crt.html#a1f148e8fb52e03e2604e716386a07df4> One starting point for this can probably found here: <https://tls.mbed.org/api/group__x509__module.html#ga03356

[Openvpn-devel] OpenVPN 3 Linux client - v8 beta released

2020-02-10 Thread David Sommerseth
/openvpn3-linux> <https://github.com/OpenVPN/openvpn3-linux> -- kind regards, David Sommerseth OpenVPN Inc Source tarballs * OpenVPN 3 Linux v8 beta <https://swupdate.openvpn.net/community/releases/openvpn3-linux-8_b

[Openvpn-devel] [PATCH 3/4] Add gc_arena to struct argv to save allocations

2020-02-06 Thread David Sommerseth
From: Heiko Hund With the private gc_arena we do not have to allocate the strings found during parsing again, since we know the arena they are allocated in is valid as long as the argv vector is. Signed-off-by: Heiko Hund Signed-off-by: David Sommerseth --- src/openvpn/argv.c

[Openvpn-devel] [PATCH 4/4] Documented all the argv related code with minor refactoring

2020-02-06 Thread David Sommerseth
Added doxygen comments for all the functions in argv.c. There are some slight refactoring, renaming a few variables to make their use case more obvious and ensure lines do not break our 80-chars per line coding style limit. Signed-off-by: David Sommerseth --- src/openvpn/argv.c | 251

[Openvpn-devel] [PATCH 2/4] argv: do fewer memory re-allocations

2020-02-06 Thread David Sommerseth
so that it can be used to actually reset the argv without re-allocation. Signed-off-by: Heiko Hund Signed-off-by: David Sommerseth --- src/openvpn/argv.c | 81 ++-- src/openvpn/argv.h | 2 +- src/openvpn/console_systemd.c| 2

[Openvpn-devel] [PATCH 0/4] struct argv overhaul - Feb 2020 edition

2020-02-06 Thread David Sommerseth
/dev/struct-argv-overhaul-2020.02> [5] <https://patchwork.openvpn.net/project/openvpn2/list/?series=553=%2A=both> -- kind regards, David Sommerseth OpenVPN Inc ------- David Sommerseth (1): Documented all the argv r

[Openvpn-devel] [PATCH 1/4] re-implement argv_printf_*()

2020-02-06 Thread David Sommerseth
t actually is the ASCII "group separator" control character, which fits its purpose). This commit has been updated by David Sommerseth based on Arne Schwabe and his own feedback on the mailing list. Signed-off-by: Heiko Hund Signed-off-by: David Sommerseth --- v2 - Improved comments, to make

[Openvpn-devel] OpenVPN 3 Linux client - v7 beta released

2019-12-16 Thread David Sommerseth
ac508 openvpn3-linux-7_beta.tar.xz.asc git references - git tag: v7_beta git commit: 9478329ed017ba252b61b702d16a076b3adab678 Changes from v6 to v7 ---------- David Sommerseth (72): docs: Updat

Re: [Openvpn-devel] [PATCH] fix clang warning about missing braces

2019-11-29 Thread David Sommerseth
On 29/11/2019 12:37, Gert Doering wrote: > Hi, > > On Fri, Nov 29, 2019 at 12:25:13PM +0100, David Sommerseth wrote: >> On 29/11/2019 11:52, Gert Doering wrote: >>> On Fri, Nov 29, 2019 at 11:47:02AM +0100, David Sommerseth wrote: >>>> With GCC-4.3.8, I see

<    1   2   3   4   5   6   7   8   9   10   >