Hi Paolo,
On 20/06/2022 14:21, Paolo Cerrito wrote:
From: paolo
Is this a new version of your previous patch having subject "Insert
client connection data into PAM environment"?
If yes, you should send it as a v2 (i.e. with subject starting with
"[PATCH v2]") instead of appending ",
From: paolo
---
src/plugins/auth-pam/auth-pam.c | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index 70339445..c2e66e5c 100644
--- a/src/plugins/auth-pam/auth-pam.c
+++
From: paolo
---
src/plugins/auth-pam/auth-pam.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index 70339445..f91a2f02 100644
--- a/src/plugins/auth-pam/auth-pam.c
+++
Hi Paolo,
Thank you very much for this patch. Selva has already given this a
feature-ack, which I agree to. So lets continue here.
First of all, it is really important that the commit message is good on
patches. Please read this really good blog post on this topic:
Hi,
On Tue, Oct 1, 2019 at 1:02 PM Antonio Quartulli wrote:
> Hi Paolo,
>
> On 01/10/2019 14:06, Paolo Cerrito wrote:
> > From: paolo
>
> On June 27th another patch with the same subject was sent by you to this
> mailing list. Is this new patch any different?
>
> If so, it should bear a "v2"
Hi,
Its useful to set PAM_RHOSTS which will allow use of
pam_access for access control etc. So feature ACK.
I would like to see a more precise commit message header like:
"Insert remote IP address into PAM environment"
On Tue, Oct 1, 2019 at 8:25 AM Paolo Cerrito wrote:
> From: paolo
>
> ---
Hi Paolo,
On 01/10/2019 14:06, Paolo Cerrito wrote:
> From: paolo
On June 27th another patch with the same subject was sent by you to this
mailing list. Is this new patch any different?
If so, it should bear a "v2" in the subject and the differences should
be explicitly mentioned to ease the
From: paolo
---
src/plugins/auth-pam/auth-pam.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index 88b53204..9d8dfb95 100644
--- a/src/plugins/auth-pam/auth-pam.c
+++
Do not pay attention to osx. I will fix it soon
On Fri, Jun 28, 2019, 4:29 PM Paolo wrote:
> Hi,
>
> after rebasing my fork on current master, the are no conflicts with
> current source code. Travis error on osx are not releated to my code,
> they are errors about configuration peace not
Hi,
after rebasing my fork on current master, the are no conflicts with
current source code. Travis error on osx are not releated to my code,
they are errors about configuration peace not working on osx.
--
-***-
Paolo Cerrito
-***-
Hi,
another example (and the simplest case) is:
support to set remote client data into PAM environment, in turn
correctly allow PAM logging the client address to syslog
Paolo Cerrito
Il 27/06/19 11:07, Antonio Quartulli ha scritto:
> Hi,
>
> On 27/06/2019 10:26, Paolo Cerrito wrote:
>> From:
Hi,
this change is needed to pass remote ip address to pam environment. I
try to explain by an example, so this is the case for us.
I would use pam_recent module to make dynamic ip firewalling. User can
try to login some times, after for example 3 times, pam_recent could
block ip using iptables
Hi,
On 27/06/2019 10:26, Paolo Cerrito wrote:
> From: paolo
>
> Signed-off-by: Paolo Cerrito
Why do we need this change?
What benefit does it give us?
How can it be used?
IMHO it would be nice to add these pieces of information to the commit
message (right now it feels .. "empty" ;-) )
From: paolo
Signed-off-by: Paolo Cerrito
---
src/plugins/auth-pam/auth-pam.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/src/plugins/auth-pam/auth-pam.c b/src/plugins/auth-pam/auth-pam.c
index 88b53204..9d8dfb95 100644
---
14 matches
Mail list logo
