Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-17 Thread Heiko Hund
On Sonntag, 9. Oktober 2016 17:25:50 CEST Gert Doering wrote: > diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c > index 4a11d10..1250547 100644 > --- a/src/openvpn/tun.c > +++ b/src/openvpn/tun.c > @@ -1373,11 +1373,13 @@ do_ifconfig (struct tuntap *tt, > else > { > /*

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen
Il 10/10/2016 18:09, debbie10t ha scritto: > Hi > > On 10/10/16 14:42, Samuli Seppänen wrote: > >> Installers with the attached patch: >> >> >>

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread debbie10t
Hi On 10/10/16 14:42, Samuli Seppänen wrote: > Installers with the attached patch: > > >

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-10-10 Thread Samuli Seppänen
Il 09/10/2016 18:25, Gert Doering ha scritto: > Hi, > > On Sun, Oct 09, 2016 at 05:06:59PM +0200, Gert Doering wrote: >> Running more tests with that hunk reverted next... > > With the following patch applied on top of Heiko's patch > > diff --git a/src/openvpn/tun.c b/src/openvpn/tun.c > index

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-25 Thread Selva Nair
On Sat, Jun 25, 2016 at 3:45 AM, Heiko Hund wrote: > On Freitag, 24. Juni 2016 19:37:13 CEST Gert Doering wrote: > > This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some > > initialization code to init_tun, where it belongs, and removes duplicate > > code

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-25 Thread Heiko Hund
On Freitag, 24. Juni 2016 19:37:13 CEST Gert Doering wrote: > This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some > initialization code to init_tun, where it belongs, and removes duplicate > code that is now no longer needed. Yeah, I was skeptic at first, too. But it seems to

Re: [Openvpn-devel] [PATCH] Windows: do_ifconfig() after open_tun()

2016-06-24 Thread Gert Doering
Hi, On Fri, Jun 24, 2016 at 06:01:41PM +0200, Heiko Hund wrote: > This patch changes the order to IFCONFIG_AFTER_TUN_OPEN, moves some > initialization code to init_tun, where it belongs, and removes duplicate > code that is now no longer needed. While I totally like this, I'm still baffled why