[Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

From: David Sommerseth This is to include peercred support on hosts where _GNU_SOURCE is not defined by default. This issue has been found on Gentoo with glibc-2.8. The solution was discussed on the IRC meeting March 4, 2010 in #openvpn-discussions.

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 11:49, David Sommerseth wrote: > From: David Sommerseth > > This is to include peercred support on hosts where _GNU_SOURCE is not > defined by default. This issue has been found on Gentoo with glibc-2.8. > >

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/10 22:12, David Sommerseth wrote: > From: Dan Nelson > > Many of the scripts in the openvpn source have their shell set to > /bin/bash, but only two use bash features. The attached patch (against >

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/03/10 00:26, Davide Brini wrote: > On Sunday 28 February 2010, David Sommerseth wrote: >> From: Dan Nelson >> >> Many of the scripts in the openvpn source have their shell set to >> /bin/bash, but only two use

Re: [Openvpn-devel] [PATCH] Implement --passtos for tagged ethernet frames

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 28/02/10 23:07, David Sommerseth wrote: > From: Davide Guerri > > This patch makes it possible to use the --passtos option with 802.1Q tagged > ethernet frames. > > sf.net tracker: >

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

On Wednesday 10 Mar 2010 15:45:32 David Sommerseth wrote: > On 01/03/10 00:26, Davide Brini wrote: > > On Sunday 28 February 2010, David Sommerseth wrote: > >> From: Dan Nelson > >> > >> Many of the scripts in the openvpn source have their shell set to > >>

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

This is not the way to do it. Use AC_USE_SYSTEM_EXTENSIONS in autoconf, which detects libc settings. The current autoconf shape is poor, long ago I offered James to rewrite it but he refused. I only made it partially work for cross compile. There are a lot of none standard/best practice stuff

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 17:42, Alon Bar-Lev wrote: > This is not the way to do it. > > Use AC_USE_SYSTEM_EXTENSIONS in autoconf, which detects libc settings. > > The current autoconf shape is poor, long ago I offered James to > rewrite it but he refused. I only

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:03, Alon Bar-Lev wrote: > On Wed, Mar 10, 2010 at 6:50 PM, David Sommerseth > wrote: >> I'm willing to accept patches with updates as long as it don't break the >> oldest version OpenVPN need to support

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

I will try to explain again. You have two roles of environments: 1. Developer/packager workstation. 2. Target environment. For example, 1 would be my computer, and 2 would be the old redhat computer. You go to (1) and do: $ autoreconf -ivf $ ./configure && make dist Now, you transfer the

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Peter Stuge wrote: > RHEL4.6 can easily build a release that was prepared using the most > recent autoconf. In fact, I would suggest that using the newest autotools when creating the package makes it *more* likely to build effortlessly on older systems. //Peter

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:26, Peter Stuge wrote: > David Sommerseth wrote: >> it's a requirement to be able to build OpenVPN on RHEL4.6. > > As Alon explained, building is not the problem. autotools are used > when preparing git source for build. This is done

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: > I will try to explain again. > > You have two roles of environments: > > 1. Developer/packager workstation. > > 2. Target environment. > > For example, 1 would be my computer, and 2 would be the old redhat > computer. > > You go to (1) and do:

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:37:57 AM, David Sommerseth wrote: > On 10/03/10 18:26, Peter Stuge wrote: > > The only way autoconf on that RHEL4.6 would be relevant is if those > > RHEL4.6 systems strictly need to build directly from git source, as > > opposed to building from a prepared tarball. Is that the

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 18:39, Karl O. Pinc wrote: > On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: >> I will try to explain again. >> >> You have two roles of environments: >> >> 1. Developer/packager workstation. >> >> 2. Target environment. >> >> For example,

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:41:49 AM, Alon Bar-Lev wrote: > On Wed, Mar 10, 2010 at 7:39 PM, Karl O. Pinc wrote: > > In other words ./configure is not expected to be run under normal > > circumstances. > > > > The whole point of autoconf is to produce something that can > > be made into a

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

On 03/10/2010 11:54:52 AM, David Sommerseth wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/03/10 18:39, Karl O. Pinc wrote: > > On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: > >> I will try to explain again. > >> > >> You have two roles of environments: > >> > >> 1.

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 19:04, Karl O. Pinc wrote: > On 03/10/2010 11:54:52 AM, David Sommerseth wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> On 10/03/10 18:39, Karl O. Pinc wrote: >>> On 03/10/2010 11:19:13 AM, Alon Bar-Lev wrote: I will

Re: [Openvpn-devel] [PATCH] On TARGET_LINUX define _GNU_SOURCE if not defined

Karl O. Pinc wrote: > And, to reiterate, applying patches within an rpm > spec file is normal, expected, and part of the > rpm design so a certain level of "development" is supported. Should also not be a problem, since those patches are likely to start from a known release tarball, so autoconf

Re: [Openvpn-devel] [PATCH] bash->bourne script cleanup

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/03/10 17:34, Davide Brini wrote: >> > >>The only scripts that actually require bash are >> > >> contrib/pull-resolv-conf/client.{up,down} ; they use the ${!var} >> > >> variable indirection feature. >>> >>> > > Not only that, they also use