Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Selva Nair
Hi, On Tue, Nov 24, 2015 at 3:11 PM, Gert Doering wrote: > > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. > > Well, the 2.3 version would need all the #ifdefs around the code if not > running at VISTA level, and

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Selva Nair
Hi, On Tue, Nov 24, 2015 at 12:49 PM, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Its not a thunderbird-specific malady, almost every mail client messes up with line breaks, adds extra spaces etc. As Gert suggested please use git

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
It's cron2 who wanted clear ifdefs for master, because there's no WinXP support there. I need help with 2.3 build system. While the code itself would compile fine, it won't link because I can't figure out how to link libraries available in vista+ only for vista+ build and do not link it for XP.

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Selva Nair
On Wed, Nov 25, 2015 at 12:31 AM, ValdikSS wrote: > It's cron2 who wanted clear ifdefs for master, because there's no WinXP > support there. If WinXP support is really going away in 2.4, agreed, ifdef WIN32 is cleaner. That apart, the patch doesn't apply to 2.3, please

[Openvpn-devel] [PATCH] Unbreak reading username-password from management

2015-11-25 Thread Selva Nair
Fix a bug introduced by commit 6e9373c84639382c16d9eb8f1f78f60079bb89df Signed-off-by: Selva Nair --- Without this, management-query-passwords is broken. After successfully taking the username and password from management the code falls to the if block where it is prompted

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Gert Doering
Hi, On Tue, Nov 24, 2015 at 07:13:17PM -0500, Selva Nair wrote: > Not sure I understand this. The patch I had tested all along had ifdef > _WINNT_WIN32 >= 0x0600 around everything. So the code nicely silences > itself when built for XP (I did not try this though). I built only 64 bit > version

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Gert Doering
Hi, On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > I need help with 2.3 build system. While the code itself would compile fine, > it won't link because I can't figure out how to link libraries available in > vista+ > only for vista+ build and do not link it for XP. Cross-build

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Gert Doering
Hi, On Wed, Nov 25, 2015 at 01:32:38AM -0500, Selva Nair wrote: > On Wed, Nov 25, 2015 at 12:31 AM, ValdikSS wrote: > > > It's cron2 who wanted clear ifdefs for master, because there's no WinXP > > support there. > > If WinXP support is really going away in 2.4, It

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Gert Doering
Hi, On Tue, Nov 24, 2015 at 08:49:08PM +0300, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Please use the attached version. > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. Thanks for the attachments,

[Openvpn-devel] [PATCHv3] extend management interface command "state"

2015-11-25 Thread Heiko Hund
Currently the state command shows only the tun/tap IPv4 address. The IPv4 address of the remote peer is also displayed. In case you connect via IPv6 it just shows the first 4 bytes of the address in IPv4 notation. This patch extends the state command, so it handles IPv6 addresses. In addition it

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Selva Nair
Hi, On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering wrote: > Hi, > > On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > > I need help with 2.3 build system. While the code itself would compile > fine, it won't link because I can't figure out how to link libraries >

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Arne Schwabe
Am 25.11.15 um 15:15 schrieb Selva Nair: > Hi, > > On Wed, Nov 25, 2015 at 2:54 AM, Gert Doering > wrote: > > Hi, > > On Wed, Nov 25, 2015 at 08:31:23AM +0300, ValdikSS wrote: > > I need help with 2.3 build system. While the code

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Gert Doering
Hi, On Wed, Nov 25, 2015 at 03:19:51PM +0100, Arne Schwabe wrote: > I am not sure if we want to ship separate WIN XP and Vista+ versions. We are in agremeent that we do *not* want that :-) - but we *do* want this patch to work around Win10 DNS brokenness, and that binary won't run on XP. Which

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread David Sommerseth
On 24/11/15 18:49, ValdikSS wrote: > I can't figure out why Thunderbird corrupts my patches. > Please use the attached version. > I still need help with 2.3 build system. If somebody willing to help me, > please use the attached version. Thunderbird works great in many areas, but my experience

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Morris, Russell
FYI, no joy … ☹. Configure below gives the following error, configure: error: Cannot find OpenSSL library So still looking for OpenSSL. Thanks! … Russell From: Selva Nair [mailto:selva.n...@gmail.com] Sent: Sunday, November 22, 2015 1:22 PM To: Morris, Russell Cc: Samuli

Re: [Openvpn-devel] FoxIT acquired by NCC group

2015-11-25 Thread Steffan Karger
Hi Jan Just, On 25-11-15 17:14, Jan Just Keijser wrote: > just saw this: > https://www.fox-it.com/en/press-releases/acquisition-of-fox-it-by-ncc-group/ > > Congratulation, I guess. Does this mean that you guys are now multi > millionaires and no longer have to work ? > What does this mean for

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Heiko Hund
You seem to have gotten the path to the cross compiled openssl wrong. On Wednesday 25 November 2015 16:07:12 Morris, Russell wrote: > FYI, no joy … ☹. Configure below gives the following error, > configure: error: Cannot find OpenSSL library > > So still looking for OpenSSL. > > Thanks! > > …

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Morris, Russell
Hi, Yep, that makes sense - but Selva was thinking this would ignore the libraries for now ... or did I misunderstand? Thanks, ... Russell -Original Message- From: Heiko Hund [mailto:heiko.h...@sophos.com] Sent: Wednesday, November 25, 2015 10:42 AM To:

Re: [Openvpn-devel] [PATCH v4-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread Fish Wang
Just a small suggestion: I think the following will work: - Check the version of the current operating system. - Dynamically loading related DLLs (in this case, should be WFP-related libraries) using LoadLibrary() only if OpenVPN is running Windows Vista+, and pops a warning for XP users who has

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Selva Nair
On Wed, Nov 25, 2015 at 11:48 AM, Morris, Russell wrote: > Hi, > > Yep, that makes sense - but Selva was thinking this would ignore the > libraries for now ... or did I misunderstand? > Yes, as a first test its easier to build without openssl and with my suggested configure

[Openvpn-devel] [PATCH v5-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
This option blocks all out-of-tunnel communication on TCP/UDP port 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. --- doc/openvpn.8 | 12 ++- src/openvpn/Makefile.am | 2 +- src/openvpn/init.c | 17 src/openvpn/openvpn.vcxproj | 4

[Openvpn-devel] [PATCH v5-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
This option blocks all out-of-tunnel communication on TCP/UDP port 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. --- doc/openvpn.8 | 12 ++- src/openvpn/Makefile.am | 2 +- src/openvpn/init.c | 17 src/openvpn/openvpn.vcxproj | 4

[Openvpn-devel] [PATCH v5-2.3] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
This option blocks all out-of-tunnel communication on TCP/UDP port 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10. --- doc/openvpn.8 | 12 ++- src/openvpn/init.c | 17 src/openvpn/openvpn.vcxproj | 0 src/openvpn/options.c | 16

Re: [Openvpn-devel] [PATCH v5-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
Sorry for double post. This patch comes with removed wfp_init, moved defines to win32.c from win32.h, whitespace fix in documentation. signature.asc Description: OpenPGP digital signature

Re: [Openvpn-devel] [PATCH v5-master] Add Windows DNS Leak fix using WFP ('block-outside-dns')

2015-11-25 Thread ValdikSS
Please ignore this patch, it won't compile, I'm an idiot. signature.asc Description: OpenPGP digital signature

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Morris, Russell
Yep, that works better … ☺. Thanks! Any pointers on fixing the OpenSSL “limitation”? … Russell From: Selva Nair [mailto:selva.n...@gmail.com] Sent: Wednesday, November 25, 2015 11:08 AM To: Morris, Russell Cc: Heiko Hund ;

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Selva Nair
Hi, On Wed, Nov 25, 2015 at 4:14 PM, Morris, Russell wrote: > Yep, that works better … J. Thanks! > > So did it compile? > > > Any pointers on fixing the OpenSSL “limitation”? > Its not a limitation. You just need cross-compiled openssl library and include files to

Re: [Openvpn-devel] OpenVPN-GUI now on GitHub + other Windows team things

2015-11-25 Thread Morris, Russell
Hi, Yep, built – and very quickly … ☺. Is there information on the entire / overall build? I’d be happy to try that – then set up to try to work on the GUI overall after. Thanks! … Russell From: Selva Nair [mailto:selva.n...@gmail.com] Sent: Wednesday, November 25, 2015 3:23 PM To: Morris,