Hi,
On Fri, Feb 17, 2012 at 10:04:50PM +0100, Frank de Brabander wrote:
> This causes compiler warnings when using Clang instead of default GCC.
I'm not particularily interested in source code fixes "just to silence
a compiler warning" - but Clang is right, of course, that this variable
cannot ev
This causes compiler warnings when using Clang instead of default GCC.
Signed-off-by: Frank de Brabander
---
mroute.c | 24 +---
1 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/mroute.c b/mroute.c
index 285b151..0213a3e 100644
--- a/mroute.c
+++ b/mroute.c
@
This causes compiler warnings when using Clang instead of default GCC.
Signed-off-by: Frank de Brabander
---
mroute.c | 24 +---
1 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/mroute.c b/mroute.c
index 285b151..0213a3e 100644
--- a/mroute.c
+++ b/mroute.c
@
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17/02/12 12:13, David Sommerseth wrote:
> This file was moved to win/config.h.in and is the template used by the
> Python build tools in win/. This happened in commit
> 4b312378e9e7084a0699ca6d4b895bdadb7540db
>
> For all other autotools based env
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17/02/12 12:30, David Sommerseth wrote:
> In commit 9a160b796e1a40f9635231e5533ce40d46dba25f ssl_common.h was
> introduced, but never listed as a source file in Makefile.am
>
> Signed-off-by: David Sommerseth --- Makefile.am |
> 1 + 1 files chan
Hi,
On Fri, Feb 17, 2012 at 12:30:33PM +0100, David Sommerseth wrote:
> In commit 9a160b796e1a40f9635231e5533ce40d46dba25f ssl_common.h
> was introduced, but never listed as a source file in Makefile.am
ACK, together with the other one.
(Side remark: buildbot should do "make distcheck", at least
In commit 9a160b796e1a40f9635231e5533ce40d46dba25f ssl_common.h
was introduced, but never listed as a source file in Makefile.am
Signed-off-by: David Sommerseth
---
Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 2029389..26b80
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17/02/12 12:18, Alon Bar-Lev wrote:
> When did this file gone? Anyway, this was required with compiling
> using MSVC...
This is the commit referenced:
commit 4b312378e9e7084a0699ca6d4b895bdadb7540db
Author: Samuli Seppänen
List-Post: openvpn-dev
When did this file gone?
Anyway, this was required with compiling using MSVC...
On Fri, Feb 17, 2012 at 1:13 PM, David Sommerseth wrote:
> This file was moved to win/config.h.in and is the template used
> by the Python build tools in win/. This happened in
> commit 4b312378e9e7084a0699ca6d4b895b
This file was moved to win/config.h.in and is the template used
by the Python build tools in win/. This happened in
commit 4b312378e9e7084a0699ca6d4b895bdadb7540db
For all other autotools based environments, ./configure will take
care of creating the proper config.h
Signed-off-by: David Sommerse
Hi,
On Fri, Feb 17, 2012 at 09:39:35AM +0100, Heiko Hund wrote:
> MSVC chokes on this as it's not according to C89.
>
> Signed-off-by: Heiko Hund
> ---
> buffer.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/buffer.c b/buffer.c
> index 6800e6e..391085b 100644
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 17/02/12 09:39, Heiko Hund wrote:
> MSVC chokes on this as it's not according to C89.
>
> Signed-off-by: Heiko Hund --- buffer.c |2
> +- 1 files changed, 1 insertions(+), 1 deletions(-)
ACK! Applied to master on -testing and stable trees.
c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 16/02/12 18:30, Heiko Hund wrote:
> Hi,
>
> this patch series fixes several issues when building for Windows with
> the MSVC buildsystem discovered today:
>
> [PATCH 1/4] replace check for TARGET_WIN32 with WIN32 [PATCH 2/4] do
> not use mode_t on
On Fri, Feb 17, 2012 at 11:39 AM, Heiko Hund wrote:
> Alon,
>
> On Thursday 16 February 2012 18:34:34 Alon Bar-Lev wrote:
>> Anyway, this is not the correct solution.
>> Correct solution is to have config-msvc.h and have:
>> ---
>> #define mode_t int
>
> I don't think that a MSVC specific header w
On Fri, Feb 17, 2012 at 11:51 AM, Heiko Hund wrote:
> Alon,
>
> On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote:
>> On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote:
>> > Windows API CommandLineToArgvW(), introduced in Windows unicode path
>> > commit 71bbbd76c62630c88441237d72fe5b61f0b
Alon,
On Thursday 16 February 2012 18:37:21 Alon Bar-Lev wrote:
> On Thu, Feb 16, 2012 at 7:30 PM, Heiko Hund wrote:
> > Windows API CommandLineToArgvW(), introduced in Windows unicode path
> > commit 71bbbd76c62630c88441237d72fe5b61f0b45b2a, is defined therein.
>
> Usually this should be avoide
Alon,
On Thursday 16 February 2012 18:34:34 Alon Bar-Lev wrote:
> Anyway, this is not the correct solution.
> Correct solution is to have config-msvc.h and have:
> ---
> #define mode_t int
I don't think that a MSVC specific header will do good. mode_t shouldn't
actually be used in mingw either,
MSVC chokes on this as it's not according to C89.
Signed-off-by: Heiko Hund
---
buffer.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/buffer.c b/buffer.c
index 6800e6e..391085b 100644
--- a/buffer.c
+++ b/buffer.c
@@ -321,9 +321,9 @@ gc_malloc (size_t size, bool clea
18 matches
Mail list logo
