Re: [Openvpn-devel] [PATCH 2.3] Fix compilation in pedantic mode

2016-10-05 Thread Daniel Hunsaker 
On Wednesday, October 5, 2016 12:43, David Sommerseth wrote:
On 05/10/16 20:34, Steffan Karger wrote:
> On 5 October 2016 at 20:25, David Sommerseth
>  wrote:
>> The Hackathon in Munich 2014 [1] decided on the the Allmann style
>> [2]. The only thing I'm not sure we agreed upon is the indent
>> size (4 or 8 spaces), in addition to the line length which is not
>> that explicitly agreed upon.
>
> I seem to remember we agreed on 4 spaces.  (8 would really not
> work with the current code and a 80-chars-per-line limit.)

Fair point!  I remember we discussed both, but as we never truly
documented any result here I have forgotten it.  And it is aligned
what Gert claims too.

Also, 8 spaces is a terrible idea anyway.  Even the most ancient printing 
presses (after indentation was initially used) only went as far as (the 
equivalent of) 5 - and their fonts were proportional.

That said, I will always prefer \t over \x20*.

Daniel Hunsaker
QA / Automation
OpenVPN Technologies, Inc

irc://irc.freenode.net: danhunsaker
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 2.3] Fix compilation in pedantic mode

2016-10-05 Thread Gert Doering 
Hi,

On Wed, Oct 05, 2016 at 08:25:51PM +0200, David Sommerseth wrote:
> The Hackathon in Munich 2014 [1] decided on the the Allmann style [2].
>  The only thing I'm not sure we agreed upon is the indent size (4 or 8
> spaces), in addition to the line length which is not that explicitly
> agreed upon.

/me claims "it was 4" :)

gert
-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 2.3] Fix compilation in pedantic mode

2016-10-05 Thread David Sommerseth 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 05/10/16 17:29, Lev Stipakov wrote:
> Hi,
> 
> 
> I am, and the first version is what we do in (most?) other places, 
> so I'll change that on the fly.
> 
> 
> Got it.
> 
> 
> Also, the patch introduces spurious tab<->whitespace changes "close
> to comments" in a few places - will undo those, too.
> 
> 
> I noticed that in few places indentation is a bit off - like 8 
> whitespaces instead of tab so I decided to "fix" it.
> 
> Should I just ignore those things or do it in separate PR?

Currently I think we can leave them.  Before the release of 2.4-RC we
will do a lot of coding style fixes to the whole source tree, so that
we have one unified coding style over the whole code base in both the
new releases/2.4 and master branch.

The Hackathon in Munich 2014 [1] decided on the the Allmann style [2].
 The only thing I'm not sure we agreed upon is the indent size (4 or 8
spaces), in addition to the line length which is not that explicitly
agreed upon.

[1] 
[2] 


- -- 
kind regards,

David Sommerseth
OpenVPN Technologies, Inc

-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJX9UWvAAoJEIbPlEyWcf3ytj4P/iuXf+htHtFjQfE9/QSWY/Ui
+jpF1kqlAKac6eS1t0cN1OYVUmXZwNkZjGNKYl8vi9zVSciZf2rFslTAhaaRLuWW
LMtL1MxGJbADvLpKkHPfvSNk3ITXxhnMKjgXqzxnPY2WeyV7f48jKOUeBma3RY1R
m4hT8Hg0Im2cqVmU9XRDvEc3u0EqTKzA/NP6sKO1dWut05ZwKlIyUknsJfLoZyEx
OPghZaTgFmz0YZKQqam0cenkL2g3cYuz60GQw8Lpio6GFLQMMbjV9fRpdIJ4d36W
qIdulNh+idXDvuSe3bFFQqYItdUIIgaBvz8dUDCubz47OR6vkTD+/+KR0f4F5C/9
HHt1CW4GAs5AEvFpF9BhPoxajQHNjoZsrWOL+YgumVKcTUclgd/iUoRTBusSF87H
fYp/b7XjLO1cr1QPprK0szzNQB4HMFx3aVxZlvhC8WePN+uO8a6X55g08pnuy7kS
PQ5nrfOywwQsqhl9p9E5lFV2HoeIfxGkwjoq4xztGI9xyV3jFroaqn4cN9314+aF
RREgmCYInDEZzVXjqFCC/0isgEXOYdC/p6Hpy6EWzCecFf8fm1Gs4CQnhodR7Min
QyKZhhC/yAXgOKuEKCPw+NY+eulE1VwRmIBEJujKgeVBNVIoaQc43wEARIYhTdcO
SrffianKpvhWJiPjLRUd
=TF/Z
-END PGP SIGNATURE-

--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 2.3] Fix compilation in pedantic mode

2016-10-05 Thread Gert Doering 
Hi,

On Wed, Oct 05, 2016 at 05:29:46PM +0200, Lev Stipakov wrote:
> I noticed that in few places indentation is a bit off - like 8 whitespaces
> instead of tab so I decided to "fix" it.
> 
> Should I just ignore those things or do it in separate PR?

Please do not intermix whitespace changes with "other changes" - this
makes it harder to track what really changed in a patch.

We are planning to do a massive re-indentation before 2.4 release
(right when we branch off the release/2.4 branch, or so) - so I'd not
bother right now.

If you do actual code changes to a line that has funny whitespace, of
course feel free to fix that as well ;-)

gert

-- 
USENET is *not* the non-clickable part of WWW!
   //www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025g...@net.informatik.tu-muenchen.de


signature.asc
Description: PGP signature
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Re: [Openvpn-devel] [PATCH 2.3] Fix compilation in pedantic mode

2016-10-05 Thread Lev Stipakov 
Hi,


I am, and the first version is what we do in (most?) other places, so I'll
> change that on the fly.
>

Got it.


> Also, the patch introduces spurious tab<->whitespace changes "close to
> comments" in a few places - will undo those, too.


I noticed that in few places indentation is a bit off - like 8 whitespaces
instead of tab so I decided to "fix" it.

Should I just ignore those things or do it in separate PR?

-- 
-Lev
--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel