Re: [Openvpn-devel] [PATCH v2] tun: Fix compiler warnings

2016-11-16 Thread Gert Doering
Hi, On Wed, Nov 16, 2016 at 05:32:48PM +0100, David Sommerseth wrote: > > On Tue, Nov 15, 2016 at 12:13:05AM +0100, David Sommerseth wrote: > >> Fixes two compiler warnings idetified by using CFLAGS=-O2 > > Spelling... > Meh. Will fix that one. [..] As discussed on IRC - there's a few issues with

Re: [Openvpn-devel] [PATCH v2] tun: Fix compiler warnings

2016-11-16 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 16/11/16 17:26, Gert Doering wrote: > Hi, > > On Tue, Nov 15, 2016 at 12:13:05AM +0100, David Sommerseth wrote: >> Fixes two compiler warnings idetified by using CFLAGS=-O2 > > Spelling... Meh. Will fix that one. >> 1) ifconfig_ipv6_remote is on

Re: [Openvpn-devel] [PATCH v2] tun: Fix compiler warnings

2016-11-16 Thread Gert Doering
Hi, On Tue, Nov 15, 2016 at 12:13:05AM +0100, David Sommerseth wrote: > Fixes two compiler warnings idetified by using CFLAGS=-O2 Spelling... > 1) ifconfig_ipv6_remote is only used on Solaris, move the >declaration and assignment of this variable into the >TARGET_SOLARIS block. > > 2) L

[Openvpn-devel] [PATCH v2] tun: Fix compiler warnings

2016-11-14 Thread David Sommerseth
Fixes two compiler warnings idetified by using CFLAGS=-O2 1) ifconfig_ipv6_remote is only used on Solaris, move the declaration and assignment of this variable into the TARGET_SOLARIS block. 2) Linux have it's own open_tun() function and does not depend on open_tun_generic() at all. So